Re: Review Request 50759: Force periodic cleanup of EpollPoller memory

2016-08-04 Thread Chuck Rolke
"qpid" > Sent: Thursday, August 4, 2016 12:28:17 PM > Subject: Re: Review Request 50759: Force periodic cleanup of EpollPoller > memory > > > --- > This is an automatically ge

Re: Review Request 50759: Force periodic cleanup of EpollPoller memory

2016-08-04 Thread Robbie Gemmell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50759/#review144779 --- I haven't even looked at the diff, but regarding the comments arou

Re: Review Request 50759: Force periodic cleanup of EpollPoller memory

2016-08-04 Thread Andrew Stitcher
> On Aug. 4, 2016, 2:57 p.m., Andrew Stitcher wrote: > > src/qpid/sys/epoll/EpollPoller.cpp, line 573 > > > > > > Tiny quibble: > > > > Could be > > > > if (now_ >= targetTimeout) ... > > Cliff Jan

Re: Review Request 50759: Force periodic cleanup of EpollPoller memory

2016-08-04 Thread Cliff Jansen
> On Aug. 4, 2016, 2:57 p.m., Andrew Stitcher wrote: > > src/qpid/sys/epoll/EpollPoller.cpp, line 573 > > > > > > Tiny quibble: > > > > Could be > > > > if (now_ >= targetTimeout) ... I tried that

Re: Review Request 50759: Force periodic cleanup of EpollPoller memory

2016-08-04 Thread Andrew Stitcher
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50759/#review144765 --- This is good. Some small things that would make the code easier t

Re: Review Request 50759: Force periodic cleanup of EpollPoller memory

2016-08-04 Thread Cliff Jansen
> On Aug. 3, 2016, 7:07 p.m., Chug Rolke wrote: > > src/qpid/sys/epoll/EpollPoller.cpp, line 552 > > > > > > Before these changes the code was very friendly to low power > > configurations by not waking up unnecessa

Re: Review Request 50759: Force periodic cleanup of EpollPoller memory

2016-08-03 Thread Cliff Jansen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50759/ --- (Updated Aug. 4, 2016, 3:32 a.m.) Review request for qpid and Andrew Stitcher.

Re: Review Request 50759: Force periodic cleanup of EpollPoller memory

2016-08-03 Thread Cliff Jansen
> On Aug. 3, 2016, 6:33 p.m., Andrew Stitcher wrote: > > src/qpid/sys/epoll/EpollPoller.cpp, line 669 > > > > > > I think it would be easier to understand all the timer manipulations to > > put something like: > >

Re: Review Request 50759: Force periodic cleanup of EpollPoller memory

2016-08-03 Thread Chug Rolke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50759/#review144647 --- src/qpid/sys/epoll/EpollPoller.cpp (line 552)

Re: Review Request 50759: Force periodic cleanup of EpollPoller memory

2016-08-03 Thread Andrew Stitcher
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50759/#review144631 --- This looks good to me - I've made some (I hope) constructive sugge

Review Request 50759: Force periodic cleanup of EpollPoller memory

2016-08-03 Thread Cliff Jansen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50759/ --- Review request for qpid and Andrew Stitcher. Bugs: qpid-7373 https://issues