[GitHub] [qpid-proton] astitcher commented on a change in pull request #185: PROTON-2079: Fix usage of formatting placeholders in printfs

astitcher commented on a change in pull request #185: PROTON-2079: Fix usage of formatting placeholders in printfs URL: https://github.com/apache/qpid-proton/pull/185#discussion_r306539270 ## File path: c/tools/msgr-send.c ## @@ -289,7 +289,7 @@ int main(int argc, char** a

[GitHub] [qpid-proton] astitcher commented on a change in pull request #185: PROTON-2079: Fix usage of formatting placeholders in printfs

astitcher commented on a change in pull request #185: PROTON-2079: Fix usage of formatting placeholders in printfs URL: https://github.com/apache/qpid-proton/pull/185#discussion_r306540680 ## File path: c/tools/msgr-send.c ## @@ -289,7 +289,7 @@ int main(int argc, char** a

[GitHub] [qpid-proton] jdanekrh commented on a change in pull request #185: PROTON-2079: Fix usage of formatting placeholders in printfs

jdanekrh commented on a change in pull request #185: PROTON-2079: Fix usage of formatting placeholders in printfs URL: https://github.com/apache/qpid-proton/pull/185#discussion_r306744500 ## File path: c/tools/msgr-send.c ## @@ -289,7 +289,7 @@ int main(int argc, char** ar

[GitHub] [qpid-dispatch] franz1981 commented on issue #542: DISPATCH-1389: force inlining of local compose functions

franz1981 commented on issue #542: DISPATCH-1389: force inlining of local compose functions URL: https://github.com/apache/qpid-dispatch/pull/542#issuecomment-514665993 @ChugR agree! This is an automated message from the Apac

[GitHub] [qpid-dispatch] ganeshmurthy opened a new pull request #545: DISPATCH-1391 - Zero out pn_link references on all qd_links related t…

ganeshmurthy opened a new pull request #545: DISPATCH-1391 - Zero out pn_link references on all qd_links related t… URL: https://github.com/apache/qpid-dispatch/pull/545 …o the session This is an automated message from the Ap

[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #545: DISPATCH-1391 - Zero out pn_link references on all qd_links related t…

kgiusti commented on a change in pull request #545: DISPATCH-1391 - Zero out pn_link references on all qd_links related t… URL: https://github.com/apache/qpid-dispatch/pull/545#discussion_r306927274 ## File path: src/container.c ## @@ -541,14 +541,16 @@ void qd_container_h

[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #545: DISPATCH-1391 - Zero out pn_link references on all qd_links related t…

kgiusti commented on a change in pull request #545: DISPATCH-1391 - Zero out pn_link references on all qd_links related t… URL: https://github.com/apache/qpid-dispatch/pull/545#discussion_r306927274 ## File path: src/container.c ## @@ -541,14 +541,16 @@ void qd_container_h

[GitHub] [qpid-dispatch] asfgit closed pull request #545: DISPATCH-1391 - Zero out pn_link references on all qd_links related t…

asfgit closed pull request #545: DISPATCH-1391 - Zero out pn_link references on all qd_links related t… URL: https://github.com/apache/qpid-dispatch/pull/545 This is an automated message from the Apache Git Service. To respo

[GitHub] [qpid-proton] astitcher commented on issue #185: PROTON-2079: Fix usage of formatting placeholders in printfs

astitcher commented on issue #185: PROTON-2079: Fix usage of formatting placeholders in printfs URL: https://github.com/apache/qpid-proton/pull/185#issuecomment-514909804 +1 Feel free to rebase and merge this. This is an auto

[GitHub] [qpid-proton] jdanekrh merged pull request #185: PROTON-2079: Fix usage of formatting placeholders in printfs

jdanekrh merged pull request #185: PROTON-2079: Fix usage of formatting placeholders in printfs URL: https://github.com/apache/qpid-proton/pull/185 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [qpid-dispatch] asfgit closed pull request #542: DISPATCH-1389: force inlining of local compose functions

asfgit closed pull request #542: DISPATCH-1389: force inlining of local compose functions URL: https://github.com/apache/qpid-dispatch/pull/542 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [qpid-dispatch] asfgit closed pull request #544: DISPATCH-1389: export qd_buffer_t access methods inline

asfgit closed pull request #544: DISPATCH-1389: export qd_buffer_t access methods inline URL: https://github.com/apache/qpid-dispatch/pull/544 This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [qpid-dispatch] jdanekrh commented on issue #459: DISPATCH-1282 - Support for building on macOS

jdanekrh commented on issue #459: DISPATCH-1282 - Support for building on macOS URL: https://github.com/apache/qpid-dispatch/pull/459#issuecomment-516004987 @RoddieKieley Thank you for the review. I've opened followup Jira for fixing tests https://issues.apache.org/jira/browse/DISPATCH-1384

[GitHub] [qpid-dispatch] jdanekrh edited a comment on issue #459: DISPATCH-1282 - Support for building on macOS

jdanekrh edited a comment on issue #459: DISPATCH-1282 - Support for building on macOS URL: https://github.com/apache/qpid-dispatch/pull/459#issuecomment-516004987 @RoddieKieley Thank you for the review. I've opened followup Jira for fixing tests https://issues.apache.org/jira/browse/DISPA

[GitHub] [qpid-dispatch] asfgit closed pull request #541: DISPATCH-1389: optimize the STATE_IN_BODY codepath in qd_iterator_octet

asfgit closed pull request #541: DISPATCH-1389: optimize the STATE_IN_BODY codepath in qd_iterator_octet URL: https://github.com/apache/qpid-dispatch/pull/541 This is an automated message from the Apache Git Service. To resp

[GitHub] [qpid-dispatch] kgiusti opened a new pull request #546: DISPATCH-1389: optimize qd_iterator_advance, qd_iterator_ncopy and

kgiusti opened a new pull request #546: DISPATCH-1389: optimize qd_iterator_advance, qd_iterator_ncopy and URL: https://github.com/apache/qpid-dispatch/pull/546 qd_iterator_equal to use multi-byte operations when the iterator view is in the raw data. Results of two-hop router test

[GitHub] [qpid-dispatch] bhardesty opened a new pull request #547: NO JIRA: Fix typo and minor issues in doc

bhardesty opened a new pull request #547: NO JIRA: Fix typo and minor issues in doc URL: https://github.com/apache/qpid-dispatch/pull/547 This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [qpid-dispatch] codecov-io commented on issue #547: NO JIRA: Fix typo and minor issues in doc

codecov-io commented on issue #547: NO JIRA: Fix typo and minor issues in doc URL: https://github.com/apache/qpid-dispatch/pull/547#issuecomment-516184344 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/547?src=pr&el=h1) Report > Merging [#547](https://codecov.io/gh/apache/

[GitHub] [qpid-dispatch] codecov-io commented on issue #546: DISPATCH-1389: optimize qd_iterator_advance, qd_iterator_ncopy and

codecov-io commented on issue #546: DISPATCH-1389: optimize qd_iterator_advance, qd_iterator_ncopy and URL: https://github.com/apache/qpid-dispatch/pull/546#issuecomment-516413915 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/546?src=pr&el=h1) Report > Merging [#546](htt

[GitHub] [qpid-dispatch] asfgit closed pull request #547: NO JIRA: Fix typo and minor issues in doc

asfgit closed pull request #547: NO JIRA: Fix typo and minor issues in doc URL: https://github.com/apache/qpid-dispatch/pull/547 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [qpid-broker-j] overmeulen opened a new pull request #33: QPID-8289: [Broker-J] Broker startup can fail due to ConcurrentModificationException

overmeulen opened a new pull request #33: QPID-8289: [Broker-J] Broker startup can fail due to ConcurrentModificationException URL: https://github.com/apache/qpid-broker-j/pull/33 This is an automated message from the Apache

[GitHub] [qpid-broker-j] overmeulen commented on issue #33: QPID-8289: [Broker-J] Broker startup can fail due to ConcurrentModificationException

overmeulen commented on issue #33: QPID-8289: [Broker-J] Broker startup can fail due to ConcurrentModificationException URL: https://github.com/apache/qpid-broker-j/pull/33#issuecomment-517609770 The appveyor failure seems technical... --

[GitHub] [qpid-dispatch] asfgit closed pull request #546: DISPATCH-1389: optimize qd_iterator_advance, qd_iterator_ncopy and

asfgit closed pull request #546: DISPATCH-1389: optimize qd_iterator_advance, qd_iterator_ncopy and URL: https://github.com/apache/qpid-dispatch/pull/546 This is an automated message from the Apache Git Service. To respond t

[GitHub] [qpid-proton] kpvdr opened a new pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx

kpvdr opened a new pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx URL: https://github.com/apache/qpid-proton/pull/186 The epydoc documentation has been removed. Sphinx markup has been added to the code comments. For a successful build, the version of Sph

[GitHub] [qpid-broker-j] asfgit closed pull request #33: QPID-8289: [Broker-J] Broker startup can fail due to ConcurrentModificationException

asfgit closed pull request #33: QPID-8289: [Broker-J] Broker startup can fail due to ConcurrentModificationException URL: https://github.com/apache/qpid-broker-j/pull/33 This is an automated message from the Apache Git Servi

[GitHub] [qpid-dispatch] bhardesty opened a new pull request #548: DISPATCH-1396: Add starting router procedure

bhardesty opened a new pull request #548: DISPATCH-1396: Add starting router procedure URL: https://github.com/apache/qpid-dispatch/pull/548 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [qpid-proton] astitcher commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx

astitcher commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx URL: https://github.com/apache/qpid-proton/pull/186#discussion_r313477224 ## File path: python/docs/Makefile ## @@ -0,0 +1,20 @@ +# Minimal makefile for Sphin

[GitHub] [qpid-proton] astitcher commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx

astitcher commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx URL: https://github.com/apache/qpid-proton/pull/186#discussion_r313476350 ## File path: python/CMakeLists.txt ## @@ -112,35 +112,46 @@ endmacro(py_compile) p

[GitHub] [qpid-proton] astitcher commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx

astitcher commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx URL: https://github.com/apache/qpid-proton/pull/186#discussion_r313477968 ## File path: python/proton/utils.py ## @@ -19,12 +19,14 @@ from __future__ impor

[GitHub] [qpid-dispatch] codecov-io commented on issue #548: DISPATCH-1396: Add starting router procedure

codecov-io commented on issue #548: DISPATCH-1396: Add starting router procedure URL: https://github.com/apache/qpid-dispatch/pull/548#issuecomment-520926388 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/548?src=pr&el=h1) Report > Merging [#548](https://codecov.io/gh/apac

[GitHub] [qpid-dispatch] bhardesty opened a new pull request #549: NO JIRA: Add "qdstat -e" descriptions to qdstat man page

bhardesty opened a new pull request #549: NO JIRA: Add "qdstat -e" descriptions to qdstat man page URL: https://github.com/apache/qpid-dispatch/pull/549 This is an automated message from the Apache Git Service. To respond to

[GitHub] [qpid-dispatch] codecov-io commented on issue #549: NO JIRA: Add "qdstat -e" descriptions to qdstat man page

codecov-io commented on issue #549: NO JIRA: Add "qdstat -e" descriptions to qdstat man page URL: https://github.com/apache/qpid-dispatch/pull/549#issuecomment-520998325 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/549?src=pr&el=h1) Report > Merging [#549](https://codec

[GitHub] [qpid-dispatch] jdanekrh opened a new pull request #550: DISPATCH-1300 - doc default httpRootDir as being stand-alone console install path

jdanekrh opened a new pull request #550: DISPATCH-1300 - doc default httpRootDir as being stand-alone console install path URL: https://github.com/apache/qpid-dispatch/pull/550 I am intentionally not mentioning the CMAKE_INSTALL_PREFIX here. I hope people who know of it can guess that it

[GitHub] [qpid-proton] kpvdr commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx

kpvdr commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx URL: https://github.com/apache/qpid-proton/pull/186#discussion_r315279286 ## File path: python/docs/Makefile ## @@ -0,0 +1,20 @@ +# Minimal makefile for Sphinx do

[GitHub] [qpid-proton] kpvdr commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx

kpvdr commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx URL: https://github.com/apache/qpid-proton/pull/186#discussion_r315281467 ## File path: python/proton/utils.py ## @@ -19,12 +19,14 @@ from __future__ import ab

[GitHub] [qpid-proton] kpvdr commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx

kpvdr commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx URL: https://github.com/apache/qpid-proton/pull/186#discussion_r315299683 ## File path: python/CMakeLists.txt ## @@ -112,35 +112,46 @@ endmacro(py_compile) py_co

[GitHub] [qpid-proton] astitcher commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx

astitcher commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx URL: https://github.com/apache/qpid-proton/pull/186#discussion_r315666188 ## File path: python/CMakeLists.txt ## @@ -112,35 +112,46 @@ endmacro(py_compile) p

[GitHub] [qpid-proton] kpvdr commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx

kpvdr commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx URL: https://github.com/apache/qpid-proton/pull/186#discussion_r315683102 ## File path: python/CMakeLists.txt ## @@ -112,35 +112,46 @@ endmacro(py_compile) py_co

[GitHub] [qpid-proton] astitcher commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx

astitcher commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx URL: https://github.com/apache/qpid-proton/pull/186#discussion_r315687196 ## File path: python/CMakeLists.txt ## @@ -112,35 +112,46 @@ endmacro(py_compile) p

[GitHub] [qpid-proton] astitcher commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx

astitcher commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx URL: https://github.com/apache/qpid-proton/pull/186#discussion_r315687196 ## File path: python/CMakeLists.txt ## @@ -112,35 +112,46 @@ endmacro(py_compile) p

[GitHub] [qpid-proton] kpvdr commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx

kpvdr commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx URL: https://github.com/apache/qpid-proton/pull/186#discussion_r315689748 ## File path: python/CMakeLists.txt ## @@ -112,35 +112,46 @@ endmacro(py_compile) py_co

[GitHub] [qpid-proton] kpvdr commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx

kpvdr commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx URL: https://github.com/apache/qpid-proton/pull/186#discussion_r315698367 ## File path: python/CMakeLists.txt ## @@ -112,35 +112,46 @@ endmacro(py_compile) py_co

[GitHub] [qpid-proton] astitcher commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx

astitcher commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx URL: https://github.com/apache/qpid-proton/pull/186#discussion_r31562 ## File path: python/CMakeLists.txt ## @@ -112,35 +112,46 @@ endmacro(py_compile) p

[GitHub] [qpid-proton] astitcher commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx

astitcher commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx URL: https://github.com/apache/qpid-proton/pull/186#discussion_r315700883 ## File path: python/CMakeLists.txt ## @@ -112,35 +112,46 @@ endmacro(py_compile) p

[GitHub] [qpid-proton] kpvdr commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx

kpvdr commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx URL: https://github.com/apache/qpid-proton/pull/186#discussion_r315704839 ## File path: python/CMakeLists.txt ## @@ -112,35 +112,46 @@ endmacro(py_compile) py_co

[GitHub] [qpid-proton] kpvdr commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx

kpvdr commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx URL: https://github.com/apache/qpid-proton/pull/186#discussion_r315706680 ## File path: python/CMakeLists.txt ## @@ -112,35 +112,46 @@ endmacro(py_compile) py_co

[GitHub] [qpid-proton] astitcher commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx

astitcher commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx URL: https://github.com/apache/qpid-proton/pull/186#discussion_r315739603 ## File path: python/CMakeLists.txt ## @@ -112,35 +112,46 @@ endmacro(py_compile) p

[GitHub] [qpid-dispatch] bhardesty opened a new pull request #551: DISPATCH-1374 - Doc qdstat state dump procedure

bhardesty opened a new pull request #551: DISPATCH-1374 - Doc qdstat state dump procedure URL: https://github.com/apache/qpid-dispatch/pull/551 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [qpid-proton] kpvdr commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx

kpvdr commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx URL: https://github.com/apache/qpid-proton/pull/186#discussion_r315831142 ## File path: python/CMakeLists.txt ## @@ -112,35 +112,46 @@ endmacro(py_compile) py_co

[GitHub] [qpid-proton] astitcher commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx

astitcher commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx URL: https://github.com/apache/qpid-proton/pull/186#discussion_r315833802 ## File path: python/CMakeLists.txt ## @@ -112,35 +112,46 @@ endmacro(py_compile) p

[GitHub] [qpid-dispatch] bhardesty opened a new pull request #552: NO JIRA - Add prereq for accessing console

bhardesty opened a new pull request #552: NO JIRA - Add prereq for accessing console URL: https://github.com/apache/qpid-dispatch/pull/552 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [qpid-proton] kpvdr commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx

kpvdr commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx URL: https://github.com/apache/qpid-proton/pull/186#discussion_r316206620 ## File path: python/CMakeLists.txt ## @@ -112,35 +112,46 @@ endmacro(py_compile) py_co

[GitHub] [qpid-proton] kpvdr commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx

kpvdr commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx URL: https://github.com/apache/qpid-proton/pull/186#discussion_r316207427 ## File path: python/proton/utils.py ## @@ -19,12 +19,14 @@ from __future__ import ab

[GitHub] [qpid-dispatch] jdanekrh commented on a change in pull request #548: DISPATCH-1396: Add starting router procedure

jdanekrh commented on a change in pull request #548: DISPATCH-1396: Add starting router procedure URL: https://github.com/apache/qpid-dispatch/pull/548#discussion_r316213191 ## File path: docs/books/_common/fragment-start-router-service-command.adoc ## @@ -0,0 +1,23 @@ +//

[GitHub] [qpid-dispatch] jdanekrh commented on a change in pull request #552: NO JIRA - Add prereq for accessing console

jdanekrh commented on a change in pull request #552: NO JIRA - Add prereq for accessing console URL: https://github.com/apache/qpid-dispatch/pull/552#discussion_r316215328 ## File path: docs/books/_common/fragment-console-prereq.adoc ## @@ -0,0 +1,24 @@ + +Licensed to

[GitHub] [qpid-dispatch] kgiusti opened a new pull request #553: NO-JIRA: update Travis with latest Proton (0.9.0)

kgiusti opened a new pull request #553: NO-JIRA: update Travis with latest Proton (0.9.0) URL: https://github.com/apache/qpid-dispatch/pull/553 I also took the liberty to bump up the test timeout when running in travis - occasionally hitting the default timeout. --

[GitHub] [qpid-dispatch] kgiusti commented on issue #553: NO-JIRA: update Travis with latest Proton (0.9.0)

kgiusti commented on issue #553: NO-JIRA: update Travis with latest Proton (0.9.0) URL: https://github.com/apache/qpid-dispatch/pull/553#issuecomment-523505795 I'll fix the bad version # in the commit log before merging! This

[GitHub] [qpid-proton] astitcher commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx

astitcher commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx URL: https://github.com/apache/qpid-proton/pull/186#discussion_r316257193 ## File path: python/CMakeLists.txt ## @@ -112,35 +112,46 @@ endmacro(py_compile) p

[GitHub] [qpid-proton] astitcher commented on issue #186: PROTON-2086: Changed API documentation from epydoc to Sphinx

astitcher commented on issue #186: PROTON-2086: Changed API documentation from epydoc to Sphinx URL: https://github.com/apache/qpid-proton/pull/186#issuecomment-523516240 This looks good from the pov of my concerns (I haven't looked at the actual documentation changes much though!) If y

[GitHub] [qpid-dispatch] asfgit closed pull request #553: NO-JIRA: update Travis with latest Proton (0.9.0)

asfgit closed pull request #553: NO-JIRA: update Travis with latest Proton (0.9.0) URL: https://github.com/apache/qpid-dispatch/pull/553 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [qpid-proton] kpvdr commented on issue #186: PROTON-2086: Changed API documentation from epydoc to Sphinx

kpvdr commented on issue #186: PROTON-2086: Changed API documentation from epydoc to Sphinx URL: https://github.com/apache/qpid-proton/pull/186#issuecomment-523533365 astitcher: Could you take a look at the summary on the main page (look at index.rst if not built, but you'll have to endure

[GitHub] [qpid-dispatch] kgiusti opened a new pull request #554: DISPATCH-1266: Fix unsettled multicast forwarding

kgiusti opened a new pull request #554: DISPATCH-1266: Fix unsettled multicast forwarding URL: https://github.com/apache/qpid-dispatch/pull/554 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [qpid-dispatch] bhardesty commented on a change in pull request #548: DISPATCH-1396: Add starting router procedure

bhardesty commented on a change in pull request #548: DISPATCH-1396: Add starting router procedure URL: https://github.com/apache/qpid-dispatch/pull/548#discussion_r316408384 ## File path: docs/books/_common/fragment-start-router-service-command.adoc ## @@ -0,0 +1,23 @@ +/

[GitHub] [qpid-dispatch] ChugR commented on issue #554: DISPATCH-1266: Fix unsettled multicast forwarding

ChugR commented on issue #554: DISPATCH-1266: Fix unsettled multicast forwarding URL: https://github.com/apache/qpid-dispatch/pull/554#issuecomment-523907220 I ran this with a tortured configuration: 4 interior routers zigzagging between two hosts 8 edge routers: four on each host

[GitHub] [qpid-dispatch] kgiusti commented on issue #554: DISPATCH-1266: Fix unsettled multicast forwarding

kgiusti commented on issue #554: DISPATCH-1266: Fix unsettled multicast forwarding URL: https://github.com/apache/qpid-dispatch/pull/554#issuecomment-523909067 Nice catch - a memory leak! My favorite! I'll see what I can uncover on my end as well... ---

[GitHub] [qpid-dispatch] codecov-io commented on issue #554: DISPATCH-1266: Fix unsettled multicast forwarding

codecov-io commented on issue #554: DISPATCH-1266: Fix unsettled multicast forwarding URL: https://github.com/apache/qpid-dispatch/pull/554#issuecomment-524011262 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/554?src=pr&el=h1) Report > Merging [#554](https://codecov.io/g

[GitHub] [qpid-dispatch] ChugR commented on issue #554: DISPATCH-1266: Fix unsettled multicast forwarding

ChugR commented on issue #554: DISPATCH-1266: Fix unsettled multicast forwarding URL: https://github.com/apache/qpid-dispatch/pull/554#issuecomment-524043580 This patch @ 7e1cc88 is good. * I ran the torture test with one sender and four receivers and a million messages. All receivers

[GitHub] [qpid-proton] ffontaine opened a new pull request #187: cpp/CMakeLists.txt: fix qpid-proton-cpp linking

ffontaine opened a new pull request #187: cpp/CMakeLists.txt: fix qpid-proton-cpp linking URL: https://github.com/apache/qpid-proton/pull/187 gpid-proton-cpp must use LINK_PUBLIC to link with qpid-proton-core and qpid-proton-proactor otherwise build will fail if those libraries are no

[GitHub] [qpid-proton] astitcher commented on issue #187: cpp/CMakeLists.txt: fix qpid-proton-cpp linking

astitcher commented on issue #187: cpp/CMakeLists.txt: fix qpid-proton-cpp linking URL: https://github.com/apache/qpid-proton/pull/187#issuecomment-524436160 Can you explain your specific situation more because this fix doesn't entirely make sense: These libraries should be LINK_PRIVATE

[GitHub] [qpid-proton] astitcher edited a comment on issue #187: cpp/CMakeLists.txt: fix qpid-proton-cpp linking

astitcher edited a comment on issue #187: cpp/CMakeLists.txt: fix qpid-proton-cpp linking URL: https://github.com/apache/qpid-proton/pull/187#issuecomment-524436160 Can you explain your specific situation more because this fix doesn't entirely make sense: These libraries should be LINK_

[GitHub] [qpid-proton] astitcher commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx

astitcher commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx URL: https://github.com/apache/qpid-proton/pull/186#discussion_r317287382 ## File path: python/docs/index.rst ## @@ -1,11 +1,134 @@ -Apache Qpid Proton: pytho

[GitHub] [qpid-proton] astitcher commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx

astitcher commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx URL: https://github.com/apache/qpid-proton/pull/186#discussion_r317289512 ## File path: python/docs/index.rst ## @@ -1,11 +1,134 @@ -Apache Qpid Proton: pytho

[GitHub] [qpid-proton] astitcher commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx

astitcher commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx URL: https://github.com/apache/qpid-proton/pull/186#discussion_r317289496 ## File path: python/docs/index.rst ## @@ -1,11 +1,134 @@ -Apache Qpid Proton: pytho

[GitHub] [qpid-proton] astitcher commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx

astitcher commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx URL: https://github.com/apache/qpid-proton/pull/186#discussion_r317293384 ## File path: python/docs/index.rst ## @@ -1,11 +1,134 @@ -Apache Qpid Proton: pytho

[GitHub] [qpid-proton] astitcher commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx

astitcher commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx URL: https://github.com/apache/qpid-proton/pull/186#discussion_r317294349 ## File path: python/docs/proton.handlers.rst ## @@ -0,0 +1,106 @@ +

[GitHub] [qpid-proton] astitcher commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx

astitcher commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx URL: https://github.com/apache/qpid-proton/pull/186#discussion_r317293874 ## File path: python/docs/proton.handlers.rst ## @@ -0,0 +1,106 @@ +

[GitHub] [qpid-proton] astitcher commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx

astitcher commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx URL: https://github.com/apache/qpid-proton/pull/186#discussion_r317289764 ## File path: python/docs/index.rst ## @@ -1,11 +1,134 @@ -Apache Qpid Proton: pytho

[GitHub] [qpid-proton] astitcher commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx

astitcher commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx URL: https://github.com/apache/qpid-proton/pull/186#discussion_r317290849 ## File path: python/docs/index.rst ## @@ -1,11 +1,134 @@ -Apache Qpid Proton: pytho

[GitHub] [qpid-proton] astitcher commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx

astitcher commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx URL: https://github.com/apache/qpid-proton/pull/186#discussion_r317291003 ## File path: python/docs/index.rst ## @@ -1,11 +1,134 @@ -Apache Qpid Proton: pytho

[GitHub] [qpid-proton] astitcher commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx

astitcher commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx URL: https://github.com/apache/qpid-proton/pull/186#discussion_r317290561 ## File path: python/docs/index.rst ## @@ -1,11 +1,134 @@ -Apache Qpid Proton: pytho

[GitHub] [qpid-proton] kpvdr commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx

kpvdr commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx URL: https://github.com/apache/qpid-proton/pull/186#discussion_r317298149 ## File path: python/docs/index.rst ## @@ -1,11 +1,134 @@ -Apache Qpid Proton: python do

[GitHub] [qpid-proton] kpvdr commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx

kpvdr commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx URL: https://github.com/apache/qpid-proton/pull/186#discussion_r317298210 ## File path: python/docs/index.rst ## @@ -1,11 +1,134 @@ -Apache Qpid Proton: python do

[GitHub] [qpid-proton] kpvdr commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx

kpvdr commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx URL: https://github.com/apache/qpid-proton/pull/186#discussion_r317298014 ## File path: python/docs/index.rst ## @@ -1,11 +1,134 @@ -Apache Qpid Proton: python do

[GitHub] [qpid-proton] kpvdr commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx

kpvdr commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx URL: https://github.com/apache/qpid-proton/pull/186#discussion_r317298104 ## File path: python/docs/index.rst ## @@ -1,11 +1,134 @@ -Apache Qpid Proton: python do

[GitHub] [qpid-proton] kpvdr commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx

kpvdr commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx URL: https://github.com/apache/qpid-proton/pull/186#discussion_r317298694 ## File path: python/docs/index.rst ## @@ -1,11 +1,134 @@ -Apache Qpid Proton: python do

[GitHub] [qpid-proton] kpvdr commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx

kpvdr commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx URL: https://github.com/apache/qpid-proton/pull/186#discussion_r317298952 ## File path: python/docs/index.rst ## @@ -1,11 +1,134 @@ -Apache Qpid Proton: python do

[GitHub] [qpid-proton] kpvdr commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx

kpvdr commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx URL: https://github.com/apache/qpid-proton/pull/186#discussion_r317299082 ## File path: python/docs/index.rst ## @@ -1,11 +1,134 @@ -Apache Qpid Proton: python do

[GitHub] [qpid-proton] kpvdr commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx

kpvdr commented on a change in pull request #186: PROTON-2086: Changed API documentation from epydoc to Sphinx URL: https://github.com/apache/qpid-proton/pull/186#discussion_r317299565 ## File path: python/docs/proton.handlers.rst ## @@ -0,0 +1,106 @@ +

[GitHub] [qpid-proton] jdanekrh opened a new pull request #188: PROTON-2091: fix `len(queue)` in python/examples and reformat for PEP8

jdanekrh opened a new pull request #188: PROTON-2091: fix `len(queue)` in python/examples and reformat for PEP8 URL: https://github.com/apache/qpid-proton/pull/188 This is an automated message from the Apache Git Service. To

[GitHub] [qpid-proton] astitcher commented on issue #188: PROTON-2091: fix `len(queue)` in python/examples and reformat for PEP8

astitcher commented on issue #188: PROTON-2091: fix `len(queue)` in python/examples and reformat for PEP8 URL: https://github.com/apache/qpid-proton/pull/188#issuecomment-524469383 I think you left extraneous testing code in the bottom of the file. Otherwise looks good to me. --

[GitHub] [qpid-proton] jdanekrh commented on issue #188: PROTON-2091: fix `len(queue)` in python/examples and reformat for PEP8

jdanekrh commented on issue #188: PROTON-2091: fix `len(queue)` in python/examples and reformat for PEP8 URL: https://github.com/apache/qpid-proton/pull/188#issuecomment-524469661 I meant to keep the test code there. It will only execute if user does `python -m unittest discover`, otherwis

[GitHub] [qpid-proton] astitcher commented on issue #188: PROTON-2091: fix `len(queue)` in python/examples and reformat for PEP8

astitcher commented on issue #188: PROTON-2091: fix `len(queue)` in python/examples and reformat for PEP8 URL: https://github.com/apache/qpid-proton/pull/188#issuecomment-524470568 Please remove it - this is meant to be example code. No other example has test code included. If you r

[GitHub] [qpid-proton] jdanekrh commented on issue #188: PROTON-2091: fix `len(queue)` in python/examples and reformat for PEP8

jdanekrh commented on issue #188: PROTON-2091: fix `len(queue)` in python/examples and reformat for PEP8 URL: https://github.com/apache/qpid-proton/pull/188#issuecomment-524471523 Ok, it is trivial enough it does not need a test. Adding this as a python doctest would be similarly distracti

[GitHub] [qpid-proton] jdanekrh merged pull request #188: PROTON-2091: fix `len(queue)` in python/examples and reformat for PEP8

jdanekrh merged pull request #188: PROTON-2091: fix `len(queue)` in python/examples and reformat for PEP8 URL: https://github.com/apache/qpid-proton/pull/188 This is an automated message from the Apache Git Service. To respo

[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #554: DISPATCH-1266: Fix unsettled multicast forwarding

kgiusti commented on a change in pull request #554: DISPATCH-1266: Fix unsettled multicast forwarding URL: https://github.com/apache/qpid-dispatch/pull/554#discussion_r317628508 ## File path: src/router_core/delivery.c ## @@ -558,81 +572,386 @@ void qdr_delivery_decref_CT(

[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #554: DISPATCH-1266: Fix unsettled multicast forwarding

kgiusti commented on a change in pull request #554: DISPATCH-1266: Fix unsettled multicast forwarding URL: https://github.com/apache/qpid-dispatch/pull/554#discussion_r317628990 ## File path: src/router_core/delivery.c ## @@ -558,81 +572,386 @@ void qdr_delivery_decref_CT(

[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #554: DISPATCH-1266: Fix unsettled multicast forwarding

kgiusti commented on a change in pull request #554: DISPATCH-1266: Fix unsettled multicast forwarding URL: https://github.com/apache/qpid-dispatch/pull/554#discussion_r317628702 ## File path: src/router_core/delivery.c ## @@ -558,81 +572,386 @@ void qdr_delivery_decref_CT(

[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #554: DISPATCH-1266: Fix unsettled multicast forwarding

kgiusti commented on a change in pull request #554: DISPATCH-1266: Fix unsettled multicast forwarding URL: https://github.com/apache/qpid-dispatch/pull/554#discussion_r317630103 ## File path: src/router_core/delivery.c ## @@ -558,81 +572,386 @@ void qdr_delivery_decref_CT(

[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #554: DISPATCH-1266: Fix unsettled multicast forwarding

kgiusti commented on a change in pull request #554: DISPATCH-1266: Fix unsettled multicast forwarding URL: https://github.com/apache/qpid-dispatch/pull/554#discussion_r317630736 ## File path: src/router_core/delivery.c ## @@ -558,81 +572,386 @@ void qdr_delivery_decref_CT(

[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #554: DISPATCH-1266: Fix unsettled multicast forwarding

kgiusti commented on a change in pull request #554: DISPATCH-1266: Fix unsettled multicast forwarding URL: https://github.com/apache/qpid-dispatch/pull/554#discussion_r317631718 ## File path: src/router_core/delivery.c ## @@ -558,81 +572,386 @@ void qdr_delivery_decref_CT(

  1   2   3   4   5   6   7   8   9   10   >