Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/120
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/120
LGTM. Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wis
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/120#discussion_r84570072
--- Diff: storage/FastSeparateChainingHashTable.hpp ---
@@ -145,10 +145,10 @@ class FastSeparateChainingHashTable
header_->buckets_a
Github user hakanmemisoglu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/120#discussion_r84566413
--- Diff: storage/FastSeparateChainingHashTable.hpp ---
@@ -145,10 +145,10 @@ class FastSeparateChainingHashTable
header_->buc
Github user hbdeshmukh commented on the issue:
https://github.com/apache/incubator-quickstep/pull/120
Hi @hakanmemisoglu
Can you please review this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
GitHub user hbdeshmukh opened a pull request:
https://github.com/apache/incubator-quickstep/pull/120
Store handle count in FastSeparateChainingHashTable
- Using handles_ vector directly in FastSeparateChainingHashTable can
cause problems. One example is a distinctify hash table
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/118
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
Github user hbdeshmukh commented on the issue:
https://github.com/apache/incubator-quickstep/pull/111
Looks good to me, merging. As travis was green before the minor change, I
won't wait for it.
---
If your project is set up for it, you can reply to this email and have your
reply ap
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/111
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/111#discussion_r84499311
--- Diff: query_execution/PolicyEnforcerBase.hpp ---
@@ -163,6 +174,8 @@ class PolicyEnforcerBase {
// Key = query ID, value = QueryManagerBas
Github user hbdeshmukh commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/111#discussion_r84497021
--- Diff: query_execution/PolicyEnforcerBase.hpp ---
@@ -163,6 +174,8 @@ class PolicyEnforcerBase {
// Key = query ID, value = QueryMana
11 matches
Mail list logo
