Re: [DISCUSS] Retire Quickstep podling from Apache Incubator

2018-10-29 Thread Zuyu Zhang
+1 to retire. Cheers, Zuyu

Re: quickstep server

2017-04-01 Thread Zuyu Zhang
Hi Marc, With the NetworkWrapper, does the QuickstepServer could serve queries from multiple clients? ​ Cheers, Zuyu

Re: quickstep server

2017-03-31 Thread Zuyu Zhang
Hi Marc, The distributed version uses the network-based implementation of TMB to communicate among multiple components, including DistributedCli, Conductor (which contains Foreman), and Executor (which contains a Worker pool). We have defined additional TMB message types for the communication. Fo

Re: release: third_party/

2017-03-27 Thread Zuyu Zhang
Hi Harshad -- I did reply regarding the protobuf version (link ). ​ Anyway, it is ok for me to keep the submodule. And I have tested that upgrading to protobuf 3 as a git s

Re: release: third_party/

2017-03-27 Thread Zuyu Zhang
Hi Harshad, A quick question: any reason why we still keep protobuf as a git submodule? To test the distributed version in the Travis CI, we need at least protobuf 3.0 and grpc. Cheers, Zuyu​

Re: tmb compile error

2017-03-07 Thread Zuyu Zhang
Btw, it seems that the compiler does not support or honor the flag '-Wno-unused-variable' set by the TMB. https://github.com/apache/incubator-quickstep/blob/master/third_party/src/tmb/CMakeLists.txt#L57

Re: tmb compile error

2017-03-07 Thread Zuyu Zhang
Hi Marc, Yes, I am looking at this issue. How to produce this issue? It seems that the error was generated by gcc? ​ Cheers, Zuyu

Re: release: third_party/

2017-01-22 Thread Zuyu Zhang
FYI, there are some Apache projects in C++ ( https://projects.apache.org/projects.html?language), and more in github ( https://github.com/apache?language=c%2B%2B), including incubator projects. I summaries how typically they deal with the third parties and the release. - Apache Mesos (https://

Re: release: third_party/

2017-01-22 Thread Zuyu Zhang
Hi all, If I remembered correctly, the IWYU script (iwyu/iwyu_helper.py) was added by Shoban. As of the protobuf version, the distributed Quickstep needs protobuf 3 (on which gRPC depends). And there is no hard requirements for the single node version, at least 2.6 works. Sorry for that I missed

Re: Travis CI 50-minute Timeout

2016-11-25 Thread Zuyu Zhang
Hi Harshad, I could add back the debug build with LLVM. Thanks! Cheers, Zuyu ​

Re: Travis CI 50-minute Timeout

2016-11-22 Thread Zuyu Zhang
Hi Harshad, I don't think we need the debug build in Travis CI, as I believe both the release builds and the debug build should produce the same results for a PR, although the latter in a test failure case, would provide additional info, like DEBUG_ASSERT as you mentioned. But as the PR reviewers

Re: Bug in recent commit

2016-11-22 Thread Zuyu Zhang
Hi Nav, Thank you for pointing it out, and I have fixed it. Cheers, Zuyu

QueryHandle Ownership During a Query Execution

2016-11-19 Thread Zuyu Zhang
Hi guys, I would like to discuss some design changes regarding the QueryHandle ownership during the life of serving a query. I would propose to let QueryManager owns QueryHandle during the query execution phase, instead of the main thread in QuickstepCli. For those who are not familiar, QueryHan

Re: Clang format file

2016-08-17 Thread Zuyu Zhang
p abc-clang.hpp to see the differences. You can use any > other diff tool instead of vimdiff (e.g. meld) > > The long term goal should be to perfect the clang-format file so that it > always gives trusted output. Then the pull request reviewer's burden (wrt > style related comm

Travis CI Hangs Forever

2016-07-09 Thread Zuyu Zhang
Hi, I observed that two Travis CI builds hang forever: https://travis-ci.org/apache/incubator-quickstep/builds/143581084 https://travis-ci.org/apache/incubator-quickstep/builds/143590105 And I have reported this in JIRA: https://issues.apache.org/jira/browse/INFRA-12229 Cheers, Zuyu

Re: [Design Discussion] StorageManager in PolicyEnforcer in Distributed Case

2016-06-23 Thread Zuyu Zhang
In the distributed version, ForemanDistributed would pass a nullptr of StorageManager to PolicyEnforcer. And QueryManager in the distributed version would not use StorageManager at all, as QueryContext would be reconstructed in Worker site. Actually, we may use the QUICKSTEP_DISTRIBUTED micro in Q

Re: [Design Discussion] StorageManager in PolicyEnforcer in Distributed Case

2016-06-23 Thread Zuyu Zhang
Hi Harshad, After a second though, I have the following proposal: We add a new base class called QueryManagerLite, from which the current QueryManager and the future QueryManagerDistributed would derive. Thus, we could keep the current QueryManager intact, including holding QueryContext. With th

Re: [Design Discussion] StorageManager in PolicyEnforcer in Distributed Case

2016-06-20 Thread Zuyu Zhang
The main issue is that QueryManager -> QueryContext. I don't think late binding would work, since in the distributed case, QueryContext will be reconstructed by Worker's Shiftboss. So in the single node case, if Foreman could create QueryContext w/ StorageManager, it would be fine. Zuyu

[Design Discussion] StorageManager in PolicyEnforcer in Distributed Case

2016-06-20 Thread Zuyu Zhang
Hi Harshad, I am working on the distributed query execution engine, and would like to have a discussion regarding how both PolicyEnforcer and QueryManager fit into the distributed case. I was wondering if we could remove using StorageManager in PolicyEnforcer. In other words, could Foreman create

Re: Code Style Guidelines and Code Review pages added to ASF wiki

2016-06-12 Thread Zuyu Zhang
The CI would fail if there are explicit style errors, although not all issues would be caught by our scripts.​

Guideline To Update Copyright Header

2016-06-12 Thread Zuyu Zhang
Hi, I was wondering how to update copyright info in a file header to reflect outside contributors' change. More specifically, is it appropriate to add "Copyright 2016 The Apache Quickstep Contributors."? https://github.com/apache/incubator-quickstep/pull/27/files#diff-357f532831c389c757e7c87c7db

Re: Travis Vector_Copy_Elision_Level

2016-06-08 Thread Zuyu Zhang
Hi Nav, Please go ahead with all the four options as a trial. We've solved all the CI issues. Cheers, Zuyu

Re: Travis Vector_Copy_Elision_Level

2016-06-08 Thread Zuyu Zhang
We could add the other two options if all CI tests finish in a reasonable time frame, say 2 hours. This is a trade-off between the development and the tests. Historically, the CI takes too long to finish due to the limited concurrent jobs, so we choose to build two copy elision level options: the

Re: Travis build problems

2016-06-08 Thread Zuyu Zhang
GCC is killed by Travis due to out of memory, which happens when we build templatized operations (i.e., EqualComparison). Zuyu On Wed, Jun 8, 2016 at 5:49 PM, Navneet Potti wrote: > Does anyone know why we’re getting internal compiler errors using g++-5 on > Travis? > See build log < > https://

Re: Update on the Quickstep project

2016-05-31 Thread Zuyu Zhang
On Tue, May 31, 2016 at 10:24 AM, Jignesh Patel wrote: > > I see Siddharth Suresh, Navneet Potti and Craig Chasseur are missing. I > believe they have signed the ICLA. > Both Sid and Navneet are in the contributor list: http://people.apache.org/unlistedclas.html

Re: Update on the Quickstep project

2016-05-31 Thread Zuyu Zhang
Hi Jignesh, I could find your name in the list: http://people.apache.org/committer-index.html#P ​ Cheers, Zuyu

Re: Confluence Permissions

2016-05-17 Thread Zuyu Zhang
Thanks Roman.​ Cheers, Zuyu

Re: Confluence Permissions

2016-05-16 Thread Zuyu Zhang
zuyuz Thanks, Zuyu On Mon, May 16, 2016 at 4:19 PM Roman Shaposhnik wrote: > what's your Confluence ID? > > On Mon, May 16, 2016 at 3:22 PM, Zuyu Zhang wrote: > > Hi there, > > > > I was wondering if someone would give me write permissions to the > follow

Confluence Permissions

2016-05-16 Thread Zuyu Zhang
Hi there, I was wondering if someone would give me write permissions to the following Confluence space, so that I could add pages regarding how to contribute Apache Quickstep as well as code review guideline. https://cwiki.apache.org/confluence/display/QUICKSTEP/Quickstep+Home Cheers, Zuyu

Re: When do you think you can fully transition to ASF infrastructure?

2016-05-10 Thread Zuyu Zhang
Thank you Julian for the info. I've created an INFRA ticket for this. https://issues.apache.org/jira/browse/INFRA-11839

Re: When do you think you can fully transition to ASF infrastructure?

2016-05-10 Thread Zuyu Zhang
We have a JIRA ticket QUICKSTEP-2 to track the progress of the Travis CI setup. What should we do regarding the INFRA request?

QUICKSTEP-2: Travis CI in ASF github

2016-05-09 Thread Zuyu Zhang
Hi, I was wondering how to set up the Travis CI for Apache Quickstep mirror repo, like Apache Geode. https://github.com/apache/incubator-geode https://travis-ci.org/apache/incubator-geode Cheers, Zuyu

Re: When do you think you can fully transition to ASF infrastructure?

2016-05-08 Thread Zuyu Zhang
Yes, we need fix QUICKSTEP-2 before transiting to ASF. Cheers, Zuyu

Re: Podling Report Reminder - May 2016

2016-05-01 Thread Zuyu Zhang
Hi Julian, I believe Jignesh has done so in the wiki page. http://wiki.apache.org/incubator/May2016 ​ Cheers, Zuyu

Re: [jira] [Commented] (QUICKSTEP-1) Add incubation disclaimer to README.md

2016-04-19 Thread Zuyu Zhang
2" in the commit messages? If not, what do I miss? Thanks! commit f9b48a8ab5229375f4927af10d8be82e9928e8ae Author: Zuyu Zhang Date: Tue Apr 19 12:23:51 2016 -0500 QUICKSTEP-1: Add incubation disclaimer to README.md. This closes #2 Thanks, Zuyu

Re: QUICKSTEP-1

2016-04-19 Thread Zuyu Zhang
I have questions to how to merge PR #2 as a committer. I've noticed the following hints, but I still do not know how to achieve it. Should I edit the commit message again with "This closes #2"? To close this pull request, make a commit to your master/trunk branch with (at least) the following in

Re: Apache Quickstep (incubating) on-boarding

2016-04-19 Thread Zuyu Zhang
Hi Jignesh, Now the master branch of the Apache repo is synced with that of the pivotal software repo. Thanks Julian for the hints. Cheers, Zuyu ​

Re: Apache Quickstep (incubating) on-boarding

2016-04-18 Thread Zuyu Zhang
Hi Julian, I got your point on how to merge the existing open PRs. That should work. Thanks! My concern is that the current master branch of the Apache repo is a few commits behind that of the pivotalsotware one. So could we rebase some commits in the master branch? ​ Cheers, Zuyu

Re: Apache Quickstep (incubating) on-boarding

2016-04-17 Thread Zuyu Zhang
Hi Roman, Thank you for setting up the Apache repo. I have three basic questions: - Could you please point out the basic workflow of how to contribute Apache incubating projects for us? Does a merged PR in Github mirror automatically sync with git://git.apache.org/incubator-quickstep.gi