Patches with trivial changes

2017-05-23 Thread Madhan Neethiraj
All, I notice a number of recent patches address trivial issues like white space, spelling mistakes (one patch just changed a single letter in a label). And few other patches update a large number of files for trivial/non-functional changes – like whitespaces. I strongly suggest we refrain f

[jira] [Resolved] (RANGER-1611) The init_logfiles function had been removed in RANGER-1599. The segment code that calls the init_logfiles function should also be removed in setup.sh for Ranger Admin.

2017-05-23 Thread Qiang Zhang (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qiang Zhang resolved RANGER-1611. - Resolution: Fixed > The init_logfiles function had been removed in RANGER-1599. The segment code

Re: Review Request 59512: The init_logfiles function had been removed in RANGER-1599. The segment code that calls the init_logfiles function should also be removed in setup.sh for Ranger Admin.

2017-05-23 Thread Qiang Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59512/#review175893 --- Ship it! Ship It! - Qiang Zhang On 五月 24, 2017, 3:08 a.m., p

Re: Review Request 59512: The init_logfiles function had been removed in RANGER-1599. The segment code that calls the init_logfiles function should also be removed in setup.sh for Ranger Admin.

2017-05-23 Thread pengjianhua
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59512/ --- (Updated 五月 24, 2017, 3:08 a.m.) Review request for ranger, Alok Lal, Ankita Si

[jira] [Updated] (RANGER-1611) The init_logfiles function had been removed in RANGER-1599. The segment code that calls the init_logfiles function should also be removed in setup.sh for Ranger Admin.

2017-05-23 Thread peng.jianhua (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] peng.jianhua updated RANGER-1611: - Description: The init_logfiles function had been removed in RANGER-1599. The segment code that ca

Review Request 59512: The init_logfiles function had been removed in RANGER-1599. The segment code that calls the init_logfiles function should also be removed in setup.sh for Ranger Admin.

2017-05-23 Thread pengjianhua
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59512/ --- Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEige

[jira] [Updated] (RANGER-1611) The init_logfiles function had been removed in RANGER-1599. The segment code that calls the init_logfiles function should also be removed in setup.sh for Ranger Admin.

2017-05-23 Thread peng.jianhua (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] peng.jianhua updated RANGER-1611: - Attachment: 0001-RANGER-1611-The-init_logfiles-function-had-been-remo.patch > The init_logfiles f

Review Request 59511: Modify the Logger scope and keep the consistent info in XPolicyService.java

2017-05-23 Thread Qiang Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59511/ --- Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEige

[jira] [Created] (RANGER-1611) The init_logfiles function had been removed in RANGER-1599. The segment code that calls the init_logfiles function should also be removed in setup.sh for Ranger Admin.

2017-05-23 Thread peng.jianhua (JIRA)
peng.jianhua created RANGER-1611: Summary: The init_logfiles function had been removed in RANGER-1599. The segment code that calls the init_logfiles function should also be removed in setup.sh for Ranger Admin. Key: RANGER-1611

[jira] [Commented] (RANGER-1608) SOLR resource lookup fails with basic auth

2017-05-23 Thread Qiang Zhang (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16022209#comment-16022209 ] Qiang Zhang commented on RANGER-1608: - Please create a RR. > SOLR resource lookup fa

[jira] [Commented] (RANGER-1570) Finish cleaning up Mockito stubs

2017-05-23 Thread Qiang Zhang (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16022207#comment-16022207 ] Qiang Zhang commented on RANGER-1570: - Please create a RR. > Finish cleaning up Mock

[jira] [Commented] (RANGER-1587) Cleanup Ranger KMS service dependencies

2017-05-23 Thread Qiang Zhang (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16022208#comment-16022208 ] Qiang Zhang commented on RANGER-1587: - Please create a RR. > Cleanup Ranger KMS serv

Re: Review Request 59395: RANGER-1593 - Avoid Classloading default AtlasResourceMappers

2017-05-23 Thread Qiang Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59395/#review175890 --- Ship it! Ship It! - Qiang Zhang On 五月 22, 2017, 9:46 a.m., C

[jira] [Updated] (RANGER-1610) Modify the Logger scope and keep the consistent info in XPolicyService.java

2017-05-23 Thread Qiang Zhang (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qiang Zhang updated RANGER-1610: Attachment: 0001-RANGER-1610-Modify-the-Logger-scope-and-keep-the-con.patch > Modify the Logger sco

[jira] [Created] (RANGER-1610) Modify the Logger scope and keep the consistent info in XPolicyService.java

2017-05-23 Thread Qiang Zhang (JIRA)
Qiang Zhang created RANGER-1610: --- Summary: Modify the Logger scope and keep the consistent info in XPolicyService.java Key: RANGER-1610 URL: https://issues.apache.org/jira/browse/RANGER-1610 Project: R

[jira] [Resolved] (RANGER-1605) These invalid codes that were copied have not been deleted in db_setup.py for the Ranger admin

2017-05-23 Thread Qiang Zhang (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qiang Zhang resolved RANGER-1605. - Resolution: Fixed > These invalid codes that were copied have not been deleted in db_setup.py for

Re: Review Request 59486: These invalid codes that were copied have not been deleted in db_setup.py for the Ranger admin

2017-05-23 Thread Qiang Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59486/#review175887 --- Ship it! Ship It! - Qiang Zhang On 五月 23, 2017, 8:53 a.m., p

[jira] [Created] (RANGER-1609) AtlasTagSource shouldn't use Guice injection

2017-05-23 Thread Apoorv Naik (JIRA)
Apoorv Naik created RANGER-1609: --- Summary: AtlasTagSource shouldn't use Guice injection Key: RANGER-1609 URL: https://issues.apache.org/jira/browse/RANGER-1609 Project: Ranger Issue Type: Bug

[jira] [Commented] (RANGER-980) User sync does not delete users if they do not exist anymore

2017-05-23 Thread Leon Li (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021893#comment-16021893 ] Leon Li commented on RANGER-980: I can confirm this issue occurs on Ranger 0.7 as well >

[jira] [Commented] (RANGER-1607) Ranger service check failed on SLES11.3 cluster with sslv3 alert handshake failure

2017-05-23 Thread Ankita Sinha (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021210#comment-16021210 ] Ankita Sinha commented on RANGER-1607: -- Committed to Master : https://github.com/ap

Re: Review Request 59487: Ranger service check failed on SLES11.3 cluster with sslv3 alert handshake failure

2017-05-23 Thread Gautam Borad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59487/#review175790 --- Ship it! Ship It! - Gautam Borad On May 23, 2017, 1:31 p.m.,

Re: Review Request 59487: Ranger service check failed on SLES11.3 cluster with sslv3 alert handshake failure

2017-05-23 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59487/#review175787 --- Ship it! Ship It! - Velmurugan Periasamy On May 23, 2017, 1:

Review Request 59487: Ranger service check failed on SLES11.3 cluster with sslv3 alert handshake failure

2017-05-23 Thread Ankita Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59487/ --- Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan

Review Request 59489: RANGER-1608 - SOLR resource lookup fails with basic auth

2017-05-23 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59489/ --- Review request for ranger. Bugs: RANGER-1608 https://issues.apache.org/jira

[jira] [Updated] (RANGER-1608) SOLR resource lookup fails with basic auth

2017-05-23 Thread Colm O hEigeartaigh (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colm O hEigeartaigh updated RANGER-1608: Attachment: 0001-RANGER-1608-SOLR-resource-lookup-fails-with-basic-au.patch > SOLR

[jira] [Created] (RANGER-1608) SOLR resource lookup fails with basic auth

2017-05-23 Thread Colm O hEigeartaigh (JIRA)
Colm O hEigeartaigh created RANGER-1608: --- Summary: SOLR resource lookup fails with basic auth Key: RANGER-1608 URL: https://issues.apache.org/jira/browse/RANGER-1608 Project: Ranger Iss

Re: Review Request 59486: These invalid codes that were copied have not been deleted in db_setup.py for the Ranger admin

2017-05-23 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59486/#review175784 --- Ship it! Ship It! - Colm O hEigeartaigh On May 23, 2017, 8:5

[jira] [Updated] (RANGER-1607) Ranger service check failed on SLES11.3 cluster with sslv3 alert handshake failure

2017-05-23 Thread Ankita Sinha (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankita Sinha updated RANGER-1607: - Attachment: RANGER-1607.patch > Ranger service check failed on SLES11.3 cluster with sslv3 alert

[jira] [Created] (RANGER-1607) Ranger service check failed on SLES11.3 cluster with sslv3 alert handshake failure

2017-05-23 Thread Ankita Sinha (JIRA)
Ankita Sinha created RANGER-1607: Summary: Ranger service check failed on SLES11.3 cluster with sslv3 alert handshake failure Key: RANGER-1607 URL: https://issues.apache.org/jira/browse/RANGER-1607 Pr

Re: Review Request 59486: These invalid codes that were copied have not been deleted in db_setup.py for the Ranger admin

2017-05-23 Thread pengjianhua
> On 五月 23, 2017, 9:05 a.m., Colm O hEigeartaigh wrote: > > Could you describe why they are invalid? className = re.match("(Patch.*?)_.*.class",filename) className = className.group(1) The className variable is not used in the current loop. This segment code is copied from other places. These e

Re: Review Request 59436: In install.properties, I configured the testusr user and the testgroup groups that not exist in system. The error “chown: invalid user: testusr:testgroup” occured during inst

2017-05-23 Thread pengjianhua
> On 五月 23, 2017, 9:08 a.m., Colm O hEigeartaigh wrote: > > I'm not sure about the changed logic to be honest. If the user or group > > doesn't exist, wouldn't it be better to print an error message and abort? Initially, I was consistent with your idea. The original developer is to determine w

[jira] [Commented] (RANGER-1602) Include / Exclude toggle not working for same level resources

2017-05-23 Thread Gautam Borad (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16020976#comment-16020976 ] Gautam Borad commented on RANGER-1602: -- Committed to master : 56e28489607eb7e7da68a7

Re: Review Request 59479: RangerUI: Include / Exclude toggle not working for same level resources.

2017-05-23 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59479/#review175780 --- Ship it! Ship It! - Velmurugan Periasamy On May 23, 2017, 6:

Re: Review Request 59479: RangerUI: Include / Exclude toggle not working for same level resources.

2017-05-23 Thread Ankita Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59479/#review175779 --- Ship it! Ship It! - Ankita Sinha On May 23, 2017, 6:13 a.m.,

Re: Review Request 59376: RANGER-1584 Allow tagsync to support log directory from Ambari configuration

2017-05-23 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59376/#review175775 --- Ship it! Ship It! - Colm O hEigeartaigh On May 18, 2017, 8:3

Re: Review Request 59436: In install.properties, I configured the testusr user and the testgroup groups that not exist in system. The error “chown: invalid user: testusr:testgroup” occured during inst

2017-05-23 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59436/#review175774 --- I'm not sure about the changed logic to be honest. If the user or

Re: Review Request 59486: These invalid codes that were copied have not been deleted in db_setup.py for the Ranger admin

2017-05-23 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59486/#review175773 --- Could you describe why they are invalid? - Colm O hEigeartaigh

Re: Review Request 59275: RANGER-1580 - Update Kafka tests to work with 0.10.1.1

2017-05-23 Thread Qiang Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59275/#review175772 --- Ship it! Ship It! - Qiang Zhang On 五月 16, 2017, 12:20 p.m.,

Review Request 59486: These invalid codes that were copied have not been deleted in db_setup.py for the Ranger admin

2017-05-23 Thread pengjianhua
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59486/ --- Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEige

[jira] [Updated] (RANGER-1605) These invalid codes that were copied have not been deleted in db_setup.py for the Ranger admin

2017-05-23 Thread peng.jianhua (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] peng.jianhua updated RANGER-1605: - Attachment: 0001-RANGER-1605-These-invalid-codes-that-were-copied-hav.patch > These invalid codes

[jira] [Created] (RANGER-1606) Case insensitive user/group ACL matching

2017-05-23 Thread Hari Sekhon (JIRA)
Hari Sekhon created RANGER-1606: --- Summary: Case insensitive user/group ACL matching Key: RANGER-1606 URL: https://issues.apache.org/jira/browse/RANGER-1606 Project: Ranger Issue Type: Improveme

[jira] [Created] (RANGER-1605) These invalid codes that were copied have not been deleted in db_setup.py for the Ranger admin

2017-05-23 Thread peng.jianhua (JIRA)
peng.jianhua created RANGER-1605: Summary: These invalid codes that were copied have not been deleted in db_setup.py for the Ranger admin Key: RANGER-1605 URL: https://issues.apache.org/jira/browse/RANGER-1605

[jira] [Updated] (RANGER-1604) DB based auditing had been removed in RANGER-900. But some configurations and codes are not removed accordingly in Ranger Admin. It often makes the user feel confused su

2017-05-23 Thread Qiang Zhang (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qiang Zhang updated RANGER-1604: Description: DB based auditing had been removed in RANGER-900. But some configurations and codes a