Re: Code conventions

2020-01-21 Thread Lars Francke
Hi Pradeep, thank you for getting back to me and pointing me at your issue. As a newcomer to a project, I agree that it'd be a tremendous help if things were a bit more consistent. Cheers, Lars On Wed, Jan 22, 2020 at 6:15 AM PradeeP AgrawaL < pradeepagrawal8...@gmail.com> wrote: > Hi Lars, > >

Re: Review Request 71999: RANGER-2697: Usersync and Ranger admin changes to support retriving additional user/group attributes from LDAP/AD

2020-01-21 Thread Sailaja Polavarapu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71999/ --- (Updated Jan. 22, 2020, 7:02 a.m.) Review request for ranger. Changes ---

Re: Code conventions

2020-01-21 Thread PradeeP AgrawaL
Hi Lars, There is no specific code conventions and checkstyle being followed currently, but important reviews are given during patch review process. I created one JIRA RANGER-2588 to implement checkstyle. I might need suggestion on that from community. This might force me to make changes in all th

Re: Review Request 71993: RANGER-2699 : JVM metrics for Ranger usersync and Ranger tagsync

2020-01-21 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71993/#review219347 --- tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncCo

Re: Review Request 72010: RANGER-2688: Make cookie name configurable

2020-01-21 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72010/#review219346 --- Ship it! Ship It! - Abhay Kulkarni On Jan. 18, 2020, 6:08 p.

[jira] [Commented] (RANGER-2689) Support multiple versions of Hive

2020-01-21 Thread Andrew Charneski (Jira)
[ https://issues.apache.org/jira/browse/RANGER-2689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17020400#comment-17020400 ] Andrew Charneski commented on RANGER-2689: -- My largest concern with that approa

Call for presentations for ApacheCon North America 2020 now open

2020-01-21 Thread Rich Bowen
Dear Apache enthusiast, (You’re receiving this message because you are subscribed to one or more project mailing lists at the Apache Software Foundation.) The call for presentations for ApacheCon North America 2020 is now open at https://apachecon.com/acna2020/cfp ApacheCon will be held at

[jira] [Updated] (RANGER-2694) TagSync fails to start due to NoClassDefFoundError

2020-01-21 Thread Velmurugan Periasamy (Jira)
[ https://issues.apache.org/jira/browse/RANGER-2694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Velmurugan Periasamy updated RANGER-2694: - Fix Version/s: 2.1.0 > TagSync fails to start due to NoClassDefFoundError >

[jira] [Updated] (RANGER-2665) Policy engine for delegate-admin processing is not built correctly when policy-deltas are enabled and a zone policy is updated

2020-01-21 Thread Velmurugan Periasamy (Jira)
[ https://issues.apache.org/jira/browse/RANGER-2665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Velmurugan Periasamy updated RANGER-2665: - Fix Version/s: 2.1.0 > Policy engine for delegate-admin processing is not built

[jira] [Updated] (RANGER-2666) Rename matchType and matchScope enumerators to more descriptive names

2020-01-21 Thread Velmurugan Periasamy (Jira)
[ https://issues.apache.org/jira/browse/RANGER-2666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Velmurugan Periasamy updated RANGER-2666: - Fix Version/s: 2.1.0 > Rename matchType and matchScope enumerators to more descr

[jira] [Updated] (RANGER-2668) Remove tag service linking for any service created in Ranger KMS

2020-01-21 Thread Velmurugan Periasamy (Jira)
[ https://issues.apache.org/jira/browse/RANGER-2668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Velmurugan Periasamy updated RANGER-2668: - Fix Version/s: 2.1.0 > Remove tag service linking for any service created in Ran

[jira] [Updated] (RANGER-2667) Running the disable-presto-plugin.sh script will always get stuck

2020-01-21 Thread Velmurugan Periasamy (Jira)
[ https://issues.apache.org/jira/browse/RANGER-2667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Velmurugan Periasamy updated RANGER-2667: - Fix Version/s: 2.1.0 > Running the disable-presto-plugin.sh script will always g

[jira] [Updated] (RANGER-2671) Running the setup.sh in usersync a second time will change the permissions and owner of hadoop core-site.xml

2020-01-21 Thread Velmurugan Periasamy (Jira)
[ https://issues.apache.org/jira/browse/RANGER-2671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Velmurugan Periasamy updated RANGER-2671: - Fix Version/s: 2.1.0 > Running the setup.sh in usersync a second time will chang

[jira] [Updated] (RANGER-2674) Allow service admins to manage tag policies

2020-01-21 Thread Velmurugan Periasamy (Jira)
[ https://issues.apache.org/jira/browse/RANGER-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Velmurugan Periasamy updated RANGER-2674: - Fix Version/s: 2.1.0 > Allow service admins to manage tag policies > ---

[jira] [Updated] (RANGER-2678) RangerUgSyncRESTClient sets password as username for basic auth

2020-01-21 Thread Velmurugan Periasamy (Jira)
[ https://issues.apache.org/jira/browse/RANGER-2678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Velmurugan Periasamy updated RANGER-2678: - Fix Version/s: 2.1.0 > RangerUgSyncRESTClient sets password as username for basi

[jira] [Updated] (RANGER-2676) Before obtaining AuthzAuditEvent Object should check xasecure.audit.destination.xx value

2020-01-21 Thread Velmurugan Periasamy (Jira)
[ https://issues.apache.org/jira/browse/RANGER-2676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Velmurugan Periasamy updated RANGER-2676: - Fix Version/s: (was: 2.0.0) > Before obtaining AuthzAuditEvent Object should

[jira] [Updated] (RANGER-2679) upgrade spring framework version to 4.3.23 to be compatible with current spring security version(4.2.13)

2020-01-21 Thread Velmurugan Periasamy (Jira)
[ https://issues.apache.org/jira/browse/RANGER-2679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Velmurugan Periasamy updated RANGER-2679: - Fix Version/s: 2.1.0 > upgrade spring framework version to 4.3.23 to be compatib

[jira] [Updated] (RANGER-2680) Ranger Usersync and Tagsync is not updating session cookie until restart

2020-01-21 Thread Velmurugan Periasamy (Jira)
[ https://issues.apache.org/jira/browse/RANGER-2680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Velmurugan Periasamy updated RANGER-2680: - Fix Version/s: 2.1.0 > Ranger Usersync and Tagsync is not updating session cooki

[jira] [Resolved] (RANGER-2681) CVE-2019-12397: Apache Ranger cross site scripting issue

2020-01-21 Thread Velmurugan Periasamy (Jira)
[ https://issues.apache.org/jira/browse/RANGER-2681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Velmurugan Periasamy resolved RANGER-2681. -- Resolution: Information Provided > CVE-2019-12397: Apache Ranger cross site sc

[jira] [Commented] (RANGER-2681) CVE-2019-12397: Apache Ranger cross site scripting issue

2020-01-21 Thread Velmurugan Periasamy (Jira)
[ https://issues.apache.org/jira/browse/RANGER-2681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17020252#comment-17020252 ] Velmurugan Periasamy commented on RANGER-2681: -- https://issues.apache.org/j

[jira] [Updated] (RANGER-2685) set_globals.sh will throw an exception "cp ews/logs/* failed"

2020-01-21 Thread Velmurugan Periasamy (Jira)
[ https://issues.apache.org/jira/browse/RANGER-2685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Velmurugan Periasamy updated RANGER-2685: - Fix Version/s: 2.1.0 > set_globals.sh will throw an exception "cp ews/logs/* fai

[jira] [Updated] (RANGER-2692) RangerKafkaAuthorizer support for ConsumerGroup resource for authorization

2020-01-21 Thread Velmurugan Periasamy (Jira)
[ https://issues.apache.org/jira/browse/RANGER-2692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Velmurugan Periasamy updated RANGER-2692: - Fix Version/s: 2.1.0 > RangerKafkaAuthorizer support for ConsumerGroup resource

[jira] [Updated] (RANGER-2691) Upgrade with MsSQL fails because of invalid syntax

2020-01-21 Thread Velmurugan Periasamy (Jira)
[ https://issues.apache.org/jira/browse/RANGER-2691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Velmurugan Periasamy updated RANGER-2691: - Fix Version/s: 2.1.0 > Upgrade with MsSQL fails because of invalid syntax >

[jira] [Updated] (RANGER-2702) Upgrade Kafka Version in Ranger to 2.4

2020-01-21 Thread Velmurugan Periasamy (Jira)
[ https://issues.apache.org/jira/browse/RANGER-2702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Velmurugan Periasamy updated RANGER-2702: - Fix Version/s: 2.1.0 > Upgrade Kafka Version in Ranger to 2.4 >

[jira] [Updated] (RANGER-2701) Improve Logging mechanism for Ranger KMS

2020-01-21 Thread Velmurugan Periasamy (Jira)
[ https://issues.apache.org/jira/browse/RANGER-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Velmurugan Periasamy updated RANGER-2701: - Fix Version/s: 2.1.0 > Improve Logging mechanism for Ranger KMS > --

[jira] [Updated] (RANGER-2703) Grant operation succeeds even though there is no delegate admin permission

2020-01-21 Thread Velmurugan Periasamy (Jira)
[ https://issues.apache.org/jira/browse/RANGER-2703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Velmurugan Periasamy updated RANGER-2703: - Fix Version/s: 2.1.0 > Grant operation succeeds even though there is no delegate

[jira] [Updated] (RANGER-2696) Fix unit test failure in TestPolicyEngine.testValiditySchedulerApplicable

2020-01-21 Thread Velmurugan Periasamy (Jira)
[ https://issues.apache.org/jira/browse/RANGER-2696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Velmurugan Periasamy updated RANGER-2696: - Fix Version/s: 2.1.0 > Fix unit test failure in TestPolicyEngine.testValiditySch

[jira] [Updated] (RANGER-2695) Default displayName for ServiceDef

2020-01-21 Thread Velmurugan Periasamy (Jira)
[ https://issues.apache.org/jira/browse/RANGER-2695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Velmurugan Periasamy updated RANGER-2695: - Fix Version/s: 2.1.0 > Default displayName for ServiceDef >

[jira] [Commented] (RANGER-2621) Ranger Policy Update fails on Kerberized Cluster

2020-01-21 Thread Leandro Loos (Jira)
[ https://issues.apache.org/jira/browse/RANGER-2621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17020237#comment-17020237 ] Leandro Loos commented on RANGER-2621: -- [~susidev33] were you able to work the issu

[jira] [Assigned] (RANGER-2708) Ranger public group check uses wrong comparison for equality

2020-01-21 Thread Lars Francke (Jira)
[ https://issues.apache.org/jira/browse/RANGER-2708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Francke reassigned RANGER-2708: Assignee: Lars Francke > Ranger public group check uses wrong comparison for equality > -

[jira] [Assigned] (RANGER-2706) usermapsyncenabled can be removed from code

2020-01-21 Thread Lars Francke (Jira)
[ https://issues.apache.org/jira/browse/RANGER-2706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Francke reassigned RANGER-2706: Assignee: Lars Francke > usermapsyncenabled can be removed from code > --

[jira] [Assigned] (RANGER-2707) ranger.usersync.enabled not respected on initial ugsync startup

2020-01-21 Thread Lars Francke (Jira)
[ https://issues.apache.org/jira/browse/RANGER-2707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Francke reassigned RANGER-2707: Assignee: Lars Francke > ranger.usersync.enabled not respected on initial ugsync startup

Re: Add to contributor list

2020-01-21 Thread Lars Francke
Thank you! On Tue, Jan 21, 2020 at 1:58 PM Velmurugan Periasamy wrote: > Hi - welcome to Ranger community. I have added you as a contributor. > Thanks. > > On Tue, Jan 21, 2020 at 5:50 AM Lars Francke > wrote: > Hi, > > could someone add me "larsfrancke" to the contributor group so I can assign

[jira] [Comment Edited] (RANGER-2689) Support multiple versions of Hive

2020-01-21 Thread Velmurugan Periasamy (Jira)
[ https://issues.apache.org/jira/browse/RANGER-2689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17020214#comment-17020214 ] Velmurugan Periasamy edited comment on RANGER-2689 at 1/21/20 1:03 PM: ---

[jira] [Commented] (RANGER-2689) Support multiple versions of Hive

2020-01-21 Thread Velmurugan Periasamy (Jira)
[ https://issues.apache.org/jira/browse/RANGER-2689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17020214#comment-17020214 ] Velmurugan Periasamy commented on RANGER-2689: -- Instead of splitting the hi

Re: Add to contributor list

2020-01-21 Thread Velmurugan Periasamy
Hi - welcome to Ranger community. I have added you as a contributor. Thanks. On Tue, Jan 21, 2020 at 5:50 AM Lars Francke wrote: Hi, could someone add me "larsfrancke" to the contributor group so I can assign myself issues? Thank you, Lars

Review Request 72032: RANGER-2708 Ranger public group check uses wrong comparison for equality

2020-01-21 Thread Lars Francke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72032/ --- Review request for ranger. Bugs: RANGER-2708 https://issues.apache.org/jira

[jira] [Updated] (RANGER-2708) Ranger public group check uses wrong comparison for equality

2020-01-21 Thread Lars Francke (Jira)
[ https://issues.apache.org/jira/browse/RANGER-2708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Francke updated RANGER-2708: - Attachment: RANGER-2708.1.patch > Ranger public group check uses wrong comparison for equality >

[jira] [Created] (RANGER-2708) Ranger public group check uses wrong comparison for equality

2020-01-21 Thread Lars Francke (Jira)
Lars Francke created RANGER-2708: Summary: Ranger public group check uses wrong comparison for equality Key: RANGER-2708 URL: https://issues.apache.org/jira/browse/RANGER-2708 Project: Ranger

Add to contributor list

2020-01-21 Thread Lars Francke
Hi, could someone add me "larsfrancke" to the contributor group so I can assign myself issues? Thank you, Lars

Review Request 72031: RANGER-2707 ranger.usersync.enabled not respected on initial ugsync startup

2020-01-21 Thread Lars Francke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72031/ --- Review request for ranger. Bugs: RANGER-2707 https://issues.apache.org/jira

[jira] [Updated] (RANGER-2707) ranger.usersync.enabled not respected on initial ugsync startup

2020-01-21 Thread Lars Francke (Jira)
[ https://issues.apache.org/jira/browse/RANGER-2707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Francke updated RANGER-2707: - Attachment: RANGER-2707.1.patch > ranger.usersync.enabled not respected on initial ugsync startu

[jira] [Created] (RANGER-2707) ranger.usersync.enabled not respected on initial ugsync startup

2020-01-21 Thread Lars Francke (Jira)
Lars Francke created RANGER-2707: Summary: ranger.usersync.enabled not respected on initial ugsync startup Key: RANGER-2707 URL: https://issues.apache.org/jira/browse/RANGER-2707 Project: Ranger

Code conventions

2020-01-21 Thread Lars Francke
Hi Ranger devs, I've stumbled through the Ranger code base in the last few days and might have a few things to contribute but I'm wondering if you have any kind of code conventions? I'm asking because there's tabs being used as well as spaces and that's just one of the things that struck me. It s

Review Request 72030: RANGER-2706 usermapsyncenabled can be removed from code

2020-01-21 Thread Lars Francke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72030/ --- Review request for ranger. Bugs: RANGER-2706 https://issues.apache.org/jira

[jira] [Updated] (RANGER-2706) usermapsyncenabled can be removed from code

2020-01-21 Thread Lars Francke (Jira)
[ https://issues.apache.org/jira/browse/RANGER-2706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Francke updated RANGER-2706: - Attachment: RANGER-2706.1.patch > usermapsyncenabled can be removed from code >

[jira] [Updated] (RANGER-2705) Group sync does does not parse DNs properly

2020-01-21 Thread Lars Francke (Jira)
[ https://issues.apache.org/jira/browse/RANGER-2705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Francke updated RANGER-2705: - Description: When we have enabled user & group search ({{ranger.usersync.group.search.first.ena

[jira] [Created] (RANGER-2706) usermapsyncenabled can be removed from code

2020-01-21 Thread Lars Francke (Jira)
Lars Francke created RANGER-2706: Summary: usermapsyncenabled can be removed from code Key: RANGER-2706 URL: https://issues.apache.org/jira/browse/RANGER-2706 Project: Ranger Issue Type: Impr

[jira] [Updated] (RANGER-2705) Group sync does does not parse DNs properly

2020-01-21 Thread Lars Francke (Jira)
[ https://issues.apache.org/jira/browse/RANGER-2705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Francke updated RANGER-2705: - Description: When we have enabled user & group search ({{ranger.usersync.group.search.first.ena

[jira] [Updated] (RANGER-2705) Group sync does does not parse DNs properly

2020-01-21 Thread Lars Francke (Jira)
[ https://issues.apache.org/jira/browse/RANGER-2705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Francke updated RANGER-2705: - Summary: Group sync does does not parse DNs properly (was: Group sync does not respect ldap.use

[jira] [Updated] (RANGER-2705) Group sync does not respect ldap.user.nameattribute

2020-01-21 Thread Lars Francke (Jira)
[ https://issues.apache.org/jira/browse/RANGER-2705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Francke updated RANGER-2705: - Description: When we have enabled user & group search ({{ranger.usersync.group.search.first.ena

[jira] [Updated] (RANGER-2705) Group sync does not respect ldap.user.nameattribute

2020-01-21 Thread Lars Francke (Jira)
[ https://issues.apache.org/jira/browse/RANGER-2705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Francke updated RANGER-2705: - Description: When we have enabled user & group search ({{ranger.usersync.group.search.first.ena