Re: Review Request 74144: RANGER-3934: optimization in loading of tags into cache

2022-09-28 Thread Madhan Neethiraj
> On Sept. 29, 2022, 12:31 a.m., Abhay Kulkarni wrote: > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerServiceTagsDeltaUtil.java > > Line 107 (original), 101 (patched) > > > > > > This conversio

Re: Review Request 74144: RANGER-3934: optimization in loading of tags into cache

2022-09-28 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74144/ --- (Updated Sept. 29, 2022, 6:46 a.m.) Review request for ranger, Ankita Sinha, Ki

Re: Review Request 74147: Ranger KMS generates master key on every restart before inserting into DB

2022-09-28 Thread Vikas Kumar
> On Sept. 28, 2022, 6:05 p.m., Ramesh Mani wrote: > > kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java > > Lines 412 (patched) > > > > > > can the daoManager be null if so do null check. Thanks f

Re: Review Request 74147: Ranger KMS generates master key on every restart before inserting into DB

2022-09-28 Thread Vikas Kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74147/ --- (Updated Sept. 29, 2022, 6:44 a.m.) Review request for ranger, Dhaval Shah and

[jira] [Commented] (RANGER-3935) In hdfs authorizer 'processResult', is accessType and action misused?

2022-09-28 Thread Xuze Yang (Jira)
[ https://issues.apache.org/jira/browse/RANGER-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17610791#comment-17610791 ] Xuze Yang commented on RANGER-3935: --- Yes, I think the code is confusing the two. The a

[jira] [Created] (RANGER-3935) In hdfs authorizer 'processResult', is accessType and action misused?

2022-09-28 Thread wangningito (Jira)
wangningito created RANGER-3935: --- Summary: In hdfs authorizer 'processResult', is accessType and action misused? Key: RANGER-3935 URL: https://issues.apache.org/jira/browse/RANGER-3935 Project: Ranger

Re: Review Request 73694: RANGER-3500: Ranger policy list doesn't support sorting by field

2022-09-28 Thread Xuze Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73694/ --- (Updated 九月 29, 2022, 2:37 a.m.) Review request for ranger, Abhay Kulkarni, Mad

[jira] [Commented] (RANGER-3500) Ranger policy list doesn't support sorting by field

2022-09-28 Thread Xuze Yang (Jira)
[ https://issues.apache.org/jira/browse/RANGER-3500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17610773#comment-17610773 ] Xuze Yang commented on RANGER-3500: --- The changes are as following: 1. Add sortBy and s

[jira] [Updated] (RANGER-3500) Ranger policy list doesn't support sorting by field

2022-09-28 Thread Xuze Yang (Jira)
[ https://issues.apache.org/jira/browse/RANGER-3500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xuze Yang updated RANGER-3500: -- Attachment: 0002-RANGER-3500-Ranger-policy-list-doesn-t-support-sorti.patch > Ranger policy list doesn

[jira] [Updated] (RANGER-3500) Ranger policy list doesn't support sorting by field

2022-09-28 Thread Xuze Yang (Jira)
[ https://issues.apache.org/jira/browse/RANGER-3500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xuze Yang updated RANGER-3500: -- Description: When getting the ranger policy list, we may want to sort the returned policy list accord

Re: Review Request 74144: RANGER-3934: optimization in loading of tags into cache

2022-09-28 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74144/#review224719 --- agents-common/src/main/java/org/apache/ranger/plugin/util/RangerS

Re: Review Request 74144: RANGER-3934: optimization in loading of tags into cache

2022-09-28 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74144/ --- (Updated Sept. 28, 2022, 10:58 p.m.) Review request for ranger, Ankita Sinha, K

Re: Review Request 74144: RANGER-3934: optimization in loading of tags into cache

2022-09-28 Thread Madhan Neethiraj
> On Sept. 28, 2022, 6:12 p.m., Abhay Kulkarni wrote: > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerServiceTagsDeltaUtil.java > > Line 102 (original), 105 (patched) > > > > > > This needs a revi

Re: Review Request 74144: RANGER-3934: optimization in loading of tags into cache

2022-09-28 Thread Abhay Kulkarni
> On Sept. 28, 2022, 6:12 p.m., Abhay Kulkarni wrote: > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerServiceTagsDeltaUtil.java > > Line 102 (original), 105 (patched) > > > > > > This needs a revi

Re: Review Request 74144: RANGER-3934: optimization in loading of tags into cache

2022-09-28 Thread Madhan Neethiraj
> On Sept. 28, 2022, 6:12 p.m., Abhay Kulkarni wrote: > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerServiceTagsDeltaUtil.java > > Line 102 (original), 105 (patched) > > > > > > This needs a revi

Re: Review Request 74144: RANGER-3934: optimization in loading of tags into cache

2022-09-28 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74144/#review224714 --- agents-common/src/main/java/org/apache/ranger/plugin/util/RangerS

Re: Review Request 74147: Ranger KMS generates master key on every restart before inserting into DB

2022-09-28 Thread Ramesh Mani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74147/#review224715 --- kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.ja

Re: Review Request 74124: RANGER-3913: Reduce number of calls to FilenameUtils.wildcardMatch() when evaluating resource matching

2022-09-28 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74124/#review224713 --- Ship it! Ship It! - Madhan Neethiraj On Sept. 27, 2022, 6:13

[jira] [Commented] (RANGER-3900) Roles deletion Takes time in Apache Ranger when there are more users,groups,roles

2022-09-28 Thread Ramachandran (Jira)
[ https://issues.apache.org/jira/browse/RANGER-3900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17610623#comment-17610623 ] Ramachandran commented on RANGER-3900: -- The review is available here :[https://revi

Review Request 74148: Roles deletion Takes time in Apache Ranger when there are more users, groups, roles

2022-09-28 Thread Ramachandran Krishnan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74148/ --- Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Nikhil P, Pradeep A

[jira] [Updated] (RANGER-3900) Roles deletion Takes time in Apache Ranger when there are more users,groups,roles

2022-09-28 Thread Ramachandran (Jira)
[ https://issues.apache.org/jira/browse/RANGER-3900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ramachandran updated RANGER-3900: - Summary: Roles deletion Takes time in Apache Ranger when there are more users,groups,roles (was

[jira] [Updated] (RANGER-3929) To support batching in SQL IN clause of SQL queries used in Ranger

2022-09-28 Thread Ramachandran (Jira)
[ https://issues.apache.org/jira/browse/RANGER-3929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ramachandran updated RANGER-3929: - Attachment: 0001-RANGER-3929-To-support-batching-in-SQL-IN-clause-of-.patch > To support batchin

Re: Review Request 74131: Logback.xml has been incorrectly modified by RANGER-3704.

2022-09-28 Thread Ramachandran Krishnan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74131/ --- (Updated Sept. 28, 2022, 3:02 p.m.) Review request for ranger, Madhan Neethiraj

Re: Review Request 74131: Logback.xml has been incorrectly modified by RANGER-3704.

2022-09-28 Thread Ramachandran Krishnan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74131/ --- (Updated Sept. 28, 2022, 2:54 p.m.) Review request for ranger, Madhan Neethiraj

Re: Review Request 74131: Logback.xml has been incorrectly modified by RANGER-3704.

2022-09-28 Thread Ramachandran Krishnan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74131/ --- (Updated Sept. 28, 2022, 2:50 p.m.) Review request for ranger, Madhan Neethiraj

[jira] [Commented] (RANGER-3927) Ranger KMS generates master key on every restart before inserting into DB

2022-09-28 Thread Vikas Kumar (Jira)
[ https://issues.apache.org/jira/browse/RANGER-3927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17610603#comment-17610603 ] Vikas Kumar commented on RANGER-3927: - Review request : https://reviews.apache.org/r

Review Request 74147: Ranger KMS generates master key on every restart before inserting into DB

2022-09-28 Thread Vikas Kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74147/ --- Review request for ranger and Sailaja Polavarapu. Bugs: RANGER-3927 https:/

Review Request 74146: RANGER-3825: Ranger admin user is unable to change another user email after the upgrade

2022-09-28 Thread Pradeep Agrawal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74146/ --- Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Nikhil P, Pradeep A

[jira] [Commented] (RANGER-3825) Ranger internal user is unable to change his password after the upgrade.

2022-09-28 Thread Pradeep Agrawal (Jira)
[ https://issues.apache.org/jira/browse/RANGER-3825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17610583#comment-17610583 ] Pradeep Agrawal commented on RANGER-3825: - This Jira commit is causing below pro

[jira] [Reopened] (RANGER-3825) Ranger internal user is unable to change his password after the upgrade.

2022-09-28 Thread Pradeep Agrawal (Jira)
[ https://issues.apache.org/jira/browse/RANGER-3825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pradeep Agrawal reopened RANGER-3825: - > Ranger internal user is unable to change his password after the upgrade. > ---

[jira] [Comment Edited] (RANGER-3927) Ranger KMS generates master key on every restart before inserting into DB

2022-09-28 Thread Vikas Kumar (Jira)
[ https://issues.apache.org/jira/browse/RANGER-3927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17610564#comment-17610564 ] Vikas Kumar edited comment on RANGER-3927 at 9/28/22 1:22 PM:

[jira] [Updated] (RANGER-3927) Ranger KMS generates master key on every restart before inserting into DB

2022-09-28 Thread Vikas Kumar (Jira)
[ https://issues.apache.org/jira/browse/RANGER-3927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vikas Kumar updated RANGER-3927: Attachment: 0001-RANGER-3927-Avoid-Master-Key-regeneration-on-every-r.patch > Ranger KMS generates

[jira] [Commented] (RANGER-3927) Ranger KMS generates master key on every restart before inserting into DB

2022-09-28 Thread Vikas Kumar (Jira)
[ https://issues.apache.org/jira/browse/RANGER-3927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17610564#comment-17610564 ] Vikas Kumar commented on RANGER-3927: - *Issue:* Master Key(MK) was being first gener

Re: Review Request 74131: Logback.xml has been incorrectly modified by RANGER-3704.

2022-09-28 Thread Ramachandran Krishnan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74131/ --- (Updated Sept. 28, 2022, 11:19 a.m.) Review request for ranger, Madhan Neethira

Re: Review Request 74131: Logback.xml has been incorrectly modified by RANGER-3704.

2022-09-28 Thread Ramachandran Krishnan
> On Sept. 28, 2022, 9:19 a.m., Kirby Zhou wrote: > > There was an error displaying this diff. > > > > > > The patch to 'security-admin/src/main/resources/conf.dist/logback.xml' > > didn't apply cleanly. The temporary files have been left in > > '/tmp/reviewboard.joRCmj' for debugging

Re: Review Request 74136: RANGER-3685:hive 'show' sql produces excessive audit log

2022-09-28 Thread Xuze Yang
> On 九月 28, 2022, 9:15 a.m., Kirby Zhou wrote: > > Why modify filterListCmdObjects() only? filterListCmdObjects() will filter out any objects that should not be shown to the user, from the list of tables or databases coming from a 'show tables' or 'show databases' command. This patch gives an

Re: Review Request 74131: Logback.xml has been incorrectly modified by RANGER-3704.

2022-09-28 Thread Ramachandran Krishnan
> On Sept. 28, 2022, 9:19 a.m., Kirby Zhou wrote: > > There was an error displaying this diff. > > > > > > The patch to 'security-admin/src/main/resources/conf.dist/logback.xml' > > didn't apply cleanly. The temporary files have been left in > > '/tmp/reviewboard.joRCmj' for debugging

Re: Review Request 74131: Logback.xml has been incorrectly modified by RANGER-3704.

2022-09-28 Thread Kirby Zhou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74131/#review224708 --- There was an error displaying this diff. The patch to 's

[jira] [Commented] (RANGER-3775) Logback.xml has been incorrectly modified by RANGER-3704.

2022-09-28 Thread kirby zhou (Jira)
[ https://issues.apache.org/jira/browse/RANGER-3775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17610461#comment-17610461 ] kirby zhou commented on RANGER-3775: It works > Logback.xml has been incorrectly mo

Re: Review Request 74136: RANGER-3685:hive 'show' sql produces excessive audit log

2022-09-28 Thread Kirby Zhou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74136/#review224707 --- Why modify filterListCmdObjects() only? - Kirby Zhou On 九月 24,

Re: Review Request 74134: RANGER-3888, RANGER-3887, RANGER-3886, RANGER-3931: Validity Scheduler , recurrence schedule: added validation

2022-09-28 Thread Dineshkumar Yadav
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74134/ --- (Updated Sept. 28, 2022, 8:20 a.m.) Review request for ranger, Dhaval Shah, Jay