Re: Review Request 75222: RANGER-4948: optimize GDS policy engine to use a signle trie-set for all resources across data shares

2024-10-03 Thread Abhay Kulkarni
variable) is confusing to read. Please consider renaming local variable to differentiate between the two. - Abhay Kulkarni On Oct. 2, 2024, 12:14 a.m., Madhan Neethiraj wrote: > > --- > This is an automatically generated e-

Review Request 75215: RANGER-4938: Ensure that only one instance of Ranger plugin is created in an Ozone Manager process

2024-09-24 Thread Abhay Kulkarni
/RangerOzoneAuthorizer.java f67e182bd Diff: https://reviews.apache.org/r/75215/diff/1/ Testing --- Compiled clean and ran all unit tests successfully. Thanks, Abhay Kulkarni

[jira] [Created] (RANGER-4938) Ensure that only one instance of Ranger plugin is created in an Ozone Manager process

2024-09-24 Thread Abhay Kulkarni (Jira)
Abhay Kulkarni created RANGER-4938: -- Summary: Ensure that only one instance of Ranger plugin is created in an Ozone Manager process Key: RANGER-4938 URL: https://issues.apache.org/jira/browse/RANGER-4938

[jira] [Commented] (RANGER-4820) Support authorization of multiple accesses grouped by access groups in one policy engine call

2024-09-24 Thread Abhay Kulkarni (Jira)
[ https://issues.apache.org/jira/browse/RANGER-4820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884371#comment-17884371 ] Abhay Kulkarni commented on RANGER-4820: Addendum:  Review request: [h

Review Request 75206: RANGER-4820: Support authorization of multiple accesses grouped by access groups in one policy engine call - #2

2024-09-13 Thread Abhay Kulkarni
. Thanks, Abhay Kulkarni

Re: Review Request 75194: RANGER-4922: Reduce time to find tags associated with multi-level resource

2024-09-05 Thread Abhay Kulkarni
, Abhay Kulkarni

Re: Review Request 75198: RANGER-4889: updated RangerMemSizing tool to generate requests for the given resource key hierarchy only

2024-09-03 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75198/#review226895 --- Ship it! Ship It! - Abhay Kulkarni On Sept. 3, 2024, 10 p.m

Re: Review Request 75194: RANGER-4922: Reduce time to find tags associated with multi-level resource

2024-08-29 Thread Abhay Kulkarni
, avgTimeTaken=383638ns (repeated requests in previous run multiple times) Thanks, Abhay Kulkarni

[jira] [Created] (RANGER-4922) Reduce time to find tags associated with multi-level resource

2024-08-29 Thread Abhay Kulkarni (Jira)
Abhay Kulkarni created RANGER-4922: -- Summary: Reduce time to find tags associated with multi-level resource Key: RANGER-4922 URL: https://issues.apache.org/jira/browse/RANGER-4922 Project: Ranger

Re: Review Request 75183: RANGER-4911: support validity-schedule in datasets/projects to enable automatic expiry

2024-08-22 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75183/#review226877 --- Ship it! Ship It! - Abhay Kulkarni On Aug. 21, 2024, 5:24

Re: Review Request 75164: RANGER-4905: Reduce memory needed to create Ranger policy engine

2024-08-14 Thread Abhay Kulkarni
https://reviews.apache.org/r/75164/diff/6/ Testing (updated) --- Compiled and ran all unit test case successfully. Tested using dockerized Ranger. Ran ranger-mem-sizing tool with a large number of tags for Ozone service, and noticed about 32% less memory used by the policy engine. Thanks, Abhay Kulkarni

[jira] [Created] (RANGER-4905) Reduce memory needed to create Ranger policy engine

2024-08-14 Thread Abhay Kulkarni (Jira)
Abhay Kulkarni created RANGER-4905: -- Summary: Reduce memory needed to create Ranger policy engine Key: RANGER-4905 URL: https://issues.apache.org/jira/browse/RANGER-4905 Project: Ranger

Re: Review Request 75140: RANGER-4891: replaced use of PrivilegedAction with PrivilegedExceptionAction in calls to UserGroupInformation.doAs()

2024-08-12 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75140/#review226819 --- Ship it! Ship It! - Abhay Kulkarni On Aug. 8, 2024, 11:32

Re: Review Request 75138: RANGER-4889: updated RangerMemSizing to support access request evaluations

2024-08-08 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75138/#review226796 --- Ship it! Ship It! - Abhay Kulkarni On Aug. 6, 2024, 5:13

Re: Review Request 75151: RANGER-4893: enhanced trie to support custom handling of matches

2024-08-08 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75151/#review226794 --- Ship it! Ship It! - Abhay Kulkarni On Aug. 8, 2024, 7:46

Re: [VOTE] Release Apache Ranger version 2.5.0 - RC4

2024-08-05 Thread Abhay Kulkarni
Thank-you Bhavik for publishing the Apache Ranger 2.5.0 release candidate #4. +1 for release 2.5.0 RC4. - Verified hashes - Verified build with unit tests Thanks! Abhay On Mon, Aug 5, 2024 at 9:40 AM vishal suvagia wrote: > Thank-you Bhavik for publishing the Apache Ranger 2.5.0 relea

Re: Review Request 75084: RANGER-4852: De-duplicated tags do not work correctly when tag-deltas are enabled

2024-07-12 Thread Abhay Kulkarni
Expected behaviour as the tag is not associated with the table). 9. As hrt_21 user, try a select operation from table_2, it is denied. The expected behaviour in this scenario is that the select operation should be allowed as the tag is still associated with table_2. Thanks, Abhay Kulkarni

Re: Review Request 75084: RANGER-4852: De-duplicated tags do not work correctly when tag-deltas are enabled

2024-07-12 Thread Abhay Kulkarni
nd downloaded as part of tags download. - Abhay --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75084/#review22 -------

Review Request 75084: RANGER-4852: De-duplicated tags do not work correctly when tag-deltas are enabled

2024-07-11 Thread Abhay Kulkarni
viour in this scenario is that the select operation should be allowed as the tag is still associated with table_2. Thanks, Abhay Kulkarni

[jira] [Created] (RANGER-4852) De-duplicated tags do not work correctly when tag-deltas are enabled.

2024-07-11 Thread Abhay Kulkarni (Jira)
Abhay Kulkarni created RANGER-4852: -- Summary: De-duplicated tags do not work correctly when tag-deltas are enabled. Key: RANGER-4852 URL: https://issues.apache.org/jira/browse/RANGER-4852 Project

Re: Review Request 75071: RANGER-4835:RangerHiveAuthorizer audit enhancement for metadata operations like show table and databases

2024-06-28 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75071/#review226609 --- Ship it! Ship It! - Abhay Kulkarni On June 28, 2024, 10:45

Re: Review Request 75055: RANGER-4824: Remove ACL-based policy engine unit test code

2024-06-18 Thread Abhay Kulkarni
/TestPolicyEngineForDeltas.java 3e5086cdf Diff: https://reviews.apache.org/r/75055/diff/2/ Changes: https://reviews.apache.org/r/75055/diff/1-2/ Testing --- Compiled and ran all unit tests successfully. Thanks, Abhay Kulkarni

Review Request 75055: RANGER-4824: Remove ACL-based policy engine unit test code

2024-06-18 Thread Abhay Kulkarni
/ Testing --- Compiled and ran all unit tests successfully. Thanks, Abhay Kulkarni

Review Request 75052: RANGER-4823: Incorrect processing of downloaded policies in plugin when policy-deltas are enabled

2024-06-17 Thread Abhay Kulkarni
@JsonSerialize(include=JsonSerialize.Inclusion.NON_NULL) Diffs - agents-common/src/main/java/org/apache/ranger/plugin/util/ServicePolicies.java dd64a6767 Diff: https://reviews.apache.org/r/75052/diff/1/ Testing --- Ran all unit tests successfully Thanks, Abhay Kulkarni

[jira] [Created] (RANGER-4824) Remove ACL-based policy engine unit test code

2024-06-17 Thread Abhay Kulkarni (Jira)
Abhay Kulkarni created RANGER-4824: -- Summary: Remove ACL-based policy engine unit test code Key: RANGER-4824 URL: https://issues.apache.org/jira/browse/RANGER-4824 Project: Ranger Issue

[jira] [Created] (RANGER-4823) Incorrect processing of downloaded policies in plugin when policy-deltas are enabled

2024-06-17 Thread Abhay Kulkarni (Jira)
Abhay Kulkarni created RANGER-4823: -- Summary: Incorrect processing of downloaded policies in plugin when policy-deltas are enabled Key: RANGER-4823 URL: https://issues.apache.org/jira/browse/RANGER-4823

Re: Review Request 75047: RANGER-4820: Support authorization of multiple accesses grouped by access groups in one policy engine call

2024-06-17 Thread Abhay Kulkarni
Changes: https://reviews.apache.org/r/75047/diff/2-3/ Testing --- Updated the unit tests for muliple access (agents-common/src/test/resources/policyengine/test_policyengine_hdfs_multiple_accesses.json). Ran all unit tests successfully. Thanks, Abhay Kulkarni

Re: Review Request 75047: RANGER-4820: Support authorization of multiple accesses grouped by access groups in one policy engine call

2024-06-17 Thread Abhay Kulkarni
ply, visit: https://reviews.apache.org/r/75047/#review226540 ------- On June 15, 2024, 9:09 p.m., Abhay Kulkarni wrote: > > --- > This is an automatically ge

Re: Review Request 75047: RANGER-4820: Support authorization of multiple accesses grouped by access groups in one policy engine call

2024-06-15 Thread Abhay Kulkarni
n/src/test/resources/policyengine/test_policyengine_hdfs_multiple_accesses.json). Ran all unit tests successfully. Thanks, Abhay Kulkarni

[jira] [Assigned] (RANGER-4820) Support authorization of multiple accesses grouped by access groups in one policy engine call

2024-06-12 Thread Abhay Kulkarni (Jira)
[ https://issues.apache.org/jira/browse/RANGER-4820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhay Kulkarni reassigned RANGER-4820: -- Assignee: Abhay Kulkarni > Support authorization of multiple accesses grouped

Review Request 75047: RANGER-4820: Support authorization of multiple accesses grouped by access groups in one policy engine call

2024-06-12 Thread Abhay Kulkarni
adoop/RangerHdfsAuthorizer.java c892bced3 Diff: https://reviews.apache.org/r/75047/diff/1/ Testing --- Updated the unit tests for muliple access (agents-common/src/test/resources/policyengine/test_policyengine_hdfs_multiple_accesses.json). Ran all unit tests successfully. Thanks, Abhay Kulkarni

[jira] [Created] (RANGER-4820) Support authorization of multiple accesses grouped by access groups in one policy engine call

2024-06-12 Thread Abhay Kulkarni (Jira)
Abhay Kulkarni created RANGER-4820: -- Summary: Support authorization of multiple accesses grouped by access groups in one policy engine call Key: RANGER-4820 URL: https://issues.apache.org/jira/browse/RANGER-4820

Re: Review Request 75045: RANGER-4817: Optimize Ranger HDFS Authorization by combining multiple authorization calls

2024-06-12 Thread Abhay Kulkarni
ion/hadoop/RangerHdfsAuthorizer.java 22d0b450d Diff: https://reviews.apache.org/r/75045/diff/2/ Changes: https://reviews.apache.org/r/75045/diff/1-2/ Testing --- Passes all unit tests. Verified the optimization by setting the config parameter "ranger.hdfs.authz.enable.optimization" to true. Thanks, Abhay Kulkarni

Review Request 75045: RANGER-4817: Optimize Ranger HDFS Authorization by combining multiple authorization calls

2024-06-11 Thread Abhay Kulkarni
-- Passes all unit tests. Verified the optimization by setting the config parameter "ranger.hdfs.authz.enable.optimization" to true. Thanks, Abhay Kulkarni

[jira] [Assigned] (RANGER-4817) Optimize Ranger HDFS Authorization by combining multiple authorization calls

2024-06-11 Thread Abhay Kulkarni (Jira)
[ https://issues.apache.org/jira/browse/RANGER-4817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhay Kulkarni reassigned RANGER-4817: -- Assignee: Abhay Kulkarni > Optimize Ranger HDFS Authorization by combining multi

[jira] [Created] (RANGER-4817) Optimize Ranger HDFS Authorization by combining multiple authorization calls

2024-06-11 Thread Abhay Kulkarni (Jira)
Abhay Kulkarni created RANGER-4817: -- Summary: Optimize Ranger HDFS Authorization by combining multiple authorization calls Key: RANGER-4817 URL: https://issues.apache.org/jira/browse/RANGER-4817

Re: Review Request 75012: RANGER-4803: create a single x_trx_log_v2 record instead of multiple x_trx_log records

2024-06-06 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75012/#review226522 --- Ship it! Ship It! - Abhay Kulkarni On June 7, 2024, 12:42

Re: Review Request 75012: RANGER-4803: create a single x_trx_log_v2 record instead of multiple x_trx_log records

2024-06-06 Thread Abhay Kulkarni
ws.apache.org/r/75012/#comment314768> Please see if uidNameCache needs to be created here. There may be always only one VXTrxLogV2 object for a given transactionId. - Abhay Kulkarni On May 26, 2024, 7:37 a.m., Madhan Neethiraj wrote: > > --

Re: Review Request 74953: RANGER-4769: removed code duplication in generation of admin audit logs

2024-05-21 Thread Abhay Kulkarni
iews.apache.org/r/74953/#comment314681> This class duplicates many methods in AbstractAuditedResourceService class. Please review and see if the common methods can be moved to a base class. - Abhay Kulkarni On April 5, 2024, 10:56 p.m., Ma

Re: Review Request 74966: RANGER-4787: reduce plugin memory footprint by avoiding unnecessary creation of collections

2024-05-06 Thread Abhay Kulkarni
<https://reviews.apache.org/r/74966/#comment314625> The default value seems to be OptimalNullSafeSupplier. Should it be DefaultNullSafeSupplier? - Abhay Kulkarni On May 5, 2024, 8:43 a.m., Madhan Neethiraj wrote: > > --- > Thi

Re: Review Request 74966: RANGER-4787: reduce plugin memory footprint by avoiding unnecessary creation of collections

2024-05-01 Thread Abhay Kulkarni
to add respective objects to the Lists, Sets, HashMaps. This can be done either by searching entire code-base for such usages or by making such getter methods as private and fixing the compilation issues that are reported. Which way is used here to get this assurance? - Abhay Kulkarni On

Re: Review Request 74968: RANGER-4786: Ranger override policy is not working

2024-04-30 Thread Abhay Kulkarni
s.apache.org/r/74968/diff/2-3/ Testing --- Passed all unit tests. Ensured that the repro scenario yields correct evaluation result. Thanks, Abhay Kulkarni

Re: Review Request 74968: RANGER-4786: Ranger override policy is not working

2024-04-30 Thread Abhay Kulkarni
iews.apache.org/r/74968/diff/2/ Changes: https://reviews.apache.org/r/74968/diff/1-2/ Testing --- Passed all unit tests. Ensured that the repro scenario yields correct evaluation result. Thanks, Abhay Kulkarni

Review Request 74968: RANGER-4786: Ranger override policy is not working

2024-04-29 Thread Abhay Kulkarni
org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java ded8d0993 Diff: https://reviews.apache.org/r/74968/diff/1/ Testing --- Passed all unit tests. Ensured that the repro scenario yields correct evaluation result. Thanks, Abhay Kulkarni

[jira] [Assigned] (RANGER-4786) Ranger override policy is not working

2024-04-29 Thread Abhay Kulkarni (Jira)
[ https://issues.apache.org/jira/browse/RANGER-4786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhay Kulkarni reassigned RANGER-4786: -- Assignee: Abhay Kulkarni > Ranger override policy is not work

Re: Review Request 74834: RANGER-4650: Hive plugin should make column-type available in masking expression

2024-04-25 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74834/#review226401 --- Ship it! Ship It! - Abhay Kulkarni On Feb. 10, 2024, 5:17

Review Request 74952: RANGER-4767: Deleted policies are still taking effect if all policies for a security zone are deleted

2024-04-04 Thread Abhay Kulkarni
. Diffs - agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java 6a3d59dae Diff: https://reviews.apache.org/r/74952/diff/1/ Testing --- Compiled and ran all unit tests successfully. Verified by manually testing the scenario in the cluster. Thanks, Abhay

[jira] [Updated] (RANGER-4767) Deleted policies are still taking effect if all policies for a security zone are deleted

2024-04-04 Thread Abhay Kulkarni (Jira)
[ https://issues.apache.org/jira/browse/RANGER-4767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhay Kulkarni updated RANGER-4767: --- Description: If all the policies for a security zone are deleted, then still the previous

[jira] [Updated] (RANGER-4767) Deleted policies are still taking effect if all policies for a security zone are deleted

2024-04-04 Thread Abhay Kulkarni (Jira)
[ https://issues.apache.org/jira/browse/RANGER-4767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhay Kulkarni updated RANGER-4767: --- Summary: Deleted policies are still taking effect if all policies for a security zone are

[jira] [Updated] (RANGER-4767) Deleted policies are still taking effect if all policies in a repo for a security zone are deleted

2024-04-04 Thread Abhay Kulkarni (Jira)
[ https://issues.apache.org/jira/browse/RANGER-4767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhay Kulkarni updated RANGER-4767: --- Summary: Deleted policies are still taking effect if all policies in a repo for a security

Re: Review Request 74936: RANGER-4745: Enhance handling of subAccess authorization in Ranger HDFS plugin

2024-03-26 Thread Abhay Kulkarni
orization/hadoop/RangerHdfsAuthorizer.java 9b410a185 Diff: https://reviews.apache.org/r/74936/diff/4/ Changes: https://reviews.apache.org/r/74936/diff/3-4/ Testing --- Tested with HDFS namenode; passes all unit tests. Thanks, Abhay Kulkarni

Re: Review Request 74718: RANGER-4511: Enable Parallel Compilation for Multiple Modules in Ranger

2024-03-19 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74718/#review226336 --- Ship it! Ship It! - Abhay Kulkarni On Nov. 3, 2023, 3:43

Re: Review Request 74936: RANGER-4745: Enhance handling of subAccess authorization in Ranger HDFS plugin

2024-03-12 Thread Abhay Kulkarni
r.java 9b410a185 Diff: https://reviews.apache.org/r/74936/diff/3/ Changes: https://reviews.apache.org/r/74936/diff/2-3/ Testing --- Tested with HDFS namenode; passes all unit tests. Thanks, Abhay Kulkarni

[jira] [Created] (RANGER-4745) Enhance handling of subAccess authorization in Ranger HDFS plugin

2024-03-12 Thread Abhay Kulkarni (Jira)
Abhay Kulkarni created RANGER-4745: -- Summary: Enhance handling of subAccess authorization in Ranger HDFS plugin Key: RANGER-4745 URL: https://issues.apache.org/jira/browse/RANGER-4745 Project

[jira] [Assigned] (RANGER-4745) Enhance handling of subAccess authorization in Ranger HDFS plugin

2024-03-12 Thread Abhay Kulkarni (Jira)
[ https://issues.apache.org/jira/browse/RANGER-4745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhay Kulkarni reassigned RANGER-4745: -- Assignee: Abhay Kulkarni > Enhance handling of subAccess authorization in Ran

Re: [DRAFT][REPORT] Apache Ranger - Quarterly period ending Feb-2024

2024-03-11 Thread Abhay Kulkarni
+1 Thank you, Selva! On Mon, Mar 11, 2024 at 8:12 AM Madhan Neethiraj wrote: > +1 > > > > Selva – thank you for compiling the report. > > > > Thanks, > > Madhan > > > > > > *From: *Selvamohan Neethiraj > *Reply-To: * > *Date: *Monday, March 11, 2024 at 12:05 AM > *To: *, > *Subject: *[DRAFT][

Re: Review Request 74901: RANGER-4723: zone matcher updated to handle descendent match

2024-02-21 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74901/#review226231 --- Ship it! Ship It! - Abhay Kulkarni On Feb. 21, 2024, 11:09

Re: Review Request 74900: RANGER-4722: HDFS authorization logic for directory hierarchy rooted at "/" is incorrect

2024-02-20 Thread Abhay Kulkarni
00/diff/1/ Testing (updated) --- Compiles clean and passes unit tests. Thanks, Abhay Kulkarni

[jira] [Created] (RANGER-4722) HDFS authorization logic for directory hierarchy rooted at "/" is incorrect

2024-02-20 Thread Abhay Kulkarni (Jira)
Abhay Kulkarni created RANGER-4722: -- Summary: HDFS authorization logic for directory hierarchy rooted at "/" is incorrect Key: RANGER-4722 URL: https://issues.apache.org/jira/browse/R

Re: Review Request 74866: RANGER-4695: updated API to find zones for a resource to handle deleted services

2024-02-09 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74866/#review226210 --- Ship it! Ship It! - Abhay Kulkarni On Feb. 9, 2024, 6:22

Re: Review Request 74866: RANGER-4695: updated API to find zones for a resource to handle deleted services

2024-02-08 Thread Abhay Kulkarni
/RangerPolicyAdminCache.java Line 100 (original), 109 (patched) <https://reviews.apache.org/r/74866/#comment314456> Please consider having this code block (109-121) under the condition if (svcStore.serviceExists(serviceName)) { - Abhay Kulkarni On Feb. 8, 2024, 6:11 p.m., Madhan Neethiraj

Re: Review Request 74825: RANGER-4638:Multiple Columns Revoke not generating policies with correct number of columns

2024-01-25 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74825/#review226174 --- Ship it! Ship It! - Abhay Kulkarni On Jan. 24, 2024, 4:07

Re: Review Request 74825: RANGER-4638:Multiple Columns Revoke not generating policies with correct number of columns

2024-01-19 Thread Abhay Kulkarni
rce 'a' loses its 'r' and 'w' access whereas only 'w' access needs to be removed. Please review. - Abhay Kulkarni On Jan. 19, 2024, 9:14 a.m., Ramesh Mani wrote: > > --- > This is an a

Re: Review Request 74847: RANGER-4666: fixed getResourceACLs() API to account for tags assigned to ancestor resources

2024-01-19 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74847/#review226158 --- Ship it! Ship It! - Abhay Kulkarni On Jan. 19, 2024, 5:06

Re: Review Request 74825: RANGER-4638:Multiple Columns Revoke not generating policies with correct number of columns

2024-01-18 Thread Abhay Kulkarni
--- > > (Updated Jan. 17, 2024, 8:32 a.m.) > > > Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, > Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan > Periasamy. > > >

Re: Review Request 74833: RANGER-4655: Execute and read permissions granted to a user in different HDFS policies does not take effect.

2024-01-16 Thread Abhay Kulkarni
ff/5/ Changes: https://reviews.apache.org/r/74833/diff/4-5/ Testing --- Passes all unit tests. Added unit test for checking the patch. Thanks, Abhay Kulkarni

Re: Review Request 74833: RANGER-4655: Execute and read permissions granted to a user in different HDFS policies does not take effect.

2024-01-15 Thread Abhay Kulkarni
d4 Diff: https://reviews.apache.org/r/74833/diff/4/ Changes: https://reviews.apache.org/r/74833/diff/3-4/ Testing --- Passes all unit tests. Added unit test for checking the patch. Thanks, Abhay Kulkarni

[jira] [Updated] (RANGER-4655) Execute and read permissions granted to a user in different HDFS policies does not take effect.

2024-01-15 Thread Abhay Kulkarni (Jira)
[ https://issues.apache.org/jira/browse/RANGER-4655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhay Kulkarni updated RANGER-4655: --- Description: This bug is shown up when multiple accesses are requested using one access

[jira] [Created] (RANGER-4655) Execute and read permissions granted to a user in different HDFS policies does not take effect.

2024-01-15 Thread Abhay Kulkarni (Jira)
Abhay Kulkarni created RANGER-4655: -- Summary: Execute and read permissions granted to a user in different HDFS policies does not take effect. Key: RANGER-4655 URL: https://issues.apache.org/jira/browse/RANGER

Re: Review Request 74829: RANGER-4645: fix for unit test failures in TestAssetREST.testCountXAssets and TestXAuditREST.Test8countXAccessAudits

2024-01-11 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74829/#review226129 --- Ship it! Ship It! - Abhay Kulkarni On Jan. 11, 2024, 8:18

Re: Review Request 74825: RANGER-4638:Multiple Columns Revoke not generating policies with correct number of columns

2024-01-10 Thread Abhay Kulkarni
sourceMap is extracted from existingPolicy. In that case, is it necessary to set it back into existingPolicy? Please review. - Abhay Kulkarni On Jan. 9, 2024, 6:48 a.m., Ramesh Mani wrote: > > --- > This is an

Re: Review Request 74823: RANGER-4639: Provide an option to bypass evaluation of chained plugin if the parent plugin has applicable policy

2024-01-08 Thread Abhay Kulkarni
tests. Verified that for HDFS base-plugin there is no regression, and when the configuration parameter is set to true, the chained-plugin evaluation is bypassed. Thanks, Abhay Kulkarni

[jira] [Updated] (RANGER-4639) Provide an option to bypass evaluation of chained plugin if the parent plugin has applicable policy

2024-01-08 Thread Abhay Kulkarni (Jira)
[ https://issues.apache.org/jira/browse/RANGER-4639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhay Kulkarni updated RANGER-4639: --- Description: When a chained plugin is configured, for every access request processed by the

Review Request 74823: RANGER-4639: Provide an option to bypass evaluation of chained plugin if the parent plugin has applicable policy

2024-01-08 Thread Abhay Kulkarni
evaluation is bypassed. Thanks, Abhay Kulkarni

[jira] [Created] (RANGER-4639) Provide an option to bypass evaluation of chained plugin if the parent plugin has applicable policy

2024-01-08 Thread Abhay Kulkarni (Jira)
Abhay Kulkarni created RANGER-4639: -- Summary: Provide an option to bypass evaluation of chained plugin if the parent plugin has applicable policy Key: RANGER-4639 URL: https://issues.apache.org/jira/browse

Re: Review Request 74777: RANGER-4585:Support multiple columns policy creation in ranger for Grant / Revoke request

2023-12-20 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74777/#review226073 --- Ship it! Ship It! - Abhay Kulkarni On Dec. 7, 2023, 9:59

Re: Review Request 74795: RANGER-4609: Support in File-based Tag Retriever to provide tag-deltas

2023-12-14 Thread Abhay Kulkarni
fetching of successive tag-deltas for processing. Diffs (updated) - agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerFileBasedTagRetriever.java 448c665fc Diff: https://reviews.apache.org/r/74795/diff/2/ Changes: https://reviews.apache.org/r/74795/diff/1-2/ Testing --- Compiled and ran all unit tests successfully Thanks, Abhay Kulkarni

Re: Review Request 74795: RANGER-4609: Support in File-based Tag Retriever to provide tag-deltas

2023-12-14 Thread Abhay Kulkarni
- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74795/#review226053 --- On Dec. 14, 2023, 10:28 p.m., Abhay Kulkarni wrote: > > -

[jira] [Updated] (RANGER-4609) Support in File-based Tag Retriever to provide tag-deltas

2023-12-14 Thread Abhay Kulkarni (Jira)
[ https://issues.apache.org/jira/browse/RANGER-4609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhay Kulkarni updated RANGER-4609: --- Description: As a part of test infrastructure, a file-based tag retriever class is created

Review Request 74795: RANGER-4609: Support in File-based Tag Retriever to provide tag-deltas

2023-12-14 Thread Abhay Kulkarni
rocessing. Diffs - agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerFileBasedTagRetriever.java 448c665fc Diff: https://reviews.apache.org/r/74795/diff/1/ Testing --- Compiled and ran all unit tests successfully Thanks, Abhay Kulkarni

[jira] [Created] (RANGER-4609) Support in File-based Tag Retriever to provide tag-deltas

2023-12-14 Thread Abhay Kulkarni (Jira)
Abhay Kulkarni created RANGER-4609: -- Summary: Support in File-based Tag Retriever to provide tag-deltas Key: RANGER-4609 URL: https://issues.apache.org/jira/browse/RANGER-4609 Project: Ranger

Re: Review Request 74773: RANGER-4571: update handling of expressions that evaluate to null

2023-12-01 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74773/#review226027 --- Ship it! Ship It! - Abhay Kulkarni On Dec. 2, 2023, 1:07

Re: Review Request 74766: RANGER-4565: Enhance Ranger's performance tracing module to optionally collect statistical information

2023-11-28 Thread Abhay Kulkarni
------- On Nov. 28, 2023, 5:55 p.m., Abhay Kulkarni wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74766/ > --

Review Request 74766: RANGER-4565: Enhance Ranger's performance tracing module to optionally collect statistical information

2023-11-28 Thread Abhay Kulkarni
common/src/main/java/org/apache/ranger/plugin/util/RangerPerfTracer.java c8804739f Diff: https://reviews.apache.org/r/74766/diff/1/ Testing --- Passes all unit tests. Verified that the aggregate performance is collected at specified intervals when properly configured. Thanks, Abhay Kulkarni

[jira] [Created] (RANGER-4565) Enhance Ranger's performance tracing module to optionally collect statistical information

2023-11-28 Thread Abhay Kulkarni (Jira)
Abhay Kulkarni created RANGER-4565: -- Summary: Enhance Ranger's performance tracing module to optionally collect statistical information Key: RANGER-4565 URL: https://issues.apache.org/jira/browse/RANGER

Re: Review Request 74739: RANGER-4529: optimized script condition evaluator to avoid creation of multiple bindings

2023-11-20 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74739/#review225980 --- Ship it! Ship It! - Abhay Kulkarni On Nov. 14, 2023, 8:44

Re: Review Request 74739: RANGER-4529: optimized script condition evaluator to avoid creation of multiple bindings

2023-11-20 Thread Abhay Kulkarni
/policyengine/RangerRequestScriptEvaluator.java Line 225 (original), 205 (patched) <https://reviews.apache.org/r/74739/#comment314349> Why is the safe execution prefix is removed in the new code? - Abhay Kulkarni On Nov. 14, 2023, 8:44 a.m., Madhan Neethiraj

Re: Review Request 74731: RANGER-4522: fixed NPE in RangerGdsInfoRefresher.run()

2023-11-09 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74731/#review225956 --- Ship it! Ship It! - Abhay Kulkarni On Nov. 9, 2023, 6:46

Re: Review Request 74721: RANGER-4515: Enhance perf-tracer to get CPU time when possible

2023-11-07 Thread Abhay Kulkarni
/diff/1-2/ Testing --- Built ranger and ran all unit tests successfully. Thanks, Abhay Kulkarni

Review Request 74721: RANGER-4515: Enhance perf-tracer to get CPU time when possible

2023-11-07 Thread Abhay Kulkarni
3c985c62c agents-common/src/main/java/org/apache/ranger/plugin/util/RangerPerfTracerFactory.java 1a4e86dce Diff: https://reviews.apache.org/r/74721/diff/1/ Testing --- Built ranger and ran all unit tests successfully. Thanks, Abhay Kulkarni

[jira] [Created] (RANGER-4515) Enhance perf-tracer to get CPU time when possible

2023-11-07 Thread Abhay Kulkarni (Jira)
Abhay Kulkarni created RANGER-4515: -- Summary: Enhance perf-tracer to get CPU time when possible Key: RANGER-4515 URL: https://issues.apache.org/jira/browse/RANGER-4515 Project: Ranger Issue

Re: Review Request 74717: RANGER-4378: removed static PolicyEngine.impliedAccessGrants

2023-11-06 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74717/#review225939 --- Ship it! Ship It! - Abhay Kulkarni On Nov. 3, 2023, 3:31

[jira] [Comment Edited] (RANGER-4478) Incorrect trie updates when processing deltas

2023-11-04 Thread Abhay Kulkarni (Jira)
[ https://issues.apache.org/jira/browse/RANGER-4478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17776394#comment-17776394 ] Abhay Kulkarni edited comment on RANGER-4478 at 11/4/23 9:0

Re: Review Request 74711: RANGER-4507: refactored PolicyEngine to move functionality that finds security-zone for a resource to RangerSecurityZoneMatcher

2023-11-01 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74711/#review225921 --- Ship it! Ship It! - Abhay Kulkarni On Nov. 1, 2023, 2:17

Re: Review Request 74711: RANGER-4507: refactored PolicyEngine to move functionality that finds security-zone for a resource to RangerSecurityZoneMatcher

2023-11-01 Thread Abhay Kulkarni
/RangerAuthContext.java Lines 40 (patched) <https://reviews.apache.org/r/74711/#comment314327> This is a new addition. What is the net new functionality added which needed this addition? - Abhay Kulkarni On Nov. 1, 2023, 2:17 a.m., Madhan Neethiraj

[jira] [Comment Edited] (RANGER-4478) Incorrect trie updates when processing deltas

2023-10-27 Thread Abhay Kulkarni (Jira)
[ https://issues.apache.org/jira/browse/RANGER-4478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17776393#comment-17776393 ] Abhay Kulkarni edited comment on RANGER-4478 at 10/27/23 11:3

Re: Review Request 74702: RANGER-4478: Incorrect trie updates when processing deltas - Part 3

2023-10-27 Thread Abhay Kulkarni
. Diffs - agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerResourceTrie.java d95da7c50 Diff: https://reviews.apache.org/r/74702/diff/1/ Testing --- Passed all unit tests. Thanks, Abhay Kulkarni

[jira] [Comment Edited] (RANGER-4478) Incorrect trie updates when processing deltas

2023-10-23 Thread Abhay Kulkarni (Jira)
[ https://issues.apache.org/jira/browse/RANGER-4478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17776394#comment-17776394 ] Abhay Kulkarni edited comment on RANGER-4478 at 10/23/23 10:5

[jira] [Comment Edited] (RANGER-4478) Incorrect trie updates when processing deltas

2023-10-23 Thread Abhay Kulkarni (Jira)
[ https://issues.apache.org/jira/browse/RANGER-4478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17776393#comment-17776393 ] Abhay Kulkarni edited comment on RANGER-4478 at 10/23/23 8:2

Review Request 74694: RANGER-4478: Incorrect trie updates when processing deltas - Part 2

2023-10-23 Thread Abhay Kulkarni
/diff/1/ Testing --- Compiled and ran unit tests successfully. Tested with a long running cluster with a client updating Hive policies frequenty and Hive queries issued from a beeline client. Thanks, Abhay Kulkarni

  1   2   3   4   5   6   7   8   9   10   >