[jira] [Commented] (RANGER-2255) Add JavaScript unit tests

2019-01-16 Thread Csaba Koncz (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1672#comment-1672 ] Csaba Koncz commented on RANGER-2255: - RANGER-2321 was merged. However, it does not exactly act

[jira] [Resolved] (RANGER-2255) Add JavaScript unit tests

2019-01-16 Thread Csaba Koncz (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Csaba Koncz resolved RANGER-2255. - Resolution: Fixed > Add JavaScript unit te

Re: Review Request 69731: RANGER-2321 Docker build fails due to PhantomJS dependency

2019-01-13 Thread Csaba Koncz
: ``` mvn clean verify -am -pl security-admin -DskipJSTests ``` Thanks, Csaba Koncz

Re: Review Request 69731: RANGER-2321 Docker build fails due to PhantomJS dependency

2019-01-13 Thread Csaba Koncz
ps://reviews.apache.org/r/69731/#review211937 ------- On Jan. 13, 2019, 7:18 p.m., Csaba Koncz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69731/ > -

[jira] [Commented] (RANGER-2321) Docker build fails due to PhantomJS dependency

2019-01-12 Thread Csaba Koncz (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741310#comment-16741310 ] Csaba Koncz commented on RANGER-2321: - Created review: https://reviews.apache.org/r/69731/ > Doc

Review Request 69731: RANGER-2321 Docker build fails due to PhantomJS dependency

2019-01-12 Thread Csaba Koncz
verify -am -pl security-admin ``` The following succeeds and does not run JavaScript tests and does not download PhantomJS: ``` mvn clean verify -am -pl security-admin -DskipJSTests ``` Thanks, Csaba Koncz

[jira] [Commented] (RANGER-2321) Docker build fails due to PhantomJS dependency

2019-01-11 Thread Csaba Koncz (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16740238#comment-16740238 ] Csaba Koncz commented on RANGER-2321: - The attached patch builds on RANGER-2319, which has not been

[jira] [Updated] (RANGER-2321) Docker build fails due to PhantomJS dependency

2019-01-11 Thread Csaba Koncz (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Csaba Koncz updated RANGER-2321: Attachment: 0001-RANGER-2321-Docker-build-fails-due-to-PhantomJS-depe.patch > Docker build fa

[jira] [Comment Edited] (RANGER-2255) Add JavaScript unit tests

2019-01-10 Thread Csaba Koncz (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739227#comment-16739227 ] Csaba Koncz edited comment on RANGER-2255 at 1/10/19 9:10 AM: -- Reverted

[jira] [Comment Edited] (RANGER-2255) Add JavaScript unit tests

2019-01-10 Thread Csaba Koncz (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739227#comment-16739227 ] Csaba Koncz edited comment on RANGER-2255 at 1/10/19 9:09 AM: -- Reverted

[jira] [Commented] (RANGER-2255) Add JavaScript unit tests

2019-01-10 Thread Csaba Koncz (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739227#comment-16739227 ] Csaba Koncz commented on RANGER-2255: - Reverted the patch belonging to RANGER-2319 to its original

[jira] [Created] (RANGER-2321) Docker build fails due to PhantomJS dependency

2019-01-10 Thread Csaba Koncz (JIRA)
Csaba Koncz created RANGER-2321: --- Summary: Docker build fails due to PhantomJS dependency Key: RANGER-2321 URL: https://issues.apache.org/jira/browse/RANGER-2321 Project: Ranger Issue Type

[jira] [Commented] (RANGER-2255) Add JavaScript unit tests

2019-01-09 Thread Csaba Koncz (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16738293#comment-16738293 ] Csaba Koncz commented on RANGER-2255: - [~pradeep.agrawal]: updated the review at [https

[jira] [Commented] (RANGER-2255) Add JavaScript unit tests

2019-01-09 Thread Csaba Koncz (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16738135#comment-16738135 ] Csaba Koncz commented on RANGER-2255: - [~pradeep.agrawal]: my change does not add any functionality

[jira] [Commented] (RANGER-2319) Remove deprecated phantomjs NPM package

2019-01-08 Thread Csaba Koncz (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16737022#comment-16737022 ] Csaba Koncz commented on RANGER-2319: - https://reviews.apache.org/r/69693/ > Remove depreca

[jira] [Commented] (RANGER-2255) Add JavaScript unit tests

2019-01-08 Thread Csaba Koncz (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16737025#comment-16737025 ] Csaba Koncz commented on RANGER-2255: - [~pradeep.agrawal], I noticed that two Phantomjs versions

[jira] [Assigned] (RANGER-2319) Remove deprecated phantomjs NPM package

2019-01-08 Thread Csaba Koncz (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Csaba Koncz reassigned RANGER-2319: --- Assignee: Csaba Koncz > Remove deprecated phantomjs NPM pack

[jira] [Updated] (RANGER-2319) Remove deprecated phantomjs NPM package

2019-01-08 Thread Csaba Koncz (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Csaba Koncz updated RANGER-2319: Description: [Phantomjs|https://github.com/apache/ranger/blob

[jira] [Created] (RANGER-2319) Remove deprecated phantomjs NPM package

2019-01-08 Thread Csaba Koncz (JIRA)
Csaba Koncz created RANGER-2319: --- Summary: Remove deprecated phantomjs NPM package Key: RANGER-2319 URL: https://issues.apache.org/jira/browse/RANGER-2319 Project: Ranger Issue Type: Wish

[jira] [Commented] (RANGER-2255) Add JavaScript unit tests

2019-01-08 Thread Csaba Koncz (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16736938#comment-16736938 ] Csaba Koncz commented on RANGER-2255: - Sorry [~pradeep.agrawal], I was not aware of the dependency

Re: Review Request 69067: RANGER-2255 JavaScript tests for UI loading

2019-01-03 Thread Csaba Koncz
lly generated e-mail. To reply, visit: https://reviews.apache.org/r/69067/#review211616 ------- On Jan. 3, 2019, 1:43 p.m., Csaba Koncz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 69067: RANGER-2255 JavaScript tests for UI loading

2019-01-03 Thread Csaba Koncz
r/69067/#review211591 --- On Jan. 3, 2019, 1:43 p.m., Csaba Koncz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > h

Re: Review Request 69067: RANGER-2255 JavaScript tests for UI loading

2019-01-03 Thread Csaba Koncz
ssfully executed. There are also logs that indicate that JavaScript application startup was triggered. However, this could not succeed because of missing backend services. Thanks, Csaba Koncz

Re: Review Request 69067: RANGER-2255 JavaScript tests for UI loading

2018-10-22 Thread Csaba Koncz
pplication startup was triggered. However, this could not succeed because of missing backend services. Thanks, Csaba Koncz

Re: Review Request 69067: RANGER-2255 JavaScript tests for UI loading

2018-10-18 Thread Csaba Koncz
ng war: /Users/ckoncz/work/git/hwx/ranger/security-admin/target/security-admin-web-2.0.0-SNAPSHOT.war [INFO] I.e. Karma was launched two times and and each time a single test was successfully executed. There are also logs that indicate that JavaScript application startup was triggered. However, this could not succeed because of missing backend services. Thanks, Csaba Koncz

[jira] [Commented] (RANGER-2255) Add JavaScript unit tests

2018-10-17 Thread Csaba Koncz (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16654137#comment-16654137 ] Csaba Koncz commented on RANGER-2255: - Added JavaScript testing infrastructure (Karma, Mocha

Review Request 69067: RANGER-2255 JavaScript tests for UI loading

2018-10-17 Thread Csaba Koncz
secs] [INFO] Building war: /Users/ckoncz/work/git/hwx/ranger/security-admin/target/security-admin-web-2.0.0-SNAPSHOT.war [INFO] I.e. Karma was launched two times and and each time a single test was successfully executed. There are also logs that indicate that JavaScript application startup was triggered. However, this could not succeed because of missing backend services. Thanks, Csaba Koncz

Re: Review Request 68770: RANGER-2220 minify JavaScript files during packaging

2018-10-12 Thread Csaba Koncz
> On Oct. 10, 2018, 3:39 p.m., Velmurugan Periasamy wrote: > > pom.xml > > Lines 608 (patched) > > <https://reviews.apache.org/r/68770/diff/4/?file=2094705#file2094705line608> > > > > Could you please make sure this is merged in 1.x branches? Thanks.

Re: Review Request 68770: RANGER-2220 minify JavaScript files during packaging

2018-10-11 Thread Csaba Koncz
eviews.apache.org/r/68770/#review209413 ------- On Oct. 4, 2018, 7:50 p.m., Csaba Koncz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68770/ > ---

Re: Review Request 68770: RANGER-2220 minify JavaScript files during packaging

2018-10-04 Thread Csaba Koncz
: # network tab lists only 26 requests # console contains no packaging related errors (it contains 4 errors due to missing backend service) Thanks, Csaba Koncz

Re: Review Request 68770: RANGER-2220 minify JavaScript files during packaging

2018-09-26 Thread Csaba Koncz
> On Sept. 24, 2018, 1:03 p.m., Nitin Galave wrote: > > security-admin/pom.xml > > Lines 562 (patched) > > <https://reviews.apache.org/r/68770/diff/2/?file=2090907#file2090907line562> > > > > maven build stuck after appyinng this patch > > C

Re: Review Request 68770: RANGER-2220 minify JavaScript files during packaging

2018-09-26 Thread Csaba Koncz
errors due to missing backend service) Thanks, Csaba Koncz

Re: Review Request 68770: RANGER-2220 minify JavaScript files during packaging

2018-09-24 Thread Csaba Koncz
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68770/#review208940 --- On Sept. 21, 2018, 5:21 p.m., Csaba Koncz wrote: > > --

Re: Review Request 68770: RANGER-2220 minify JavaScript files during packaging

2018-09-21 Thread Csaba Koncz
--------- On Sept. 21, 2018, 5:21 p.m., Csaba Koncz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68770/ > -

Re: Review Request 68770: RANGER-2220 minify JavaScript files during packaging

2018-09-21 Thread Csaba Koncz
/security-admin-web-2.0.0-SNAPSHOT http-server # opened http://localhost:8080 and inspected browser network tab and console: # network tab lists only 26 requests # console contains no packaging related errors (it contains 4 errors due to missing backend service) Thanks, Csaba Koncz

[jira] [Commented] (RANGER-2220) Admin UI loads slowly because of many small JavaScript files

2018-09-19 Thread Csaba Koncz (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621209#comment-16621209 ] Csaba Koncz commented on RANGER-2220: - Here is the promised patch: [https://reviews.apache.org/r

Re: Review Request 68770: RANGER-2220 minify JavaScript files during packaging

2018-09-19 Thread Csaba Koncz
requests # console contains no packaging related errors (it contains 4 errors due to missing backend service) Thanks, Csaba Koncz

Re: Review Request 68770: RANGER-2220 minify JavaScript files during packaging

2018-09-19 Thread Csaba Koncz
r/68770/diff/1/ > > > Testing > --- > > Performed: > > mvn package -pl security-admin -am > cd security-admin/ > cd security-admin/target/security-admin-web-2.0.0-SNAPSHOT > http-server > # opened http://localhost:8080 and inspected browser network tab and console: > # network tab lists only 26 requests > # console contains no packaging related errors (it contains 4 errors due to > missing backend service) > > > Thanks, > > Csaba Koncz > >

Review Request 68770: RANGER-2220 minify JavaScript files during packaging

2018-09-19 Thread Csaba Koncz
related errors (it contains 4 errors due to missing backend service) Thanks, Csaba Koncz

[jira] [Created] (RANGER-2220) Admin UI loads slowly because of many small JavaScript files

2018-09-13 Thread Csaba Koncz (JIRA)
Csaba Koncz created RANGER-2220: --- Summary: Admin UI loads slowly because of many small JavaScript files Key: RANGER-2220 URL: https://issues.apache.org/jira/browse/RANGER-2220 Project: Ranger