Re: [VOTE] Release Apache Ranger version 2.5.0 - RC3

Thank you, Bhavik, for providing Apache Ranger 2.5.0 Release +1 for Ranger 2.5.0 rc3 *Successfully validated,* 1.validated clean build Ranger from the source tar succeeded without any issues. 2.validated unit tests. 3. validated the Ranger admin login. Thanks, Ram On Thu, Aug 1, 2024 at 5:52 PM D

Re: Review Request 74758: RANGER-4560:Ranger Roles Cache improvement to reduce DB calls to the Database

cache, and then return roles to the User/Ranger Plugins Diffs - security-admin/src/main/java/org/apache/ranger/common/RangerRoleCache.java 933104a16 Diff: https://reviews.apache.org/r/74758/diff/1/ Testing --- Thanks, Ramachandran Krishnan

Re: Review Request 74828: RANGER-4636, RANGER-4637: Fix /public/api/policy/count and /public/api/repository/count to return the proper value

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74828/#review226120 --- Ship it! Ship It! - Ramachandran Krishnan On Jan. 10, 2024

Re: Review Request 74828: RANGER-4636, RANGER-4637: Fix /public/api/policy/count and /public/api/repository/count to return the proper value

> On Jan. 10, 2024, 6:49 a.m., Ramachandran Krishnan wrote: > > security-admin/src/main/java/org/apache/ranger/rest/PublicAPIs.java > > Line 400 (original) > > <https://reviews.apache.org/r/74828/diff/1/?file=2284717#file2284717line403> > > > > I f

Re: Review Request 74828: RANGER-4636, RANGER-4637: Fix /public/api/policy/count and /public/api/repository/count to return the proper value

} if(logger.isDebugEnabled()) { logger.debug("<== PublicAPIs.countPolicies(): " + request ); } - Ramachandran Krishnan On Jan. 10, 2024, 5:41 a.m., Abhishek Patil wrote: > > --- >

Re: Review Request 74791: RANGER-4606 /assets/assets/count API does not return the proper count if the number of services is greater than 200

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74791/#review226048 --- Ship it! Ship It! - Ramachandran Krishnan On Dec. 14, 2023

Re: Review Request 74538: RANGER-4345 plugin side metrics on polling from the policy server

/PolicyRefresher.java Lines 55 (patched) <https://reviews.apache.org/r/74538/#comment314364> Are we adding metrics only for Policy download ?.It would be great if you add the same for roles as well.The policy refresher thread will download policies as well as roles also. - Ramachandran Kr

Re: Review Request 74405: RANGER-4195:Exposing the Ranger REST API is used to fetch the health check status of Ranger Admin

ATION Diff: https://reviews.apache.org/r/74405/diff/6/ Testing --- Tested this API and the response below {"status":"UP","details":{"components":{"db":{"details":{"database":"ORACLE Oracle Database 19c Enterprise Edition Release 19.0.0.0.0 - Production","validationQuery":"SELECT banner from v$version where rownum<2"},"status":"UP" Thanks, Ramachandran Krishnan

Re: Review Request 74405: RANGER-4195:Exposing the Ranger REST API is used to fetch the health check status of Ranger Admin

va PRE-CREATION Diff: https://reviews.apache.org/r/74405/diff/6/ Changes: https://reviews.apache.org/r/74405/diff/5-6/ Testing --- Tested this API and the response below {"status":"UP","details":{"components":{"db":{"details":{"database":"ORACLE Oracle Database 19c Enterprise Edition Release 19.0.0.0.0 - Production","validationQuery":"SELECT banner from v$version where rownum<2"},"status":"UP" Thanks, Ramachandran Krishnan

Re: Review Request 74758: RANGER-4560:Ranger Roles Cache improvement to reduce DB calls to the Database

/ Testing --- Thanks, Ramachandran Krishnan

Review Request 74759: RANGER-4561:Adding the mechanism to eanble/disable Ranager Access logs based on property

- embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java a0d616925 Diff: https://reviews.apache.org/r/74759/diff/1/ Testing --- Thanks, Ramachandran Krishnan

Review Request 74758: Ranger Roles Cache improvement to reduce DB calls to the Database

- security-admin/src/main/java/org/apache/ranger/common/RangerRoleCache.java 933104a16 Diff: https://reviews.apache.org/r/74758/diff/1/ Testing --- Thanks, Ramachandran Krishnan

Re: Review Request 73950: RANGER-3722 : Fix Test-case failure

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73950/#review226002 --- Ship it! Ship It! - Ramachandran Krishnan On April 8, 2023

Re: Review Request 74557: RANGER-4196- Tomcat runtime metrics collection

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74557/#review225682 --- Ship it! Ship It! - Ramachandran Krishnan On Aug. 24, 2023

Re: Review Request 74557: RANGER-4196- Tomcat runtime metrics collection

/RangerMetricsContainerSource.java Lines 78 (patched) <https://reviews.apache.org/r/74557/#comment314130> Is it possible to write a UT for covering this - Ramachandran Krishnan On Aug. 22, 2023, 1:05 p.m., Vikas Kumar

Re: Review Request 74552: RANGER-4353: Introduce config within Ranger to control retention period of x_trx_log data

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74552/#review225670 --- Ship it! Ship It! - Ramachandran Krishnan On Aug. 21, 2023

Re: Review Request 74556: RANGER-4373: Deleting a role which is already present in policy is giving incorrect message.

/RoleREST.java Line 289 (original), 290 (patched) <https://reviews.apache.org/r/74556/#comment314129> Can you write a Unit case to cover this condition ? - Ramachandran Krishnan On Aug. 22, 2023, 7:14 a.m., sanket shelar wrote: > > -

Re: Review Request 74543: RANGER-4350: removed @Xml annotations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74543/#review225651 --- Ship it! Ship It! - Ramachandran Krishnan On Aug. 10, 2023

Re: Review Request 74528: RANGER-4325: GDS: Need api for collective search of user/group/roles

Lines 130 (patched) <https://reviews.apache.org/r/74528/#comment314104> Is it possible to move this native query into jpa_named_queries.xml and passing the binding parameter - Ramachandran Krishnan On Aug. 7, 2023, 9:12 a.m., Prashant Satam

Re: Review Request 74538: RANGER-4345 plugin side metrics on polling from the policy server

/PolicyRefresher.java Lines 119 (patched) <https://reviews.apache.org/r/74538/#comment314103> Can we make it understand feature flag via plugin properties whether this needs to be enabled or not ? - Ramachandran Krishnan On Aug. 8, 2023, 11:17 a.m., Sai Sandeep Rangisetti

Re: Review Request 74533: RANGER-4337: Upgrade spring framework and spring-security

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74533/#review225620 --- Ship it! Ship It! - Ramachandran Krishnan On Aug. 1, 2023

Re: Review Request 74519: RANGER-4321 : RangerMDCFilter is not working as defined in RANGER-4024

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74519/#review225607 --- Ship it! Ship It! - Ramachandran Krishnan On July 18, 2023

Re: Review Request 74453: RANGER-4250 : Ranger throws BAD Request Error when we are not passing exec user to the getRoles (/public/v2/api/roles/name/{name})

453/diff/3/ Changes: https://reviews.apache.org/r/74453/diff/2-3/ Testing --- Thanks, Ramachandran Krishnan

Re: Review Request 74349: RANGER-4133 Improvement in Ranger Roles Rest API's

nging signature of existing public > > methods - to avoid breaking clients using these methods. Instead, consider > > adding new methods. > > Ramachandran Krishnan wrote: > Hi Madhan, > >Do we need to keep both old and new behaviour like this >

Re: Review Request 74405: RANGER-4195:Exposing the Ranger REST API is used to fetch the health check status of Ranger Admin

-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74405/#review225403 --- On May 30, 2023, 4:37 p.m., Ramachandran Krishnan wrote: > > ---

Re: Review Request 74464: RANGER-4255: Introduce option in Ranger to control retention period of x_auth_sess table data

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74464/#review225507 --- Ship it! Ship It! - Ramachandran Krishnan On June 2, 2023

Re: Review Request 74464: RANGER-4255: Introduce option in Ranger to control retention period of x_auth_sess table data

> On June 2, 2023, 10:24 a.m., Ramachandran Krishnan wrote: > > security-admin/src/main/resources/META-INF/jpa_named_queries.xml > > Lines 28 (patched) > > <https://reviews.apache.org/r/74464/diff/1/?file=2277035#file2277035line28> > > > > < ---

Re: Review Request 74464: RANGER-4255: Introduce option in Ranger to control retention period of x_auth_sess table data

Lines 28 (patched) <https://reviews.apache.org/r/74464/#comment314071> < ---> Is this the current symbol .I guess this could < - Ramachandran Krishnan On June 2, 2023, 9:07 a.m., Pradeep Agrawal wrote: > > ---

It would be great if you take a look at some of the Pull requests were raised by me if possible

Hi All, Could you please take a look at the below-mentioned Pull requests if possible Bugs/Feature Review URL RANGER-4195:Exposing the Ranger REST API is used to fetch the health check status of Ranger Admin https://reviews.apache.org/r/74405/ RANGER-4250 :Ranger throws BAD Request Error when we a

Re: Review Request 74405: RANGER-4195:Exposing the Ranger REST API is used to fetch the health check status of Ranger Admin

hUtil.java PRE-CREATION Diff: https://reviews.apache.org/r/74405/diff/5/ Changes: https://reviews.apache.org/r/74405/diff/4-5/ Testing --- Tested this API and the response below {"status":"UP","details":{"components":{"db":{"details":{"database":"ORACLE Oracle Database 19c Enterprise Edition Release 19.0.0.0.0 - Production","validationQuery":"SELECT banner from v$version where rownum<2"},"status":"UP" Thanks, Ramachandran Krishnan

Re: Review Request 74405: RANGER-4195:Exposing the Ranger REST API is used to fetch the health check status of Ranger Admin

java PRE-CREATION Diff: https://reviews.apache.org/r/74405/diff/4/ Testing (updated) --- Tested this API and the response below {"status":"UP","details":{"components":{"db":{"details":{"database":"ORACLE Oracle Database 19c Enterprise Edition Release 19.0.0.0.0 - Production","validationQuery":"SELECT banner from v$version where rownum<2"},"status":"UP" Thanks, Ramachandran Krishnan

Re: Review Request 74405: RANGER-4195:Exposing the Ranger REST API is used to fetch the health check status of Ranger Admin

in/src/main/resources/conf.dist/security-applicationContext.xml 807791f28 security-admin/src/test/java/org/apache/ranger/biz/TestRangerBizUtil.java 22e290a66 security-admin/src/test/java/org/apache/ranger/rest/TestPublicAPIsv2.java 73a593e9f security-admin/src/test/java/org/apache/ranger/util/TestRangerServerHealthUtil.java PRE-CREATION Diff: https://reviews.apache.org/r/74405/diff/4/ Changes: https://reviews.apache.org/r/74405/diff/3-4/ Testing --- Thanks, Ramachandran Krishnan

Re: Review Request 74453: RANGER-4250 : Ranger throws BAD Request Error when we are not passing exec user to the getRoles (/public/v2/api/roles/name/{name})

ST.getRole(RoleREST.java:301)| at Diffs - security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java 4f0edd2b0 Diff: https://reviews.apache.org/r/74453/diff/2/ Testing --- Thanks, Ramachandran Krishnan

Re: Review Request 74453: RANGER-4250 : Ranger throws BAD Request Error when we are not passing exec user to the getRoles (/public/v2/api/roles/name/{name)

453/diff/2/ Changes: https://reviews.apache.org/r/74453/diff/1-2/ Testing --- Thanks, Ramachandran Krishnan

Review Request 74453: RANGER-4250 : Ranger throws BAD Request Error when we are not passing exec user to the getRoles (/public/v2/api/roles/name/{name)

iff: https://reviews.apache.org/r/74453/diff/1/ Testing --- Thanks, Ramachandran Krishnan

Re: Review Request 74449: RANGER-4245: Upgrade derby, spring-ldap and testng libraries

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74449/#review225481 --- Ship it! Ship It! - Ramachandran Krishnan On May 22, 2023

Re: Review Request 74399: RANGER-4191:Expose the Ranger REST API to fetch all the roles that groups belong to

---- On May 21, 2023, 2:19 p.m., Ramachandran Krishnan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74399/ >

Re: Review Request 74399: RANGER-4191:Expose the Ranger REST API to fetch all the roles that groups belong to

/ranger/rest/TestRoleREST.java 217c1bba3 Diff: https://reviews.apache.org/r/74399/diff/2/ Changes: https://reviews.apache.org/r/74399/diff/1-2/ Testing --- Thanks, Ramachandran Krishnan

Re: Review Request 74425: RANGER-4226: Upgrade Nimbus-JOSE-JWT and bcpkix-jdk15

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74425/#review225455 --- Ship it! Ship It! - Ramachandran Krishnan On May 8, 2023, 8

Re: Review Request 74435: RANGER-4232: Upgrade Spring Security to 5.7.8

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74435/#review225454 --- Ship it! Ship It! - Ramachandran Krishnan On May 15, 2023

Re: Review Request 74405: RANGER-4195:Exposing the Ranger REST API is used to fetch the health check status of Ranger Admin

security-applicationContext.xml 807791f28 security-admin/src/test/java/org/apache/ranger/biz/TestRangerBizUtil.java 22e290a66 security-admin/src/test/java/org/apache/ranger/rest/TestPublicAPIsv2.java 73a593e9f security-admin/src/test/java/org/apache/ranger/util/TestRangerServerHealthUtil.java PRE-CREATION Diff: https://reviews.apache.org/r/74405/diff/3/ Changes: https://reviews.apache.org/r/74405/diff/2-3/ Testing --- Thanks, Ramachandran Krishnan

Re: Review Request 74398: RANGER-4190: Apache Ranger does not recover from a recoverable SQL exception

ty.egd seems unrelated to the DNS issue addressed in this > > patch. Is this necessary here? > > > > Also, is this issue specific to OCI? Is there additional overhead in > > not caching positive name resoluions? > > Ramachandran Krishnan wrote: > By default,

Re: Review Request 74398: RANGER-4190: Apache Ranger does not recover from a recoverable SQL exception

hen invoking Java: Example: java -Dnetworkaddress.cache.ttl=0 -Dnetworkaddress.cache.negative.ttl=0 app.jar Diffs (updated) - embeddedwebserver/scripts/ranger-admin-services.sh a76f0986c Diff: https://reviews.apache.org/r/74398/diff/2/ Changes: https://reviews.apache.org/r/74398/diff/1-2/ Testing --- Thanks, Ramachandran Krishnan

Re: Review Request 74398: RANGER-4190: Apache Ranger does not recover from a recoverable SQL exception

ty.egd seems unrelated to the DNS issue addressed in this > > patch. Is this necessary here? > > > > Also, is this issue specific to OCI? Is there additional overhead in > > not caching positive name resoluions? > > Ramachandran Krishnan wrote: > By default,

Re: Review Request 74398: RANGER-4190: Apache Ranger does not recover from a recoverable SQL exception

-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74398/#review225442 --- On April 15, 2023, 2:57 p.m., Ramachandran Krishnan wrote: > > --

Re: Review Request 74397: RANGER-4188: updatePolicy results in 400 status code

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74397/#review225441 --- Ship it! Ship It! - Ramachandran Krishnan On April 14, 2023

Re: Review Request 74413: RANGER-4204: RANGER-4205: RANGER-4206: RANGER-4212: Upgrade woodstox, commons-net, kerby, json-smart libraries versions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74413/#review225417 --- Ship it! Ship It! - Ramachandran Krishnan On April 27, 2023

Re: Review Request 74413: RANGER-4204: RANGER-4205: RANGER-4206: Upgrade woodstox, commons-net and kerby libraries versions

tps://reviews.apache.org/r/74413/#comment314039> I guess jsonsmart jar also needs to be upgraded (we are sessing some CVE's are getting reported) if possible 2.4.7 - Ramachandran Krishnan On April 24, 2023, 12:49 p.m., Pradeep Ag

Is there a way to prune Admin audit (by purging vx_trx_log table ) ?

Hi All, The admin audit log is written into the *vx_trx_log* table whenever policy/role/user/group is getting created/updated/deleted. We are seeing the *vx_trx_log* table is growing very fast. This also might affect DB performance. We do not have any flag to disable the admin audit. Regards, Ram

Review Request 74415: RANGER-4208:Recording DB Read Time while downloading policies, roles and users

/RangerServiceTagsCache.java 05850ed6e security-admin/src/main/java/org/apache/ranger/common/RangerUserStoreCache.java 2b331f3c2 Diff: https://reviews.apache.org/r/74415/diff/1/ Testing --- Thanks, Ramachandran Krishnan

Re: Review Request 74405: RANGER-4195:Exposing the Ranger REST API is used to fetch the health check status of Ranger Admin

in/src/main/resources/conf.dist/security-applicationContext.xml 807791f28 security-admin/src/test/java/org/apache/ranger/biz/TestRangerBizUtil.java 22e290a66 security-admin/src/test/java/org/apache/ranger/rest/TestPublicAPIsv2.java 73a593e9f security-admin/src/test/java/org/apache/ranger/util/TestRangerServerHealthUtil.java PRE-CREATION Diff: https://reviews.apache.org/r/74405/diff/2/ Changes: https://reviews.apache.org/r/74405/diff/1-2/ Testing --- Thanks, Ramachandran Krishnan

Re: Review Request 74405: RANGER-4195:Exposing the Ranger REST API is used to fetch the health check status of Ranger Admin

s is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74405/#review225403 --- On April 20, 2023, 11:03 a.m., Ramachandran Krishnan wrote: > > ---

Re: Review Request 74395: RANGER-4168 :Improvement Adding Unit test cases are some of the missing classes

, Ramachandran Krishnan

Re: Review Request 74395: RANGER-4168 :Improvement Adding Unit test cases are some of the missing classes

: https://reviews.apache.org/r/74395/diff/2/ Changes: https://reviews.apache.org/r/74395/diff/1-2/ Testing --- All the Unit test cases are Tested and it is working fine Thanks, Ramachandran Krishnan

Review Request 74405: RANGER-4195:Exposing the Ranger REST API is used to fetch the health check status of Ranger Admin

BaseDao.java 0d0697990 security-admin/src/main/java/org/apache/ranger/patch/cliutil/MetricUtil.java 7d4828ed0 security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java 85cd7dd67 security-admin/src/main/resources/conf.dist/security-applicationContext.xml 807791f28 security-admin/src/test/java/org/apache/ranger/biz/TestRangerBizUtil.java 22e290a66 security-admin/src/test/java/org/apache/ranger/rest/TestPublicAPIsv2.java 73a593e9f Diff: https://reviews.apache.org/r/74405/diff/1/ Testing --- Thanks, Ramachandran Krishnan

Re: Review Request 74395: RANGER-4168 :Improvement Adding Unit test cases are some of the missing classes

/biz/TestTagDBStore.java PRE-CREATION Diff: https://reviews.apache.org/r/74395/diff/1/ Testing --- All the Unit test cases are Tested and it is working fine Thanks, Ramachandran Krishnan

Re: Review Request 74141: RANGER-3010 : To support roleName as part of Path parameter for addUsersAndGroups, removeUsersAndGroups, removeAdminFromUsersAndGroups REST API's (Both :RoleREST and PublicAP

.java 4f0edd2b0 security-admin/src/test/java/org/apache/ranger/rest/TestPublicAPIsv2.java 73a593e9f security-admin/src/test/java/org/apache/ranger/rest/TestRoleREST.java 217c1bba3 Diff: https://reviews.apache.org/r/74141/diff/5/ Testing (updated) --- Thanks, Ramachandran Krishnan

Re: Review Request 74141: RANGER-3010 : To support roleName as part of Path parameter for addUsersAndGroups, removeUsersAndGroups, removeAdminFromUsersAndGroups REST API's (Both :RoleREST and PublicAP

l -u -X PUT -H 'Content-Type:application/json' "http://:/service/roles/api/roles/name//removeUsersAndGroups?users=&serviceName=&execUser=&groups=" -v -k curl -u -X PUT -H 'Content-Type:application/json' "http://:/service/roles/api/roles/name//removeUsersAndGroups?users=&serviceName=&execUser=&groups=" -v -k Thanks, Ramachandran Krishnan

Re: Review Request 74397: RANGER-4188: updatePolicy results in 400 status code

> On April 17, 2023, 7:13 a.m., Abhishek Kumar wrote: > > security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java > > Line 1764 (original), 1764 (patched) > > > > > > There are other occurences of upda

Review Request 74399: RANGER-4191:Expose the Ranger REST API to fetch all the roles that groups belong to

.java 73a593e9f security-admin/src/test/java/org/apache/ranger/rest/TestRoleREST.java 217c1bba3 Diff: https://reviews.apache.org/r/74399/diff/1/ Testing --- Thanks, Ramachandran Krishnan

Re: Review Request 74398: RANGER-4190: Apache Ranger does not recover from a recoverable SQL exception

hen invoking Java: Example: java -Dnetworkaddress.cache.ttl=0 -Dnetworkaddress.cache.negative.ttl=0 app.jar Diffs - embeddedwebserver/scripts/ranger-admin-services.sh a76f0986c Diff: https://reviews.apache.org/r/74398/diff/1/ Testing --- Thanks, Ramachandran Krishnan

Review Request 74398: RANGER-4190: Apache Ranger does not recover from a recoverable SQL exception

etworkaddress.cache.ttl=0 -Dnetworkaddress.cache.negative.ttl=0 app.jar Diffs - embeddedwebserver/scripts/ranger-admin-services.sh a76f0986c Diff: https://reviews.apache.org/r/74398/diff/1/ Testing --- Thanks, Ramachandran Krishnan

Review Request 74395: RANGER-4168 : Unit test cases are missing for TagDBStore.java

working fine Thanks, Ramachandran Krishnan

Re: Review Request 74349: RANGER-4133 Improvement in Ranger Roles Rest API's

RoleREST.java 4f0edd2b0 security-admin/src/test/java/org/apache/ranger/rest/TestPublicAPIsv2.java 73a593e9f security-admin/src/test/java/org/apache/ranger/rest/TestRoleREST.java 217c1bba3 Diff: https://reviews.apache.org/r/74349/diff/2/ Testing --- Thanks, Ramachandran Krishnan

Re: Review Request 74349: RANGER-4133 Improvement in Ranger Roles Rest API's

/ranger/rest/TestPublicAPIsv2.java 73a593e9f security-admin/src/test/java/org/apache/ranger/rest/TestRoleREST.java 217c1bba3 Diff: https://reviews.apache.org/r/74349/diff/2/ Changes: https://reviews.apache.org/r/74349/diff/1-2/ Testing --- Thanks, Ramachandran Krishnan

Re: Review Request 74379: RANGER-4164:Adding contributor name into ranger

ranger Diffs (updated) - docs/pom.xml 94f90abe6 Diff: https://reviews.apache.org/r/74379/diff/2/ Changes: https://reviews.apache.org/r/74379/diff/1-2/ Testing --- Thanks, Ramachandran Krishnan

Re: Review Request 74379: RANGER-4164:Adding contributor name into ranger

che.org/r/74379/#review225339 --- On April 4, 2023, 3:41 p.m., Ramachandran Krishnan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:/

Review Request 74379: RANGER-4164:Adding contributor name into ranger

94f90abe6 Diff: https://reviews.apache.org/r/74379/diff/1/ Testing --- Thanks, Ramachandran Krishnan

Re: [VOTE] Apache Ranger 2.4.0 Release - rc2

+1 Thanks & Regards, Ram On Tue, Mar 28, 2023 at 10:18 AM Subhrat Chaudhary wrote: > +1 > > Thanks & Regards,Subhrat Chaudhary > > > On Tuesday, March 28, 2023 at 09:10:29 AM GMT+5:30, Selvamohan > Neethiraj wrote: > > Rangers: > > Apache Ranger 2.4.0 release candidate #2 is now available

Re: Review Request 74363: RANGER-4156:Unit test cases are missing for RoleDBStore.java

, Ramachandran Krishnan

Re: Review Request 74349: RANGER-4133 Improvement in Ranger Roles Rest API's

users=" + Arrays.toString(users.toArray()) + ", groups=" + Arrays.toString(groups.toArray()) + ", isAdmin=" + isAdmin + ")"); } - Ramachandran --- This is an automatically generated e-mail. To

Review Request 74363: RANGER-4156:Unit test cases are missing for RoleDBStore.java

RoleDBStore.java Diffs - security-admin/src/test/java/org/apache/ranger/biz/TestRoleDBStore.java PRE-CREATION Diff: https://reviews.apache.org/r/74363/diff/1/ Testing --- Thanks, Ramachandran Krishnan

Re: [VOTE] Apache Ranger 2.4.0 Release - rc0

+1 On Wed, Mar 22, 2023 at 11:54 AM Selvamohan Neethiraj wrote: > > Dear Rangers: > > Thanks to all of the Rangers for your dedicated efforts to reach "2.4.0 > release" milestone for Apache Ranger. > > Apache Ranger 2.4.0 release candidate #0 is now available for a vote > within the dev commun

Re: Review Request 74349: RANGER-4133 Improvement in Ranger Roles Rest API's

ot;); > > > > // do something with the lists and the boolean parameter > > > > return ResponseEntity.ok("Success"); > > } > > > > ``` > > Ramachandran Krishnan wrote: > Are you expecting something like this ? > >

Re: Review Request 74349: RANGER-4133 Improvement in Ranger Roles Rest API's

ot;); > > > > // do something with the lists and the boolean parameter > > > > return ResponseEntity.ok("Success"); > > } > > > > ``` > > Ramachandran Krishnan wrote: > Are you expecting something like this ? > >

Re: Review Request 74349: RANGER-4133 Improvement in Ranger Roles Rest API's

ot;); > > > > // do something with the lists and the boolean parameter > > > > return ResponseEntity.ok("Success"); > > } > > > > ``` > > Ramachandran Krishnan wrote: > Are you expecting something like this ? > >

Re: Review Request 74349: RANGER-4133 Improvement in Ranger Roles Rest API's

ot;); > > > > // do something with the lists and the boolean parameter > > > > return ResponseEntity.ok("Success"); > > } > > > > ``` > > Ramachandran Krishnan wrote: > Are you expecting something like this ? > >

Re: Review Request 74349: RANGER-4133 Improvement in Ranger Roles Rest API's

ot;); > > > > // do something with the lists and the boolean parameter > > > > return ResponseEntity.ok("Success"); > > } > > > > ``` > > Ramachandran Krishnan wrote: > Are you expecting something like this ? > >

Re: Review Request 74349: RANGER-4133 Improvement in Ranger Roles Rest API's

lists and the boolean parameter return ResponseEntity.ok("Success"); } - Ramachandran ------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74349/#review225274 -

Review Request 74349: RANGER-4133 Improvement in Ranger Roles Rest API's

4f0edd2b0 security-admin/src/test/java/org/apache/ranger/rest/TestPublicAPIsv2.java 73a593e9f security-admin/src/test/java/org/apache/ranger/rest/TestRoleREST.java 217c1bba3 Diff: https://reviews.apache.org/r/74349/diff/1/ Testing --- Thanks, Ramachandran Krishnan

Re: Review Request 74342: RANGER-4126:Fetching getDBVersion in BaseDao class in the security-admin-web throws Exception for Oracle Database

/BaseDao.java 418557bcb security-admin/src/main/java/org/apache/ranger/patch/cliutil/MetricUtil.java 8a13a1712 Diff: https://reviews.apache.org/r/74342/diff/3/ Changes: https://reviews.apache.org/r/74342/diff/2-3/ Testing --- Tested with Oracle DB and works fine Thanks, Ramachandran

Re: Review Request 74342: RANGER-4126:Fetching getDBVersion in BaseDao class in the security-admin-web throws Exception for Oracle Database

/ Testing --- Tested with Oracle DB and works fine Thanks, Ramachandran Krishnan

Improvement in Ranger Roles Rest API's

Hi All, I have attached the Proposal document for some of the Ranger Roles REST Api's improvements. Kindly please take a look

Review Request 74342: RANGER-4126:Fetching getDBVersion in BaseDao class in the security-admin-web throws Exception for Oracle Database

/org/apache/ranger/patch/cliutil/MetricUtil.java 8a13a1712 Diff: https://reviews.apache.org/r/74342/diff/1/ Testing --- Tested with Oracle DB and works fine Thanks, Ramachandran Krishnan

Re: Review Request 74112: RANGER-3903:Improvement in RangerPolicyDeltaUtil--> applyDeltas method

ly, visit: https://reviews.apache.org/r/74112/#review225211 --- On Feb. 24, 2023, 5:02 a.m., Ramachandran Krishnan wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 74329: RANGER-4112: Update servicedef by name results in 400 status code

> On Feb. 28, 2023, 11:22 p.m., Abhay Kulkarni wrote: > > security-admin/src/test/java/org/apache/ranger/rest/TestPublicAPIsv2.java > > Line 320 (original), 320 (patched) > > > > > > Consider reverting this change an

Re: Review Request 74329: RANGER-4112: Update servicedef by name results in 400 status code

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74329/#review225228 --- Ship it! Ship It! - Ramachandran Krishnan On Feb. 28, 2023

Review Request 74320: RANGER-4110: Upgrade to TLS to version 1.2 -Part2

/ranger/authentication/unix/jaas/RemoteUnixLoginModule.java 204398f7e Diff: https://reviews.apache.org/r/74320/diff/1/ Testing --- Thanks, Ramachandran Krishnan

Re: Review Request 74112: RANGER-3903:Improvement in RangerPolicyDeltaUtil--> applyDeltas method

rviceREST Rest API :GET /plugins/policies/download/{serviceName} 2. ServiceREST Rest API :GET /plugins/secure/policies/download/{serviceName} Thanks, Ramachandran Krishnan

Re: Review Request 74112: RANGER-3903:Improvement in RangerPolicyDeltaUtil--> applyDeltas method

g/r/74112/#review225207 --- On Jan. 29, 2023, 1:01 p.m., Ramachandran Krishnan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revie

Re: Review Request 74112: RANGER-3903:Improvement in RangerPolicyDeltaUtil--> applyDeltas method

ust call ret.addAll(policesIdMap.values()) ? > > Ramachandran Krishnan wrote: > Done Madhan, I feel we can consider this fix which will reduce the time complexity from O(N * M) to O(N + M) and simplify the code . - Ramachandran

Re: Review Request 74112: RANGER-3903:Improvement in RangerPolicyDeltaUtil--> applyDeltas method

> On Jan. 29, 2023, 11:16 a.m., Kirby Zhou wrote: > > > > Ramachandran Krishnan wrote: > madhan I think that we have addressed all of the review comments in this > PR .I feel it is good to go for merging Madhan As Abhishek Kumar said, The optimizations in the review

Re: Review Request 74251: RANGER-4012:getPolicyByName searches policy by serviceName, policyName simply by traverse all policies in RangerServicePoliciesCache instead of DB

org/r/74251/diff/8/ Changes: https://reviews.apache.org/r/74251/diff/7-8/ Testing --- Thanks, Ramachandran Krishnan

Re: Review Request 74251: RANGER-4012:getPolicyByName searches policy by serviceName, policyName simply by traverse all policies in RangerServicePoliciesCache instead of DB

org/r/74251/diff/7/ Changes: https://reviews.apache.org/r/74251/diff/6-7/ Testing --- Thanks, Ramachandran Krishnan

Re: Review Request 74262: RANGER-4024:Adding requestId as part of Ranger logs via RangerMDCFilter when the request header contains request-Id

/1-2/ Testing --- Thanks, Ramachandran Krishnan

Re: Review Request 74112: RANGER-3903:Improvement in RangerPolicyDeltaUtil--> applyDeltas method

------ On Jan. 29, 2023, 1:01 p.m., Ramachandran Krishnan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74112/ > ---

Re: Review Request 74285: RANGER-4057 :[Ranger] /tags/tags/cache/reset api give 200 response for invalid service

it: https://reviews.apache.org/r/74285/#review225124 --- On Jan. 24, 2023, 5:46 a.m., Ramachandran Krishnan wrote: > > --- > This is an automatically generated e-mail. To rep

Review Request 74291: RANGER-4055:Compulsory field firstName can be passed empty or null in the payload while creating user through API

ist": [ 1 ], "groupNameList": [ "public" ], "status": 1, "isVisible": 1, "userSource": 0, "userRoleList": [ "ROLE_USER" ] } With firstName as null also the user is creating successfully. Diffs - security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 0a03da567 security-admin/src/test/java/org/apache/ranger/biz/TestXUserMgr.java 871857bbf Diff: https://reviews.apache.org/r/74291/diff/1/ Testing --- Thanks, Ramachandran Krishnan

Re: Review Request 74112: RANGER-3903:Improvement in RangerPolicyDeltaUtil--> applyDeltas method

-mail. To reply, visit: https://reviews.apache.org/r/74112/#review225137 --- On Jan. 29, 2023, 1:01 p.m., Ramachandran Krishnan wrote: > > --- > This is an automatically generate

Re: Review Request 74251: RANGER-4012:getPolicyByName searches policy by serviceName, policyName simply by traverse all policies in RangerServicePoliciesCache instead of DB

r/74251/#review225143 --- On Feb. 1, 2023, 3:58 a.m., Ramachandran Krishnan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > h

  1   2   3   >