----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74538/#review226013 -----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/util/PolicyRefresher.java Lines 55 (patched) <https://reviews.apache.org/r/74538/#comment314364> Are we adding metrics only for Policy download ?.It would be great if you add the same for roles as well.The policy refresher thread will download policies as well as roles also. - Ramachandran Krishnan On Aug. 11, 2023, 9:05 a.m., Sai Sandeep Rangisetti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74538/ > ----------------------------------------------------------- > > (Updated Aug. 11, 2023, 9:05 a.m.) > > > Review request for ranger, Kishor Gollapalliwar, Abhay Kulkarni, Madhan > Neethiraj, Mehul Parikh, Pradeep Agrawal, and Ramachandran Krishnan. > > > Bugs: RANGER-4345 > https://issues.apache.org/jira/browse/RANGER-4345 > > > Repository: ranger > > > Description > ------- > > Add metrics in the plugins for increased visibility on what is happening in > the systems > > > Diffs > ----- > > agents-common/pom.xml b753c1368 > > agents-common/src/main/java/org/apache/ranger/plugin/util/PolicyRefresher.java > c130309ea > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerMetricRegistry.java > PRE-CREATION > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTClient.java > e54313403 > > > Diff: https://reviews.apache.org/r/74538/diff/4/ > > > Testing > ------- > > Compiled and installed the hbase plugin and verified that metrics are being > published to jmx. Simulated failures by blocking port and verified timeout > and retry metrics are also being published > > > Thanks, > > Sai Sandeep Rangisetti > >
