Re: Review Request 74763: RANGER-4607: Ranger REST API improvements

2024-10-24 Thread Abhishek Patil
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74763/#review226997 --- Ship it! Ship It! - Abhishek Patil On Oct. 9, 2024, 12:47

Re: Review Request 74800: RANGER-4620: Add python based Public V2 REST API tests to the Apache Ranger repo

2024-08-17 Thread Abhishek Patil
ocalhost:6080";, > > "admin_user": "admin", > > "key_admin_user": "keyadmin", > > "admin_user_password": "rangerR0cks!" > > } > > ``` Thanks for the review Madhan. Will look i

Re: Review Request 75059: RANGER-4812 : Database schema patch to create x_trx_log_v2 table

2024-06-20 Thread Abhishek Patil
ensure that the required table and indexes are created in the database. Thanks, Abhishek Patil

Review Request 74935: RANGER-4653: [addendum] Use Name validation regex instead of service name validation regex for Display name

2024-03-08 Thread Abhishek Patil
that service creation / update fails if service display name contains a special character / if the name is longer than 255 characters. Thanks, Abhishek Patil

Re: Review Request 74880: RANGER-4698: Audit UI improvements with respect to values overflowing into other columns

2024-02-13 Thread Abhishek Patil
: https://reviews.apache.org/r/74880/diff/1/ Testing --- Applied the patch on a cluster and ensured that the values are clipped when the value is long, and ensured that the text is not overflowing into other columns Thanks, Abhishek Patil

Review Request 74867: RANGER-4696: Fix User Deletion Issue for GDS approver users in Ranger

2024-02-11 Thread Abhishek Patil
successful. Thanks, Abhishek Patil

Review Request 74861: RANGER-4688 Display query information for show roles/databases/schemas/grant role commands on Ranger Admin UI

2024-02-05 Thread Abhishek Patil
r show databases command 3. Ensured that the query information is displayed for "grant role to user {username};" command 4. Ensured that the query information is displayed for "show schemas;" command Thanks, Abhishek Patil

Re: Review Request 74820: RANGER-4498: Newly created user with admin role doesn't get permission for GDS module automatically

2024-01-29 Thread Abhishek Patil
behaviour). Thanks, Abhishek Patil

Re: Review Request 74856: RANGER-4652: Value for datasets and projects field in the access audits must be JSON serializable

2024-01-27 Thread Abhishek Patil
he value of the datasets field in the access audits was {"datasets": "[\"test_dataset_1\"]"}. This value can be parsed as a JSON object / array Thanks, Abhishek Patil

Review Request 74857: RANGER-4536: Audit UI updates to support datasets and projects

2024-01-27 Thread Abhishek Patil
hiding is working for datasets and projects. 5. Ensured that the audit log details view contains the datasets and projects section. Thanks, Abhishek Patil

Review Request 74856: RANGER-4652: Value for datasets and projects field in the access audits must be JSON serializable

2024-01-27 Thread Abhishek Patil
Created a datashare, a dataset, linked both and performed an operation such that the access was allowed through a dataset policy. The value of the datasets field in the access audits was {"datasets": "[\"test_dataset_1\"]"}. This value can be parsed as a JSON object / array Thanks, Abhishek Patil

Review Request 74849: RANGER-4654 : Handle Dataset and Datashare creation errors gracefully

2024-01-22 Thread Abhishek Patil
ilure", and it was not descriptive. The issue has been fixed to display the proper error message. Thanks, Abhishek Patil

Re: Review Request 74835: RANGER-4648: Return proper error message if GDS entities name is longer than 512 characters and assertions in the UI form as well

2024-01-14 Thread Abhishek Patil
------ On Jan. 14, 2024, 9:39 a.m., Abhishek Patil wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74835/ >

Re: Review Request 74835: RANGER-4648: Return proper error message if GDS entities name is longer than 512 characters and assertions in the UI form as well

2024-01-14 Thread Abhishek Patil
proper error message was returned. 4. Tried to update a datashare/dataset with name length greater than 512 characters, proper error message was shown on the UI and also in the API response. Thanks, Abhishek Patil

Review Request 74837: RANGER-4653: Add inline assertions for displayName length in service creation / update form

2024-01-13 Thread Abhishek Patil
modifying the displayName with invalid special characters, form submission failed (as expected). 7. Edit a service by modifying the displayName with length greater than 256 characters, form submission failed (as expected). Thanks, Abhishek Patil

Review Request 74835: RANGER-4648: Return proper error message if GDS entities name is longer than 512 characters and assertions in the UI form as well

2024-01-12 Thread Abhishek Patil
, Abhishek Patil

Review Request 74832: RANGER-4647 [Ranger UI] Text overflowing in the datashares table listing in the dataset -> datashares page

2024-01-11 Thread Abhishek Patil
--- Applied the patch on a cluster and ensured that the data was being rendered properly in the table Thanks, Abhishek Patil

Re: Review Request 74828: RANGER-4636, RANGER-4637: Fix /public/api/policy/count and /public/api/repository/count to return the proper value

2024-01-10 Thread Abhishek Patil
modified according to the code change, and the unit tests were run by triggering a maven build. The unit tests passed Thanks, Abhishek Patil

Re: Review Request 74828: RANGER-4636, RANGER-4637: Fix /public/api/policy/count and /public/api/repository/count to return the proper value

2024-01-09 Thread Abhishek Patil
now if more debug statements are required? Thanks - Abhishek --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74828/#review226116 ---

Review Request 74828: RANGER-4636, RANGER-4637: Fix /public/api/policy/count and /public/api/repository/count to return the proper value

2024-01-09 Thread Abhishek Patil
tests passed Thanks, Abhishek Patil

Re: Review Request 74820: RANGER-4498: Newly created user with admin role doesn't get permission for GDS module automatically

2024-01-06 Thread Abhishek Patil
have access to GDS module (expected behaviour). Thanks, Abhishek Patil

Re: Review Request 74820: RANGER-4498: Newly created user with admin role doesn't get permission for GDS module automatically

2024-01-06 Thread Abhishek Patil
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74820/#review226108 --- On Jan. 6, 2024, 4:37 p.m., Abhishek Patil wrote: > > -

Review Request 74820: RANGER-4498: Newly created user with admin role doesn't get permission for GDS module automatically

2024-01-06 Thread Abhishek Patil
GDS module 2. Created users of role ROLE_ADMIN_AUDITOR and ROLE_USER, and these users did not have access to GDS module (expected behaviour). Thanks, Abhishek Patil

Review Request 74813: RANGER-4631: Operation column empty in Ranger admin audits for datashare and dataset CRUD operations

2024-01-03 Thread Abhishek Patil
creation, update, and delete 2. Dataset create, update and delete 3. Datashare in Dataset create, update, and delete Thanks, Abhishek Patil

Re: Review Request 74810: RANGER-4615 : Keep the LDAP usersync details popup names same as the backbone js names

2024-01-03 Thread Abhishek Patil
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74810/#review226080 --- Ship it! Ship It! - Abhishek Patil On Jan. 3, 2024, 8:14

Review Request 74800: RANGER-4620: Add python based Public V2 REST API tests to the Apache Ranger repo

2023-12-20 Thread Abhishek Patil
/python_tests/test_runner.py PRE-CREATION security-admin/src/test/python_tests/utils.py PRE-CREATION Diff: https://reviews.apache.org/r/74800/diff/1/ Testing --- Executed the tests against the latest release of Apache Ranger and ensured that all the tests are passing. Thanks, Abhishek

Review Request 74792: RANGER-4605: /assets/resources/count does not return proper count if policies are greater than 200

2023-12-13 Thread Abhishek Patil
s for hive, fetched the count using the API, and ensured that the proper count is returned. 3. Made a get request to the API endpoint using keyadmin user, and ensured that the count returned is 0 (0 is the expected value as keyadmin user can access only kms policies). Thanks, Abhishek Patil

Review Request 74791: RANGER-4606 /assets/assets/count API does not return the proper count if the number of services is greater than 200

2023-12-13 Thread Abhishek Patil
services is less than 20, and then ensured that the proper count is returned (i.e count is returned only for legacy services). 2. Created 250 Hdfs service repos, and fetched the count using the API, and ensured that the proper count is returned. Thanks, Abhishek Patil

Review Request 74784: RANGER-4601: /xaudit/access_audit/count API does not return the proper value

2023-12-12 Thread Abhishek Patil
er count is returned in the response. Thanks, Abhishek Patil

Review Request 74782: RANGER-4600: Add improvement for /xaudit/access_audit API based on user role

2023-12-12 Thread Abhishek Patil
Thanks, Abhishek Patil

Review Request 74765: RANGER-4599: Prevent admin users from performing CRUD operations on KMS service repos

2023-12-11 Thread Abhishek Patil
for keyadmin user. Thanks, Abhishek Patil

Review Request 74780: RANGER-4564: DELETE /groupsgroups/{id} API doesn't work as forceDelete is hardcoded to false

2023-12-11 Thread Abhishek Patil
g the groupgroup using id with request param forceDelete=true, and also with param forceDelete=True, the groupgroup was deleted 5. Tried deleting the groupgrouo using id with request param forceDelete=random_string, the group is not deleted, and returned using a GET request Thanks, Abhishek Patil

Re: Review Request 74752: RANGER-4543 : Add flink service user to default audit filters, and add spark3 path for default audit filters in HDFS

2023-11-22 Thread Abhishek Patil
s://reviews.apache.org/r/74752/diff/1-2/ Testing --- Tested on a fresh install cluster and verified that no audits are logged for flink user on the path "/user/flink/applicationHistory", for the "listStatus" operation, after the servicedef is updated for hdfs service Thanks, Abhishek Patil

Review Request 74752: RANGER-4543 : Add flink service user to default audit filters in HDFS

2023-11-21 Thread Abhishek Patil
752/diff/1/ Testing --- Tested on a fresh install cluster and verified that no audits are logged for flink user on the path "/user/flink/applicationHistory", for the "listStatus" operation, after the servicedef is updated for hdfs service Thanks, Abhishek Patil

Re: Review Request 74593: RANGER-4358: Keep the usersync details popup names same as the backbone js names

2023-09-11 Thread Abhishek Patil
://reviews.apache.org/r/74593/diff/2/ Changes: https://reviews.apache.org/r/74593/diff/1-2/ Testing --- Built Ranger admin with the changes and verified the behaviour in React UI Thanks, Abhishek Patil

Review Request 74593: RANGER-4358: Keep the usersync details popup names same as the backbone js names

2023-09-11 Thread Abhishek Patil
UI Thanks, Abhishek Patil

Re: Review Request 74534: RANGER-4339: Correct spelling of delegate in React JS policy form

2023-08-02 Thread Abhishek Patil
has to be corrected Diffs - security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyPermissionItem.jsx 380c2ec30 Diff: https://reviews.apache.org/r/74534/diff/1/ Testing --- Tested locally Thanks, Abhishek Patil

Review Request 74486: RANGER-4296: [Ranger UI] [React JS] Dropdown option in the access audits must display "User" instead of "Users"

2023-06-21 Thread Abhishek Patil
Even in the old UI's, the option is displayed as "User" Diffs - security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogs.jsx bd8011fd5 Diff: https://reviews.apache.org/r/74486/diff/1/ Testing --- Tested locally Thanks, Abhishek Patil

Review Request 74309: RANGER-4084: Use the exact login ID in the header instead of capitalising the first character

2023-02-16 Thread Abhishek Patil
iff: https://reviews.apache.org/r/74309/diff/1/ Testing --- Tested changes on a cluster Thanks, Abhishek Patil

Re: Review Request 74307: RANGER-4082: Correct the spelling "succesfully" in UI alert messages

2023-02-14 Thread Abhishek Patil
eForm.jsx a46e370e9 security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/GroupAssociateUserDetails.jsx cdd249391 Diff: https://reviews.apache.org/r/74307/diff/2/ Changes: https://reviews.apache.org/r/74307/diff/1-2/ Testing --- Tested the changes on a live cluster. Thanks, Abhishek Patil

Re: Review Request 74307: RANGER-4082: Correct the spelling "succesfully" in UI alert messages

2023-02-13 Thread Abhishek Patil
9 security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/GroupAssociateUserDetails.jsx cdd249391 Diff: https://reviews.apache.org/r/74307/diff/1/ Testing --- Tested the changes on a live cluster. Thanks, Abhishek Patil

Request to add me as a contributor

2023-02-13 Thread abhishek patil
Regards, Abhishek Patil