Re: Review Request 60043: Ranger KMS should validate key name before importing into DB

2017-07-09 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60043/#review180006 --- Ship it! Ship It! - Velmurugan Periasamy On June 22, 2017, 1

Re: Review Request 60043: Ranger KMS should validate key name before importing into DB

2017-06-22 Thread Ankita Sinha
> On June 13, 2017, 12:20 p.m., Colm O hEigeartaigh wrote: > > Ship It! > > Colm O hEigeartaigh wrote: > Actually, is it feasible to add some unit tests for this? Thanks Colm, added unit tests. - Ankita --- This is an automatically

Re: Review Request 60043: Ranger KMS should validate key name before importing into DB

2017-06-22 Thread Ankita Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60043/ --- (Updated June 22, 2017, 1:50 p.m.) Review request for ranger, Don Bosco Durai,

Re: Review Request 60043: Ranger KMS should validate key name before importing into DB

2017-06-13 Thread Colm O hEigeartaigh
> On June 13, 2017, 12:20 p.m., Colm O hEigeartaigh wrote: > > Ship It! Actually, is it feasible to add some unit tests for this? - Colm --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60043/

Re: Review Request 60043: Ranger KMS should validate key name before importing into DB

2017-06-13 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60043/#review177731 --- Ship it! Ship It! - Colm O hEigeartaigh On June 13, 2017, 12

Re: Review Request 60043: Ranger KMS should validate key name before importing into DB

2017-06-13 Thread Ankita Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60043/ --- (Updated June 13, 2017, 12:06 p.m.) Review request for ranger, Don Bosco Durai,

Re: Review Request 60043: Ranger KMS should validate key name before importing into DB

2017-06-13 Thread Ankita Sinha
- Ankita --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60043/#review177725 --- On June 13, 2017, 12:06 p.m., Ankita Sinha wrote: > >

Re: Review Request 60043: Ranger KMS should validate key name before importing into DB

2017-06-13 Thread Ankita Sinha
> On June 13, 2017, 10:31 a.m., Colm O hEigeartaigh wrote: > > Instead of calling Pattern.compile for each check, it's better to make the > > Pattern static + call Pattern.compile once, as the regex itself is static > > and doesn't change. Thanks, Updated the review request. - Ankita -

Re: Review Request 60043: Ranger KMS should validate key name before importing into DB

2017-06-13 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60043/#review177725 --- Instead of calling Pattern.compile for each check, it's better to

Review Request 60043: Ranger KMS should validate key name before importing into DB

2017-06-13 Thread Ankita Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60043/ --- Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan