Re: Review Request 66079: RANGER-1808:Write unit test for RANGER-1672 kylin plugin

2018-03-28 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66079/#review200108 --- Ship it! Ship It! - Colm O hEigeartaigh On March 28, 2018, 8

Re: Review Request 66079: RANGER-1808:Write unit test for RANGER-1672 kylin plugin

2018-03-28 Thread Qiang Zhang
> On 三月 27, 2018, 2:12 p.m., Colm O hEigeartaigh wrote: > > Can we re-use the value for ${springframework.security.version} as it's now > > 4.2.4.RELEASE? Thank you, Colm O hEigeartaigh, I'm glad to see that Ranger has upgraded to Spring 4. - Qiang -

Re: Review Request 66079: RANGER-1808:Write unit test for RANGER-1672 kylin plugin

2018-03-28 Thread Qiang Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66079/ --- (Updated 三月 28, 2018, 8:46 a.m.) Review request for ranger, Ankita Sinha, Don B

Re: Review Request 66079: RANGER-1808:Write unit test for RANGER-1672 kylin plugin

2018-03-27 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66079/#review200044 --- Can we re-use the value for ${springframework.security.version} as

Re: Review Request 66079: RANGER-1808:Write unit test for RANGER-1672 kylin plugin

2018-03-27 Thread Qiang Zhang
> On March 16, 2018, 3:29 p.m., Colm O hEigeartaigh wrote: > > Minor quibble - avoid creating unnecessary variables, e.g.: > > > > > ProjectInstance project = getProjectInstance(name); > > > return project; > > > > could simply be: > > > > return getProjectInstance(name); > > > > Same goes fo

Re: Review Request 66079: RANGER-1808:Write unit test for RANGER-1672 kylin plugin

2018-03-18 Thread Qiang Zhang
> On 三月 16, 2018, 3:29 p.m., Colm O hEigeartaigh wrote: > > Minor quibble - avoid creating unnecessary variables, e.g.: > > > > > ProjectInstance project = getProjectInstance(name); > > > return project; > > > > could simply be: > > > > return getProjectInstance(name); > > > > Same goes for:

Re: Review Request 66079: RANGER-1808:Write unit test for RANGER-1672 kylin plugin

2018-03-18 Thread Qiang Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66079/ --- (Updated 三月 19, 2018, 3:32 a.m.) Review request for ranger, Ankita Sinha, Don B

Re: Review Request 66079: RANGER-1808:Write unit test for RANGER-1672 kylin plugin

2018-03-16 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66079/#review199325 --- Minor quibble - avoid creating unnecessary variables, e.g.: > Pro

Re: Review Request 66079: RANGER-1808:Write unit test for RANGER-1672 kylin plugin

2018-03-16 Thread pengjianhua
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66079/#review199310 --- Ship it! Ship It! - pengjianhua On 三月 15, 2018, 6:55 a.m., Q

Review Request 66079: RANGER-1808:Write unit test for RANGER-1672 kylin plugin

2018-03-14 Thread Qiang Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66079/ --- Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, G