Re: Review Request 72941: RANGER-3030 : Replace Findbugs with Spotbugs maven plugin

2021-12-09 Thread Pradeep Agrawal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72941/#review223836 --- Ship it! Ship It! - Pradeep Agrawal On Dec. 8, 2021, 8:03 a.

Re: Review Request 72941: RANGER-3030 : Replace Findbugs with Spotbugs maven plugin

2021-12-09 Thread bhavik patel
> On Dec. 10, 2021, 4:20 a.m., Pradeep Agrawal wrote: > > What if we keep both ? > > bhavik patel wrote: > Spotbugs is developed on top Findbugs so keeping both it's not good idea. > > Pradeep Agrawal wrote: > That i know, I wanted to know that whether anything has been > removed/depre

Re: Review Request 72941: RANGER-3030 : Replace Findbugs with Spotbugs maven plugin

2021-12-09 Thread Pradeep Agrawal
> On Dec. 10, 2021, 4:20 a.m., Pradeep Agrawal wrote: > > What if we keep both ? > > bhavik patel wrote: > Spotbugs is developed on top Findbugs so keeping both it's not good idea. That i know, I wanted to know that whether anything has been removed/deprecated from Spotbugs which was alrea

Re: Review Request 72941: RANGER-3030 : Replace Findbugs with Spotbugs maven plugin

2021-12-09 Thread bhavik patel
> On Dec. 10, 2021, 4:20 a.m., Pradeep Agrawal wrote: > > What if we keep both ? Spotbugs is developed on top Findbugs so keeping both it's not good idea. - bhavik --- This is an automatically generated e-mail. To reply, visit: https://

Re: Review Request 72941: RANGER-3030 : Replace Findbugs with Spotbugs maven plugin

2021-12-09 Thread Pradeep Agrawal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72941/#review223830 --- What if we keep both ? - Pradeep Agrawal On Dec. 8, 2021, 8:03

Re: Review Request 72941: RANGER-3030 : Replace Findbugs with Spotbugs maven plugin

2021-12-08 Thread bhavik patel
> On Jan. 5, 2021, 5:33 p.m., Velmurugan Periasamy wrote: > > pom.xml > > Line 116 (original), 116 (patched) > > > > > > Can you please make sure this is not packaged? I see > > spotbugs-annotations-3.1.9.jar is get

Re: Review Request 72941: RANGER-3030 : Replace Findbugs with Spotbugs maven plugin

2021-12-08 Thread bhavik patel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72941/ --- (Updated Dec. 8, 2021, 8:03 a.m.) Review request for ranger, Ankita Sinha, Dhav

Re: Review Request 72941: RANGER-3030 : Replace Findbugs with Spotbugs maven plugin

2021-01-11 Thread bhavik patel
> On Jan. 5, 2021, 5:33 p.m., Velmurugan Periasamy wrote: > > pom.xml > > Line 116 (original), 116 (patched) > > > > > > Can you please make sure this is not packaged? I see > > spotbugs-annotations-3.1.9.jar is get

Re: Review Request 72941: RANGER-3030 : Replace Findbugs with Spotbugs maven plugin

2021-01-11 Thread Velmurugan Periasamy
> On Jan. 5, 2021, 5:33 p.m., Velmurugan Periasamy wrote: > > pom.xml > > Line 116 (original), 116 (patched) > > > > > > Can you please make sure this is not packaged? I see > > spotbugs-annotations-3.1.9.jar is get

Re: Review Request 72941: RANGER-3030 : Replace Findbugs with Spotbugs maven plugin

2021-01-10 Thread bhavik patel
> On Jan. 5, 2021, 5:33 p.m., Velmurugan Periasamy wrote: > > pom.xml > > Line 116 (original), 116 (patched) > > > > > > Can you please make sure this is not packaged? I see > > spotbugs-annotations-3.1.9.jar is get

Re: Review Request 72941: RANGER-3030 : Replace Findbugs with Spotbugs maven plugin

2021-01-05 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72941/#review222406 --- pom.xml Line 116 (original), 116 (patched)

Re: Review Request 72941: RANGER-3030 : Replace Findbugs with Spotbugs maven plugin

2021-01-04 Thread bhavik patel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72941/ --- (Updated Jan. 5, 2021, 6:05 a.m.) Review request for ranger, Ankita Sinha, Dhav

Review Request 72941: RANGER-3030 : Replace Findbugs with Spotbugs maven plugin

2020-10-08 Thread bhavik patel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72941/ --- Review request for ranger, Ankita Sinha, Dhaval Shah, Dineshkumar Yadav, Gautam