Re: Review Request 73913: RANGER-3681:Ranger Database deadlock when createPolicy is running parallel

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73913/#review224222 --- Ship it! Ship It! - Madhan Neethiraj On March 26, 2022, 5:35

Re: Review Request 73913: RANGER-3681:Ranger Database deadlock when createPolicy is running parallel

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73913/#review224221 --- Ship it! Ship It! - Abhay Kulkarni On March 26, 2022, 5:35 a

Re: Review Request 73913: RANGER-3681:Ranger Database deadlock when createPolicy is running parallel

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73913/ --- (Updated 三月 26, 2022, 5:35 a.m.) Review request for ranger, Abhay Kulkarni, Mad

Re: Review Request 73913: RANGER-3681:Ranger Database deadlock when createPolicy is running parallel

> On 三月 25, 2022, 4:23 a.m., Madhan Neethiraj wrote: > > src/security-admin/src/main/java/org/apache/ranger/db/XXPolicyRefAccessTypeDao.java > > Lines 108 (patched) > > > > > > findByPolicyId(policyId) returns XXPoli

Re: Review Request 73913: RANGER-3681:Ranger Database deadlock when createPolicy is running parallel

> On 三月 26, 2022, 12:45 a.m., Kirby Zhou wrote: > > src/security-admin/src/main/java/org/apache/ranger/db/XXPolicyRefRoleDao.java > > Lines 124 (patched) > > > > > > It seems unnecessery to catch NoResultException wh

Re: Review Request 73913: RANGER-3681:Ranger Database deadlock when createPolicy is running parallel

> On 三月 25, 2022, 4:20 p.m., Abhay Kulkarni wrote: > > src/security-admin/src/main/resources/META-INF/jpa_named_queries.xml > > Line 1669 (original), 1697 (patched) > > > > > > The commented lines in this file and

Re: Review Request 73913: RANGER-3681:Ranger Database deadlock when createPolicy is running parallel

> On 三月 25, 2022, 4:20 p.m., Abhay Kulkarni wrote: > > src/security-admin/src/main/java/org/apache/ranger/db/XXPolicyRefDataMaskTypeDao.java > > Line 97 (original), 95 (patched) > > > > > > This is not really relate

Re: Review Request 73913: RANGER-3681:Ranger Database deadlock when createPolicy is running parallel

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73913/#review224216 --- src/security-admin/src/main/java/org/apache/ranger/db/XXPolicyRef

Re: Review Request 73913: RANGER-3681:Ranger Database deadlock when createPolicy is running parallel

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73913/#review224215 --- src/security-admin/src/main/java/org/apache/ranger/db/XXPolicyRef

Re: Review Request 73913: RANGER-3681:Ranger Database deadlock when createPolicy is running parallel

> On March 25, 2022, 4:23 a.m., Madhan Neethiraj wrote: > > src/security-admin/src/main/java/org/apache/ranger/db/XXPolicyRefAccessTypeDao.java > > Lines 108 (patched) > > > > > > findByPolicyId(policyId) returns XXP

Re: Review Request 73913: RANGER-3681:Ranger Database deadlock when createPolicy is running parallel

> On 三月 25, 2022, 5:55 a.m., Kirby Zhou wrote: > > Can you add some comments to code to explain? > > I'm worried that someone will delete this code as redundant code in the > > future. Thanks for your review and suggetion, I have added some comments in this code. Please check whether it is suf

Re: Review Request 73913: RANGER-3681:Ranger Database deadlock when createPolicy is running parallel

> On 三月 25, 2022, 4:23 a.m., Madhan Neethiraj wrote: > > src/security-admin/src/main/java/org/apache/ranger/db/XXPolicyRefAccessTypeDao.java > > Lines 108 (patched) > > > > > > findByPolicyId(policyId) returns XXPoli

Re: Review Request 73913: RANGER-3681:Ranger Database deadlock when createPolicy is running parallel

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73913/ --- (Updated 三月 25, 2022, 9:33 a.m.) Review request for ranger, Abhay Kulkarni, Mad

Re: Review Request 73913: RANGER-3681:Ranger Database deadlock when createPolicy is running parallel

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73913/#review224208 --- Can you add some comments to code to explain? I'm worried that som

Re: Review Request 73913: RANGER-3681:Ranger Database deadlock when createPolicy is running parallel

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73913/#review224207 --- src/security-admin/src/main/java/org/apache/ranger/db/XXPolicyRef

Review Request 73913: RANGER-3681:Ranger Database deadlock when createPolicy is running parallel

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73913/ --- Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, and Velmurugan Peri