ommit" and then "git
format-patch -n HEAD~"
- Colm O hEigeartaigh
On March 10, 2017, 8:27 p.m., Yan Zhou wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> ht
ger/plugin/util/XMLUtils.java
4647004
Diff: https://reviews.apache.org/r/57553/diff/1/
Testing
---
Thanks,
Colm O hEigeartaigh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57585/#review168891
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On March 14, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57501/#review168619
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On March 10, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57407/#review168612
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On March 9, 2017, 2
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56700/#review168616
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On March 10, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57531/#review168746
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On March 11, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56912/#review168747
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On March 11, 2017
[
https://issues.apache.org/jira/browse/RANGER-1455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colm O hEigeartaigh updated RANGER-1455:
Attachment: 0001-RANGER-1455-Incorrect-conf-dir-in-scripts-for-Hadoop.patch
Colm O hEigeartaigh created RANGER-1455:
---
Summary: Incorrect conf dir in scripts for Hadoop
Key: RANGER-1455
URL: https://issues.apache.org/jira/browse/RANGER-1455
Project: Ranger
quot;etc/hadoop". This is the
default conf directory location for Hadoop post 2.0.
Diffs
-
agents-common/scripts/enable-agent.sh 9270c5f
Diff: https://reviews.apache.org/r/57603/diff/1/
Testing
---
Tested it with Hadoop 2.7.3
Thanks,
Colm O hEigeartaigh
I request all patch submitters to close the submitted/discarded
> review requests.
>
> From: Colm O hEigeartaigh <cohei...@apache.org>
> Reply-To: "dev@ranger.apache.org" <dev@ranger.apache.org>, "
> cohei...@apache.org" <cohei...@apache.org
, Selvamohan Neethiraj <sneet...@apache.org>
wrote:
> Colm:
>
> I was able to close all older RR from https://reviews.apache.org/r
> Do you still see them in your inbox of your review board ?
>
> Selva-
>
> On 3/7/17, 7:00 AM, "Colm O hEigeartaigh" <cohei...@apach
[
https://issues.apache.org/jira/browse/RANGER-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colm O hEigeartaigh updated RANGER-1318:
Attachment: (was:
0001-RANGER-1318-Consolidate-XML-configuration-parsing.patch
[
https://issues.apache.org/jira/browse/RANGER-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colm O hEigeartaigh updated RANGER-1318:
Attachment: 0001-RANGER-1318-Consolidate-XML-configuration-parsing.patch
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57270/#review167800
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On March 3, 2017, 8
[
https://issues.apache.org/jira/browse/RANGER-1348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colm O hEigeartaigh resolved RANGER-1348.
-
Resolution: Fixed
> Atlas Autocompletion not working prope
26dc151
plugin-kafka/src/test/resources/kafka-policies-tag.json PRE-CREATION
plugin-kafka/src/test/resources/kafka-policies.json cc1c927
plugin-kafka/src/test/resources/ranger-kafka-security.xml b2cc5f8
Diff: https://reviews.apache.org/r/57285/diff/1/
Testing
---
Thanks,
Colm O
[
https://issues.apache.org/jira/browse/RANGER-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colm O hEigeartaigh updated RANGER-1408:
Fix Version/s: 1.0.0
> When the error occurs, the system does not record the er
(updated)
---
Tested Admin Server.
Thanks,
Colm O hEigeartaigh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57409/#review168260
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On March 8, 2017, 3
[
https://issues.apache.org/jira/browse/RANGER-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colm O hEigeartaigh updated RANGER-1318:
Attachment: 0001-RANGER-1318-Consolidate-XML-configuration-parsing.patch
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57406/#review168263
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On March 8, 2017, 2
[
https://issues.apache.org/jira/browse/RANGER-1500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15960351#comment-15960351
]
Colm O hEigeartaigh commented on RANGER-1500:
-
For 0.7.1 at least, we should probably support
getPolicyEngineOptions()
configured via "configureDelegateAdmin"? Why not just let ServiceREST do that
part?
- Colm O hEigeartaigh
On March 31, 2017, 12:50 p.m., Zsombor Gegesy wrote:
>
> ---
> This is an automatically generat
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57988/#review170719
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On March 31, 2017
-
>
> (Updated April 17, 2017, 9:20 a.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan
> Neethiraj, and Velmurugan Periasamy.
>
>
> Bug
of the patch is missing?
- Colm O hEigeartaigh
On April 18, 2017, 6:24 a.m., Ankita Sinha wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
;Hive configuration directory"
to "Hive installation directory".
- Colm O hEigeartaigh
On April 17, 2017, 6:57 a.m., Qiang Zhang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> ht
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58472/#review172180
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On April 17, 2017
---
Tested that we can sync Storm tags in to Ranger from Atlas + create tag based
policies as a result for Storm.
Thanks,
Colm O hEigeartaigh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58475/#review172185
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On April 18, 2017
Colm O hEigeartaigh created RANGER-1523:
---
Summary: Add AtlasResourceMapper implementation for Apache Storm
Key: RANGER-1523
URL: https://issues.apache.org/jira/browse/RANGER-1523
Project: Ranger
[
https://issues.apache.org/jira/browse/RANGER-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colm O hEigeartaigh updated RANGER-1523:
Attachment: 0001-RANGER-1523-Add-AtlasResourceMapper-implementation-f.patch
>
as well? Then we
can just delete the build section from the pom, as the log4j.properties get
automatically copied to classes.
- Colm O hEigeartaigh
On March 9, 2017, 3:13 a.m., Qiang Zhang wrote:
>
> ---
> This is an automatically ge
authorizer?
- Colm O hEigeartaigh
On July 31, 2017, 2:15 a.m., pengjianhua wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revi
> On July 31, 2017, 2:12 p.m., Colm O hEigeartaigh wrote:
> > I'm wondering what the expected output of "show grant user X" is? I would
> > have expected to see the privileges that correspond to policies created in
> > the Ranger admin service, but this
> On July 31, 2017, 2:12 p.m., Colm O hEigeartaigh wrote:
> > I'm wondering what the expected output of "show grant user X" is? I would
> > have expected to see the privileges that correspond to policies created in
> > the Ranger admin service, but this
starting line 1473...
- Colm O hEigeartaigh
On Aug. 4, 2017, 9:21 a.m., pengjianhua wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61383/#review182197
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On Aug. 2, 2017, 8
errList.add(excp.getMessage() + ". \n");
}
}
We should just have one if statement here and replace the last two checks with
StringUtils.isNotEmpty(str) - and put it as the first part of the if statement.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61395/#review182198
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On Aug. 3, 2017, 2
[
https://issues.apache.org/jira/browse/RANGER-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colm O hEigeartaigh resolved RANGER-1733.
-
Resolution: Fixed
> Duplicate RangerDaoManager fields in the servi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61624/#review182934
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On Aug. 14, 2017, 9
---
Thanks,
Colm O hEigeartaigh
[
https://issues.apache.org/jira/browse/RANGER-1734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colm O hEigeartaigh updated RANGER-1734:
Attachment: 0001-RANGER-1734-Close-the-connection-in-the-HIVERangerAu.patch
Colm O hEigeartaigh created RANGER-1734:
---
Summary: Close the connection in the HIVERangerAuthorizerTest
Key: RANGER-1734
URL: https://issues.apache.org/jira/browse/RANGER-1734
Project: Ranger
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61202/#review182580
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On Aug. 10, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59523/#review182682
---
*bump*
- Colm O hEigeartaigh
On May 24, 2017, 11:08 a.m., Colm
of the other devs
before applying it.
- Colm O hEigeartaigh
On July 22, 2017, 10:31 a.m., Zsombor Gegesy wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
[
https://issues.apache.org/jira/browse/RANGER-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121441#comment-16121441
]
Colm O hEigeartaigh commented on RANGER-1729:
-
I wonder how much the slowdown could have been
-
>
> (Updated Aug. 10, 2017, 2:41 a.m.)
>
>
> Review request for ranger, Don Bosco Durai, Colm O hEigeartaigh, and Qiang
> Zhang.
>
>
> Bugs: RANGER-1669
> https://issues.apache.org/jira/browse/RANGER-1669
>
>
> Repository: ranger
>
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60837/#review180530
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On July 13, 2017, 9
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60696/#review180189
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On July 11, 2017, 2
[
https://issues.apache.org/jira/browse/RANGER-1671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16082119#comment-16082119
]
Colm O hEigeartaigh commented on RANGER-1671:
-
Sorry, I still don't understand the problem
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60759/#review180190
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On July 11, 2017, 7
[
https://issues.apache.org/jira/browse/RANGER-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081866#comment-16081866
]
Colm O hEigeartaigh commented on RANGER-1684:
-
I've tested Ranger with the Solr plugin using
[
https://issues.apache.org/jira/browse/RANGER-1671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16080167#comment-16080167
]
Colm O hEigeartaigh commented on RANGER-1671:
-
Hi [~zhangqiang2],
Could you expand a bit
cument);
Better to write this as:
final Collection docs = Collections.singletonList(document);
- Colm O hEigeartaigh
On July 7, 2017, 1:46 a.m., pengjianhua wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60801/#review180413
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On July 13, 2017, 3
Colm O hEigeartaigh created RANGER-1683:
---
Summary: Fix the failing Kerberos tests on Jenkins
Key: RANGER-1683
URL: https://issues.apache.org/jira/browse/RANGER-1683
Project: Ranger
; has a test client which reads from the file as a mock policy store. Is this
> the way to go?
> Also is there any generic RangerAdminClient for tests?
>
> Thanks.
>
--
Colm O hEigeartaigh
Talend Community Coder
http://coders.talend.com
the noggit
dependency back in, instead modify src/main/assembly/kms.xml + replace:
org.noggit:noggit:jar:${noggit.version}
with
org.noggit:noggit
The ews/lib is also missing this jar which it should have:
com.google.protobuf:protobuf-java
- Colm O hEigeartaigh
On July 20, 2017, 12:56 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60997/#review181333
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On July 25, 2017, 9
it should be
somewhere in the target directory:
src/test/resources/kms/kms-audit-localhost-autotest.log
- Colm O hEigeartaigh
On July 25, 2017, 11:41 a.m., pengjianhua wrote:
>
> ---
> This is an automatically generated e-mail.
not depend on
specific Maven versions.
You could add in a section on notifications:
notifications:
email:
- dev@ranger.apache.org
- Colm O hEigeartaigh
On July 21, 2017, 2:50 p.m., Zsombor Gegesy wrote:
>
> ---
> This is an auto
> On July 24, 2017, 4:40 p.m., Colm O hEigeartaigh wrote:
> > Why is the noggit dependency introduced in agents-audit? Also the protobuf
> > version in the root pom that isn't used? You need to make the changes to
> > src/main/assembly/kms.xml as I explained above.
Actu
[
https://issues.apache.org/jira/browse/RANGER-1706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colm O hEigeartaigh resolved RANGER-1706.
-
Resolution: Fixed
> Running CI on Tra
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61173/#review181554
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On July 27, 2017, 7
[
https://issues.apache.org/jira/browse/RANGER-1706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colm O hEigeartaigh updated RANGER-1706:
Fix Version/s: 1.0.0
> Running CI on Tra
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61035/#review181552
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On July 25, 2017, 9
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61175/#review181551
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On July 27, 2017, 9
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61035/#review181450
---
Was there a specific reason for the surefire upgrade?
- Colm O
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61106/#review181449
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On July 26, 2017, 3
ically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61021/
> ---
>
> (Updated July 21, 2017, 7:40 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O
> hEigeartaigh, Gautam Borad, Madhan Neethiraj
://reviews.apache.org/r/60803/diff/1/
Testing
---
Thanks,
Colm O hEigeartaigh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60772/#review180305
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On July 11, 2017, 1
> On April 18, 2017, 10:59 a.m., Colm O hEigeartaigh wrote:
> > Shouldn't we include log4j.properties in src/main/resources as well? Then
> > we can just delete the build section from the pom, as the log4j.properties
> > get automatically copied to clas
Colm O hEigeartaigh created RANGER-1673:
---
Summary: The default plugin configuration file is not readable
Key: RANGER-1673
URL: https://issues.apache.org/jira/browse/RANGER-1673
Project: Ranger
/enable-agent.sh 562a404d
Diff: https://reviews.apache.org/r/60635/diff/1/
Testing
---
Tested that the file has the correct permissions after installing the Hive
plugin.
Thanks,
Colm O hEigeartaigh
[
https://issues.apache.org/jira/browse/RANGER-1673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colm O hEigeartaigh updated RANGER-1673:
Attachment: 0001-RANGER-1673-The-default-plugin-configuration-file-is.patch
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60260/#review179235
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On June 27, 2017
source?
- Colm O hEigeartaigh
On April 10, 2017, 5:28 a.m., Qiang Zhang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58730/#review173035
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On April 26, 2017
[
https://issues.apache.org/jira/browse/RANGER-1537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15984888#comment-15984888
]
Colm O hEigeartaigh commented on RANGER-1537:
-
This bug has already been fixed:
https
to 0.7.x as well IMO.
- Colm O hEigeartaigh
On April 26, 2017, 11:02 a.m., bhavik patel wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> ht
[
https://issues.apache.org/jira/browse/RANGER-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985107#comment-15985107
]
Colm O hEigeartaigh commented on RANGER-1501:
-
Great thanks for the feedback guys.
> Au
[
https://issues.apache.org/jira/browse/RANGER-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15986193#comment-15986193
]
Colm O hEigeartaigh commented on RANGER-1535:
-
Please close + mark as submitted the review
[
https://issues.apache.org/jira/browse/RANGER-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15986209#comment-15986209
]
Colm O hEigeartaigh commented on RANGER-1531:
-
Please mark the review requests as "res
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58781/#review173175
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On April 27, 2017
()) {
+ LOG.debug("maskTypeDef-to-add:[" +
maskTypeDef + "]");
+ }
+ }
+
Much better to instead put the if statement outside the for loop.
- Colm O hEigeartaigh
On April 21, 2017, 9:23 p.m.,
Colm O hEigeartaigh created RANGER-1549:
---
Summary: Add COMPONENT_INSTALL_DIR_NAME to the Storm
install.properties
Key: RANGER-1549
URL: https://issues.apache.org/jira/browse/RANGER-1549
Project
,
Colm O hEigeartaigh
[
https://issues.apache.org/jira/browse/RANGER-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colm O hEigeartaigh updated RANGER-1549:
Attachment: 0001-RANGER-1549-Add-COMPONENT_INSTALL_DIR_NAME-to-the-St.patch
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58655/#review172770
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On April 24, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58529/#review172771
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On April 24, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58647/#review172769
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On April 22, 2017
[
https://issues.apache.org/jira/browse/RANGER-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colm O hEigeartaigh updated RANGER-1536:
Fix Version/s: 1.0.0
> Error information in the printed l
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58630/#review172766
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On April 21, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58633/#review172765
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On April 21, 2017
201 - 300 of 888 matches
Mail list logo
