er or group doesn't
exist, wouldn't it be better to print an error message and abort?
- Colm O hEigeartaigh
On May 23, 2017, 2:13 a.m., pengjianhua wrote:
>
> ---
> This is an automatically generated e-mail.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59376/#review175775
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On May 18, 2017, 8
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59486/#review175784
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On May 23, 2017, 8
enabled.
Thanks,
Colm O hEigeartaigh
xes. I would greatly appreciate if the patches focus on
> fixing/enhancing Ranger functionality; this would be benefit the community
> immensely.
>
>
>
> Thanks,
>
> Madhan
>
>
>
--
Colm O hEigeartaigh
Talend Community Coder
http://coders.talend.com
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59255/#review175914
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On May 23, 2017, 4
.
Thanks,
Colm O hEigeartaigh
f the getInstallProperty
function in different scripts. Would it be possible to put the common functions
into a separate script that gets picked up by the other scripts?
- Colm O hEigeartaigh
On May 25, 2017, 8:15 a.m., Qiang Zhang
rvice/TestRangerTagDefServiceBase.java
15fd5036
Diff: https://reviews.apache.org/r/59575/diff/1/
Testing
---
Thanks,
Colm O hEigeartaigh
g/apache/ranger/services/solr/client/ServiceSolrConnectionMgr.java
> d8470a0b
>
>
> Diff: https://reviews.apache.org/r/59489/diff/1/
>
>
> Testing
> ---
>
> Tested connection + that we can pull down resources from a SOLR Cloud
> instance with basic auth enabled.
>
>
> Thanks,
>
> Colm O hEigeartaigh
>
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59571/#review176088
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On May 25, 2017, 8
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59572/#review176090
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On May 25, 2017, 9
rvice/TestRangerTagDefServiceBase.java
15fd5036
Diff: https://reviews.apache.org/r/59577/diff/1/
Testing
---
Thanks,
Colm O hEigeartaigh
/site.xml 5a210f3e
docs/src/site/xdoc/download.xml 39074aa6
Diff: https://reviews.apache.org/r/59604/diff/1/
Testing
---
Thanks,
Colm O hEigeartaigh
> On May 23, 2017, 9:08 a.m., Colm O hEigeartaigh wrote:
> > I'm not sure about the changed logic to be honest. If the user or group
> > doesn't exist, wouldn't it be better to print an error message and abort?
>
> pengjianhua wrote:
> Initiall
/jira/browse/RANGER-1621
Repository: ranger
Description
---
The knox pom has a hard-coded version of Knox instead of using the version
defined in the parent pom.
Diffs
-
knox-agent/pom.xml 63b06f66
Diff: https://reviews.apache.org/r/59630/diff/1/
Testing
---
Thanks,
Colm O
-common/scripts/enable-agent.sh 76ba8f0d
Diff: https://reviews.apache.org/r/59631/diff/1/
Testing
---
Tested the jars installed correctly into Knox after the fix.
Thanks,
Colm O hEigeartaigh
://reviews.apache.org/r/59636/diff/1/
Testing
---
Thanks,
Colm O hEigeartaigh
f2d710bd
Diff: https://reviews.apache.org/r/59630/diff/2/
Changes: https://reviews.apache.org/r/59630/diff/1-2/
Testing
---
Thanks,
Colm O hEigeartaigh
gt; PGP Signature:
> https://dist.apache.org/repos/dist/dev/ranger/0.7.1-
> rc1/apache-ranger-0.7.1.tar.gz.asc
> MD5/SHA Hash:
> https://dist.apache.org/repos/dist/dev/ranger/0.7.1-
> rc1/apache-ranger-0.7.1.tar.gz.mds
>
> Keys to verify the signature of the release artifact
NC_PID_DIR_PATH}/{TAGSYNC_PID_NAME}
- Colm O hEigeartaigh
On June 1, 2017, 8:15 p.m., Yujie Li wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https:/
tatic class instead.
Diffs
-
storm-agent/src/main/java/org/apache/ranger/services/storm/client/StormClient.java
b72a9a23
Diff: https://reviews.apache.org/r/59753/diff/1/
Testing
---
Tested we can connect successfully to Storm.
Thanks,
Colm O hEigeartaigh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59725/#review177005
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On June 2, 2017, 6
:
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=55151244).
Also there are two extra whitespace changes in the patch that could be removed.
- Colm O hEigeartaigh
On June 5, 2017, 10:04 a.m., Rob Vesse wrote:
>
> ---
sting
---
Tested we can connect successfully to Storm.
Thanks,
Colm O hEigeartaigh
> +apache-ranger-0.7.1.tar.gz: SHA512 = D8D0417D 70C6A4A9 E59CC0C9 7A59FF68
> + 35A5A367 24B32A7F CC80B95E D3729F06
> + 31681DED 6CE839BD 7797D20D D7E0BA80
> + 4C20266D 08A55BF2 2461958F 3B966FD9
>
>
>
--
Colm O hEigeartaigh
Talend Community Coder
http://coders.talend.com
I've prepared a staging repo for 0.7.1:
https://repository.apache.org/content/repositories/orgapacheranger-1011/
I'll promote it in a few days if I don't hear any objections.
Colm.
--
Colm O hEigeartaigh
Talend Community Coder
http://coders.talend.com
pported as well here?
- Colm O hEigeartaigh
On June 8, 2017, 7:05 a.m., Qiang Zhang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https:/
no issues.
- Colm
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59636/#review177275
---
On May 30, 2017, 10:31 a.m., Colm O
Publishing+Apache+Ranger+
> artifacts+to+Maven+Central
>
> Thanks,
> Vel
>
>
> From: Colm O hEigeartaigh
> Reply-To: "dev@ranger.apache.org" ,
> "cohei...@apache.org"
> Date: Thursday, June 8, 2017 at 5:50 AM
> To: "dev@ranger.apache.org
> On June 8, 2017, 10:05 a.m., Colm O hEigeartaigh wrote:
> > "Currently it only support solr" - isn't hdfs supported as well here?
>
> Qiang Zhang wrote:
> The Ranger Admin uses the configuration item to determine log should be
> queried from db or sol
Testing
---
Thanks,
Colm O hEigeartaigh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59801/#review177458
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On June 9, 2017, 9
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59908/#review177459
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On June 9, 2017, 9
quot;, click https://u2389337.ct.sendgrid.
> net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-
> 2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq47mxskBQgxRJXpeEpoMwX
> 0McAuDRyJUckvXbF17DhDLsPMLsQ8vjMxWA8prVpW8XFQLFUT1SyR1J0pL1y
> CZ20nVmr2nMWjTeARQKttMH-2FASk-3D_LnAJ35ABvEvOrnniInKJw2EvFzzVWfd-
> 2BYI3WJ8Im3vGLykd3jixR4gwMhd13bE1GMScgHH1AdhZ1pAXRa1-
> 2FoQQ0CEZkVLdYRzAr4kvhDYuagJ5ZrDOmJ4D-2FWCQDR9Z63-2FNP5eASnG929-2BcMpCQB-
> 2B0wXgmbRYxrNtjVpKFkHl7pYqa2vI8pmrceflJUo2Pr6M11V7M6exwKRKOa
> k3pDSTgT68e6SOTlK3PZfkFxqJE0k-3D
>
>
>
>
>
--
Colm O hEigeartaigh
Talend Community Coder
http://coders.talend.com
://reviews.apache.org/r/59996/diff/1/
Testing
---
Thanks,
Colm O hEigeartaigh
:
if(LOG.isDebugEnabled())
- Colm O hEigeartaigh
On June 13, 2017, 8:23 a.m., Ankita Sinha wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60032/#review177717
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On June 13, 2017, 4
er to make the
Pattern static + call Pattern.compile once, as the regex itself is static and
doesn't change.
- Colm O hEigeartaigh
On June 13, 2017, 10:07 a.m., Ankita Sinha wrote:
>
> ---
> This is an automatically generat
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60034/#review177726
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On June 13, 2017, 9
ac04e
Diff: https://reviews.apache.org/r/60046/diff/1/
Testing
---
Tested that the connection works fine in the Admin UI when creating a service
and also when editing an already created service.
Thanks,
Colm O hEigeartaigh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60043/#review177731
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On June 13, 2017
> On June 13, 2017, 12:20 p.m., Colm O hEigeartaigh wrote:
> > Ship It!
Actually, is it feasible to add some unit tests for this?
- Colm
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.or
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60061/#review177873
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On June 14, 2017, 6
t; comment in
validatePassword. Also the "boolean checkPassword" definition could be brought
inside the if statement, as it's only used in there.
- Colm O hEigeartaigh
On June 16, 2017, 4:31 a.m., Gautam Borad wrote:
>
> -
.should be "Unable to
find"
- Colm O hEigeartaigh
On June 15, 2017, 10:23 p.m., Zsombor Gegesy wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> ht
uld be "xForwardedProto"
b) The "while" loop looks a bit odd...it will always discard all but the last
value?
c) loginURL = loginURL + -> Should just be loginURL += ...
- Colm O hEigeartaigh
On June 19, 2017, 8:5
uot; where it is not
surrounded either side by a space, e.g. mKeyStoreFile+"
- Colm O hEigeartaigh
On June 16, 2017, 11:48 a.m., Zsombor Gegesy wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60193/#review178209
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On June 19, 2017, 9
/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerAuthorizerGSSTest.java
PRE-CREATION
plugin-kafka/src/test/resources/kafka_kerberos.jaas PRE-CREATION
pom.xml d619f624
Diff: https://reviews.apache.org/r/60194/diff/1/
Testing
---
Thanks,
Colm O hEigeartaigh
de to construct the
"xForwardedURL" could all be moved into a separate method.
- Colm O hEigeartaigh
On June 19, 2017, 9:44 a.m., Ankita Sinha wrote:
>
> ---
> This is an automatically generated e-mail.
"xForwardedURL" as a
class variable, instead it would be better to return it from
"constructForwardableURL".
- Colm O hEigeartaigh
On June 19, 2017, 10:26 a.m., Ankita Sinha wrote:
>
> ---
> This is an automatical
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60192/#review178225
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On June 19, 2017
: https://reviews.apache.org/r/60194/diff/2/
Changes: https://reviews.apache.org/r/60194/diff/1-2/
Testing
---
Thanks,
Colm O hEigeartaigh
to Ranger and I would greatly appreciate if
> someone from the dev team act as a mentor and guide me through the process.
>
> Thank you.
>
> Regards,
> Anirudh
>
--
Colm O hEigeartaigh
Talend Community Coder
http://coders.talend.com
: https://reviews.apache.org/r/60194/diff/2-3/
Testing
---
Thanks,
Colm O hEigeartaigh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60134/#review178362
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On June 19, 2017
. "cat>", "if [
-f" etc.
- Colm O hEigeartaigh
On June 20, 2017, 6:53 a.m., Qiang Zhang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60224/#review178381
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On June 20, 2017, 6
ies recently without
having to edit them in this way.
Colm.
--
Colm O hEigeartaigh
Talend Community Coder
http://coders.talend.com
all. Do we know
what $LOGFILES is meant to do, and why we have both $LOGFILE and $LOGFILES?
- Colm O hEigeartaigh
On June 21, 2017, 3:10 a.m., pengjianhua wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60262/#review178476
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On June 21, 2017, 4
> On June 21, 2017, 9:38 a.m., Colm O hEigeartaigh wrote:
> > With the patch, the $LOGFILES property is not actually used at all. Do we
> > know what $LOGFILES is meant to do, and why we have both $LOGFILE and
> > $LOGFILES?
>
> pengjianhua wrote:
> I also no
---
>
> (Updated June 22, 2017, 7:16 a.m.)
>
>
> Review request for ranger, Don Bosco Durai, Colm O hEigeartaigh, Ramesh Mani,
> Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
>
>
> Bugs: RANGER-1662
> https://issues.apache
tion/kafka/authorizer/KafkaRangerAuthorizerGSSTest.java
2b65cbf8
plugin-kafka/src/test/resources/kafka_kerberos.jaas b764932d
Diff: https://reviews.apache.org/r/60361/diff/1/
Testing
---
Thanks,
Colm O hEigeartaigh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60359/#review178648
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On June 22, 2017, 9
>
> Other service types are not having by default selected permission because
> there are multiple permissions to be selected from.
>
> Regarding validation to select user / group: it applies for all services
> if any of the permission is selected in policy create / edit s
auto-select of permission if service has single permission
>>
>>for policy.
>>
>> @Abhay and @Nitin - any other thoughts on this scenario?
>>
>> On Thu, Jun 22, 2017 at 3:30 PM, Colm O hEigeartaigh > >
>> wrote:
>>
>> > Thanks Mehul!
ache.org/r/60361/diff/1-2/
Testing
---
Thanks,
Colm O hEigeartaigh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60452/#review178959
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On June 27, 2017, 5
iff/1/
Testing
---
Tested against Solr which requires basic authentication.
Thanks,
Colm O hEigeartaigh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60260/#review179235
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On June 27, 2017
source?
- Colm O hEigeartaigh
On April 10, 2017, 5:28 a.m., Qiang Zhang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58285/#review179335
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On June 30, 2017, 3
> On April 18, 2017, 10:59 a.m., Colm O hEigeartaigh wrote:
> > Shouldn't we include log4j.properties in src/main/resources as well? Then
> > we can just delete the build section from the pom, as the log4j.properties
> > get automatically copied to
/enable-agent.sh 562a404d
Diff: https://reviews.apache.org/r/60635/diff/1/
Testing
---
Tested that the file has the correct permissions after installing the Hive
plugin.
Thanks,
Colm O hEigeartaigh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57443/#review179618
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On July 5, 2017, 3
cument);
Better to write this as:
final Collection docs = Collections.singletonList(document);
- Colm O hEigeartaigh
On July 7, 2017, 1:46 a.m., pengjianhua wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
/r/60746/diff/1/
Testing
---
Thanks,
Colm O hEigeartaigh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60696/#review180189
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On July 11, 2017, 2
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60759/#review180190
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On July 11, 2017, 7
://reviews.apache.org/r/60803/diff/1/
Testing
---
Thanks,
Colm O hEigeartaigh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60772/#review180305
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On July 11, 2017, 1
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60801/#review180413
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On July 13, 2017, 3
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60837/#review180530
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On July 13, 2017, 9
Yan
>
> Motivations and functional specs can be found at https://cwiki.apache.org/
confluence/display/RANGER/Ranger+Plugin+for+Hive+MetaStore
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
--
Colm O hEigeartaigh
Talend Community Coder
http://coders.talend.com
from the file as a mock policy store. Is this
> the way to go?
> Also is there any generic RangerAdminClient for tests?
>
> Thanks.
>
--
Colm O hEigeartaigh
Talend Community Coder
http://coders.talend.com
noggit
dependency back in, instead modify src/main/assembly/kms.xml + replace:
org.noggit:noggit:jar:${noggit.version}
with
org.noggit:noggit
The ews/lib is also missing this jar which it should have:
com.google.protobuf:protobuf-java
- Colm O hEigeartaigh
On July 20, 2017, 12:56 p.m
r not depend on
specific Maven versions.
You could add in a section on notifications:
notifications:
email:
- dev@ranger.apache.org
- Colm O hEigeartaigh
On July 21, 2017, 2:50 p.m., Zsombor Gegesy wrote:
>
> ---
> This is an
protobuf
version in the root pom that isn't used? You need to make the changes to
src/main/assembly/kms.xml as I explained above.
- Colm O hEigeartaigh
On July 24, 2017, 1:23 p.m., pengjianhua wrote:
>
> ---
> This is an
> On July 24, 2017, 4:40 p.m., Colm O hEigeartaigh wrote:
> > Why is the noggit dependency introduced in agents-audit? Also the protobuf
> > version in the root pom that isn't used? You need to make the changes to
> > src/main/assembly/kms.xml as I explained above.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60997/#review181333
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On July 25, 2017, 9
should be
somewhere in the target directory:
src/test/resources/kms/kms-audit-localhost-autotest.log
- Colm O hEigeartaigh
On July 25, 2017, 11:41 a.m., pengjianhua wrote:
>
> ---
> This is an automatically generated e-mail.
tomatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61021/
> ---
>
> (Updated July 21, 2017, 7:40 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O
> hEigeartaigh, Gautam Borad, Madhan Neet
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61106/#review181449
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On July 26, 2017, 3
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61035/#review181450
---
Was there a specific reason for the surefire upgrade?
- Colm O
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61035/#review181552
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On July 25, 2017, 9
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61175/#review181551
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On July 27, 2017, 9
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61173/#review181554
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On July 27, 2017, 7
null) {" is not necessary.
- Colm O hEigeartaigh
On July 28, 2017, 3:32 a.m., pengjianhua wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> ht
301 - 400 of 1156 matches
Mail list logo
