Hi Madhan, Trivial commits provide a path to get new contributors on board to the project - something that the project needs IMO. Yes it may make backporting fixes a little more difficult, but it's hardly an intractable problem to figure out some whitespace changes between branches - it's not as if Ranger is a particularly large project.
Having said that I agree that some of the very trivial patches could maybe be consolidated a bit more. I will encourage future review requests that have a very trivial spelling fix to hold on to the fix for a while, so that we can fix multiple spelling fixes etc. at the same time. Colm. On Wed, May 24, 2017 at 7:27 AM, Madhan Neethiraj <mad...@apache.org> wrote: > All, > > > > I notice a number of recent patches address trivial issues like white > space, spelling mistakes (one patch just changed a single letter in a > label). And few other patches update a large number of files for > trivial/non-functional changes – like whitespaces. I strongly suggest we > refrain from authoring/encouraging such patches – for many reasons. One of > the main reasons is the overhead such updates add in backporting > real/critical fixes (that would come later) to other branches, as these > changes might force dealing with merge conflicts. > > > > Since the changes introduced in such patches are not essential, I would > suggest to take these up when these source files are updated for other > functional fixes. I would greatly appreciate if the patches focus on > fixing/enhancing Ranger functionality; this would be benefit the community > immensely. > > > > Thanks, > > Madhan > > > -- Colm O hEigeartaigh Talend Community Coder http://coders.talend.com
