[GitHub] [rocketmq] duhenglucky commented on issue #3275: 192.168.1.1:9876;192.161.2:9876 is wrong

2021-08-18 Thread GitBox
duhenglucky commented on issue #3275: URL: https://github.com/apache/rocketmq/issues/3275#issuecomment-901651454 > > > https://github.com/apache/rocketmq/blob/master/docs/cn/operation.md > > > 如上启动命令是在单个NameServer情况下使用的。对于多个NameServer的集群,Broker启动命令中-n后面的地址列表用分号隔开即可,例如 192.168.1.1:9876;1

[GitHub] [rocketmq] lgd8069465 commented on issue #3275: 192.168.1.1:9876;192.161.2:9876 is wrong

2021-08-18 Thread GitBox
lgd8069465 commented on issue #3275: URL: https://github.com/apache/rocketmq/issues/3275#issuecomment-901650180 > > https://github.com/apache/rocketmq/blob/master/docs/cn/operation.md > > 如上启动命令是在单个NameServer情况下使用的。对于多个NameServer的集群,Broker启动命令中-n后面的地址列表用分号隔开即可,例如 192.168.1.1:9876;192.16

Re:[VOTE]:Release Apache RocketMQ 4.9.1 RC1.

2021-08-18 Thread ShannonDing
+1, checked: [OK] Source code artifacts have correct names matching the current release. [OK] Hash and Tag in GitHub repo is matching the current artifacts. [OK] The code can be built success in the source package. [OK] Start nameserver and broker according to the quick-start [OK] Run clusterL

[GitHub] [rocketmq-externals] vongosling closed issue #775: Facing ussue when using flink version 1.1.2

2021-08-18 Thread GitBox
vongosling closed issue #775: URL: https://github.com/apache/rocketmq-externals/issues/775 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-uns

[GitHub] [rocketmq-externals] SteNicholas commented on issue #775: Facing ussue when using flink version 1.1.2

2021-08-18 Thread GitBox
SteNicholas commented on issue #775: URL: https://github.com/apache/rocketmq-externals/issues/775#issuecomment-901606776 > Hi guys, > I am using flink version 1.1.2, which is lower than master version 1.1.3. So I face NoclassFoundError. Is some milestone support flink 1.1.2 ? > >

[GitHub] [rocketmq-externals] vongosling commented on issue #780: [rocketmq-flink] Support the RocketMQ TableSink based on the new Sink interface

2021-08-18 Thread GitBox
vongosling commented on issue #780: URL: https://github.com/apache/rocketmq-externals/issues/780#issuecomment-901602487 We could link the issue with pr in case of forgetting to close the related issues. -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [rocketmq-externals] vongosling closed issue #780: [rocketmq-flink] Support the RocketMQ TableSink based on the new Sink interface

2021-08-18 Thread GitBox
vongosling closed issue #780: URL: https://github.com/apache/rocketmq-externals/issues/780 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-uns

[GitHub] [rocketmq-dashboard] vongosling commented on pull request #6: [ISSUE #5]Add permission control when loginRequired is true.

2021-08-18 Thread GitBox
vongosling commented on pull request #6: URL: https://github.com/apache/rocketmq-dashboard/pull/6#issuecomment-901601418 @zhangjidi2016 there are many places waiting to be clarified. BTW, do we have a better way to support here. do not link permission to URL directly? -- This is an autom

[GitHub] [rocketmq-dashboard] vongosling closed issue #5: Added permission control for the login user role in rocketmq-dashboard.

2021-08-18 Thread GitBox
vongosling closed issue #5: URL: https://github.com/apache/rocketmq-dashboard/issues/5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubsc

[GitHub] [rocketmq-dashboard] vongosling merged pull request #7: [ISSUE #5]Different pages are displayed based on the user role.

2021-08-18 Thread GitBox
vongosling merged pull request #7: URL: https://github.com/apache/rocketmq-dashboard/pull/7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-un

[GitHub] [rocketmq-dashboard] vongosling commented on issue #9: manifest for docker.io/apacherocketmq/rocketmq-console:latest not found

2021-08-18 Thread GitBox
vongosling commented on issue #9: URL: https://github.com/apache/rocketmq-dashboard/issues/9#issuecomment-901599935 @francisoliverlee -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [rocketmq-dashboard] vongosling closed issue #9: manifest for docker.io/apacherocketmq/rocketmq-console:latest not found

2021-08-18 Thread GitBox
vongosling closed issue #9: URL: https://github.com/apache/rocketmq-dashboard/issues/9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubsc

[GitHub] [rocketmq-externals] duhenglucky commented on issue #786: [Rocketmq-flink] Thread Pool do not close when job finish.

2021-08-18 Thread GitBox
duhenglucky commented on issue #786: URL: https://github.com/apache/rocketmq-externals/issues/786#issuecomment-901596119 merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [rocketmq-externals] duhenglucky closed issue #786: [Rocketmq-flink] Thread Pool do not close when job finish.

2021-08-18 Thread GitBox
duhenglucky closed issue #786: URL: https://github.com/apache/rocketmq-externals/issues/786 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-un

[GitHub] [rocketmq-externals] duhenglucky merged pull request #790: [#786] RocketMQSourceFunction supports the close of ExecutorService and ScheduledExecutorService

2021-08-18 Thread GitBox
duhenglucky merged pull request #790: URL: https://github.com/apache/rocketmq-externals/pull/790 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: d

[GitHub] [rocketmq-dashboard] fwhezfwhez commented on issue #9: manifest for docker.io/apacherocketmq/rocketmq-console:latest not found

2021-08-18 Thread GitBox
fwhezfwhez commented on issue #9: URL: https://github.com/apache/rocketmq-dashboard/issues/9#issuecomment-901587942 3q done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [rocketmq-externals] SteNicholas opened a new pull request #790: [#786] RocketMQSourceFunction supports the close of ExecutorService and ScheduledExecutorService

2021-08-18 Thread GitBox
SteNicholas opened a new pull request #790: URL: https://github.com/apache/rocketmq-externals/pull/790 ## What is the purpose of the change `RocketMQSourceFunction` should support the close of `ExecutorService` and `ScheduledExecutorService` which should be closed when the `SourceOpe

[GitHub] [rocketmq-externals] duhenglucky closed issue #788: [Rocketmq-flink] Rocketmq client does not guaranteed to be closed properly.

2021-08-18 Thread GitBox
duhenglucky closed issue #788: URL: https://github.com/apache/rocketmq-externals/issues/788 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-un

[GitHub] [rocketmq-externals] SteNicholas commented on issue #788: [Rocketmq-flink] Rocketmq client does not guaranteed to be closed properly.

2021-08-18 Thread GitBox
SteNicholas commented on issue #788: URL: https://github.com/apache/rocketmq-externals/issues/788#issuecomment-901582108 @ni-ze , `RocketMQSourceFunction` starts the `DefaultMQPullConsumer` in the `open()` method and closes the `DefaultMQPullConsumer` in the `close` method. This behavior

[GitHub] [rocketmq] codecov-commenter edited a comment on pull request #3256: [ISSUE #3257] Ignore irrelevant commit log files on startup

2021-08-18 Thread GitBox
codecov-commenter edited a comment on pull request #3256: URL: https://github.com/apache/rocketmq/pull/3256#issuecomment-901581106 # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/3256?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_

[GitHub] [rocketmq] coveralls edited a comment on pull request #3256: [ISSUE #3257] Ignore irrelevant commit log files on startup

2021-08-18 Thread GitBox
coveralls edited a comment on pull request #3256: URL: https://github.com/apache/rocketmq/pull/3256#issuecomment-897788933 [![Coverage Status](https://coveralls.io/builds/42256829/badge)](https://coveralls.io/builds/42256829) Coverage increased (+0.2%) to 54.145% when pulling **

[GitHub] [rocketmq] codecov-commenter commented on pull request #3256: [ISSUE #3257] Ignore irrelevant commit log files on startup

2021-08-18 Thread GitBox
codecov-commenter commented on pull request #3256: URL: https://github.com/apache/rocketmq/pull/3256#issuecomment-901581106 # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/3256?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Th

Fixed: apache/rocketmq-externals#171 (master - ea2bfd4)

2021-08-18 Thread Travis CI
Build Update for apache/rocketmq-externals - Build: #171 Status: Fixed Duration: 2 mins and 17 secs Commit: ea2bfd4 (master) Author: SteNicholas Message: [#780] Support the RocketMQ TableSink based on the legacy Sink implementation (#781) View the changeset:

[GitHub] [rocketmq] duhenglucky commented on issue #3275: 192.168.1.1:9876;192.161.2:9876 is wrong

2021-08-18 Thread GitBox
duhenglucky commented on issue #3275: URL: https://github.com/apache/rocketmq/issues/3275#issuecomment-901574868 > https://github.com/apache/rocketmq/blob/master/docs/cn/operation.md > 如上启动命令是在单个NameServer情况下使用的。对于多个NameServer的集群,Broker启动命令中-n后面的地址列表用分号隔开即可,例如 192.168.1.1:9876;192.161.2

[GitHub] [rocketmq] duhenglucky closed issue #3275: 192.168.1.1:9876;192.161.2:9876 is wrong

2021-08-18 Thread GitBox
duhenglucky closed issue #3275: URL: https://github.com/apache/rocketmq/issues/3275 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr..

[GitHub] [rocketmq-externals] duhenglucky closed issue #785: [rocketmq-flink]Why rocketmq-flink package has flink jar?That will lead a package conflict when run on Flink

2021-08-18 Thread GitBox
duhenglucky closed issue #785: URL: https://github.com/apache/rocketmq-externals/issues/785 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-un

[GitHub] [rocketmq-externals] SteNicholas commented on issue #785: [rocketmq-flink]Why rocketmq-flink package has flink jar?That will lead a package conflict when run on Flink

2021-08-18 Thread GitBox
SteNicholas commented on issue #785: URL: https://github.com/apache/rocketmq-externals/issues/785#issuecomment-901564869 @ni-ze , thanks for the problem reportor to the Flink maven dependencies. I have set the scope of Flink dependencies to `provided`. -- This is an automated message fr

[GitHub] [rocketmq] AaronW-BE opened a new issue #3276: JAVA path blank space caluse application cannot start

2021-08-18 Thread GitBox
AaronW-BE opened a new issue #3276: URL: https://github.com/apache/rocketmq/issues/3276 The cmd batch file ignored java default install directory like `program files`, it's will cause cannot start mq -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [rocketmq] lgd8069465 opened a new issue #3275: 192.168.1.1:9876;192.161.2:9876 is wrong

2021-08-18 Thread GitBox
lgd8069465 opened a new issue #3275: URL: https://github.com/apache/rocketmq/issues/3275 https://github.com/apache/rocketmq/blob/master/docs/cn/operation.md 如上启动命令是在单个NameServer情况下使用的。对于多个NameServer的集群,Broker启动命令中-n后面的地址列表用分号隔开即可,例如 192.168.1.1:9876;192.161.2:9876。 -- This is an autom

[GitHub] [rocketmq-externals] duhenglucky closed issue #787: [Rocketmq-flink] MessageQueues never update duration Flink job running, How to support message queues rebalance?

2021-08-18 Thread GitBox
duhenglucky closed issue #787: URL: https://github.com/apache/rocketmq-externals/issues/787 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-un

[GitHub] [rocketmq-externals] duhenglucky commented on issue #787: [Rocketmq-flink] MessageQueues never update duration Flink job running, How to support message queues rebalance?

2021-08-18 Thread GitBox
duhenglucky commented on issue #787: URL: https://github.com/apache/rocketmq-externals/issues/787#issuecomment-901524283 merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [rocketmq-externals] duhenglucky merged pull request #781: [#780] Support the RocketMQ TableSink based on the legacy Sink implementation

2021-08-18 Thread GitBox
duhenglucky merged pull request #781: URL: https://github.com/apache/rocketmq-externals/pull/781 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: d

[GitHub] [rocketmq] schnell18 commented on a change in pull request #3256: [ISSUE #3257] Ignore irrelevant commit log files on startup

2021-08-18 Thread GitBox
schnell18 commented on a change in pull request #3256: URL: https://github.com/apache/rocketmq/pull/3256#discussion_r691685939 ## File path: store/src/main/java/org/apache/rocketmq/store/MappedFileQueue.java ## @@ -34,6 +37,7 @@ private static final InternalLogger LOG_ERRO

[GitHub] [rocketmq] caigy commented on issue #3264: Use Executors to create a thread pool, there is a risk of resource exhaustion.

2021-08-18 Thread GitBox
caigy commented on issue #3264: URL: https://github.com/apache/rocketmq/issues/3264#issuecomment-901070559 @zhaohai1299002788 Could you submit a PR to fix it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [rocketmq-externals] ni-ze commented on pull request #779: [#715] Support the RocketMQ TableSource based on the legacy Source implementation

2021-08-18 Thread GitBox
ni-ze commented on pull request #779: URL: https://github.com/apache/rocketmq-externals/pull/779#issuecomment-900797723 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [rocketmq] coveralls edited a comment on pull request #3256: [ISSUE #3257] Ignore irrelevant commit log files on startup

2021-08-18 Thread GitBox
coveralls edited a comment on pull request #3256: URL: https://github.com/apache/rocketmq/pull/3256#issuecomment-897788933 [![Coverage Status](https://coveralls.io/builds/42223255/badge)](https://coveralls.io/builds/42223255) Coverage increased (+0.3%) to 54.219% when pulling **

[GitHub] [rocketmq-externals] ni-ze edited a comment on pull request #779: [#715] Support the RocketMQ TableSource based on the legacy Source implementation

2021-08-18 Thread GitBox
ni-ze edited a comment on pull request #779: URL: https://github.com/apache/rocketmq-externals/pull/779#issuecomment-900797723 @SteNicholas Thread Pool do not close when job finish https://github.com/apache/rocketmq-externals/issues/786#issue-973254402 -- This is an automated mes

[GitHub] [rocketmq] liuruinl commented on issue #3265: add GrayRelease AllocateMessageQueue strategy

2021-08-18 Thread GitBox
liuruinl commented on issue #3265: URL: https://github.com/apache/rocketmq/issues/3265#issuecomment-900946121 Thanks for Good job ! But in the other hand, it seems like this is not a MQ's responsibility to handle our deployment requirements, keep simple and clean. -- This is an automat

[GitHub] [rocketmq-externals] duhenglucky merged pull request #703: [#702] Adjust task check order

2021-08-18 Thread GitBox
duhenglucky merged pull request #703: URL: https://github.com/apache/rocketmq-externals/pull/703 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: d

[GitHub] [rocketmq-externals] vongosling commented on pull request #779: [#715] Support the RocketMQ TableSource based on the legacy Source implementation

2021-08-18 Thread GitBox
vongosling commented on pull request #779: URL: https://github.com/apache/rocketmq-externals/pull/779#issuecomment-900869821 @SteNicholas I see the status of our flink integration, there is still improvement to polish before we call for gruduation. #787 (comment), do we have a plan to sup

[GitHub] [rocketmq-dashboard] zhangjidi2016 commented on a change in pull request #7: [ISSUE #5]Different pages are displayed based on the user role.

2021-08-18 Thread GitBox
zhangjidi2016 commented on a change in pull request #7: URL: https://github.com/apache/rocketmq-dashboard/pull/7#discussion_r690842785 ## File path: src/main/java/org/apache/rocketmq/dashboard/controller/LoginController.java ## @@ -65,10 +66,10 @@ public Object check(HttpServl

[GitHub] [rocketmq] zxcvbnm3057 commented on issue #3272: 是否可以在其他线程中标记某消息已被消费?

2021-08-18 Thread GitBox
zxcvbnm3057 commented on issue #3272: URL: https://github.com/apache/rocketmq/issues/3272#issuecomment-900503281 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [rocketmq] drgnchan commented on a change in pull request #3256: [ISSUE #3257] Ignore irrelevant commit log files on startup

2021-08-18 Thread GitBox
drgnchan commented on a change in pull request #3256: URL: https://github.com/apache/rocketmq/pull/3256#discussion_r690928372 ## File path: store/src/main/java/org/apache/rocketmq/store/MappedFileQueue.java ## @@ -34,6 +37,7 @@ private static final InternalLogger LOG_ERROR

[GitHub] [rocketmq-dashboard] StyleTang commented on issue #9: manifest for docker.io/apacherocketmq/rocketmq-console:latest not found

2021-08-18 Thread GitBox
StyleTang commented on issue #9: URL: https://github.com/apache/rocketmq-dashboard/issues/9#issuecomment-901185710 Could you try ``` docker pull apacherocketmq/rocketmq-console:2.0.0 ``` We can find the tags [here](https://hub.docker.com/r/apacherocketmq/rocketmq-console/tags?p

[GitHub] [rocketmq-externals] SteNicholas commented on pull request #781: [#780] Support the RocketMQ TableSink based on the legacy Sink implementation

2021-08-18 Thread GitBox
SteNicholas commented on pull request #781: URL: https://github.com/apache/rocketmq-externals/pull/781#issuecomment-900876590 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [rocketmq] zhaohai1299002788 commented on issue #3264: Use Executors to create a thread pool, there is a risk of resource exhaustion.

2021-08-18 Thread GitBox
zhaohai1299002788 commented on issue #3264: URL: https://github.com/apache/rocketmq/issues/3264#issuecomment-900744534 newFixedThreadPool is a fixed number of threads, using an infinite queue. -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [rocketmq] francisoliverlee commented on issue #3267: we need a solution for the consumer to use filter

2021-08-18 Thread GitBox
francisoliverlee commented on issue #3267: URL: https://github.com/apache/rocketmq/issues/3267#issuecomment-900440037 same scenario we met. we made a Enhance-DefaultPushConsumer, doing your filter logic in it. -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [rocketmq-externals] ni-ze commented on pull request #781: [#780] Support the RocketMQ TableSink based on the legacy Sink implementation

2021-08-18 Thread GitBox
ni-ze commented on pull request #781: URL: https://github.com/apache/rocketmq-externals/pull/781#issuecomment-900895647 I can help make a review, but also need approve from write permission. -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [rocketmq-client-go] duhenglucky merged pull request #712: (fix): fix push_consumer#unsubscribe unsubscribe retry

2021-08-18 Thread GitBox
duhenglucky merged pull request #712: URL: https://github.com/apache/rocketmq-client-go/pull/712 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: d

[GitHub] [rocketmq-externals] SteNicholas edited a comment on pull request #779: [#715] Support the RocketMQ TableSource based on the legacy Source implementation

2021-08-18 Thread GitBox
SteNicholas edited a comment on pull request #779: URL: https://github.com/apache/rocketmq-externals/pull/779#issuecomment-900766859 > @duhenglucky @RongtongJin @SteNicholas This connector may donate to flink like this, [apache/flink#15304](https://github.com/apache/flink/pull/15304). I w

[GitHub] [rocketmq-externals] SteNicholas commented on pull request #779: [#715] Support the RocketMQ TableSource based on the legacy Source implementation

2021-08-18 Thread GitBox
SteNicholas commented on pull request #779: URL: https://github.com/apache/rocketmq-externals/pull/779#issuecomment-900766859 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [rocketmq-dashboard] StyleTang commented on a change in pull request #7: [ISSUE #5]Different pages are displayed based on the user role.

2021-08-18 Thread GitBox
StyleTang commented on a change in pull request #7: URL: https://github.com/apache/rocketmq-dashboard/pull/7#discussion_r690492743 ## File path: src/main/resources/static/src/ops.js ## @@ -15,10 +15,12 @@ * limitations under the License. */ -app.controller('opsController'

[GitHub] [rocketmq-dashboard] vongosling commented on a change in pull request #6: [ISSUE #5]Add permission control when loginRequired is true.

2021-08-18 Thread GitBox
vongosling commented on a change in pull request #6: URL: https://github.com/apache/rocketmq-dashboard/pull/6#discussion_r690844961 ## File path: doc/1_0_0/UserGuide_CN.md ## @@ -112,4 +112,35 @@ admin=admin,1 user1=user1 user2=user2 ``` -* 3. 启动控制台则开启了登录功能 \ No newline at e

[GitHub] [rocketmq] makabakaboom commented on issue #3265: add GrayRelease AllocateMessageQueue strategy

2021-08-18 Thread GitBox
makabakaboom commented on issue #3265: URL: https://github.com/apache/rocketmq/issues/3265#issuecomment-900778603 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [rocketmq-externals] duhenglucky merged pull request #779: [#715] Support the RocketMQ TableSource based on the legacy Source implementation

2021-08-18 Thread GitBox
duhenglucky merged pull request #779: URL: https://github.com/apache/rocketmq-externals/pull/779 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: d

[GitHub] [rocketmq-externals] duhenglucky commented on a change in pull request #779: [#715] Support the RocketMQ TableSource based on the legacy Source implementation

2021-08-18 Thread GitBox
duhenglucky commented on a change in pull request #779: URL: https://github.com/apache/rocketmq-externals/pull/779#discussion_r690837086 ## File path: rocketmq-flink/src/main/java/org/apache/rocketmq/flink/legacy/common/serialization/RowKeyValueDeserializationSchema.java ## @@

[GitHub] [rocketmq] francisoliverlee commented on issue #3265: add GrayRelease AllocateMessageQueue strategy

2021-08-18 Thread GitBox
francisoliverlee commented on issue #3265: URL: https://github.com/apache/rocketmq/issues/3265#issuecomment-900766282 suppose there are 10 producer instances and 10 consumer instances, if we need to do gray release, how about do-gray-deployment to producer instance 1 and consumer instance

[GitHub] [rocketmq] francisoliverlee commented on issue #3272: 是否可以在其他线程中标记某消息已被消费?

2021-08-18 Thread GitBox
francisoliverlee commented on issue #3272: URL: https://github.com/apache/rocketmq/issues/3272#issuecomment-900426274 ### request-reply message can be right for you . - demo sync producer : https://github.com/apache/rocketmq/blob/master/example/src/main/java/org/apache/rocketmq/exam

[GitHub] [rocketmq-externals] duhenglucky merged pull request #698: [ISSUE #695] Optimized the worker shutdown process.

2021-08-18 Thread GitBox
duhenglucky merged pull request #698: URL: https://github.com/apache/rocketmq-externals/pull/698 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: d

[GitHub] [rocketmq-externals] ni-ze commented on a change in pull request #779: [#715] Support the RocketMQ TableSource based on the legacy Source implementation

2021-08-18 Thread GitBox
ni-ze commented on a change in pull request #779: URL: https://github.com/apache/rocketmq-externals/pull/779#discussion_r690837199 ## File path: rocketmq-flink/pom.xml ## @@ -34,7 +34,7 @@ 1.8 1.8 4.7.1 -1.13.0 +1.13.1 Review comment:

[GitHub] [rocketmq-dashboard] zhangjidi2016 commented on a change in pull request #6: [ISSUE #5]Add permission control when loginRequired is true.

2021-08-18 Thread GitBox
zhangjidi2016 commented on a change in pull request #6: URL: https://github.com/apache/rocketmq-dashboard/pull/6#discussion_r690827669 ## File path: src/main/java/org/apache/rocketmq/dashboard/service/impl/PermissionServiceImpl.java ## @@ -0,0 +1,119 @@ +/* + * Licensed to the

[GitHub] [rocketmq-client-go] superhx commented on a change in pull request #712: (fix): fix push_consumer#unsubscribe unsubscribe retry

2021-08-18 Thread GitBox
superhx commented on a change in pull request #712: URL: https://github.com/apache/rocketmq-client-go/pull/712#discussion_r690866875 ## File path: consumer/push_consumer.go ## @@ -119,6 +119,9 @@ func NewPushConsumer(opts ...Option) (*pushConsumer, error) { p.interce

[GitHub] [rocketmq-externals] vongosling commented on a change in pull request #779: [#715] Support the RocketMQ TableSource based on the legacy Source implementation

2021-08-18 Thread GitBox
vongosling commented on a change in pull request #779: URL: https://github.com/apache/rocketmq-externals/pull/779#discussion_r690949600 ## File path: rocketmq-flink/pom.xml ## @@ -45,11 +45,13 @@ org.apache.flink flink-java ${flink.version

[GitHub] [rocketmq-client-go] ShannonDing merged pull request #714: [ISSUE #699] Fix the bug caused in HA cluster when master broker node is down

2021-08-18 Thread GitBox
ShannonDing merged pull request #714: URL: https://github.com/apache/rocketmq-client-go/pull/714 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: d

[GitHub] [rocketmq-externals] duhenglucky commented on pull request #779: [#715] Support the RocketMQ TableSource based on the legacy Source implementation

2021-08-18 Thread GitBox
duhenglucky commented on pull request #779: URL: https://github.com/apache/rocketmq-externals/pull/779#issuecomment-900745867 > @duhenglucky @RongtongJin @SteNicholas This connector may donate to flink like this, [apache/flink#15304](https://github.com/apache/flink/pull/15304). I would li

[GitHub] [rocketmq-externals] ni-ze commented on a change in pull request #781: [#780] Support the RocketMQ TableSink based on the legacy Sink implementation

2021-08-18 Thread GitBox
ni-ze commented on a change in pull request #781: URL: https://github.com/apache/rocketmq-externals/pull/781#discussion_r691140471 ## File path: rocketmq-flink/src/main/java/org/apache/rocketmq/flink/sink/table/RocketMQDynamicTableSink.java ## @@ -0,0 +1,257 @@ +/* + * License

[GitHub] [rocketmq] francisoliverlee commented on issue #3271: AclClientRPCHook failed to calculate secret when use defined extField present

2021-08-18 Thread GitBox
francisoliverlee commented on issue #3271: URL: https://github.com/apache/rocketmq/issues/3271#issuecomment-900435728 do you have a demo to re-produce it ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [rocketmq-dashboard] zhangguobin-xiyue commented on issue #1: Are you using RocketMQ Dashboard?

2021-08-18 Thread GitBox
zhangguobin-xiyue commented on issue #1: URL: https://github.com/apache/rocketmq-dashboard/issues/1#issuecomment-901024195 Organization: Mukun Technology Location: Anhui Hefei Contact: 61527...@qq.com Version: v2.0.0 Status: stage Expectations(optional): -- This is an auto

[GitHub] [rocketmq-externals] SteNicholas removed a comment on pull request #781: [#780] Support the RocketMQ TableSink based on the legacy Sink implementation

2021-08-18 Thread GitBox
SteNicholas removed a comment on pull request #781: URL: https://github.com/apache/rocketmq-externals/pull/781#issuecomment-900876590 @vongosling @duhenglucky , could you help to review the RocketMQ TableSink based on the legacy Sink implementation? -- This is an automated message from

[GitHub] [rocketmq-dashboard] StyleTang commented on issue #9: manifest for docker.io/apacherocketmq/rocketmq-console:latest not found

2021-08-18 Thread GitBox
StyleTang commented on issue #9: URL: https://github.com/apache/rocketmq-dashboard/issues/9#issuecomment-901185710 Could you try ``` docker pull apacherocketmq/rocketmq-console:2.0.0 ``` We can find the tags [here](https://hub.docker.com/r/apacherocketmq/rocketmq-console/tags?p

[GitHub] [rocketmq] caigy commented on issue #3264: Use Executors to create a thread pool, there is a risk of resource exhaustion.

2021-08-18 Thread GitBox
caigy commented on issue #3264: URL: https://github.com/apache/rocketmq/issues/3264#issuecomment-901070559 @zhaohai1299002788 Could you submit a PR to fix it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

??????[VOTE]:Release Apache RocketMQ 4.9.1 RC1.

2021-08-18 Thread panzhi
+1 I checked: [OK]  Run clusterList command to see if the version is correct [OK]  Build the source, start nameserver and broker according to the quick-start [OK]  All unit tests of the current version pass --  -- ??:

RE: [VOTE]:Release Apache RocketMQ 4.9.1 RC1.

2021-08-18 Thread panzhi33
+1,I checked. 原始信息 发件人: 胡 宗棠 日期: 2021/8/18 14:25 (GMT+08:00) 收件人: dev@rocketmq.apache.org 主题: [VOTE]:Release Apache RocketMQ 4.9.1 RC1. Hello RocketMQ Community,This is the vote for 4.9.1 of Apache RocketMQ.This release is to improve some features and issues for apache rocke

[GitHub] [rocketmq-externals] ni-ze commented on a change in pull request #781: [#780] Support the RocketMQ TableSink based on the legacy Sink implementation

2021-08-18 Thread GitBox
ni-ze commented on a change in pull request #781: URL: https://github.com/apache/rocketmq-externals/pull/781#discussion_r691140471 ## File path: rocketmq-flink/src/main/java/org/apache/rocketmq/flink/sink/table/RocketMQDynamicTableSink.java ## @@ -0,0 +1,257 @@ +/* + * License

Re: [VOTE]:Release Apache RocketMQ 4.9.1 RC1.

2021-08-18 Thread heng du
+1 I checked: [OK] Hash and Tag in GitHub repo are matching the current artifacts. [OK] The code can be built success in the source package. [OK] Run clusterList command to see if the version is correct [OK] Quickstart works well 倪泽 于2021年8月18日周三 下午4:43写道: > +1 > > My check list is as fello

[GitHub] [rocketmq-dashboard] zhangguobin-xiyue commented on issue #1: Are you using RocketMQ Dashboard?

2021-08-18 Thread GitBox
zhangguobin-xiyue commented on issue #1: URL: https://github.com/apache/rocketmq-dashboard/issues/1#issuecomment-901024195 Organization: Mukun Technology Location: Anhui Hefei Contact: 61527...@qq.com Version: v2.0.0 Status: stage Expectations(optional): -- This is an auto

[GitHub] [rocketmq-dashboard] fwhezfwhez opened a new issue #9: manifest for docker.io/apacherocketmq/rocketmq-console:latest not found

2021-08-18 Thread GitBox
fwhezfwhez opened a new issue #9: URL: https://github.com/apache/rocketmq-dashboard/issues/9 daemon.json { "registry-mirrors": ["https://registry.docker-cn.com";] } Which mirror provides acessible image -- This is an automated message from the Apache Git Service. To r

[GitHub] [rocketmq] makabakaboom commented on issue #3265: add GrayRelease AllocateMessageQueue strategy

2021-08-18 Thread GitBox
makabakaboom commented on issue #3265: URL: https://github.com/apache/rocketmq/issues/3265#issuecomment-900970870 > Thanks for Good job ! But in the other hand, it seems like this is not a MQ's responsibility to handle our deployment requirements, keep simple and clean. OK,不过在实际应用过程

Still Failing: apache/rocketmq-externals#166 (master - f93626e)

2021-08-18 Thread Travis CI
Build Update for apache/rocketmq-externals - Build: #166 Status: Still Failing Duration: 2 mins and 38 secs Commit: f93626e (master) Author: SteNicholas Message: [#715] Support the RocketMQ TableSource based on the legacy Source implementation (#779) View the

[GitHub] [rocketmq] liuruinl commented on issue #3265: add GrayRelease AllocateMessageQueue strategy

2021-08-18 Thread GitBox
liuruinl commented on issue #3265: URL: https://github.com/apache/rocketmq/issues/3265#issuecomment-900946121 Thanks for Good job ! But in the other hand, it seems like this is not a MQ's responsibility to handle our deployment requirements, keep simple and clean. -- This is an automat

Re: [VOTE]:Release Apache RocketMQ 4.9.1 RC1.

2021-08-18 Thread 倪泽
+1 My check list is as fellow: artifacts package is the same as current release version. source package can build success nameserver and broker can start up clusterlist command can success and version is correct. use tools to produce and consume message success. 周波 于2021年8月18日周三 下午4:26写道: >

Re: [VOTE]:Release Apache RocketMQ 4.9.1 RC1.

2021-08-18 Thread 周波
+1 I checked: [OK] Source code artifacts have correct names matching the current release. [OK] Hash and Tag in GitHub repo is matching the current artifacts. [OK] The code can be built success in the source package. [OK] Run clusterList command to see if the version is correct [OK] Build the

Re: [VOTE]:Release Apache RocketMQ 4.9.1 RC1.

2021-08-18 Thread caigy
I vote +1 (non-binding) I checked the following: - Licence by Apache RAT - Hashes of binary and source files are correct - Signatures of binary and source files are correct - Source code can be built successfully and all unit tests are passed locally - Nameserver and Broker can be run succe

[GitHub] [rocketmq-externals] ni-ze commented on pull request #781: [#780] Support the RocketMQ TableSink based on the legacy Sink implementation

2021-08-18 Thread GitBox
ni-ze commented on pull request #781: URL: https://github.com/apache/rocketmq-externals/pull/781#issuecomment-900895647 I can help make a review, but also need approve from write permission. -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [rocketmq-externals] 505703441 opened a new issue #789: why Multi-producer instance use the same instanceName?

2021-08-18 Thread GitBox
505703441 opened a new issue #789: URL: https://github.com/apache/rocketmq-externals/issues/789 #704 rocketmq-client:4.8.0 org.apache.rocketmq.client.impl.MQClientManager.getOrCreateMQClientInstance() same instanceName use same instance->the same TCPLink -- This is a

Re: Re: [VOTE]:Release Apache RocketMQ 4.9.1 RC1.

2021-08-18 Thread Amber Liu
+1 (non-binding) checked: - All links are valid. - All ASF files have ASF headers use: mvn clean apache-rat:check - Can compile from source use: mvn clean install -DskipTests mvn -Prelease-all -DskipTests clean package -U - Start nameserver and broker according to the quick-start Ro

[GitHub] [rocketmq-externals] SteNicholas commented on pull request #781: [#780] Support the RocketMQ TableSink based on the legacy Sink implementation

2021-08-18 Thread GitBox
SteNicholas commented on pull request #781: URL: https://github.com/apache/rocketmq-externals/pull/781#issuecomment-900881282 @vongosling @duhenglucky , could you help to review the RocketMQ TableSink based on the legacy Sink implementation? -- This is an automated message from the Apa

[GitHub] [rocketmq-externals] SteNicholas removed a comment on pull request #781: [#780] Support the RocketMQ TableSink based on the legacy Sink implementation

2021-08-18 Thread GitBox
SteNicholas removed a comment on pull request #781: URL: https://github.com/apache/rocketmq-externals/pull/781#issuecomment-900876590 @vongosling @duhenglucky , could you help to review the RocketMQ TableSink based on the legacy Sink implementation? -- This is an automated message from

[GitHub] [rocketmq] zxcvbnm3057 commented on issue #3272: Is it possible to mark that a message has been consumed in other threads?

2021-08-18 Thread GitBox
zxcvbnm3057 commented on issue #3272: URL: https://github.com/apache/rocketmq/issues/3272#issuecomment-900877543 Another problem is that `MessageUtil.createReplyMessage` needs to be called to reply in another thread, so it must have the reference of the original request message. If the rep

[GitHub] [rocketmq-externals] SteNicholas commented on pull request #781: [#780] Support the RocketMQ TableSink based on the legacy Sink implementation

2021-08-18 Thread GitBox
SteNicholas commented on pull request #781: URL: https://github.com/apache/rocketmq-externals/pull/781#issuecomment-900876590 @vongosling @duhenglucky , could you help to review the RocketMQ TableSink based on the legacy Sink implementation? -- This is an automated message from the Apac

[GitHub] [rocketmq-externals] duhenglucky merged pull request #779: [#715] Support the RocketMQ TableSource based on the legacy Source implementation

2021-08-18 Thread GitBox
duhenglucky merged pull request #779: URL: https://github.com/apache/rocketmq-externals/pull/779 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: d

Re: [VOTE]:Release Apache RocketMQ 4.9.1 RC1.

2021-08-18 Thread tiger lee
+1 周波 于2021年8月18日周三 下午2:56写道: > +1 > > 胡 宗棠 于2021年8月18日周三 下午2:25写道: > > > Hello RocketMQ Community, > > > > > > This is the vote for 4.9.1 of Apache RocketMQ. > > > > > > This release is to improve some features and issues for apache > > rocketmq,such as improving rocketmq's remarkable throughp

[GitHub] [rocketmq-externals] vongosling commented on pull request #779: [#715] Support the RocketMQ TableSource based on the legacy Source implementation

2021-08-18 Thread GitBox
vongosling commented on pull request #779: URL: https://github.com/apache/rocketmq-externals/pull/779#issuecomment-900869821 @SteNicholas I see the status of our flink integration, there is still improvement to polish before we call for gruduation. #787 (comment), do we have a plan to sup