Re: [DISCUSS][RIP-33] RocketMQ MQTT

2022-01-25 Thread yukon
Great!!! A big step of the RocketMQ community toward the IoT ecosystem. On Wed, Jan 26, 2022 at 2:22 PM heng du wrote: > long-awaited feature > > Ping Jack 于2022年1月26日周三 14:15写道: > > > Hi, RocketMQ Community: > > > > I want to start a RIP to support MQTT protocol architecture model so that > >

[GitHub] [rocketmq-dashboard] xxd763795151 opened a new issue #70: Does the dashboard need to provide a visual way to configure acl?

2022-01-25 Thread GitBox
xxd763795151 opened a new issue #70: URL: https://github.com/apache/rocketmq-dashboard/issues/70 **FEATURE REQUEST** Hello, In the year before, I developed a feature that can support config acl int the console for my team, such as following: ![image](https://user-images.githubus

[GitHub] [rocketmq-client-go] WJL3333 opened a new issue #774: Send trace data fail because context.cancel() early

2022-01-25 Thread GitBox
WJL opened a new issue #774: URL: https://github.com/apache/rocketmq-client-go/issues/774 **BUG REPORT** 1. Please describe the issue you observed: master code. local cluster. example/producer/trace/main.go 2. Please tell us about your environment:

Re: [DISCUSS][RIP-33] RocketMQ MQTT

2022-01-25 Thread heng du
long-awaited feature Ping Jack 于2022年1月26日周三 14:15写道: > Hi, RocketMQ Community: > > I want to start a RIP to support MQTT protocol architecture model so that > RocketMQ can better support messages from terminals such as IoT devices and > mobile APP. Based on the RocketMQ message unified storage

[DISCUSS][RIP-33] RocketMQ MQTT

2022-01-25 Thread Ping Jack
Hi, RocketMQ Community: I want to start a RIP to support MQTT protocol architecture model so that RocketMQ can better support messages from terminals such as IoT devices and mobile APP. Based on the RocketMQ message unified storage engine, it supports both MQTT terminal and server message sending

[GitHub] [rocketmq] Git-Yang edited a comment on pull request #3700: [ISSUE #3699] fix unit test

2022-01-25 Thread GitBox
Git-Yang edited a comment on pull request #3700: URL: https://github.com/apache/rocketmq/pull/3700#issuecomment-1021894401 > @Git-Yang Some unit tests failed, could you fix it? It's Coveralls API failed, not a unit test failed. -- This is an automated message from the Apache Git Se

[GitHub] [rocketmq] Git-Yang commented on pull request #3700: [ISSUE #3699] fix unit test

2022-01-25 Thread GitBox
Git-Yang commented on pull request #3700: URL: https://github.com/apache/rocketmq/pull/3700#issuecomment-1021894401 > @Git-Yang Some unit tests failed, could you fix it? It's Coveralls API failed, not a unit test issue. -- This is an automated message from the Apache Git Service. T

[GitHub] [rocketmq] codecov-commenter edited a comment on pull request #3788: [ISSUE #3786] fix: The length of properties value should be checked before converting them to short.

2022-01-25 Thread GitBox
codecov-commenter edited a comment on pull request #3788: URL: https://github.com/apache/rocketmq/pull/3788#issuecomment-1019760479 # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/3788?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm

[GitHub] [rocketmq] coveralls edited a comment on pull request #3788: [ISSUE #3786] fix: The length of properties value should be checked before converting them to short.

2022-01-25 Thread GitBox
coveralls edited a comment on pull request #3788: URL: https://github.com/apache/rocketmq/pull/3788#issuecomment-1019760393 [![Coverage Status](https://coveralls.io/builds/45952742/badge)](https://coveralls.io/builds/45952742) Coverage decreased (-0.04%) to 51.102% when pulling

[GitHub] [rocketmq] caigy commented on pull request #3700: [ISSUE #3699] fix unit test

2022-01-25 Thread GitBox
caigy commented on pull request #3700: URL: https://github.com/apache/rocketmq/pull/3700#issuecomment-1021869768 @Git-Yang Some unit tests failed, could you fix it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [DISSCUSS][RIP-32] Slave Acting Master Mode

2022-01-25 Thread heng du
Great improvement, whether in terms of usability or complexity of the operation, it is a very big improvement to the master-slave architecture. Thank, Henry jinrongtong 于2022年1月26日周三 11:51写道: > Hi, RocketMQ Community: > > I want to start a RIP to support a slave acting master mode which enhance

Re: [ANNOUNCE] Release Apache RocketMQ Streams 1.0.0-preview

2022-01-25 Thread heng du
A new start 周波 于2022年1月26日周三 10:52写道: > Hi all, > > The Apache RocketMQ team would like to announce the release of Apache > RocketMQ Streams 1.0.0-preview. > > This is the first release of Apache RocketMQ Streams. > > More details regarding Apache RocketMQ Streams 1.0.0-preview can be found > at

[GitHub] [rocketmq] Kvicii edited a comment on issue #3797: DefaultMQProducerImpl code improvement

2022-01-25 Thread GitBox
Kvicii edited a comment on issue #3797: URL: https://github.com/apache/rocketmq/issues/3797#issuecomment-1021853991 about the checkTransactionState API, it seems that we should remove the calls to the checkListener method and TransactionCheckListener, should we? -- This is an automated m

[GitHub] [rocketmq] Kvicii commented on issue #3797: DefaultMQProducerImpl code improvement

2022-01-25 Thread GitBox
Kvicii commented on issue #3797: URL: https://github.com/apache/rocketmq/issues/3797#issuecomment-1021853991 abount the checkTransactionState API, it seems that we should remove the calls to the checkListener method and TransactionCheckListener, should we? -- This is an automated message

[GitHub] [rocketmq] XiaoyiPeng edited a comment on pull request #3788: [ISSUE #3786] fix: The length of properties value should be checked before converting them to short.

2022-01-25 Thread GitBox
XiaoyiPeng edited a comment on pull request #3788: URL: https://github.com/apache/rocketmq/pull/3788#issuecomment-1021848547 > Whether to add more information to the RuntimeException message, such as the current prop length, limit length... Thanks for your advice, I've corrected it.

[GitHub] [rocketmq] XiaoyiPeng edited a comment on pull request #3788: [ISSUE #3786] fix: The length of properties value should be checked before converting them to short.

2022-01-25 Thread GitBox
XiaoyiPeng edited a comment on pull request #3788: URL: https://github.com/apache/rocketmq/pull/3788#issuecomment-1021848547 > Whether to add more information to the RuntimeException message, such as the current prop length, limit length... Thanks for your advice, I've corrected it.

[GitHub] [rocketmq] XiaoyiPeng commented on pull request #3788: [ISSUE #3786] fix: The length of properties value should be checked before converting them to short.

2022-01-25 Thread GitBox
XiaoyiPeng commented on pull request #3788: URL: https://github.com/apache/rocketmq/pull/3788#issuecomment-1021848547 > Whether to add more information to the RuntimeException message, such as the current prop length, limit length... Thanks for your advice, I've corrected it.

[GitHub] [rocketmq] XiaoyiPeng commented on a change in pull request #3795: [ISSUE #3789] optimize: Tag the name of consuming thread whith consumeGroup.

2022-01-25 Thread GitBox
XiaoyiPeng commented on a change in pull request #3795: URL: https://github.com/apache/rocketmq/pull/3795#discussion_r792298637 ## File path: client/src/main/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessageConcurrentlyService.java ## @@ -70,13 +70,19 @@ public Con

[GitHub] [rocketmq] XiaoyiPeng commented on a change in pull request #3795: [ISSUE #3789] optimize: Tag the name of consuming thread whith consumeGroup.

2022-01-25 Thread GitBox
XiaoyiPeng commented on a change in pull request #3795: URL: https://github.com/apache/rocketmq/pull/3795#discussion_r792298637 ## File path: client/src/main/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessageConcurrentlyService.java ## @@ -70,13 +70,19 @@ public Con

[GitHub] [rocketmq] XiaoyiPeng commented on a change in pull request #3795: [ISSUE #3789] optimize: Tag the name of consuming thread whith consumeGroup.

2022-01-25 Thread GitBox
XiaoyiPeng commented on a change in pull request #3795: URL: https://github.com/apache/rocketmq/pull/3795#discussion_r792298637 ## File path: client/src/main/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessageConcurrentlyService.java ## @@ -70,13 +70,19 @@ public Con

[GitHub] [rocketmq] XiaoyiPeng commented on a change in pull request #3795: [ISSUE #3789] optimize: Tag the name of consuming thread whith consumeGroup.

2022-01-25 Thread GitBox
XiaoyiPeng commented on a change in pull request #3795: URL: https://github.com/apache/rocketmq/pull/3795#discussion_r792298498 ## File path: client/src/main/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessageConcurrentlyService.java ## @@ -70,13 +70,19 @@ public Con

[GitHub] [rocketmq] XiaoyiPeng commented on a change in pull request #3795: [ISSUE #3789] optimize: Tag the name of consuming thread whith consumeGroup.

2022-01-25 Thread GitBox
XiaoyiPeng commented on a change in pull request #3795: URL: https://github.com/apache/rocketmq/pull/3795#discussion_r792298498 ## File path: client/src/main/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessageConcurrentlyService.java ## @@ -70,13 +70,19 @@ public Con

[DISSCUSS][RIP-32] Slave Acting Master Mode

2022-01-25 Thread jinrongtong
Hi, RocketMQ Community: I want to start a RIP to support a slave acting master mode which enhances the slave capability after the master goes offline. This mode can solve the consumption interruption of order messages, delay messages, transaction messages after the master goes offline, as well

[GitHub] [rocketmq] Kvicii opened a new issue #3797: DefaultMQProducerImpl code improvement

2022-01-25 Thread GitBox
Kvicii opened a new issue #3797: URL: https://github.com/apache/rocketmq/issues/3797 hi all, The DefaultMQProducerImpl class has some code that can be optimized, I will provide a PR later. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [rocketmq] caigy commented on a change in pull request #3795: [ISSUE #3789] optimize: Tag the name of consuming thread whith consumeGroup.

2022-01-25 Thread GitBox
caigy commented on a change in pull request #3795: URL: https://github.com/apache/rocketmq/pull/3795#discussion_r792289401 ## File path: client/src/main/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessageConcurrentlyService.java ## @@ -70,13 +70,19 @@ public ConsumeM

[GitHub] [rocketmq-externals] keranbingaa opened a new issue #860: [rocketmq spark] can rocketmq-spark support spark 3.x?

2022-01-25 Thread GitBox
keranbingaa opened a new issue #860: URL: https://github.com/apache/rocketmq-externals/issues/860 spark 2.x depends on old version netty, which exists many security vulnerabilities, spark 3.x depends on new version netty, but some source code in rocketmq-spark only support spark 2.x. --

[RESULT][VOTE][RIP-31] Support RocketMQ BrokerContainer

2022-01-25 Thread jinrongtong
Hello RocketMQ Community, This is the vote result for the kickoff of RIP-31 Support RocketMQ BrokerContainer, and it has been passed with [3] binding +1s, [4] non-binding: *Binding votes +1s:* RongtongJin(jinrongt...@apache.org) ShannonDing(ding...@apache.org) Du Heng(duhengfore...@apache.or

[GitHub] [rocketmq] caigy commented on a change in pull request #3761: [ISSUE #2986] Support for multiple ACL files in a fixed directory

2022-01-25 Thread GitBox
caigy commented on a change in pull request #3761: URL: https://github.com/apache/rocketmq/pull/3761#discussion_r791329030 ## File path: acl/src/main/java/org/apache/rocketmq/acl/plain/PlainPermissionManager.java ## @@ -30,51 +43,108 @@ import org.apache.rocketmq.common.const

[GitHub] [rocketmq] tianliuliu commented on pull request #3788: [ISSUE #3786] fix: The length of properties value should be checked before converting them to short.

2022-01-25 Thread GitBox
tianliuliu commented on pull request #3788: URL: https://github.com/apache/rocketmq/pull/3788#issuecomment-1021815816 Whether to add more information to the RuntimeException message, such as the current prop length, limit length... -- This is an automated message from the Apache Git Serv

Re: [VOTE][RIP-31] Support RocketMQ BrokerContainer

2022-01-25 Thread Hongjian Fei
+1 | | Hongjian Fei | | erikfei1...@163.com | 签名由网易邮箱大师定制 On 01/26/2022 10:50,Rongtong Jin wrote: +1 "ShannonDing" 写道: +1 At 2022-01-21 10:22:48, "jinrongtong" wrote: Hi, RocketMQ Community, As discussed in the previous email, we launched a new RIP to support RocketMQ B

[ANNOUNCE] Release Apache RocketMQ Streams 1.0.0-preview

2022-01-25 Thread 周波
Hi all, The Apache RocketMQ team would like to announce the release of Apache RocketMQ Streams 1.0.0-preview. This is the first release of Apache RocketMQ Streams. More details regarding Apache RocketMQ Streams 1.0.0-preview can be found at: https://github.com/apache/rocketmq-streams The releas

Re: Re:[VOTE][RIP-31] Support RocketMQ BrokerContainer

2022-01-25 Thread Rongtong Jin
+1 "ShannonDing" 写道: > +1 > > At 2022-01-21 10:22:48, "jinrongtong" wrote: > >Hi, RocketMQ Community, > > > >As discussed in the previous email, we launched a new RIP to support > >RocketMQ BrokerContainer. Now the shepherds @duhenglucky and @odbozhou are > >willing to sup

[GitHub] [rocketmq] duhenglucky closed issue #3720: avoid multiple expansion when the number of elements is determined

2022-01-25 Thread GitBox
duhenglucky closed issue #3720: URL: https://github.com/apache/rocketmq/issues/3720 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr..

[GitHub] [rocketmq] duhenglucky merged pull request #3721: [ISSUE #3720]perf: avoid multiple expansion when the number of elements in the `MessageConst` class is determined

2022-01-25 Thread GitBox
duhenglucky merged pull request #3721: URL: https://github.com/apache/rocketmq/pull/3721 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsub

[GitHub] [rocketmq] duhenglucky closed issue #3794: we need description of deprecated methods and classes

2022-01-25 Thread GitBox
duhenglucky closed issue #3794: URL: https://github.com/apache/rocketmq/issues/3794 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr..

[GitHub] [rocketmq] duhenglucky merged pull request #3796: DefaultMQPullConsumer document specification

2022-01-25 Thread GitBox
duhenglucky merged pull request #3796: URL: https://github.com/apache/rocketmq/pull/3796 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsub

[GitHub] [rocketmq] RongtongJin commented on issue #3792: [RIP-29] Optimize RocketMQ NameServer

2022-01-25 Thread GitBox
RongtongJin commented on issue #3792: URL: https://github.com/apache/rocketmq/issues/3792#issuecomment-1021807719 > > I want the re-election time to affect sequential message sending.Proactively push when the broker role changes > > 我希望可以减少因为选举对顺序消息发送者的不可用时间,比如nameserver主动通知客户端,或者bro

[GitHub] [rocketmq] Cczzzz commented on issue #3747: Reduce election time

2022-01-25 Thread GitBox
Cc commented on issue #3747: URL: https://github.com/apache/rocketmq/issues/3747#issuecomment-1021798216 > 例如对于 raft 的 leader transfer oldLeader 必须等待 newLeader 追上自己, 才能实现 leader 的切换, 否则的日志会出现丢失的情况 例如: oldLeader: 1 2 3 4 5 6 newLeader: 1 2 3 4 如果直接实现 NewLeader 切换, 那么 5 6 两条消息就会丢失, 即使其他的

[GitHub] [rocketmq] Cczzzz commented on issue #3792: [RIP-29] Optimize RocketMQ NameServer

2022-01-25 Thread GitBox
Cc commented on issue #3792: URL: https://github.com/apache/rocketmq/issues/3792#issuecomment-1021796659 > I want the re-election time to affect sequential message sending.Proactively push when the broker role changes 我希望可以减少因为选举对顺序消息发送者的不可用时间,比如nameserver主动通知客户端,或者broker 推送。

[GitHub] [rocketmq] Cczzzz commented on issue #3792: [RIP-29] Optimize RocketMQ NameServer

2022-01-25 Thread GitBox
Cc commented on issue #3792: URL: https://github.com/apache/rocketmq/issues/3792#issuecomment-1021795126 I want the re-election time to affect sequential message sending.Proactively push when the broker role changes -- This is an automated message from the Apache Git Service. To

[DISCUSS] RocketMQ 4.9.3 Release

2022-01-25 Thread tiger lee
Happy New Year RocketMQ Community, 🎆 🎆 🎆 This is the discussion for the release of RocketMQ 4.9.3. A hundred days since RocketMQ 4.9.2 released, and 4.9.3 will come soon. Lots of new features,performance improvements,doc updates , etc would be in this version. Especially PR 3588 and PR 3659, They

[GitHub] [rocketmq] ShannonDing commented on issue #3791: rocketmq broker IP修改后 原来的topic 没有了!

2022-01-25 Thread GitBox
ShannonDing commented on issue #3791: URL: https://github.com/apache/rocketmq/issues/3791#issuecomment-1020913662 topics and messages store are both related brokerIP, it is better not to change the broker ip. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [rocketmq] codecov-commenter commented on pull request #3796: DefaultMQPullConsumer document specification

2022-01-25 Thread GitBox
codecov-commenter commented on pull request #3796: URL: https://github.com/apache/rocketmq/pull/3796#issuecomment-1020946700 # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/3796?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [rocketmq] Kvicii commented on issue #3785: about MQClientAPIImpl improvement

2022-01-25 Thread GitBox
Kvicii commented on issue #3785: URL: https://github.com/apache/rocketmq/issues/3785#issuecomment-1020798967 [ISSUE#3785](https://github.com/apache/rocketmq/pull/3793) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [rocketmq] XiaoyiPeng closed pull request #3790: [ISSUE #3789] optimize: Tag the name of consuming thread whith consumeGroup.

2022-01-25 Thread GitBox
XiaoyiPeng closed pull request #3790: URL: https://github.com/apache/rocketmq/pull/3790 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubs

[GitHub] [rocketmq] coveralls commented on pull request #3796: DefaultMQPullConsumer document specification

2022-01-25 Thread GitBox
coveralls commented on pull request #3796: URL: https://github.com/apache/rocketmq/pull/3796#issuecomment-1020946472 [![Coverage Status](https://coveralls.io/builds/45914659/badge)](https://coveralls.io/builds/45914659) Coverage increased (+0.02%) to 51.129% when pulling **4ff2e

[GitHub] [rocketmq] codecov-commenter commented on pull request #3780: [ISSUE #3779] Add hook to execute after consume for pop

2022-01-25 Thread GitBox
codecov-commenter commented on pull request #3780: URL: https://github.com/apache/rocketmq/pull/3780#issuecomment-1020869020 # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/3780?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [rocketmq] duhenglucky commented on issue #3791: rocketmq broker IP修改后 原来的topic 没有了!

2022-01-25 Thread GitBox
duhenglucky commented on issue #3791: URL: https://github.com/apache/rocketmq/issues/3791#issuecomment-1020949171 @wanglixiang90 更换IP 不会导致topic 丢失,可以看下 topics.json 文件是否还存在?另外用的是dledger 模式还是 ms 模式? -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [rocketmq] codecov-commenter commented on pull request #3795: [ISSUE #3789] optimize: Tag the name of consuming thread whith consumeGroup.

2022-01-25 Thread GitBox
codecov-commenter commented on pull request #3795: URL: https://github.com/apache/rocketmq/pull/3795#issuecomment-1020712859 # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/3795?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [rocketmq] ni-ze commented on issue #3768: Use acl RPCHook in BrokerOuterAPI to help master-slave sync when the ip cannot predicted

2022-01-25 Thread GitBox
ni-ze commented on issue #3768: URL: https://github.com/apache/rocketmq/issues/3768#issuecomment-1020737046 Seems to work, but this method is suggested. ```java org.apache.rocketmq.broker.BrokerController#registerClientRPCHook ``` -- This is an automated message from the Apac

[GitHub] [rocketmq] Kvicii commented on issue #3794: we need description of deprecated methods and classes

2022-01-25 Thread GitBox
Kvicii commented on issue #3794: URL: https://github.com/apache/rocketmq/issues/3794#issuecomment-1020927289 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [rocketmq] coveralls commented on pull request #3795: [ISSUE #3789] optimize: Tag the name of consuming thread whith consumeGroup.

2022-01-25 Thread GitBox
coveralls commented on pull request #3795: URL: https://github.com/apache/rocketmq/pull/3795#issuecomment-1020712743 [![Coverage Status](https://coveralls.io/builds/45905330/badge)](https://coveralls.io/builds/45905330) Coverage increased (+0.06%) to 51.165% when pulling **c8943

[GitHub] [rocketmq] duhenglucky closed issue #3750: service not available now. It may be caused by one of the following reasons: the broker's disk is full [CL: 0.31 CQ: 0.31 INDEX: 0.31], messages

2022-01-25 Thread GitBox
duhenglucky closed issue #3750: URL: https://github.com/apache/rocketmq/issues/3750 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr..

[GitHub] [rocketmq] caigy commented on pull request #3761: [ISSUE #2986] Support for multiple ACL files in a fixed directory

2022-01-25 Thread GitBox
caigy commented on pull request #3761: URL: https://github.com/apache/rocketmq/pull/3761#issuecomment-1020745066 @sunxi92 Could you post your detailed design so that more people can join this pr? BTW, it should be well documented about how to use this new feature and how it effects the old

[GitHub] [rocketmq] xiongwu1 commented on issue #3794: we need description of deprecated methods and classes

2022-01-25 Thread GitBox
xiongwu1 commented on issue #3794: URL: https://github.com/apache/rocketmq/issues/3794#issuecomment-1020904436 for example? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [rocketmq-externals] vongosling merged pull request #859: Fix spelling mistakes

2022-01-25 Thread GitBox
vongosling merged pull request #859: URL: https://github.com/apache/rocketmq-externals/pull/859 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: de

[GitHub] [rocketmq] coveralls commented on pull request #3793: [ISSUE #3785] MQClientAPIImpl improvement

2022-01-25 Thread GitBox
coveralls commented on pull request #3793: URL: https://github.com/apache/rocketmq/pull/3793#issuecomment-1020661443 [![Coverage Status](https://coveralls.io/builds/45903154/badge)](https://coveralls.io/builds/45903154) Coverage increased (+0.02%) to 51.129% when pulling **47663

[GitHub] [rocketmq] Kvicii edited a comment on issue #3794: we need description of deprecated methods and classes

2022-01-25 Thread GitBox
Kvicii edited a comment on issue #3794: URL: https://github.com/apache/rocketmq/issues/3794#issuecomment-1020927289 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [rocketmq] coveralls edited a comment on pull request #3780: [ISSUE #3779] Add hook to execute after consume for pop

2022-01-25 Thread GitBox
coveralls edited a comment on pull request #3780: URL: https://github.com/apache/rocketmq/pull/3780#issuecomment-1018336385 [![Coverage Status](https://coveralls.io/builds/45911434/badge)](https://coveralls.io/builds/45911434) Coverage decreased (-0.1%) to 52.559% when pulling *

[GitHub] [rocketmq] ShannonDing closed issue #3791: rocketmq broker IP修改后 原来的topic 没有了!

2022-01-25 Thread GitBox
ShannonDing closed issue #3791: URL: https://github.com/apache/rocketmq/issues/3791 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr..

[GitHub] [rocketmq] duhenglucky commented on issue #3791: rocketmq broker IP修改后 原来的topic 没有了!

2022-01-25 Thread GitBox
duhenglucky commented on issue #3791: URL: https://github.com/apache/rocketmq/issues/3791#issuecomment-1020949171 @wanglixiang90 更换IP 不会导致topic 丢失,可以看下 topics.json 文件是否还存在?另外用的是dledger 模式还是 ms 模式? -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [rocketmq] codecov-commenter commented on pull request #3796: DefaultMQPullConsumer document specification

2022-01-25 Thread GitBox
codecov-commenter commented on pull request #3796: URL: https://github.com/apache/rocketmq/pull/3796#issuecomment-1020946700 # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/3796?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [rocketmq-externals] vongosling merged pull request #859: Fix spelling mistakes

2022-01-25 Thread GitBox
vongosling merged pull request #859: URL: https://github.com/apache/rocketmq-externals/pull/859 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: de

[GitHub] [rocketmq] coveralls commented on pull request #3796: DefaultMQPullConsumer document specification

2022-01-25 Thread GitBox
coveralls commented on pull request #3796: URL: https://github.com/apache/rocketmq/pull/3796#issuecomment-1020946472 [![Coverage Status](https://coveralls.io/builds/45914659/badge)](https://coveralls.io/builds/45914659) Coverage increased (+0.02%) to 51.129% when pulling **4ff2e

[GitHub] [rocketmq] duhenglucky closed issue #3750: service not available now. It may be caused by one of the following reasons: the broker's disk is full [CL: 0.31 CQ: 0.31 INDEX: 0.31], messages

2022-01-25 Thread GitBox
duhenglucky closed issue #3750: URL: https://github.com/apache/rocketmq/issues/3750 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr..

[GitHub] [rocketmq] Kvicii edited a comment on issue #3794: we need description of deprecated methods and classes

2022-01-25 Thread GitBox
Kvicii edited a comment on issue #3794: URL: https://github.com/apache/rocketmq/issues/3794#issuecomment-1020927289 @xiongwu1 for example, DefaultMQPullConsumer we need use `@deprecated`.If there is no explanation, you need to explicitly specify the replacement class, like this. {@link xxx

[GitHub] [rocketmq] Kvicii commented on issue #3794: we need description of deprecated methods and classes

2022-01-25 Thread GitBox
Kvicii commented on issue #3794: URL: https://github.com/apache/rocketmq/issues/3794#issuecomment-1020931624 @xiongwu1 like this. [ISSUE-3794](https://github.com/apache/rocketmq/pull/3796) -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [rocketmq] Kvicii opened a new pull request #3796: DefaultMQPullConsumer document specification

2022-01-25 Thread GitBox
Kvicii opened a new pull request #3796: URL: https://github.com/apache/rocketmq/pull/3796 If there is no explanation, you need to explicitly specify the replacement class -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [rocketmq] Kvicii edited a comment on issue #3794: we need description of deprecated methods and classes

2022-01-25 Thread GitBox
Kvicii edited a comment on issue #3794: URL: https://github.com/apache/rocketmq/issues/3794#issuecomment-1020927289 @xiongwu1 for example, DefaultMQPullConsumer we need use `@deprecated`.If there is no explanation, you need to explicitly specify the replacement class -- This is an automa

[GitHub] [rocketmq] Kvicii commented on issue #3794: we need description of deprecated methods and classes

2022-01-25 Thread GitBox
Kvicii commented on issue #3794: URL: https://github.com/apache/rocketmq/issues/3794#issuecomment-1020927289 @xiongwu1 for example, DefaultMQPullConsumer we need use `@deprecated` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [rocketmq] ShannonDing commented on issue #3791: rocketmq broker IP修改后 原来的topic 没有了!

2022-01-25 Thread GitBox
ShannonDing commented on issue #3791: URL: https://github.com/apache/rocketmq/issues/3791#issuecomment-1020913662 topics and messages store are both related brokerIP, it is better not to change the broker ip. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [rocketmq] ShannonDing closed issue #3791: rocketmq broker IP修改后 原来的topic 没有了!

2022-01-25 Thread GitBox
ShannonDing closed issue #3791: URL: https://github.com/apache/rocketmq/issues/3791 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr..