[GitHub] incubator-rocketmq issue #29: [ROCKETMQ-31] Fix "No such file or directory" ...

Github user shroman commented on the issue: https://github.com/apache/incubator-rocketmq/pull/29 @zhouxinyu @iskl's concerns are valid indeed. My major concern is the logs can be lost when the system crashes. I think it's a good idea to discuss it in another JIRA issue. I will

[GitHub] incubator-rocketmq issue #29: [ROCKETMQ-31] Fix "No such file or directory" ...

Github user zhouxinyu commented on the issue: https://github.com/apache/incubator-rocketmq/pull/29 It's our mistake. As @iskl says, we print gc logs to tmpfs in order to eliminate long time latency brought by disk I/O competition. IMO, we can merge this PR at current state, a

[GitHub] incubator-rocketmq-site pull request #3: Split 'Git setup' for contributors ...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-rocketmq-site/pull/3 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-rocketmq-site issue #3: Split 'Git setup' for contributors and com...

Github user zhouxinyu commented on the issue: https://github.com/apache/incubator-rocketmq-site/pull/3 Thanks, @shroman --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled a

Re: Podling Report Reminder - January 2017

Hi, > 2) I don't believe that all mentors are required to sign off on the podling > report, but I'm not exactly sure. Mentor sign off is mostly in the low numbers particularly at this time of year. I wouldn’t be too concerned if you don’t get all the mentors signing off. 2 or 3 is a good numbe

[GitHub] incubator-rocketmq issue #29: [ROCKETMQ-31] Fix "No such file or directory" ...

Github user shroman commented on the issue: https://github.com/apache/incubator-rocketmq/pull/29 yes, I see, you want to reduce disk I/O by placing the file into `/dev/shm`. Well, GC logging has a minimal overhead. And to get a high-performance broker, I would tune my JVM to g

[GitHub] incubator-rocketmq issue #29: [ROCKETMQ-31] Fix "No such file or directory" ...

Github user iskl commented on the issue: https://github.com/apache/incubator-rocketmq/pull/29 Dear @shroman , thanks for your suggestion :) In my concept, broker thread is **time sensitive**. When broker thread in a MQ broker is in I/O operation and GC occurs, an **I/O competi

Re: Podling Report Reminder - January 2017

Willem, Just added you. John On Thu, Jan 5, 2017 at 8:58 PM Willem Jiang wrote: > Hi Bruce, > > Could you grant the edit right to my wiki account (willemjiang)? > > Thanks, > > Willem Jiang > > Blog: http://willemjiang.blogspot.com (English) > http://jnn.iteye.com (Chinese) > Twitte

Re: Podling Report Reminder - January 2017

Hi Bruce, Could you grant the edit right to my wiki account (willemjiang)? Thanks, Willem Jiang Blog: http://willemjiang.blogspot.com (English) http://jnn.iteye.com (Chinese) Twitter: willemjiang Weibo: 姜宁willem On Tue, Jan 3, 2017 at 11:23 PM, Bruce Snyder wrote: > Hi Von, > > I

Re: Podling Report Reminder - January 2017

1) The folks on the original proposal are the first PMC members and the PMC decides as a group who should become a committer via a discussion and a vote on the private mailing list. The same is true for adding PMC members. 2) I don't believe that all mentors are required to sign off on the podling

[GitHub] incubator-rocketmq issue #29: [ROCKETMQ-31] Fix "No such file or directory" ...

Github user shroman commented on the issue: https://github.com/apache/incubator-rocketmq/pull/29 I would fix `-Xloggc:/dev/shm/mq_gc_%p.log` to point to `$HOME` instead of removing these two lines ;) --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] incubator-rocketmq issue #8: [ROCKETMQ-32] Improve concision - Reuse local v...

Github user naughtybear commented on the issue: https://github.com/apache/incubator-rocketmq/pull/8 @vongosling Hi, new JIRA Issue: https://issues.apache.org/jira/browse/ROCKETMQ-32 Is that be Ok? --- If your project is set up for it, you can reply to this email and

[GitHub] incubator-rocketmq pull request #29: [ROCKETMQ-31] Fix "No such file or dire...

GitHub user iskl opened a pull request: https://github.com/apache/incubator-rocketmq/pull/29 [ROCKETMQ-31] Fix "No such file or directory" warning for $HOME/rmq_b… The PR is to resolve the issue [ROCKETMQ-31](https://issues.apache.org/jira/browse/ROCKETMQ-31) You can merge this p

[GitHub] incubator-rocketmq issue #8: Improve concision - Reuse local variable 'broke...

Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq/pull/8 Yes, do not start a new pull request.Just modify your topic, start a JIRA and bind them :-) --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] incubator-rocketmq issue #8: Improve concision - Reuse local variable 'broke...

Github user naughtybear commented on the issue: https://github.com/apache/incubator-rocketmq/pull/8 @vongosling Hi, two places still not align with the pr procedure. 1. pull request title should be "[ROCKETMQ-11] Improve concision - Reuse local variable 'brokerAddrs' in Ro

[GitHub] incubator-rocketmq-site pull request #3: Split 'Git setup' for contributors ...

Github user lizhanhui commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq-site/pull/3#discussion_r94743138 --- Diff: _docs/06-best-practice-pull-request.md --- @@ -4,23 +4,45 @@ permalink: /docs/pull-request/ modified: 2016-12-24T15:01:43-04:0

[GitHub] incubator-rocketmq pull request #28: [ROCKETMQ-27]Add store commitlog path o...

GitHub user lizhanhui opened a pull request: https://github.com/apache/incubator-rocketmq/pull/28 [ROCKETMQ-27]Add store commitlog path online RocketMQ broker stores all messages before they are expired, which requires pretty much storage for a high load system. For now, the message

[GitHub] incubator-rocketmq-site pull request #3: Split 'Git setup' for contributors ...

Github user shroman commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq-site/pull/3#discussion_r94738341 --- Diff: _docs/06-best-practice-pull-request.md --- @@ -4,23 +4,45 @@ permalink: /docs/pull-request/ modified: 2016-12-24T15:01:43-04:00

[GitHub] incubator-rocketmq-site pull request #3: Split 'Git setup' for contributors ...

Github user lizhanhui commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq-site/pull/3#discussion_r94734427 --- Diff: _docs/06-best-practice-pull-request.md --- @@ -4,23 +4,45 @@ permalink: /docs/pull-request/ modified: 2016-12-24T15:01:43-04:0

[GitHub] incubator-rocketmq-site pull request #3: Split 'Git setup' for contributors ...

Github user shroman commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq-site/pull/3#discussion_r94733211 --- Diff: _docs/06-best-practice-pull-request.md --- @@ -4,23 +4,40 @@ permalink: /docs/pull-request/ modified: 2016-12-24T15:01:43-04:00

[GitHub] incubator-rocketmq-site pull request #3: Split 'Git setup' for contributors ...

Github user shroman commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq-site/pull/3#discussion_r94732917 --- Diff: _docs/06-best-practice-pull-request.md --- @@ -4,23 +4,45 @@ permalink: /docs/pull-request/ modified: 2016-12-24T15:01:43-04:00

[GitHub] incubator-rocketmq-site pull request #3: Split 'Git setup' for contributors ...

Github user vongosling commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq-site/pull/3#discussion_r94732806 --- Diff: _docs/06-best-practice-pull-request.md --- @@ -4,23 +4,40 @@ permalink: /docs/pull-request/ modified: 2016-12-24T15:01:43-04:

[GitHub] incubator-rocketmq issue #27: [ROCKETMQ-30] Fixed method signature for Messa...

Github user zhouxinyu commented on the issue: https://github.com/apache/incubator-rocketmq/pull/27 Cool, thanks @shroman --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-rocketmq-site pull request #3: Split 'Git setup' for contributors ...

Github user shroman commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq-site/pull/3#discussion_r94731141 --- Diff: _docs/06-best-practice-pull-request.md --- @@ -4,23 +4,40 @@ permalink: /docs/pull-request/ modified: 2016-12-24T15:01:43-04:00

[GitHub] incubator-rocketmq-site pull request #3: Split 'Git setup' for contributors ...

Github user shroman commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq-site/pull/3#discussion_r94730828 --- Diff: _docs/06-best-practice-pull-request.md --- @@ -4,23 +4,40 @@ permalink: /docs/pull-request/ modified: 2016-12-24T15:01:43-04:00

[GitHub] incubator-rocketmq-site issue #3: Split 'Git setup' for contributors and com...

Github user lizhanhui commented on the issue: https://github.com/apache/incubator-rocketmq-site/pull/3 Overall, I love this PR. Separating contributors and committers is really good to have. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] incubator-rocketmq-site pull request #3: Split 'Git setup' for contributors ...

Github user lizhanhui commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq-site/pull/3#discussion_r94730662 --- Diff: _docs/06-best-practice-pull-request.md --- @@ -4,23 +4,40 @@ permalink: /docs/pull-request/ modified: 2016-12-24T15:01:43-04:0

[GitHub] incubator-rocketmq-site pull request #3: Split 'Git setup' for contributors ...

Github user lizhanhui commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq-site/pull/3#discussion_r94730295 --- Diff: _docs/06-best-practice-pull-request.md --- @@ -4,23 +4,40 @@ permalink: /docs/pull-request/ modified: 2016-12-24T15:01:43-04:0

[GitHub] incubator-rocketmq-site pull request #3: Split 'Git setup' for contributors ...

Github user shroman commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq-site/pull/3#discussion_r94729784 --- Diff: _docs/06-best-practice-pull-request.md --- @@ -4,23 +4,40 @@ permalink: /docs/pull-request/ modified: 2016-12-24T15:01:43-04:00

[GitHub] incubator-rocketmq-site pull request #3: Split 'Git setup' for contributors ...

Github user lizhanhui commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq-site/pull/3#discussion_r94729360 --- Diff: _docs/06-best-practice-pull-request.md --- @@ -4,23 +4,40 @@ permalink: /docs/pull-request/ modified: 2016-12-24T15:01:43-04:0

[GitHub] incubator-rocketmq-site issue #3: Split 'Git setup' for contributors and com...

Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq-site/pull/3 Alright. please @zhouxinyu @lizhanhui review again:-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] incubator-rocketmq-site pull request #3: Split 'Git setup' for contributors ...

Github user vongosling commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq-site/pull/3#discussion_r94728311 --- Diff: _docs/06-best-practice-pull-request.md --- @@ -4,23 +4,40 @@ permalink: /docs/pull-request/ modified: 2016-12-24T15:01:43-04:

[GitHub] incubator-rocketmq-site pull request #3: Split 'Git setup' for contributors ...

Github user vongosling commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq-site/pull/3#discussion_r94727928 --- Diff: _docs/06-best-practice-pull-request.md --- @@ -53,7 +70,9 @@ Push your branch to Github: # How to create a PR (contributors)