Github user Jaskey commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/63
@lizhanhui , please review the updated pr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Hi,
> On 16 Feb 2017, at 6:05 pm, vintagewang wrote:
>
> +1 binding
Not a binding vote as only incubator PMC members votes are binding here as
explained on the Apache RocketMQ dev list.
While I appreciate the enthusiasm can Apache RocketMQ PPMC members please not
vote here, especially if you
Github user shroman commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/57#discussion_r101456741
--- Diff: store/src/main/java/org/apache/rocketmq/store/CommitLog.java ---
@@ -1154,7 +1249,7 @@ public AppendMessageResult doAppend(final long
fi
+1 binding
Windows users is a very large user groups, especially in the trial product
user groups, it is necessary to increase the windows boot mode[1]
We can finish it next release.
1.https://issues.apache.org/jira/browse/ROCKETMQ-102
On Thu, Feb 16, 2017 at 2:19 PM, Justin Mclean
wrote:
>
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/63
Yes, #4 is not required as MQFaultStrategy#92 may also generate NPE.
Queue ID info is contained in the request header, minimal effort suffices.
---
If your project is set up for it,
Github user shroman commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/57#discussion_r101455998
--- Diff: store/src/main/java/org/apache/rocketmq/store/CommitLog.java ---
@@ -567,6 +577,11 @@ public PutMessageResult putMessage(final
MessageEx
Github user Jaskey commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/63
@lizhanhui , # 4 is not the nessary conditions, since even it is not enble,
the tpInfo's method is still used.
try {
int index = tpInfo.getSendWhichQ
Github user Jaskey commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/53
@dongeforever
I have the same wishes for batch send too, but what drives me is that user
may propably need a batch id for one batch of message, and these message should
be success
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/63
This issue is valid and the bug will be triggered under the following
conditions:
1. A target message queue is specified, which will pass null for
TopicPublishInfo parameter;
2.
Hi,
+1 binding (carried over from dev list)
All the usual things checked for only a couple of minor issue found the
convenience binary is missing an EPL license and IMO the README needs some work.
The RocketMQ website [1]also needs some incubator branding (missing disclaimer
for instance) but
Hello Incubator PMC,
The Apache RocketMQ community has voted and approved the proposal to
release Apache RocketMQ 4.0.0 (incubating). We now kindly request the IPMC
review and vote on this incubator release.
[VOTE] Thread:
https://lists.apache.org/thread.html/349e3268cf5ae7ec65d1cd584362c76bd11f8
Thanks Justin, we will add this note to our release manual.
Regards,
yukon
On Thu, Feb 16, 2017 at 1:20 PM, Justin Mclean
wrote:
> Hi,
>
> No issue here but just a note on binding votes.
>
> For top level project only PMC members have binding votes on releases, for
> incubator projects on the P
GitHub user Jaskey opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/64
[ROCKETMQ-102] When shutdown(), the persisted offet is not the latest
consumed message, which may cause repeated messages.
Solution: add interface for push consumer to accept await termina
Hi,
No issue here but just a note on binding votes.
For top level project only PMC members have binding votes on releases, for
incubator projects on the PPMC there's not really any binding vote as such but
it’s expected that you need 3 +1 votes from anyone on the PPMC. Once the vote
goes to th
Hello RocketMQ Community,
The Apache RocketMQ 4.0.0(incubating) RC3 vote is now closed and has passed
with 3 binding +1s, 4 non-binding +1s and no 0 or -1:
Binding votes +1s:
Justin Mclean
Willem Jiang
Luke Han
Non-binding votes +1s:
vintagewang
Lollipop
dongeforever
Li Zhanhui
yukon
A vote Apa
+1 (binding)
maven compile and test passed
checked MD5 and signatures
readme/license and others looks good.
-Env: MacOS + JDK8
Thanks.
Best Regards!
-
Luke Han
On Thu, Feb 16, 2017 at 9:34 AM, Willem Jiang
wrote:
> +1 (binding)
>
> I checked
> - signatures and signed th
Hi Bruce,
Thanks for your reply.
> Why do the NOTICE files make note of commons-lang including something
from the Spring Framework?
commons-lang has this in its NOTICE file[1], so we added this to our NOTICE
file.
[1]. https://github.com/apache/commons-lang/blob/master/NOTICE.txt
> What is th
+1 (binding)
I checked
- signatures and signed the artifacts
- The nexus staging artifacts are good, I used the example to verify the
artifacts can be downloaded.
- README looks good
- No unexpected binary files in release
- The source can be compile and all tests are passed
There is a minor issu
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/63
[](https://coveralls.io/builds/10175866)
Coverage increased (+0.09%) to 31.614% when pulling
**a8802d0b153e0f4
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/63
[](https://coveralls.io/builds/10175866)
Coverage increased (+0.09%) to 31.614% when pulling
**a8802d0b153e0f4
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/63
[](https://coveralls.io/builds/10175866)
Coverage increased (+0.09%) to 31.614% when pulling
**a8802d0b153e0f4
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/63
[](https://coveralls.io/builds/10175883)
Coverage increased (+0.03%) to 31.549% when pulling
**a8802d0b153e0f4
Hi,
+1 (binding)
I checked:
- incubating in names
- signatures correct
- LICENSE and NOTICE good
- All source files have ASF header
- No unexpected binary files in release
- Can compile from source
- All tests pass (tested on OSX)
A couple of minor issues that IMO can be fixed next release:
- th
Hi,
> * It's definitely odd to point to Maven central and Github for incubating
> project releases
It’s more than odd, it’s not in line with policy. You must point to the primary
source of distribution at Apache, Maven and Github can be mentioned as
secondary distribution points but should not
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/62
[](https://coveralls.io/builds/10169825)
Coverage increased (+0.04%) to 31.561% when pulling
**ba4c5960634027a
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/62
[](https://coveralls.io/builds/10170072)
Coverage increased (+0.009%) to 31.529% when pulling
**ba4c5960634027
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/62
[](https://coveralls.io/builds/10170072)
Coverage increased (+0.009%) to 31.529% when pulling
**ba4c5960634027
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/62
[](https://coveralls.io/builds/10169825)
Coverage increased (+0.04%) to 31.561% when pulling
**ba4c5960634027a
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/62
[](https://coveralls.io/builds/10169825)
Coverage increased (+0.04%) to 31.561% when pulling
**ba4c5960634027a
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/62
[](https://coveralls.io/builds/10169806)
Coverage increased (+0.02%) to 31.538% when pulling
**ba4c5960634027a
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/62
[](https://coveralls.io/builds/10169806)
Coverage increased (+0.02%) to 31.538% when pulling
**ba4c5960634027a
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/62
[](https://coveralls.io/builds/10169806)
Coverage increased (+0.02%) to 31.538% when pulling
**ba4c5960634027a
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/53
[](https://coveralls.io/builds/10167156)
Coverage increased (+0.5%) to 32.046% when pulling
**6579e7a9299f9e6f
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/53
[](https://coveralls.io/builds/10167156)
Coverage increased (+0.5%) to 32.046% when pulling
**6579e7a9299f9e6f
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/53
[](https://coveralls.io/builds/10167156)
Coverage increased (+0.5%) to 32.046% when pulling
**6579e7a9299f9e6f
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/62
[](https://coveralls.io/builds/10167000)
Coverage increased (+0.1%) to 31.626% when pulling
**ba4c5960634027a1
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/62
[](https://coveralls.io/builds/10167000)
Coverage increased (+0.1%) to 31.626% when pulling
**ba4c5960634027a1
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/62
[](https://coveralls.io/builds/10167000)
Coverage increased (+0.1%) to 31.626% when pulling
**ba4c5960634027a1
Hi All,
None of the items that I've found are showstoppers and I know that these
items have been mentioned before, but I will bring them up since I still
see them:
* It's definitely odd to point to Maven central and Github for incubating
project releases
* Also, the URL https://github.org/apache/
Hi Von,
Agreed, Service Desk is for providing customer support so we do not need it.
Great! I'm glad it's working now.
Please let me know if you experience any additional issues.
Bruce
On Tue, Feb 14, 2017 at 8:25 PM, vongosling wrote:
> Thanks Bruce,
>
> IMO, Service Desk is a design for cu
Build Update for lizhanhui/incubator-rocketmq
-
Build: #18
Status: Errored
Duration: 15 minutes and 9 seconds
Commit: ac05611 (ROCKETMQ-99)
Author: Li Zhanhui
Message: Add end tag.
View the changeset:
https://github.com/lizhanhui/incubator-rocketmq/compare/08
Build Update for lizhanhui/incubator-rocketmq
-
Build: #19
Status: Still Failing
Duration: 7 minutes and 4 seconds
Commit: ba4c596 (ROCKETMQ-99)
Author: Li Zhanhui
Message: Add script: play
View the changeset:
https://github.com/lizhanhui/incubator-rocketmq/c
Build Update for lizhanhui/incubator-rocketmq
-
Build: #17
Status: Still Failing
Duration: 8 minutes and 1 second
Commit: 08c3ca2 (ROCKETMQ-99)
Author: Li Zhanhui
Message: Add script: mqshutdown.cmd
View the changeset:
https://github.com/lizhanhui/incubator-r
Build Update for lizhanhui/incubator-rocketmq
-
Build: #15
Status: Still Failing
Duration: 6 minutes and 5 seconds
Commit: 38b0476 (cmd)
Author: Li Zhanhui
Message: Fix
View the changeset:
https://github.com/lizhanhui/incubator-rocketmq/compare/f1a1c2a4b554..
Build Update for lizhanhui/incubator-rocketmq
-
Build: #16
Status: Failed
Duration: 6 minutes and 29 seconds
Commit: 38b0476 (ROCKETMQ-99)
Author: Li Zhanhui
Message: Fix
View the changeset:
https://github.com/lizhanhui/incubator-rocketmq/compare/ROCKETMQ-99
Build Update for lizhanhui/incubator-rocketmq
-
Build: #14
Status: Still Failing
Duration: 6 minutes and 16 seconds
Commit: f1a1c2a (cmd)
Author: Li Zhanhui
Message: Fix
View the changeset:
https://github.com/lizhanhui/incubator-rocketmq/compare/f9e599b5f818.
Build Update for lizhanhui/incubator-rocketmq
-
Build: #12
Status: Still Failing
Duration: 5 minutes and 58 seconds
Commit: 5e12f36 (cmd)
Author: Zhanhui Li
Message: Add runbroker.cmd runserver.cmd
View the changeset:
https://github.com/lizhanhui/incubator-ro
Build Update for lizhanhui/incubator-rocketmq
-
Build: #13
Status: Still Failing
Duration: 6 minutes and 44 seconds
Commit: f9e599b (cmd)
Author: Zhanhui Li
Message: Add more command
View the changeset:
https://github.com/lizhanhui/incubator-rocketmq/compare/
GitHub user Jaskey opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/63
[ROCKETMQ-101]Fix possible NullPointerException when retry in send Async way
JIRA: https://issues.apache.org/jira/browse/ROCKETMQ-101
You can merge this pull request into a Git repository
Github user Jaskey commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/40
@shroman email has been sent , please also review my imlementation and any
suggestions are welcome
---
If your project is set up for it, you can reply to this email and have your
reply app
50 matches
Mail list logo
