Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/150#discussion_r139873296
--- Diff:
store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java ---
@@ -1094,34 +1090,15 @@ private boolean
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/152#discussion_r139871853
--- Diff:
namesrv/src/main/java/org/apache/rocketmq/namesrv/routeinfo/RouteInfoManager.java
---
@@ -63,11 +65,36 @@ public RouteInfoManager
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/152#discussion_r139871793
--- Diff:
client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java ---
@@ -1167,10 +1168,13 @@ public Properties
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/152#discussion_r139871898
--- Diff:
tools/src/main/java/org/apache/rocketmq/tools/command/topic/TopicListSubCommand.java
---
@@ -65,7 +65,7 @@ public void execute
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/162
@vsair Could you follow our new PR style for this PR, like
https://github.com/apache/incubator-rocketmq/pull/152
---
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/29
Consider this is the first commit for this project, I would like to
recommend creating one module naming test for integration test :-)
---
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/29
Write necessary unit-test to verify your logic correction, more mock a
little better when cross module dependency exist. If the new feature or
significant change is
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/23
@Zhang-Ke Thanks, It is really good practice when discarded deserted pr.
---
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/29
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/projects
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/29
@leonchen83 Thanks for your contribution. BTW, have you test it in your
local environment ?
---
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/27
It is a good practice for apache way :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/161
@liucyu If no update for this PR, we will close it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/160#discussion_r135768140
--- Diff:
broker/src/test/java/org/apache/rocketmq/broker/filter/MessageStoreWithFilterTest.java
---
@@ -79,24 +79,17 @@
try
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/160#discussion_r135768040
--- Diff:
broker/src/test/java/org/apache/rocketmq/broker/filter/MessageStoreWithFilterTest.java
---
@@ -79,24 +79,17 @@
try
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/160#discussion_r135722707
--- Diff:
broker/src/test/java/org/apache/rocketmq/broker/filter/MessageStoreWithFilterTest.java
---
@@ -369,4 +367,36 @@ public void
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/160#discussion_r135724026
--- Diff:
broker/src/test/java/org/apache/rocketmq/broker/filter/MessageStoreWithFilterTest.java
---
@@ -369,4 +367,36 @@ public void
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/157#discussion_r135705543
--- Diff: common/src/main/java/org/apache/rocketmq/common/MixAll.java ---
@@ -407,12 +408,50 @@ private static String localhost
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/157
Thank you everyone. I will make some polish and merge this PR :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/145
@lindzh Thanks, I made some modifications and merged this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/132
@evthoriz Thanks, looking forward to your patch :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/145
@Jaskey @vsair Looking forward to your opinion about this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/145#discussion_r134964602
--- Diff:
client/src/test/java/org/apache/rocketmq/client/consumer/rebalance/AllocateMessageQueueConsitentHashTest.java
---
@@ -92,9 +92,9
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/146
LGTM, now~
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/145#discussion_r134941453
--- Diff:
client/src/test/java/org/apache/rocketmq/client/consumer/rebalance/AllocateMessageQueueConsitentHashTest.java
---
@@ -92,9 +92,9
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/146#discussion_r134940285
--- Diff:
broker/src/test/java/org/apache/rocketmq/broker/filter/MessageStoreWithFilterTest.java
---
@@ -238,7 +238,7 @@ public void
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/146#discussion_r134940242
--- Diff: store/src/main/java/org/apache/rocketmq/store/ConsumeQueue.java
---
@@ -446,6 +446,13 @@ private boolean putMessagePositionInfo
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/145#discussion_r133153891
--- Diff:
broker/src/test/java/org/apache/rocketmq/broker/filter/MessageStoreWithFilterTest.java
---
@@ -76,6 +86,24
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/23
@Zhang-Ke Could you remove author info and follow our codestyle, such as
add license. if have any question, please let me know :-)
---
If your project is set up for it, you
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/134
@Ritabrata-TW Thanks for your attention for rocketmq community, whats' your
scenario when using apache rocketmq in your company :-)
---
If your project is set up for it, yo
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/19
How are things going, now :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/26
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/146
@fuyou001 Could you verify your polish using unit-test ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/134
@Ritabrata-TW I found so many code format in your PR, could you import our
code style file as instruction,
http://rocketmq.incubator.apache.org/docs/code-guidelines/
---
If your
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/145
How long it would take in your computer ? @Jaskey @vsair, please double
check this optimized ut.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/126
Thanks @lindzh, i have merged it. Please close this PR :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/132
@evthoriz we usually need some measure to verify our correction, no matter
what you do. IMO, unit test is a effective practice when we coding. Looking
forward to hear from you again
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/142
I created this thread just to address some unit test naming problem. Do we
need normalize here ? naming are various nowadays, IMO, methodTest_condition or
testMethond_condition may be
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/85
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/141
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/134
@Ritabrata-TW thanks, I will take a close look it later :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/126
Now, LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/134
@Ritabrata-TW Looking forward to your following for this PR :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/120
Now, LGTM. this pr also fix the rocketmq's logger appender bug when using
any concrete implementation, no matter log4j, log4j2 or logback.
---
If your project is set up for it
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/120#discussion_r130550009
--- Diff:
client/src/test/java/org/apache/rocketmq/client/log/ClientLogTest.java ---
@@ -32,15 +33,19 @@
LOG_DIR
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/134#discussion_r130526510
--- Diff:
store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java ---
@@ -745,17 +751,7 @@ public long
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/134
@Ritabrata-TW I am not understand your refer "Story number 44 from the
Kanban Board", could you detail it ?
---
If your project is set up for it, you can reply to this emai
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/141#discussion_r130525133
--- Diff:
logappender/src/main/java/org/apache/rocketmq/logappender/common/ProducerInstance.java
---
@@ -61,7 +68,7 @@ public static
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/58
if any update for this pr, we will close it~
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/71
if any update for this pr, we will close it~
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/99
if any update for this pr, we will close it~
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/124
if any update for this pr, we will close it~
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/122
if any update for this pr, we will close it~
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/125
@lqjack what's your opinion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/134
@Ritabrata-TW Could you modify PR subject conforming to our norm :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/118
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/126#discussion_r125432988
--- Diff:
store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java ---
@@ -1110,7 +1110,7 @@ private boolean isTheBatchFull(int
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/3
any update? or close it :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/3#discussion_r93905030
--- Diff:
rocketmq-remoting/src/main/java/com/alibaba/rocketmq/remoting/common/ServiceThread.java
---
@@ -69,10 +69,10 @@ public void shutdown
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/3#discussion_r93904989
--- Diff:
rocketmq-common/src/main/java/com/alibaba/rocketmq/common/MixAll.java ---
@@ -287,8 +287,8 @@ public static void printObjectProperties
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/3#discussion_r93905062
--- Diff:
rocketmq-remoting/src/main/java/com/alibaba/rocketmq/remoting/common/ServiceThread.java
---
@@ -86,7 +86,7 @@ public void stop
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/3#discussion_r93905067
--- Diff:
rocketmq-remoting/src/main/java/com/alibaba/rocketmq/remoting/common/ServiceThread.java
---
@@ -101,7 +101,7 @@ public void stop
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/49
What's going on this pr ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/126#discussion_r123730992
--- Diff:
test/src/test/java/org/apache/rocketmq/test/client/consumer/pull/PullSizeTest.java
---
@@ -0,0 +1,135 @@
+/*
+ * Licensed
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/126#discussion_r123731300
--- Diff:
test/src/test/java/org/apache/rocketmq/test/client/consumer/pull/PullSizeTest.java
---
@@ -0,0 +1,135 @@
+/*
+ * Licensed
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/126#discussion_r123730667
--- Diff:
test/src/test/java/org/apache/rocketmq/test/client/consumer/pull/PullSizeTest.java
---
@@ -0,0 +1,135 @@
+/*
+ * Licensed
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/120#discussion_r123713735
--- Diff: client/pom.xml ---
@@ -37,13 +37,31 @@
${project.groupId}
rocketmq-common
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/120#discussion_r123714561
--- Diff: pom.xml ---
@@ -638,6 +638,16 @@
log4j-core
2.7
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/121
Could you follow standard PRï¼notice topic styleï¼ ? and squash your many
commits ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/24
I will merge this PR and polish it later
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq-site/pull/18#discussion_r120898962
--- Diff: _docs/20-logappender-example.md ---
@@ -0,0 +1,80 @@
+---
+title: "Logappender Example"
+permal
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq-externals/pull/24#discussion_r121606021
--- Diff:
rocketmq-mysql/src/main/java/org/apache/rocketmq/mysql/Config.java ---
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq-externals/pull/24#discussion_r121605897
--- Diff: rocketmq-mysql/pom.xml ---
@@ -0,0 +1,163 @@
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi=
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq-externals/pull/24#discussion_r121605783
--- Diff: rocketmq-mysql/pom.xml ---
@@ -0,0 +1,163 @@
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi=
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq-externals/pull/24#discussion_r121605624
--- Diff: rocketmq-mysql/pom.xml ---
@@ -0,0 +1,163 @@
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi=
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq-externals/pull/24#discussion_r121604785
--- Diff: rocketmq-mysql/.gitignore ---
@@ -0,0 +1,17 @@
+*dependency-reduced-pom.xml
+.classpath
+.project
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/111#discussion_r120903001
--- Diff:
remoting/src/main/java/org/apache/rocketmq/remoting/netty/SslHelper.java ---
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/111#discussion_r120901312
--- Diff:
remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingAbstract.java
---
@@ -88,6 +89,11 @@
protected
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq-site/pull/18#discussion_r120898077
--- Diff: _docs/20-logappender-example.md ---
@@ -0,0 +1,80 @@
+---
+title: "Logappender Example"
+permal
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/112
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/114
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/113
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq-site/pull/16
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq-site/pull/16
Could you resolve the conflict firstly
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq-site/pull/15
LGTM, +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq-site/pull/14
Looks good for me :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq-site/pull/13
Very pleased to see your contribution.But could you please create an issue
at
https://issues.apache.org/jira/browse/ROCKETMQ/?selectedTab=com.atlassian.jira.jira-projects
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq-site/pull/14
Very pleased to see your contribution.But could you please create an issue
at
https://issues.apache.org/jira/browse/ROCKETMQ/?selectedTab=com.atlassian.jira.jira-projects
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/105#discussion_r118622000
--- Diff:
namesrv/src/main/java/org/apache/rocketmq/namesrv/routeinfo/RouteInfoManager.java
---
@@ -125,11 +125,7 @@ public
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/105#discussion_r118621860
--- Diff:
common/src/main/java/org/apache/rocketmq/common/protocol/route/BrokerData.java
---
@@ -15,9 +15,7 @@
* limitations under the
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/101#discussion_r115886436
--- Diff:
logappender/src/main/java/org/apache/rocketmq/logappender/log4j/RocketmqLog4jAppender.java
---
@@ -0,0 +1,193
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/101#discussion_r115887404
--- Diff:
logappender/src/main/java/org/apache/rocketmq/logappender/log4j2/RocketmqLog4j2Appender.java
---
@@ -0,0 +1,232
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/101#discussion_r11558
--- Diff:
logappender/src/main/java/org/apache/rocketmq/logappender/logback/RocketmqLogbackAppender.java
---
@@ -0,0 +1,184
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/101#discussion_r115887366
--- Diff:
logappender/src/main/java/org/apache/rocketmq/logappender/log4j2/RocketmqLog4j2Appender.java
---
@@ -0,0 +1,232
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/101#discussion_r115889155
--- Diff:
logappender/src/test/java/org/apache/rocketmq/logappender/AbstractTestCase.java
---
@@ -0,0 +1,165 @@
+/*
+ * Licensed to
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/101#discussion_r11589
--- Diff:
logappender/src/main/java/org/apache/rocketmq/logappender/logback/RocketmqLogbackAppender.java
---
@@ -0,0 +1,184
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/97
IMO,if we could polish here. we 'd better tell what's wrong with your input
and what's a valid input ,right ?
---
If your project is set up for it, you can reply to
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/80
What's wrong with this PR. if no other polish, suggest close it:-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/93
Any trouble is still ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/91
Agreed. Any other opinion for this PR? @lizhanhui please resolve the
conflicts, we could merge this PR later~
---
If your project is set up for it, you can reply to this email and
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/101#discussion_r115471708
--- Diff: logappender/README.md ---
@@ -0,0 +1,64 @@
+# RocketMQ-LogAppender [