[GitHub] incubator-rocketmq pull request #20: [ROCKETMQ-23] MappedFileQueue#flush sho...

2017-09-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-rocketmq/pull/20 ---

[GitHub] incubator-rocketmq pull request #20: [ROCKETMQ-23] MappedFileQueue#flush sho...

2016-12-28 Thread zhouxinyu
Github user zhouxinyu commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/20#discussion_r94045317 --- Diff: store/src/main/java/org/apache/rocketmq/store/CommitLog.java --- @@ -964,9 +964,11 @@ public void run() { boolean

[GitHub] incubator-rocketmq pull request #20: [ROCKETMQ-23] MappedFileQueue#flush sho...

2016-12-28 Thread shroman
Github user shroman commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/20#discussion_r94043543 --- Diff: store/src/main/java/org/apache/rocketmq/store/CommitLog.java --- @@ -964,9 +964,11 @@ public void run() { boolean result

[GitHub] incubator-rocketmq pull request #20: [ROCKETMQ-23] MappedFileQueue#flush sho...

2016-12-28 Thread zhouxinyu
Github user zhouxinyu commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/20#discussion_r94043135 --- Diff: store/src/main/java/org/apache/rocketmq/store/CommitLog.java --- @@ -964,9 +964,11 @@ public void run() { boolean

[GitHub] incubator-rocketmq pull request #20: [ROCKETMQ-23] MappedFileQueue#flush sho...

2016-12-28 Thread zhouxinyu
Github user zhouxinyu commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/20#discussion_r94042593 --- Diff: store/src/main/java/org/apache/rocketmq/store/MappedFileQueue.java --- @@ -191,7 +199,7 @@ public long howMuchFallBehind() {

[GitHub] incubator-rocketmq pull request #20: [ROCKETMQ-23] MappedFileQueue#flush sho...

2016-12-28 Thread zhouxinyu
Github user zhouxinyu commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/20#discussion_r94042046 --- Diff: store/src/main/java/org/apache/rocketmq/store/MappedFileQueue.java --- @@ -39,11 +39,15 @@ private final int

[GitHub] incubator-rocketmq pull request #20: [ROCKETMQ-23] MappedFileQueue#flush sho...

2016-12-28 Thread shroman
GitHub user shroman opened a pull request: https://github.com/apache/incubator-rocketmq/pull/20 [ROCKETMQ-23] MappedFileQueue#flush should return true when flushing … …is successful. Jira issue: https://issues.apache.org/jira/browse/ROCKETMQ-23 You can merge this pull