[GitHub] [roller] adityasharma7 commented on issue #28: Improved: Editor should confirm user before leaving the page (ROL-2136)

2019-06-09 Thread GitBox
adityasharma7 commented on issue #28: Improved: Editor should confirm user before leaving the page (ROL-2136) URL: https://github.com/apache/roller/pull/28#issuecomment-500192800 Thanks @snoopdave for the review. I was just wondering we are already working on bootstrap-ui where Xinha e

Re: [VOTE] Release Roller v5.2.3

2019-06-09 Thread Kohei Nozaki
Hi Dave, thank you for handling the new release. I've checked a diff at https://github.com/apache/roller/compare/roller-5.2.2...roller-5.2.x and quickly tried the new build (roller-release-5.2.3-rc-1-standard.tar.gz), it looks good to me. +1 I didn't see the entryAdd and entryEdit symptoms wit

Re: Test failure for roller-5.2.3 using Java 7

2019-06-09 Thread sebb
On Sat, 8 Jun 2019 at 19:12, Dave wrote: > > Thanks for the report Sebb. > > It appears that the problem is that the test is attempting to fetch an RSS > feed from a website that uses TLS 1.2 and older versions of Java 1.7 do not > support TLS 1.2. That's why this error appears in roller.log: > >

mvn jetty:run fails on 5.2.3

2019-06-09 Thread sebb
Java8 cd app mvn jetty:run ... [WARNING] Failed startup of context o.e.j.m.p.JettyWebAppContext@55fdf7f9{/roller,[file:/Users/sebb/Downloads/roller-weblogger-5.2.3-source/app/src/main/webapp/, jar:file:/Users/sebb/.m2/repository/org/webjars/npm/angular/1.2.29/angular-1.2.29.jar!/META-INF/resources]

[GitHub] [roller] snoopdave commented on issue #28: Improved: Editor should confirm user before leaving the page (ROL-2136)

2019-06-09 Thread GitBox
snoopdave commented on issue #28: Improved: Editor should confirm user before leaving the page (ROL-2136) URL: https://github.com/apache/roller/pull/28#issuecomment-500207668 @adityasharma7 good point. I think this change should be merged to the roller-5.2.x branch so that it is included i

Re: Test failure for roller-5.2.3 using Java 7

2019-06-09 Thread Dave
I just pushed a fix that skips these tests on Java 1.7. Dave On Sun, Jun 9, 2019 at 4:22 AM sebb wrote: > On Sat, 8 Jun 2019 at 19:12, Dave wrote: > > > > Thanks for the report Sebb. > > > > It appears that the problem is that the test is attempting to fetch an > RSS > > feed from a website th

Re: mvn jetty:run fails on 5.2.3

2019-06-09 Thread Dave
Upgrading to latest Maven-Jetty plugin fixed this problem. Just pushed fix to roller-5.2.x branch. Dave On Sun, Jun 9, 2019 at 6:27 AM sebb wrote: > Java8 > cd app > mvn jetty:run > ... > [WARNING] Failed startup of context > o.e.j.m.p.JettyWebAppContext@55fdf7f9 > {/roller,[file:/Users/sebb/D

Re: [VOTE] Release Roller v5.2.3

2019-06-09 Thread Dave
Thanks folks for the testing and voting. I'm going to close this vote and start a new one for v5.2.3 RC2 with some additional fixes. I'm still wondering what's going on with the actions that were not working for Greg. Dave On Sun, Jun 9, 2019 at 3:56 AM Kohei Nozaki wrote: > Hi Dave, thank yo

[VOTE] Release RC2 as Apache Roller 5.2.3

2019-06-09 Thread Dave
Thanks for Greg, Sebb and others for checking out RC1. I have prepared a 2nd release candidate for Roller 5.2.3, a minor bug-fix release. You can find the list of fixes and improvements JIRA here: https://issues.apache.org/jira/projects/ROL/versions/12344883 IMPORTANT NOTE: for users of Reme

Re: Moving Roller master to Java 11

2019-06-09 Thread Dave
I've been running Roller 6.0.0-SNAPSHOT under Java 11 on my site for a while now. Unless somebody objects, I plan to merge boostrap-ui which contains the new Boostrap UI for Roller and moves Roller to Java 11 this week. Thanks, Dave On Tue, May 14, 2019 at 4:59 AM Greg Huber wrote: > for java1

Build failed in Jenkins: Roller #1565

2019-06-09 Thread Apache Jenkins Server
See Changes: [snoopdave] Simplification of recent remember-me fix. [snoopdave] More remember-me fixes. [snoopdave] Minor working and formatting changes. [snoopdave] Skip feed fetcher tests on Java 1.7 which does not supp

Build failed in Jenkins: Roller ยป Roller webapp #1565

2019-06-09 Thread Apache Jenkins Server
See Changes: [snoopdave] Simplification of recent remember-me fix. [snoopdave] More remember-me fixes. [snoopdave] Minor working and formatting changes. [snoopdave] Skip feed fetcher test