Re: ItemRenderer is not PAYG

2018-04-14 Thread Piotr Zarzycki
Carlos, It is your way of approach where everything what you are doing is in CSS, but I don't agree that the way where you are setting some styles in the code is bad one. It's just different approach which is really good in some cases. Thanks, Piotr 2018-04-14 23:02 GMT+02:00 Carlos Rovira

Re: ItemRenderer is not PAYG

2018-04-14 Thread Carlos Rovira
Hi Piotr, I have already checked Jewel List and ListItemRenderer before sending this email. Jewel is working, I only say that is carrying some overhead of properties, getters and setters and methods that Jewel users will never user at 100%, so that's why we want to avoid with PAYG and why we

Re: Helping with Jewel

2018-04-14 Thread Carlos Rovira
hehe I have my two now going to bed! ;) Good Luck! :) 2018-04-14 18:36 GMT+02:00 OmPrakash Muppirala : > Thank you! > > Now I need to find a way to put my 2 kids to sleep  > > Regards, > Om > > On Sat, Apr 14, 2018, 5:23 AM Carlos Rovira > wrote:

Re: Helping with Jewel

2018-04-14 Thread OmPrakash Muppirala
Thank you! Now I need to find a way to put my 2 kids to sleep  Regards, Om On Sat, Apr 14, 2018, 5:23 AM Carlos Rovira wrote: > Hi Om, > > I just committed Jewel List and use in Jewel Example, but it still shows > very basic. Only one you to know it if you want to

Re: ItemRenderer is not PAYG

2018-04-14 Thread Piotr Zarzycki
Hi Carlos, That's why you are creating your own Item renderer and override that method. Although if you can propose other solution. Of course on different branch with checking if you not break anything. Especially MDL Table. Thanks, Piotr On Sat, Apr 14, 2018, 5:34 PM Carlos Rovira

Re: [royale-asjs] 01/01: UIBase className changes to support new cssclassList class methods like addStyles

2018-04-14 Thread Piotr Zarzycki
Are you saying that it will work with your implementation and not with Alex's? Actually as a app developer above situation is very rare. Thanks, Piotr On Sat, Apr 14, 2018, 5:24 PM Carlos Rovira wrote: > That's what Alex want. To make className only used at init time

ItemRenderer is not PAYG

2018-04-14 Thread Carlos Rovira
Hi, this base class UIItemRendererBase has properties for all colors (hover, selected, and more) and a "useColor" property, and updateRenderer() method is switching "useColor" as a low level class, I think this class should not have all this info, since most people will never use. In Basic I

Re: [royale-asjs] 01/01: UIBase className changes to support new cssclassList class methods like addStyles

2018-04-14 Thread Carlos Rovira
That's what Alex want. To make className only used at init time then we should use classList methods. I think that the premises are not right, since Alex thinks devs will not make heavy use of switching class selectors at runtime (at init time and later while using the app). MDL and Jewel are

Re: [royale-asjs] 01/01: UIBase className changes to support new cssclassList class methods like addStyles

2018-04-14 Thread Piotr Zarzycki
Carlos, Are you saying here having your idea: " 1) I think people have the APIs (className and classList) and can/will do what they want, although we say "use className only at init time". " If I do following things: And later in the code I do: comp.className = "myOtherClass"; It won't

Re: Helping with Jewel

2018-04-14 Thread Carlos Rovira
Hi Om, I just committed Jewel List and use in Jewel Example, but it still shows very basic. Only one you to know it if you want to start using it this week end as you said. I'll be committing changes as I get things done 2018-04-13 12:28 GMT+02:00 Carlos Rovira : > Swiz

Re: [royale-asjs] 01/01: UIBase className changes to support new cssclassList class methods like addStyles

2018-04-14 Thread Carlos Rovira
Alex 2018-04-14 8:41 GMT+02:00 Alex Harui : > Carlos, > > It seems like either you have missed some of the discussion or maybe we > weren't clear enough. > I think most of what you say was considered but let's go for parts: > > Simply put: > -The Basic components do

Re: [royale-asjs] 01/01: UIBase className changes to support new cssclassList class methods like addStyles

2018-04-14 Thread Alex Harui
Carlos, It seems like either you have missed some of the discussion or maybe we weren't clear enough. Simply put: -The Basic components do not need to handle classList APIs. There is no expectation that classes will be frequently added and removed. -The goal of most component sets in Royale is