Jenkins build is back to normal : royale-asjs_MXTests #284

2018-12-19 Thread apacheroyaleci
See

Re: Need to clean

2018-12-19 Thread Alex Harui
It might just be me, but after fixing the circular dependency issue, I'm getting repeatable builds. It makes some sense in that the fix reduces the amount of mucking with the dependency lists. Let me know if you still see differences and we'll see if we can figure out why. -Alex On

Build failed in Jenkins: royale-compiler #629

2018-12-19 Thread apacheroyaleci
See Changes: [aharui] emit better message if not optimizing or there were errors [aharui] report circular dependencies in graph. handle static initializers by

Build failed in Jenkins: royale-asjs_MXTests #283

2018-12-19 Thread apacheroyaleci
See Changes: [aharui] need {locale} in source-path for resources to output bundles with the -- [...truncated 2.48 MB...] [mxmlc]

Build failed in Jenkins: royale-asjs_MXTests #282

2018-12-19 Thread apacheroyaleci
See Changes: [aharui] update test to include source bundles -- [...truncated 2.48 MB...] [mxmlc]

Re: DragEvent.clientY

2018-12-19 Thread Alex Harui
I suggest looking at the Flex code. Some of this may have been ported without considering whether it is truly needed or not. The key factor to consider is the event target and who is consuming the event. IIRC, in Flex, the event target could be something other than the source or destination

Build failed in Jenkins: royale-asjs_MXTests #281

2018-12-19 Thread apacheroyaleci
See -- [...truncated 2.41 MB...] [mxmlc] using source file:

Re: Need to clean

2018-12-19 Thread Carlos Rovira
Hi, just catching here. @Harbs the problem in TourDeJewel example is shown by running this app and all labels in menus (in the left drawer navigation menu) and also some buttons are empty? What I found, and don't know if is something related to this or not, is that recompiling TourDeJewel (or

RE: [royale-asjs] 01/04: Match DragEvent.clientX with MouseEvent.clientX

2018-12-19 Thread Yishay Weiss
This modifies Peter’s code which was committed with the comment saying it was ‘preliminary’. If there are no objections I’ll merge it by tomorrow. From: yish...@apache.org Sent: Wednesday, December 19, 2018 12:36:28 PM To: comm...@royale.apache.org Subject:

Re: Need to clean

2018-12-19 Thread Harbs
The DataBindingExample doesn’t seem to have an obvious runtime error, but there are missing requires in DataBindingExample.js and the addDependencies are different. HTH, Harbs > On Dec 19, 2018, at 10:12 AM, Harbs wrote: > > The TourDeJewel example has the problem. > > Rebuilding the debug

Re: Need to clean

2018-12-19 Thread Harbs
The TourDeJewel example has the problem. Rebuilding the debug version gets the runtime error that ApplicationBase is undefined. Rebuilding the release build results in 238 errors in the Closure Compiler. > On Dec 19, 2018, at 10:01 AM, Alex Harui wrote: > > The circular dependency issue is

Re: Need to clean

2018-12-19 Thread Alex Harui
The circular dependency issue is almost certain to affect GoogDepsWriter. It is end of my day here so I will start on those changes tomorrow. So if you can find a simple test case for your issue (it doesn't have to fail in the browser, it might be good enough that the addDependency List is

Re: Need to clean

2018-12-19 Thread Harbs
I was going to check that next. I’ll let you know what I find. > On Dec 19, 2018, at 9:25 AM, Alex Harui wrote: > > Pretty sure something will need to change in GoogDepsWriter. Don't know what > just yet. Might be best if you can come up with a simple test case.. I'm > working on a