Re: 0.9.10 Release

2023-05-04 Thread Gabe Harbs
I had some issues getting FunctionalTests to pass due to timing issues. It might not work reliably on all machines. You can probably [Ignore] the problematic one(s). Which ones fail? > On May 4, 2023, at 11:24 PM, Yishay Weiss wrote: > > The encoding issues were fixed (had to set

Re: 0.9.10 Release

2023-05-04 Thread Yishay Weiss
The encoding issues were fixed (had to set java_tool_options on CI server). After running the approval script however I noticed I did not update releasemgr/RELEASE_NOTES. Also, there is a unit test fail: Suite: flexUnitTests.FunctionalTests Tests run: 4, Failures: 1, Errors: 0, Skipped: 0,

Re: Player Global

2023-05-04 Thread Josh Tynjala
When you build royale-asjs, make two changes. 1) Don't set PLAYERLGLOBAL_HOME or AIR_HOME in your environment variables (or in env.properties, if you use that instead). PLAYERGLOBAL_HOME would normally point to that "player" folder that you rsync, but we don't want that. 2) Add

Re: Player Global

2023-05-04 Thread Gabe Harbs
This went over my head a bit. Currently, when I build Royale (withs wf support), I rsync a “player” folder which has playerglobal.swc into frameworks/libs to allow it to be used for compiling applications. I’m looking to get rid of that step and I’m not sure how we can facilitate that. Harbs

Re: Player Global

2023-05-04 Thread Josh Tynjala
There's a swf.distribution Ant property that normally gets managed automatically. It get set to true when AIR_HOME is available, and false when AIR_HOME is not available. The availability of AIR_HOME (and PLAYERGLOBAL_HOME) is normally how the Ant build determines that it needs to build a SWF/JS

Re: Mac M2 performance

2023-05-04 Thread Gabe Harbs
And the frameworks without tests (i.e. ant -Dskip-tests=true) took: Total time: 3 minutes 1 second > On May 4, 2023, at 10:53 AM, Gabe Harbs wrote: > > My Intel laptop fell and my screen broke. That was my impetus to buy a new > MacBook Pro. I just bought an M2 MacBook Pro and I figured I’d

Mac M2 performance

2023-05-04 Thread Gabe Harbs
My Intel laptop fell and my screen broke. That was my impetus to buy a new MacBook Pro. I just bought an M2 MacBook Pro and I figured I’d profile compiling Royale. Here’s what I got: A full compile of Royale including the compiler (i.e. ant all) took: Total time: 6 minutes 52 seconds A

Player Global

2023-05-04 Thread Gabe Harbs
What’s the status to compiling player global? I remember Josh doing work on creating our own version of player global so we wouldn’t have to rely on the downloads from Adobe. It does not seem to be added as part of the build process. Is there a reason why not? Thanks, Harbs