Re: [DISCUSS] Discuss Release Apache Royale 0.9.8 RC6

2021-08-25 Thread Piotr Zarzycki
Hi Guys, I have one small change, not related with any issue. I would like to make some methods protected in Jewel AlertView - Anyone would be against it ? I will push the changes, but I wanted to let you know that I can revert it at any time. Thanks, Piotr pon., 23 sie 2021 o 23:04 Greg Dove

Re: [DISCUSS] Discuss Release Apache Royale 0.9.8 RC6

2021-08-23 Thread Greg Dove
Sorry I should have followed up here yesterday. Thanks for confirming that Yishay. I pushed changes via dev to the 3 repos yesterday. I don't really know the release workflow, but I think (after my attempts to get familiar with it) that this is the way to fix the things that I raised. Can

Re: [DISCUSS] Discuss Release Apache Royale 0.9.8 RC6

2021-08-22 Thread Yishay Weiss
In the past we used to make changes to release and merge those into dev after releasing. This has the benefit of protecting the release from untested changes in dev and theoretically saving some time as some of the previous release steps can be re-used. Since there hasn't been a lot of

Re: [DISCUSS] Discuss Release Apache Royale 0.9.8 RC6

2021-08-21 Thread Greg Dove
I have made changes locally which I believe address the things I was concerned about. Can someone please advise : should these changes be pushed to the 0.9.8 release branch or to develop? I think it is supposed to be the release branch, and they will later be merged back to develop, but I just

Re: [DISCUSS] Discuss Release Apache Royale 0.9.8 RC6

2021-08-18 Thread Piotr Zarzycki
Hi Josh, Thanks for explanation. My expectation was just that if I run approval script with switch for JS only tests - I would get JS only binaries after final build. - This is not a blocker but everyone need to be aware that build producing JS-SWF version. wt., 17 sie 2021 o 18:46 Josh Tynjala

Re: [DISCUSS] Discuss Release Apache Royale 0.9.8 RC6

2021-08-18 Thread Piotr Zarzycki
Good catch Greg. +1 for fixing this things. We have a lack of documentation in many places, let's not make it worse. śr., 18 sie 2021 o 00:00 Greg Dove napisał(a): > I have started working through the ant approval script. > > Here are some things I noted so far: > > top level RELEASE_NOTES does

Re: [DISCUSS] Discuss Release Apache Royale 0.9.8 RC6

2021-08-17 Thread Takeshita Shoichiro
2021年8月18日(水) 7:00 Greg Dove : > I have started working through the ant approval script. > > Here are some things I noted so far: > > top level RELEASE_NOTES does not mention anything about 0.9.8, only 0.9.7 > > In the past it appears there has always been some summary entry for the > latest

Re: [DISCUSS] Discuss Release Apache Royale 0.9.8 RC6

2021-08-17 Thread Greg Dove
I have started working through the ant approval script. Here are some things I noted so far: top level RELEASE_NOTES does not mention anything about 0.9.8, only 0.9.7 In the past it appears there has always been some summary entry for the latest release royale-asjs has good updates for 0.9.8

Re: [DISCUSS] Discuss Release Apache Royale 0.9.8 RC6

2021-08-17 Thread Josh Tynjala
In your screenshot, the left side looks like a JS-only distribution (except for the extra player and air directories that are there, for some reason) because frameworks/libs contains KeepsFBFromHanging.swc, while the right side looks like a JS+SWF distribution with all of the framework SWCs. It's

Re: [DISCUSS] Discuss Release Apache Royale 0.9.8 RC6

2021-08-17 Thread Piotr Zarzycki
I went trough Approval script and everything goes fine. I have even tested Maven artifacts to build our Apache Royale application - this one also went fine. I have faced some wall when I wanted to try binary distribution which was produced after build in Moonshine. When I try build Royale

Re: [DISCUSS] Discuss Release Apache Royale 0.9.8 RC6

2021-08-16 Thread Andrew Wetmore
This is great news On Mon., Aug. 16, 2021, 3:22 p.m. Josh Tynjala, wrote: > Thanks again for the hard work, Yishay! > > I ran the approval script successfully, I confirmed that the royale-asjs > works correctly for powering code intelligence in vscode-as3mxml, and I can > compile and run

Re: [DISCUSS] Discuss Release Apache Royale 0.9.8 RC6

2021-08-16 Thread Josh Tynjala
Thanks again for the hard work, Yishay! I ran the approval script successfully, I confirmed that the royale-asjs works correctly for powering code intelligence in vscode-as3mxml, and I can compile and run asconfigc for Node.js. Looks good to me. -- Josh Tynjala Bowler Hat LLC

Re: [DISCUSS] Discuss Release Apache Royale 0.9.8 RC6

2021-08-16 Thread Piotr Zarzycki
Thanks Yishay! Congrats on that!. I will start looking into it later today or tomorrow :) pon., 16 sie 2021 o 10:15 napisał(a): > This is the discussion thread. > > Thanks, > Yishay Weiss -- Piotr Zarzycki

[DISCUSS] Discuss Release Apache Royale 0.9.8 RC6

2021-08-16 Thread apacheroyaleci
This is the discussion thread. Thanks, Yishay Weiss