RE: Review PR 100

2016-10-07 Thread Meier, Caleb
I'll have a look at it this afternoon. -Original Message- From: Aaron D. Mihalik [mailto:aaron.miha...@gmail.com] Sent: Friday, October 07, 2016 11:10 AM To: dev@rya.incubator.apache.org Subject: Review PR 100 Caleb/Kevin/Puja: Can you all review Keith's Fluo update PR? [1] I'd like

Re: [DISCUSS] Path forward for release

2016-10-07 Thread Puja Valiyil
I created a pull request with #2 implemented. Any comments would be appreciated. https://github.com/apache/incubator-rya/pull/101 On Fri, Oct 7, 2016 at 11:06 AM, Puja Valiyil wrote: > Hey, > I started trying to implement #2. Give me 10 minutes and I'll push it and > you

Review PR 100

2016-10-07 Thread Aaron D. Mihalik
Caleb/Kevin/Puja: Can you all review Keith's Fluo update PR? [1] I'd like to pull it in before I perform the "optional" profile. I'm taking a look at it now, but I'd like one of you all to review it as well. --Aaron [1] https://github.com/apache/incubator-rya/pull/100

Re: [DISCUSS] Path forward for release

2016-10-07 Thread Puja Valiyil
Hey, I started trying to implement #2. Give me 10 minutes and I'll push it and you can start from there. Sorry I should have communicated that earlier in this thread. On Fri, Oct 7, 2016 at 11:01 AM, Aaron D. Mihalik wrote: > Okay, I'm going to take another shot at the

Re: [DISCUSS] Path forward for release

2016-10-07 Thread Aaron D. Mihalik
Okay, I'm going to take another shot at the "profile" solution and remove tinkerpop.rya. I'll post the PR to the dev list and give let people comment on the PR. I'll look at PR over the weekend if if there aren't any issues, I'll pull it into apache master on Sunday. --Aaron On Fri, Oct 7,

Re: [DISCUSS] Path forward for release

2016-10-07 Thread Puja Valiyil
I'm fine with that. On Fri, Oct 7, 2016 at 9:29 AM, Aaron D. Mihalik wrote: > Can we remove tinkerpop.rya? I thought that this was part of the query > based reasoning, but the inference engine / rya.sail does not have a > dependency on rinkerpop.rya. > > --Aaron > > >

Re: [DISCUSS] Path forward for release

2016-10-07 Thread Aaron D. Mihalik
Can we remove tinkerpop.rya? I thought that this was part of the query based reasoning, but the inference engine / rya.sail does not have a dependency on rinkerpop.rya. --Aaron On Fri, Oct 7, 2016 at 7:39 AM Puja Valiyil wrote: The reasoning here is not the query based

Re: [DISCUSS] Path forward for release

2016-10-07 Thread Aaron D. Mihalik
I second Puja's confusion. I've been going off this article [1] from gnu.org: """ The LGPL and Java ... The typical arrangement for Java is that each library an application uses is distributed as a separate JAR (Java Archive) file. Applications use Java's “import” functionality to access

Re: [DISCUSS] Path forward for release

2016-10-07 Thread Puja Valiyil
I don't think I follow. The source references an lgpl Api, and we are publishing binary that references it in nexus. Are you sure it's not an issue? Sent from my iPhone > On Oct 6, 2016, at 10:36 PM, Seetharam Venkatesh wrote: > > If it's a runtime dependency, you are

Re: [DISCUSS] Path forward for release

2016-10-07 Thread Puja Valiyil
The reasoning here is not the query based inference-- it is the external reasoner that runs on map reduce. I need to double check but I think the dependency is due to referencing a config Utilities class that should be in accumulo Rya not in indexer. So moving a single class to a different