Re: Review Request 33735: RocksDB TTL support

2015-05-13 Thread Naveen Somasundaram
On May 12, 2015, 6:10 p.m., Mohamed Mahmoud (El-Geish) wrote: samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala, line 77 https://reviews.apache.org/r/33735/diff/2/?file=951495#file951495line77 This kind of polymorphism should be accomplished

Re: Review Request 33735: RocksDB TTL support

2015-05-13 Thread Naveen Somasundaram
On May 7, 2015, 8:07 p.m., Yi Pan (Data Infrastructure) wrote: docs/learn/documentation/versioned/jobs/configuration-table.html, line 1010 https://reviews.apache.org/r/33735/diff/2/?file=951492#file951492line1010 question: what is the default value for ttl here? null? There is no

Re: Review Request 33735: RocksDB TTL support

2015-05-13 Thread Naveen Somasundaram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33735/ --- (Updated May 13, 2015, 11:10 p.m.) Review request for samza. Changes ---

Re: Review Request 33735: RocksDB TTL support

2015-05-13 Thread Mohamed Mahmoud (El-Geish)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33735/#review83688 ---

tkafka.common.ReplicaNotAvailableException on application logs

2015-05-13 Thread Shekar Tippur
Hello, I seem to come across a issue with replication. We have 2 nodes where Kafka and yarn run. We have enabled replication factor on Kafka (Replication factor = 2). For testing redundancy, we shutdown broker01 server. On the yarn application logs, we see the exception

Re: Review Request 34009: SAMZA-552 window store implementation

2015-05-13 Thread Yi Pan (Data Infrastructure)
On May 13, 2015, 9:56 p.m., Navina Ramesh wrote: samza-sql-core/src/main/java/org/apache/samza/sql/operators/window/FullStateTimeWindowOp.java, line 309 https://reviews.apache.org/r/34009/diff/1/?file=954292#file954292line309 There are 2 refresh method definitions - one is

Re: Review Request 34009: SAMZA-552 window store implementation

2015-05-13 Thread Navina Ramesh
On May 13, 2015, 9:56 p.m., Navina Ramesh wrote: samza-sql-core/src/test/java/org/apache/samza/task/sql/RandomWindowOperatorTask.java, line 96 https://reviews.apache.org/r/34009/diff/1/?file=954320#file954320line96 Shouldn't the window id be system generated? Yi Pan (Data

Re: tkafka.common.ReplicaNotAvailableException on application logs

2015-05-13 Thread Naveen S
Hey Shekar, Can you paste the entire stacktrace/log? Where there any other errors ? On Wed, May 13, 2015 at 6:04 PM Shekar Tippur ctip...@gmail.com wrote: Hello, I seem to come across a issue with replication. We have 2 nodes where Kafka and yarn run. We have enabled replication factor on

Re: Review Request 34011: Add support for a Graphite Metrics Reporter

2015-05-13 Thread Yan Fang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34011/#review83663 ---