Re: Review Request 46644: SAMZA-889 - Change log not working properly with In memory Store

> On May 5, 2016, 4:18 p.m., Jake Maes wrote: > > samza-api/src/main/java/org/apache/samza/storage/StorageEngine.java, line 62 > > > > > > Since there is a change to the API, we probably shouldn't commit this > > unt

Re: Review Request 46644: SAMZA-889 - Change log not working properly with In memory Store

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46644/#review132109 --- Ship it! Ship It! - Yi Pan (Data Infrastructure) On May 6, 2

Re: Review Request 47073: SAMZA-946 - ConcurrentModificationException in TaskAssignmentManager

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47073/#review132090 --- Ship it! +1 lgtm! - Navina Ramesh On May 6, 2016, 5:30 p.m.,

Review Request 47073: SAMZA-946 - ConcurrentModificationException in TaskAssignmentManager

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47073/ --- Review request for samza, Boris Shkolnik, Chris Pettitt, Jake Maes, Navina Rames

Re: Review Request 46856: SAMZA-943 Occasional test failure: TestStreamPartitionCountMonitor.testStartStopBehavior

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46856/#review132079 --- Ship it! Looks good ! +1 - Navina Ramesh On May 5, 2016, 8:4

Re: Review Request 47029: SAMZA-932 port collisions in JmxServer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47029/#review132076 --- Ship it! LGTM! Thanks! - Yi Pan (Data Infrastructure) On May

Re: Review Request 47029: SAMZA-932 port collisions in JmxServer

> On May 6, 2016, 4:27 p.m., Boris Shkolnik wrote: > > samza-core/src/main/scala/org/apache/samza/metrics/JmxServer.scala, line 92 > > > > > > Can you please add a log line, so we can know what port was chosen. see l

Re: Review Request 47029: SAMZA-932 port collisions in JmxServer

> On May 6, 2016, 4:25 p.m., Boris Shkolnik wrote: > > For my sake, can you explain why the first solution doesn't work with SSL? I've lost the link, but I found a few resources online that say the ServerPort and RegistryPort must be distinct for SSL. The deeper "why" probably requires a bette

Re: Review Request 47029: SAMZA-932 port collisions in JmxServer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47029/#review132060 --- samza-core/src/main/scala/org/apache/samza/metrics/JmxServer.scal

Re: Review Request 47029: SAMZA-932 port collisions in JmxServer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47029/#review132059 --- Ship it! For my sake, can you explain why the first solution do

Re: Review Request 46644: SAMZA-889 - Change log not working properly with In memory Store

> On May 5, 2016, 9:19 p.m., Chris Pettitt wrote: > > samza-api/src/main/java/org/apache/samza/storage/StoreProperties.java, > > lines 25-31 > > > > > > I would actually move this doc to the interface. I would imagin