Github user fredji97 closed the pull request at:
https://github.com/apache/samza/pull/73
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52168/#review169231
---
Ship it!
Ship It!
- Xinyu Liu
On Feb. 16, 2017, 6:26 a.m.,
> I am working on the ApplicationRunner SEP right now. Will send out the
discussion email once I am done.
Perfect! :)
On Thu, Mar 16, 2017 at 5:13 PM, xinyu liu wrote:
> Right, the static factory is very simple as you said. It's pretty
> convenient for the client to use.
Right, the static factory is very simple as you said. It's pretty
convenient for the client to use.
I am working on the ApplicationRunner SEP right now. Will send out the
discussion email once I am done.
Thanks,
Xinyu
On Thu, Mar 16, 2017 at 4:50 PM, Navina Ramesh (Apache)
> One minor thing I found is that the name of the config is camel case
(*processor.idGenerator.class*). Seems Samza's practice is to use all lower
case configs with "." delimiter. Do you think we should stick to this
convention?
I am always torn between the "convention" we have and the better way
The proposal looks great to me! Changing the id type to string will make
sure this can work with other types of cluster which doesn't support
integer id. The interface and config provides a pluggable way to have
different id generators for different use cases. One minor thing I found is
that the
GitHub user fredji97 opened a pull request:
https://github.com/apache/samza/pull/90
SAMZA-1143 Universal config support for localized resource
More details in https://issues.apache.org/jira/browse/SAMZA-1143
Tests: ./gradlew clean check successful and all unit tests passed
Github user fredji97 closed the pull request at:
https://github.com/apache/samza/pull/72
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user xinyuiscool opened a pull request:
https://github.com/apache/samza/pull/88
SAMZA-1131: RemoteApplicationRunner for cluster-based Samza applications
RemoteApplicationRunner starts the Samza StreamApplication on the remote
cluster, e.g. Yarn. It uses ExecutionPlanner for