[GitHub] shanthoosh commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer.

2019-02-28 Thread GitBox
shanthoosh commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer. URL: https://github.com/apache/samza/pull/918#discussion_r261468553 ## File path: samza-core/src/main/scala/org/apache/samza/system/SystemConsumers.scala

[GitHub] shanthoosh commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer.

2019-02-28 Thread GitBox
shanthoosh commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer. URL: https://github.com/apache/samza/pull/918#discussion_r261470344 ## File path: samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemConsu

[GitHub] shanthoosh commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer.

2019-02-28 Thread GitBox
shanthoosh commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer. URL: https://github.com/apache/samza/pull/918#discussion_r261470344 ## File path: samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemConsu

[GitHub] shanthoosh commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer.

2019-02-28 Thread GitBox
shanthoosh commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer. URL: https://github.com/apache/samza/pull/918#discussion_r261468553 ## File path: samza-core/src/main/scala/org/apache/samza/system/SystemConsumers.scala

[GitHub] shanthoosh commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer.

2019-02-28 Thread GitBox
shanthoosh commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer. URL: https://github.com/apache/samza/pull/918#discussion_r261470344 ## File path: samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemConsu

[GitHub] shanthoosh commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer.

2019-02-28 Thread GitBox
shanthoosh commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer. URL: https://github.com/apache/samza/pull/918#discussion_r258333602 ## File path: samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemConsu

[GitHub] shanthoosh commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer.

2019-02-28 Thread GitBox
shanthoosh commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer. URL: https://github.com/apache/samza/pull/918#discussion_r258333559 ## File path: samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemConsu

[GitHub] shanthoosh merged pull request #933: SAMZA-2071: Skip StartpointManager instantiation for PassThroughCoordinator.

2019-02-28 Thread GitBox
shanthoosh merged pull request #933: SAMZA-2071: Skip StartpointManager instantiation for PassThroughCoordinator. URL: https://github.com/apache/samza/pull/933 This is an automated message from the Apache Git Service. To res

Re: "send to" ordering is inconsistent

2019-02-28 Thread Tom Davis
Thanks, Prateek! Yes, the workaround will be fine for the time being. Thank you again! Prateek Maheshwari writes: Hi Tom, Thanks for reporting this. I created a ticket (SAMZA-2116 ) to make the required API changes. We'll include this in the n

[GitHub] cameronlee314 commented on a change in pull request #934: SAMZA-1935 : Refactor TaskContextImpl to not include access to objects that are only used internally

2019-02-28 Thread GitBox
cameronlee314 commented on a change in pull request #934: SAMZA-1935 : Refactor TaskContextImpl to not include access to objects that are only used internally URL: https://github.com/apache/samza/pull/934#discussion_r261355612 ## File path: samza-core/src/main/java/org/apache/samza

[GitHub] cameronlee314 commented on a change in pull request #934: SAMZA-1935 : Refactor TaskContextImpl to not include access to objects that are only used internally

2019-02-28 Thread GitBox
cameronlee314 commented on a change in pull request #934: SAMZA-1935 : Refactor TaskContextImpl to not include access to objects that are only used internally URL: https://github.com/apache/samza/pull/934#discussion_r261361532 ## File path: samza-core/src/test/java/org/apache/samza

[GitHub] cameronlee314 commented on a change in pull request #934: SAMZA-1935 : Refactor TaskContextImpl to not include access to objects that are only used internally

2019-02-28 Thread GitBox
cameronlee314 commented on a change in pull request #934: SAMZA-1935 : Refactor TaskContextImpl to not include access to objects that are only used internally URL: https://github.com/apache/samza/pull/934#discussion_r261360838 ## File path: samza-core/src/test/java/org/apache/samza

[GitHub] cameronlee314 commented on a change in pull request #934: SAMZA-1935 : Refactor TaskContextImpl to not include access to objects that are only used internally

2019-02-28 Thread GitBox
cameronlee314 commented on a change in pull request #934: SAMZA-1935 : Refactor TaskContextImpl to not include access to objects that are only used internally URL: https://github.com/apache/samza/pull/934#discussion_r261355687 ## File path: samza-core/src/main/java/org/apache/samza

[GitHub] cameronlee314 commented on a change in pull request #934: SAMZA-1935 : Refactor TaskContextImpl to not include access to objects that are only used internally

2019-02-28 Thread GitBox
cameronlee314 commented on a change in pull request #934: SAMZA-1935 : Refactor TaskContextImpl to not include access to objects that are only used internally URL: https://github.com/apache/samza/pull/934#discussion_r261360267 ## File path: samza-core/src/main/java/org/apache/samza

[GitHub] cameronlee314 commented on a change in pull request #934: SAMZA-1935 : Refactor TaskContextImpl to not include access to objects that are only used internally

2019-02-28 Thread GitBox
cameronlee314 commented on a change in pull request #934: SAMZA-1935 : Refactor TaskContextImpl to not include access to objects that are only used internally URL: https://github.com/apache/samza/pull/934#discussion_r261362340 ## File path: samza-core/src/test/java/org/apache/samza

Re: "send to" ordering is inconsistent

2019-02-28 Thread Prateek Maheshwari
Hi Tom, Thanks for reporting this. I created a ticket (SAMZA-2116 ) to make the required API changes. We'll include this in the next Samza release, which should be mid to late next month. In the mean time, the workaround would be to keep all of th