Review Request 41884: SAMZA-802: KafkaSystemAdmin needs to handle empty topic offsets

2016-01-04 Thread Aleksandar Pejakovic
to prevent NullPointerException. Diffs - samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemAdmin.scala 9dc436a Diff: https://reviews.apache.org/r/41884/diff/ Testing --- Thanks, Aleksandar Pejakovic

Review Request 40485: SAMZA-767 yarn.queue option is not used anywhere

2015-11-19 Thread Aleksandar Pejakovic
/yarn/YarnJob.scala 02f46a1 Diff: https://reviews.apache.org/r/40485/diff/ Testing --- Thanks, Aleksandar Pejakovic

Review Request 39433: SAMZA-795: Fix getMax() error in Shanpshot

2015-10-19 Thread Aleksandar Pejakovic
: ``` this.size = values.size(); ``` to: ``` this.size = this.values.size(); ``` Diffs - samza-api/src/main/java/org/apache/samza/metrics/Snapshot.java 4c7b525 Diff: https://reviews.apache.org/r/39433/diff/ Testing --- Thanks, Aleksandar Pejakovic

Re: Review Request 38807: SAMZA-338 Support metrics report via STDOUT

2015-10-06 Thread Aleksandar Pejakovic
Diff: https://reviews.apache.org/r/38807/diff/ Testing (updated) --- Tested with hello-samza, works like a charm. Thanks, Aleksandar Pejakovic

Review Request 39045: SAMZA-782: Update all tutorial pages for 0.9.1

2015-10-06 Thread Aleksandar Pejakovic
-node-yarn.md 312efaf Diff: https://reviews.apache.org/r/39045/diff/ Testing --- Thanks, Aleksandar Pejakovic

Review Request 38949: SAMZA-341: Support metrics report via Ganglia

2015-10-02 Thread Aleksandar Pejakovic
--- Hello-samza support for Ganglia metric. Diffs - pom.xml 86148ef src/main/assembly/src.xml f57fee2 Diff: https://reviews.apache.org/r/38949/diff/ Testing --- Thanks, Aleksandar Pejakovic

Review Request 38898: SAMZA-781: Upgrade SAMZA to YARN 2.6.1

2015-09-30 Thread Aleksandar Pejakovic
--- Upgraded hello-samza to work with yarn 2.6.1. Diffs - bin/grid 8deb76e pom.xml 9804267 Diff: https://reviews.apache.org/r/38898/diff/ Testing --- Thanks, Aleksandar Pejakovic

Review Request 38897: SAMZA-781: Upgrade SAMZA to YARN 2.6.1

2015-09-30 Thread Aleksandar Pejakovic
/python/configs/yarn.json b1492bf Diff: https://reviews.apache.org/r/38897/diff/ Testing --- Thanks, Aleksandar Pejakovic

Re: Review Request 38807: SAMZA-338 Support metrics report via STDOUT

2015-09-29 Thread Aleksandar Pejakovic
/SamzaConsoleReporter.java PRE-CREATION Diff: https://reviews.apache.org/r/38807/diff/ Testing --- Thanks, Aleksandar Pejakovic

Review Request 38485: SAMZA-683 add meter and histogram support in the metrics reporter

2015-09-18 Thread Aleksandar Pejakovic
/38485/diff/ Testing --- Thanks, Aleksandar Pejakovic

Review Request 38296: SAMZA-341: Support metrics report via Ganglia

2015-09-11 Thread Aleksandar Pejakovic
PRE-CREATION settings.gradle 4c1aa10 Diff: https://reviews.apache.org/r/38296/diff/ Testing --- Thanks, Aleksandar Pejakovic

Review Request 37942: SAMZA-766 Fix broken links in samza-container.html

2015-08-31 Thread Aleksandar Pejakovic
/ Testing --- Thanks, Aleksandar Pejakovic

Review Request 37843: SAMZA-764 Change java version in hello-samza

2015-08-27 Thread Aleksandar Pejakovic
--- Changed version of hello-samza to follow samza. Diffs - pom.xml 0e3bf5f Diff: https://reviews.apache.org/r/37843/diff/ Testing --- Thanks, Aleksandar Pejakovic

Review Request 37796: SAMZA-763 Organise imports in scala packages

2015-08-26 Thread Aleksandar Pejakovic
://reviews.apache.org/r/37796/diff/ Testing --- Thanks, Aleksandar Pejakovic

Re: Review Request 36727: SAMZA-563 Upgrade Samza to YARN 2.6.0

2015-08-21 Thread Aleksandar Pejakovic
/TestSamzaAppMasterTaskManager.scala 1e936b4 Diff: https://reviews.apache.org/r/36727/diff/ Testing (updated) --- Changed samza-yarn - TestSamzaAppMaster - testAppMasterShouldReboot, now all tests pass. Thanks, Aleksandar Pejakovic

Re: Review Request 36728: HELLO-SAMZA-563 Upgrade Samza to YARN 2.6.0

2015-08-21 Thread Aleksandar Pejakovic
ran nicely. Thanks, Aleksandar Pejakovic

Re: Review Request 37528: SAMZA-736 BrokerProxy will stuck in infinite loop if consumer.fetch throws OOME

2015-08-21 Thread Aleksandar Pejakovic
/BrokerProxy.scala 614f33f samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestBrokerProxy.scala e285dec Diff: https://reviews.apache.org/r/37528/diff/ Testing --- Thanks, Aleksandar Pejakovic

Re: Review Request 37642: SAMZA-695 Update the StreamAppender doc

2015-08-21 Thread Aleksandar Pejakovic
--- Fixed patch Repository: samza Description (updated) --- Added requested param to logging.md - fixed Diffs (updated) - docs/learn/documentation/versioned/jobs/logging.md d1b372c Diff: https://reviews.apache.org/r/37642/diff/ Testing --- Thanks, Aleksandar Pejakovic

Re: Review Request 37528: SAMZA-736 BrokerProxy will stuck in infinite loop if consumer.fetch throws OOME

2015-08-19 Thread Aleksandar Pejakovic
/apache/samza/system/kafka/BrokerProxy.scala 614f33f samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestBrokerProxy.scala e285dec Diff: https://reviews.apache.org/r/37528/diff/ Testing --- Thanks, Aleksandar Pejakovic

Re: Review Request 37528: SAMZA-736 BrokerProxy will stuck in infinite loop if consumer.fetch throws OOME

2015-08-18 Thread Aleksandar Pejakovic
/samza/system/kafka/BrokerProxy.scala 614f33f samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestBrokerProxy.scala e285dec Diff: https://reviews.apache.org/r/37528/diff/ Testing --- Thanks, Aleksandar Pejakovic

Review Request 37528: SAMZA-736 BrokerProxy will stuck in infinite loop if consumer.fetch throws OOME

2015-08-17 Thread Aleksandar Pejakovic
--- Thanks, Aleksandar Pejakovic

I have a problem with Samza and YARN

2015-08-06 Thread Aleksandar Pejakovic
Hi all, I have problem with YARN 2.6.0. For this patch: https://issues.apache.org/jira/browse/SAMZA-563 i tried to change samza with hello-samza to work on YARN 2.6.0. All tests in samza pass nicely but when i try to run bin/grid bootstrap from hello-samza there are some problems with

Re: Review Request 37069: SAMZA-738 Samza Timer based metrics does not have enough precision

2015-08-05 Thread Aleksandar Pejakovic
, Aleksandar Pejakovic

Review Request 37069: SAMZA-738 Samza Timer based metrics does not have enough precision

2015-08-04 Thread Aleksandar Pejakovic
:5130.901534393375, send-calls:0, process-calls:57283, choose-ns:10368839.818551894, process-ns:10390588.194071393, event-loop-utilization:0.99807554 } ``` Thanks, Aleksandar Pejakovic

Re: Review Request 37069: SAMZA-738 Samza Timer based metrics does not have enough precision

2015-08-04 Thread Aleksandar Pejakovic
-envelopes:56292, process-envelopes:989, window-calls:0, commit-ns:5130.901534393375, send-calls:0, process-calls:57283, choose-ns:10368839.818551894, process-ns:10390588.194071393, event-loop-utilization:0.99807554 } ``` Thanks, Aleksandar Pejakovic

Re: Review Request 36727: SAMZA-563 Upgrade Samza to YARN 2.6.0

2015-07-29 Thread Aleksandar Pejakovic
works just fine. Tried hello-samza, works fine. Thanks, Aleksandar Pejakovic

Review Request 36769: SAMZA-742 Add a Contribution section in README of samza and hello-samza

2015-07-24 Thread Aleksandar Pejakovic
Contribution section to README Diffs - README.md f83fd41 Diff: https://reviews.apache.org/r/36769/diff/ Testing --- Thanks, Aleksandar Pejakovic

Review Request 36770: SAMZA-742 Add a Contribution section in README of samza and hello-samza

2015-07-24 Thread Aleksandar Pejakovic
--- Hello Samza: added Contribution section to README Diffs - README.md 14bf45e Diff: https://reviews.apache.org/r/36770/diff/ Testing --- Thanks, Aleksandar Pejakovic

Review Request 36728: HELLO-SAMZA-563 Upgrade Samza to YARN 2.6.0

2015-07-23 Thread Aleksandar Pejakovic
--- Changed version of hadoop-yarn. Diffs - bin/grid 3d0e66e pom.xml f9c4fa9 Diff: https://reviews.apache.org/r/36728/diff/ Testing --- Tried all three jobs, they all ran nicely. Thanks, Aleksandar Pejakovic

Review Request 36641: SAMZA-739 Change version of hello-samza in SAMZA tutorials/latest

2015-07-21 Thread Aleksandar Pejakovic
/tutorials/versioned/run-in-multi-node-yarn.md 312efaf Diff: https://reviews.apache.org/r/36641/diff/ Testing --- Thanks, Aleksandar Pejakovic

Review Request 36507: SAMZA-734 Remove redundant Dashboard

2015-07-15 Thread Aleksandar Pejakovic
/versioned/jobs/configuration-table.html cd7ea8d docs/learn/documentation/versioned/yarn/application-master.md d20aece Diff: https://reviews.apache.org/r/36507/diff/ Testing --- Thanks, Aleksandar Pejakovic

Re: Review Request 35644: SAMZA-718 Update links in README.md

2015-06-20 Thread Aleksandar Pejakovic
/35644/diff/ Testing --- Thanks, Aleksandar Pejakovic

Review Request 35644: SAMZA-718 Update links in README.md

2015-06-19 Thread Aleksandar Pejakovic
--- Changed links from: http://samza.apache.org/startup/hello-samza/0.8/ to http://samza.apache.org/startup/hello-samza/latest/ Diffs - README.md 4463454 Diff: https://reviews.apache.org/r/35644/diff/ Testing --- Thanks, Aleksandar Pejakovic

Review Request 35598: SAMZA-563 Upgrade Hello - Samza to YARN 2.6.0

2015-06-18 Thread Aleksandar Pejakovic
--- Changed bin/grid script and pom.xml file in samza-hello-samza to use hadoop 2.6.0 instead of 2.4.0. Diffs - bin/grid a639ade pom.xml 0e3bf5f Diff: https://reviews.apache.org/r/35598/diff/ Testing --- Thanks, Aleksandar Pejakovic

Review Request 35115: SAMZA-474 check-all script should fail more gracefully in the absence of gradlew

2015-06-05 Thread Aleksandar Pejakovic
for issue [SAMZA-474](https://issues.apache.org/jira/browse/SAMZA-474) added check search for gradlew, if not present it will use currently installed gradle. Diffs - bin/check-all.sh 0725b82 Diff: https://reviews.apache.org/r/35115/diff/ Testing --- Thanks, Aleksandar