> On May 12, 2015, 6:10 p.m., Mohamed Mahmoud (El-Geish) wrote:
> > samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala,
> > line 77
> > <https://reviews.apache.org/r/33735/diff/2/?file=951495#file951495line77>
> >
> >
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33735/#review83856
---
Ship it!
Ship It!
- Mohamed Mahmoud (El-Geish)
On May 13, 2015
> On May 12, 2015, 6:10 p.m., Mohamed Mahmoud (El-Geish) wrote:
> > samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala,
> > line 77
> > <https://reviews.apache.org/r/33735/diff/2/?file=951495#file951495line77>
> >
> >
/RocksDbKeyValueStore.scala
<https://reviews.apache.org/r/33735/#comment134726>
floor vs. round -- thoughts?
- Mohamed Mahmoud (El-Geish)
On May 13, 2015, 11:10 p.m., Naveen Somasundaram wrote:
>
> ---
> This is an automatica
to query RocksDB
to check whether or not the desired options were used when the DB was opened?
- Mohamed Mahmoud (El-Geish)
On May 6, 2015, 8:55 p.m., Naveen Somasundaram wrote:
>
> ---
> This is an automatically generated e-mail
perf test is warming
up)
C- This test hits the RocksDB APIs directly
- Mohamed
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33146/#review82429
-------------------
est/src/test/scala/org/apache/samza/storage/kv/TestKeyValueStores.scala
50dfc10bb053d74dba70fdbce0ef87609ba447ea
Diff: https://reviews.apache.org/r/33146/diff/
Testing
---
Unit-tested.
Thanks,
Mohamed Mahmoud (El-Geish)
he.org/r/33146/diff/
Testing
---
Unit-tested.
Thanks,
Mohamed Mahmoud (El-Geish)
dding perf testing and removing some
unneeded changes) are still valid, so please take a look at them and provide
feedback. Thanks!
- Mohamed Mahmoud (El-Geish)
On April 28, 2015, 10:50 a.m., Mohamed Mahmoud (El-Geish) wrote:
>
>
e0ef87609ba447ea
Diff: https://reviews.apache.org/r/33146/diff/
Testing
---
Unit-tested.
Thanks,
Mohamed Mahmoud (El-Geish)
storage/kv/TestKeyValueStores.scala
50dfc10bb053d74dba70fdbce0ef87609ba447ea
Diff: https://reviews.apache.org/r/33146/diff/
Testing
---
Unit-tested.
Thanks,
Mohamed Mahmoud (El-Geish)
/SerializedKeyValueStore.scala
<https://reviews.apache.org/r/33146/#comment132238>
This was the offending change that caused check-all.sh to fail. I reverted
it.
- Mohamed Mahmoud (El-Geish)
On April 24, 2015, 4:59 p.m., Mohamed Mahmoud (El-Geish)
mail. To reply, visit:
https://reviews.apache.org/r/33146/#review81497
---
On April 24, 2015, 4:59 p.m., Mohamed Mahmoud (El-Geish) wrote:
>
> ---
> This is an automatical
a70fdbce0ef87609ba447ea
Diff: https://reviews.apache.org/r/33146/diff/
Testing
---
Unit-tested.
Thanks,
Mohamed Mahmoud (El-Geish)
view81381
---
On April 23, 2015, 7:44 a.m., Mohamed Mahmoud (El-Geish) wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
matically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33146/#review81351
-----------
On April 23, 2015, 7:44 a.m., Mohamed Mahmoud (El-Geish) wrote:
>
> ---
>
a Infrastructure) wrote:
> > samza-test/src/test/scala/org/apache/samza/storage/kv/TestKeyValueStores.scala,
> > line 133
> > <https://reviews.apache.org/r/33146/diff/2/?file=931574#file931574line133>
> >
> > nit: prefer not to re-order the methods if not necessary.
8d1aea14ecea47bbadb24936f737feedb39
samza-test/src/test/scala/org/apache/samza/storage/kv/TestKeyValueStores.scala
50dfc10bb053d74dba70fdbce0ef87609ba447ea
Diff: https://reviews.apache.org/r/33146/diff/
Testing
---
Unit-tested.
Thanks,
Mohamed Mahmoud (El-Geish)
- Mohamed
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33146/#review80036
---
On April 16, 2015, 10:43 a.m., Mohamed Mahmoud (
---------------
On April 16, 2015, 10:43 a.m., Mohamed Mahmoud (El-Geish) wrote:
>
> ---
> This is an automatically ge
ail. To reply, visit:
https://reviews.apache.org/r/33146/#review80110
---------------
On April 16, 2015, 10:43 a.m., Mohamed Mahmoud (El-Geish) wrote:
>
> ---
> This is an automat
---
Unit-tested.
Thanks,
Mohamed Mahmoud (El-Geish)
/TestKeyValueStores.scala
50dfc10bb053d74dba70fdbce0ef87609ba447ea
Diff: https://reviews.apache.org/r/33146/diff/
Testing
---
Unit-tested.
Thanks,
Mohamed Mahmoud (El-Geish)
://reviews.apache.org/r/32860/diff/
Testing
---
Unit tests.
Thanks,
Mohamed Mahmoud (El-Geish)
24 matches
Mail list logo
