Re: Review Request 33735: RocksDB TTL support

> On May 12, 2015, 6:10 p.m., Mohamed Mahmoud (El-Geish) wrote: > > samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala, > > line 77 > > > > > > This kind of polymorphism should be ac

Re: Review Request 33735: RocksDB TTL support

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33735/#review83856 --- Ship it! Ship It! - Mohamed Mahmoud (El-Geish) On May 13, 2015,

Re: Review Request 33735: RocksDB TTL support

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33735/#review83847 --- Ship it! Ship It! - Yi Pan (Data Infrastructure) On May 13, 2015

Re: Review Request 33735: RocksDB TTL support

> On May 12, 2015, 6:10 p.m., Mohamed Mahmoud (El-Geish) wrote: > > samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala, > > line 77 > > > > > > This kind of polymorphism should be ac

Re: Review Request 33735: RocksDB TTL support

> On May 12, 2015, 6:10 p.m., Mohamed Mahmoud (El-Geish) wrote: > > samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala, > > line 77 > > > > > > This kind of polymorphism should be ac

Re: Review Request 33735: RocksDB TTL support

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33735/#review83688 --- samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDb

Re: Review Request 33735: RocksDB TTL support

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33735/ --- (Updated May 13, 2015, 11:10 p.m.) Review request for samza. Changes ---

Re: Review Request 33735: RocksDB TTL support

> On May 7, 2015, 8:07 p.m., Yi Pan (Data Infrastructure) wrote: > > docs/learn/documentation/versioned/jobs/configuration-table.html, line 1010 > > > > > > question: what is the default value for ttl here? null? The

Re: Review Request 33735: RocksDB TTL support

> On May 12, 2015, 6:10 p.m., Mohamed Mahmoud (El-Geish) wrote: > > samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala, > > line 77 > > > > > > This kind of polymorphism should be ac

Re: Review Request 33735: RocksDB TTL support

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33735/#review83438 --- docs/learn/documentation/versioned/jobs/configuration-table.html

Re: Review Request 33735: RocksDB TTL support

> On May 7, 2015, 8:07 p.m., Yi Pan (Data Infrastructure) wrote: > > samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala, > > line 94 > > > > > > It would be nicer to try catch the ex

Re: Review Request 33735: RocksDB TTL support

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33735/#review82877 --- docs/learn/documentation/versioned/jobs/configuration-table.html

Re: Review Request 33735: RocksDB TTL support

> On May 1, 2015, 6:27 a.m., Yan Fang wrote: > > docs/learn/documentation/versioned/jobs/configuration-table.html, lines > > 1009-1010 > > > > > > why do we remove the bloomfilter? > > Naveen Somasundaram wrote: >

Re: Review Request 33735: RocksDB TTL support

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33735/#review82615 --- samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDb

Re: Review Request 33735: RocksDB TTL support

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33735/ --- (Updated May 6, 2015, 8:55 p.m.) Review request for samza. Repository: samza

Re: Review Request 33735: RocksDB TTL support

> On May 1, 2015, 6:27 a.m., Yan Fang wrote: > > build.gradle, line 34 > > > > > > remember to remove the space. :) I have published it to maven, getting rid of this :) > On May 1, 2015, 6:27 a.m., Yan Fang wrote: >

Re: Review Request 33735: RocksDB TTL support

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33735/#review82237 --- build.gradle

Review Request 33735: RocksDB TTL support

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33735/ --- Review request for samza. Repository: samza Description --- RocksDB TTL