Re: Review Request 52476: SAMZA-1083 : Do not load task store which are older than delete tombstones.

> On Feb. 8, 2017, 10:06 p.m., Prateek Maheshwari wrote: > > samza-core/src/main/scala/org/apache/samza/storage/TaskStorageManager.scala, > > line 196 > > > > > > s/in the store/for the store. Fixed. > On Feb. 8,

Re: Review Request 52476: SAMZA-1083 : Do not load task store which are older than delete tombstones.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52476/#review164786 --- Fix it, then Ship it! LGTM, thanks. Few code style/documentatio

Re: Review Request 52476: SAMZA-1083 : Do not load task store which are older than delete tombstones.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52476/#review164782 --- Ship it! Ship It! - Jake Maes On Feb. 8, 2017, 9:37 p.m., Sh

Re: Review Request 52476: SAMZA-1083 : Do not load task store which are older than delete tombstones.

> On Feb. 8, 2017, 8:43 p.m., Jake Maes wrote: > > samza-core/src/main/scala/org/apache/samza/storage/TaskStorageManager.scala, > > line 177 > > > > > > Looks like this log statement belongs in an else-block. It s

Re: Review Request 52476: SAMZA-1083 : Do not load task store which are older than delete tombstones.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52476/ --- (Updated Feb. 8, 2017, 9:37 p.m.) Review request for samza. Repository: samza

Re: Review Request 52476: SAMZA-1083 : Do not load task store which are older than delete tombstones.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52476/#review164765 --- samza-core/src/main/scala/org/apache/samza/storage/TaskStorageMan

Re: Review Request 52476: SAMZA-1083 : Do not load task store which are older than delete tombstones.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52476/ --- (Updated Feb. 8, 2017, 8 p.m.) Review request for samza. Repository: samza

Re: Review Request 52476: SAMZA-1083 : Do not load task store which are older than delete tombstones.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52476/#review164749 --- samza-core/src/main/scala/org/apache/samza/config/StorageConfig.s

Re: Review Request 52476: SAMZA-1083 : Do not load task store which are older than delete tombstones.

> On Feb. 8, 2017, 5:17 p.m., Jake Maes wrote: > > samza-core/src/main/scala/org/apache/samza/config/StorageConfig.scala, line > > 33 > > > > > > nit: TimeUnit.DAYS.toMillis(1) Fixed. - Shanthoosh --

Re: Review Request 52476: SAMZA-1083 : Do not load task store which are older than delete tombstones.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52476/ --- (Updated Feb. 8, 2017, 7:09 p.m.) Review request for samza. Summary (updated)