[GitHub] [sedona] jiayuasu commented on pull request #868: [SEDONA-300] Add ST_HausdorffDistance

2023-06-22 Thread via GitHub
jiayuasu commented on PR #868: URL: https://github.com/apache/sedona/pull/868#issuecomment-1603668375 @iGN5117 Please resolve the conflicts. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [sedona] jiayuasu merged pull request #863: [SEDONA-213] Add ST_BoundingDiagonal

2023-06-22 Thread via GitHub
jiayuasu merged PR #863: URL: https://github.com/apache/sedona/pull/863 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sedona.apache.or

[GitHub] [sedona] iGN5117 opened a new pull request, #869: [SEDONA-299] Add ST_FrechetDistance

2023-06-22 Thread via GitHub
iGN5117 opened a new pull request, #869: URL: https://github.com/apache/sedona/pull/869 ## Did you read the Contributor Guide? - Yes, I have read [Contributor Rules](https://sedona.apache.org/latest-snapshot/community/rule/) and [Contributor Development Guide](https://sedona.apa

[GitHub] [sedona] iGN5117 commented on pull request #867: [SEDONA-237] Add ST_Dimension

2023-06-22 Thread via GitHub
iGN5117 commented on PR #867: URL: https://github.com/apache/sedona/pull/867#issuecomment-1603308914 Additionally, I noticed that your PR description does not have anything in the "How was this PR tested". Please fill that section too. Example PR: https://github.com/apache/sedona/pull

[GitHub] [sedona] iGN5117 opened a new pull request, #868: [SEDONA-300] Add ST_HausdorffDistance

2023-06-22 Thread via GitHub
iGN5117 opened a new pull request, #868: URL: https://github.com/apache/sedona/pull/868 ## Did you read the Contributor Guide? - Yes, I have read [Contributor Rules](https://sedona.apache.org/latest-snapshot/community/rule/) and [Contributor Development Guide](https://sedona.apa

[GitHub] [sedona] kartikeyhadiya commented on pull request #843: [SEDONA-285] Added docker images for spark-sedona-zeppelin and spark-sedona-jupyterlab

2023-06-22 Thread via GitHub
kartikeyhadiya commented on PR #843: URL: https://github.com/apache/sedona/pull/843#issuecomment-1603120817 Hey, @jiayuasu sorry for so much delay had a busy month at work. - I have made all the changes you proposed, please can you have a look. I didn't make github action for zeppelin do

[GitHub] [sedona] iGN5117 commented on a diff in pull request #867: [SEDONA-237] Add ST_Dimension

2023-06-22 Thread via GitHub
iGN5117 commented on code in PR #867: URL: https://github.com/apache/sedona/pull/867#discussion_r1238838501 ## common/src/test/java/org/apache/sedona/common/FunctionsTest.java: ## @@ -268,6 +268,38 @@ public void splitHeterogeneousGeometryCollection() { assertNull(actua

[GitHub] [sedona] yyy1000 commented on a diff in pull request #867: [SEDONA-237] Add ST_Dimension

2023-06-22 Thread via GitHub
yyy1000 commented on code in PR #867: URL: https://github.com/apache/sedona/pull/867#discussion_r1238495121 ## docs/api/sql/Function.md: ## @@ -400,6 +400,20 @@ Result: POLYGON ((0 -3, -3 -3, -3 3, 0 3, 0 -3)) ``` +## ST_Dimension + +Introduction: Return the topological dime

Re: [VOTE] Release Apache Sedona 1.4.1-rc1

2023-06-22 Thread Mo Sarwat
+1 * Download links are valid * Checksums and PGP signatures are valid * NOTICE is included * Source code artifacts have correct names matching the current release * The project can compile from the source code On Tue, Jun 20, 2023 at 10:10 PM Kristin Cowalcijk wrote: > Hi all, > > This is a ca

Re: [VOTE] Release Apache Sedona 1.4.1-rc1

2023-06-22 Thread Jia Yu
Great work, Krstin! +1, binding I checked: * Download links are valid * Checksums and PGP signatures are valid * NOTICE is included * Source code artifacts have correct names matching the current release * The project can compile from the source code On Tue, Jun 20, 2023 at 7:10 PM Kristin Cowal

[GitHub] [sedona] jiayuasu commented on a diff in pull request #867: [SEDONA-237] Add ST_Dimension

2023-06-22 Thread via GitHub
jiayuasu commented on code in PR #867: URL: https://github.com/apache/sedona/pull/867#discussion_r1238163200 ## docs/api/sql/Function.md: ## @@ -400,6 +400,20 @@ Result: POLYGON ((0 -3, -3 -3, -3 3, 0 3, 0 -3)) ``` +## ST_Dimension + +Introduction: Return the topological dim

[GitHub] [sedona] jiayuasu commented on a diff in pull request #867: [SEDONA-237] Add ST_Dimension

2023-06-22 Thread via GitHub
jiayuasu commented on code in PR #867: URL: https://github.com/apache/sedona/pull/867#discussion_r1238160222 ## docs/api/sql/Function.md: ## @@ -400,6 +400,20 @@ Result: POLYGON ((0 -3, -3 -3, -3 3, 0 3, 0 -3)) ``` +## ST_Dimension + +Introduction: Return the topological dim