[GitHub] [incubator-sedona] Imbruced commented on pull request #482: [SEDONA-1] Move to jts 1.16.1

2020-09-08 Thread GitBox
Imbruced commented on pull request #482: URL: https://github.com/apache/incubator-sedona/pull/482#issuecomment-689139826 @nirnir93 I added comments, one file had changes so I added comment within. For 3 python files I can not find appropriate place so I put changes on top of Pr changed fil

[GitHub] [incubator-sedona] Imbruced commented on pull request #482: [SEDONA-1] Move to jts 1.16.1

2020-09-08 Thread GitBox
Imbruced commented on pull request #482: URL: https://github.com/apache/incubator-sedona/pull/482#issuecomment-689131648 @nirnir93 I am still not able to push changes. :( This is an automated message from the Apache Git Serv

[GitHub] [incubator-sedona] Imbruced commented on pull request #482: [SEDONA-1] Move to jts 1.16.1

2020-09-08 Thread GitBox
Imbruced commented on pull request #482: URL: https://github.com/apache/incubator-sedona/pull/482#issuecomment-689119174 @jiayuasu I fixed it. But I have some doubts. Did anyone check how this PR affects overall performance ? Do we need this transformations ? @nirnir93 can you grant me

[GitHub] [incubator-sedona] Imbruced commented on pull request #482: [SEDONA-1] Move to jts 1.16.1

2020-09-07 Thread GitBox
Imbruced commented on pull request #482: URL: https://github.com/apache/incubator-sedona/pull/482#issuecomment-688506156 @jiayuasu I can see an issue. Python geometry data is translated to jvm using previous serlializer which assume that Geometry has userData attribute. Now it has not and