Re: JTSplus fork status

2020-10-15 Thread Jim Hughes
Hi all, I'd suggest that we look for alternatives around the changes to userData.  When I've talked to Martin Davis (lead JTS developer), he's been a little unsure and cautious around how userData is used. As one suggestion, is it possible to separate out comparison and serialization around

Re: JTSplus fork status

2020-10-14 Thread Felix Cheung
They are not too bad - IMO it will be good to pursue getting these changes accepted in jts On Wed, Oct 14, 2020 at 10:01 PM Jia Yu wrote: > Not yet. I am pretty sure that they will not accept all changes if you look > at there: > > https://github.com/locationtech/jts/compare/master...jiayuasu:m

Re: JTSplus fork status

2020-10-14 Thread Jia Yu
Not yet. I am pretty sure that they will not accept all changes if you look at there: https://github.com/locationtech/jts/compare/master...jiayuasu:master?expand=1 Especially, the "userdata" part and "findLeafBounds" function. I am gonna create a PR to JTS, and only keep acceptable changes. This w

JTSplus fork status

2020-10-14 Thread Netanel Malka
Hi Jia, I saw that you merge the PR about make Sedona depend on JTS. Did you also try to open a PR in the JTS project? I wondered if they agreed to accept your changes. BR, Netanel Malka.