Re: Review Request 48111: SENTRY-950?add column level test cases for select ... group by, order by and where

2016-06-03 Thread Anne Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48111/#review136149 --- Ship it! Ship It! - Anne Yu On June 1, 2016, 5:40 a.m., Ke J

Re: Review Request 47937: SENTRY-1134: Add user defined udf test case.

2016-06-03 Thread Anne Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47937/#review136148 --- Ship it! LGTM. Please check in after addressing all the other r

Re: Review Request 48195: SENTRY-858: Database prefix is not honoured when executing grant statement

2016-06-03 Thread Sravya Tirukkovalur
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48195/#review136130 --- sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/te

Re: [VOTE] Release Sentry version 1.7.0

2016-06-03 Thread Sravya Tirukkovalur
I checked as well and sha seems fine to me too. @Colm what exactly do you see ? +1 from me. Verified the following. - Made sure RCs are hosted @ https://dist.apache.org/repos/dist/dev/sentry - Is in format apache-$project-$version.tar.gz - Verified Signatures and hashes. - git tag

Re: [VOTE] Release Sentry version 1.7.0

2016-06-03 Thread Hao Hao
Hi Colm, Thanks for checking! But not sure how did you verify it? I downloaded the sha file and it seems look good to me: cat apache-sentry-1.7.0-src.tar.gz.sha 81c23908bc35e79a1a7c7e031cb904ee187f12bb apache-sentry-1.7.0-src.tar.gz Does anyone else give it a try? Thanks a lot! Best, Hao On T

Review Request 48217: SENTRY-859: Revoking privileges on a DB removes HDFS ACLs on its table files even if there is a role for one of its tables.

2016-06-03 Thread Rahul Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48217/ --- Review request for sentry and Sravya Tirukkovalur. Repository: sentry Descrip

Re: Review Request 47937: SENTRY-1134: Add user defined udf test case.

2016-06-03 Thread Ke Jia
> On June 3, 2016, 7:43 a.m., Dapeng Sun wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtFunctionScope.java, > > line 116 > > > > > > Could we add a negative

Re: Review Request 47937: SENTRY-1134: Add user defined udf test case.

2016-06-03 Thread Dapeng Sun
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47937/#review136048 --- sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/te

Re: Review Request 48057: SENTRY-1304?Enable CREATEMACRO and DROPMACRO operations in hive binding

2016-06-03 Thread Dapeng Sun
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48057/#review136046 --- Ship it! Ship It! - Dapeng Sun On 五月 31, 2016, 1:51 p.m., Ke