Re: Sentry HA redesign - feature branch or master?

2016-06-09 Thread Colin McCabe
Thanks, Sravya. That seems very similar to the way I've seen feature branches work in Apache Hadoop. Hadoop has an additional role called "branch committer." See https://hadoop.apache.org/bylaws.html and search for "branch committer." Basically, branch committers are authorized to make commits

Re: Review Request 48515: SENTRY-1320 : truncate table db_name.table_name fails

2016-06-09 Thread Anne Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48515/#review136918 --- Ship it! Ship It! - Anne Yu On June 9, 2016, 9:39 p.m., Viha

Re: Review Request 48515: SENTRY-1320 : truncate table db_name.table_name fails

2016-06-09 Thread Sravya Tirukkovalur
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48515/#review136902 --- Ship it! Thanks for the fix Vihang! Hopefully, these subtle ast

Review Request 48515: SENTRY-1320 : truncate table db_name.table_name fails

2016-06-09 Thread Vihang Karajgaonkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48515/ --- Review request for sentry, Hao Hao and Sravya Tirukkovalur. Bugs: SENTRY-1320

Re: Sentry HA redesign - feature branch or master?

2016-06-09 Thread Sravya Tirukkovalur
Cool. @Colin: Let me explain how feature branches worked so far in the Sentry community. And I would love to here what other communities do, and if we can adopt some of the best practices. - Committing: We create sub tasks and each sub task is reviewed as usual and is committed by one of the commi

Re: Sentry HA redesign - feature branch or master?

2016-06-09 Thread Hao Hao
+1 for having a feature branch. Thanks! Best, Hao On Thu, Jun 9, 2016 at 1:30 PM, Colin McCabe wrote: > By the way, this is the first community I've been in that has two > Colins! > Hope it's not confusing :) > > > > > On Thu, Jun 9, 2016, at 13:29, Colin McCabe wrote: > > Thanks, Sravya. > > >

Re: Sentry HA redesign - feature branch or master?

2016-06-09 Thread Colin McCabe
By the way, this is the first community I've been in that has two Colins! Hope it's not confusing :) On Thu, Jun 9, 2016, at 13:29, Colin McCabe wrote: > Thanks, Sravya. > > +1 for a feature branch, so that we don't have to worry about things > like what release it should appear in until the f

Re: Sentry HA redesign - feature branch or master?

2016-06-09 Thread Colin McCabe
Thanks, Sravya. +1 for a feature branch, so that we don't have to worry about things like what release it should appear in until the feature is complete. I am interested in working on this feature, and I think Rahul Sharma is as well (both from Cloudera). If we decide to do a feature branch, I w

Sentry HA redesign - feature branch or master?

2016-06-09 Thread Sravya Tirukkovalur
Hi folks, Shall we create a feature branch for Sentry HA redesign or do you all feel comfortable committing it to master? Thanks!