Re: Review Request 52795: SENTRY-1499: Add feature flag for using NotificationLog

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52795/#review159534 --- sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentr

Re: Review Request 54525: SENTRY-1541: toSentryPrivilege() should not copy fields that are not set in the source

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54525/#review159504 --- sentry-service/sentry-service-server/src/main/java/org/apache/sen

Re: Review Request 52795: SENTRY-1499: Add feature flag for using NotificationLog

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52795/ --- (Updated Dec. 16, 2016, 10:03 p.m.) Review request for sentry, Alexander Kolbas

Re: Review Request 54525: SENTRY-1541: toSentryPrivilege() should not copy fields that are not set in the source

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54525/ --- (Updated Dec. 16, 2016, 9:17 p.m.) Review request for sentry, Alexander Kolbaso

Re: Review Request 54525: SENTRY-1541: toSentryPrivilege() should not copy fields that are not set in the source

> On Dec. 16, 2016, 8:18 p.m., Alexander Kolbasov wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java, > > line 1449 > > > > > > I'd sugge

Re: Review Request 54454: SENTRY-1548 Setting GrantOption to UNSET upsets Sentry

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54454/#review159494 --- sentry-service/sentry-service-server/src/main/java/org/apache/sen

Re: Review Request 54808: SENTRY-1526 Sentry processed stays alive after being killed

> On Dec. 16, 2016, 7:05 p.m., Vadim Spector wrote: > > It is probably ok, but ... > > a) Did you investigate why service stayed alive? Perhaps, some knowledge > > about the implementation and its defficiencies to be gained there. Some > > unaccounted runaway threads? Or are we unable to termon

Re: Review Request 54808: SENTRY-1526 Sentry processed stays alive after being killed

> On Dec. 16, 2016, 7:05 p.m., Vadim Spector wrote: > > It is probably ok, but ... > > a) Did you investigate why service stayed alive? Perhaps, some knowledge > > about the implementation and its defficiencies to be gained there. Some > > unaccounted runaway threads? Or are we unable to termon

Re: Review Request 54808: SENTRY-1526 Sentry processed stays alive after being killed

> On Dec. 16, 2016, 7:05 p.m., Vadim Spector wrote: > > It is probably ok, but ... > > a) Did you investigate why service stayed alive? Perhaps, some knowledge > > about the implementation and its defficiencies to be gained there. Some > > unaccounted runaway threads? Or are we unable to termon

Re: Review Request 54819: SENTRY-1526: Sentry processed stays alive after being killed (Fixing Mismerge) (Alexander Kolbasov via Vamsee Yarlagadda)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54819/#review159491 --- Ship it! Ship It! - Alexander Kolbasov On Dec. 16, 2016, 8:4

Review Request 54819: SENTRY-1526: Sentry processed stays alive after being killed (Fixing Mismerge) (Alexander Kolbasov via Vamsee Yarlagadda)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54819/ --- Review request for sentry and Alexander Kolbasov. Repository: sentry Descript

Re: Review Request 54808: SENTRY-1526 Sentry processed stays alive after being killed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54808/#review159488 --- Ship it! - kalyan kumar kalvagadda On Dec. 16, 2016, 7:23 a.m

Re: Review Request 54808: SENTRY-1526 Sentry processed stays alive after being killed

> On Dec. 16, 2016, 7:05 p.m., Vadim Spector wrote: > > It is probably ok, but ... > > a) Did you investigate why service stayed alive? Perhaps, some knowledge > > about the implementation and its defficiencies to be gained there. Some > > unaccounted runaway threads? Or are we unable to termon

Re: Review Request 54525: SENTRY-1541: toSentryPrivilege() should not copy fields that are not set in the source

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54525/#review159486 --- sentry-service/sentry-service-server/src/main/java/org/apache/sen

Re: Review Request 54525: SENTRY-1541: toSentryPrivilege() should not copy fields that are not set in the source

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54525/ --- (Updated Dec. 16, 2016, 7:51 p.m.) Review request for sentry, Alexander Kolbaso

Re: Review Request 54808: SENTRY-1526 Sentry processed stays alive after being killed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54808/#review159478 --- Ship it! It is probably ok, but ... a) Did you investigate why

Re: Review Request 54808: SENTRY-1526 Sentry processed stays alive after being killed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54808/#review159475 --- Ship it! Ship It! - Vamsee Yarlagadda On Dec. 16, 2016, 7:23