Re: Review Request 55190: SENTRY-1583: Refactor ZK/Curator code

2017-01-06 Thread Alexander Kolbasov
> On Jan. 7, 2017, 4:25 a.m., Vamsee Yarlagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/LeaderStatusMonitor.java, > > line 251 > > > > > > Just curious to know ho

Re: Review Request 55190: SENTRY-1583: Refactor ZK/Curator code

2017-01-06 Thread Vamsee Yarlagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55190/#review160806 --- Fix it, then Ship it! LGTM otherwise. sentry-provider/sentry-

Re: Review Request 55246: SENTRY-1536: Refactor SentryStore transaction management to allow for extra transactions for a single permission update

2017-01-06 Thread Hao Hao
> On Jan. 6, 2017, 9:41 p.m., kalyan kumar kalvagadda wrote: > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryPlugin.java, > > line 294 > > > > > > Why is this logic changed? Can you ex

Re: Review Request 54729: SENTRY-1538: Create schema for storing HMS path change and Sentry permission change.

2017-01-06 Thread Vamsee Yarlagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54729/#review160776 --- Fix it, then Ship it! LGTM otherwise. sentry-provider/sentry-

Re: Review Request 52795: SENTRY-1499: Add feature flag for using NotificationLog

2017-01-06 Thread Vamsee Yarlagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52795/#review160773 --- sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentr

Re: Review Request 55246: SENTRY-1536: Refactor SentryStore transaction management to allow for extra transactions for a single permission update

2017-01-06 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55246/#review160754 --- sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/h

Re: Review Request 54729: SENTRY-1538: Create schema for storing HMS path change and Sentry permission change.

2017-01-06 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54729/#review159412 --- sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hd

Re: Review Request 52795: SENTRY-1499: Add feature flag for using NotificationLog

2017-01-06 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52795/#review160763 --- Fix it, then Ship it! sentry-provider/sentry-provider-db/src/m

Re: Review Request 54729: SENTRY-1538: Create schema for storing HMS path change and Sentry permission change.

2017-01-06 Thread Hao Hao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54729/#review160748 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 52795: SENTRY-1499: Add feature flag for using NotificationLog

2017-01-06 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52795/#review160747 --- Ship it! Ship It! - kalyan kumar kalvagadda On Dec. 20, 2016

Re: Review Request 54729: SENTRY-1538: Create schema for storing HMS path change and Sentry permission change.

2017-01-06 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54729/#review160738 --- Ship it! After addressing the comment. - kalyan kumar kalvagad

Re: Review Request 54729: SENTRY-1538: Create schema for storing HMS path change and Sentry permission change.

2017-01-06 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54729/#review160730 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr