Re: Review Request 58164: SENTRY-1638 Update SQL script of MSentryPathChange table to add a column for notification ID

2017-04-05 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58164/ --- (Updated April 6, 2017, 12:49 a.m.) Review request for sentry, Alexander

Re: Review Request 58164: SENTRY-1638 Update SQL script of MSentryPathChange table to add a column for notification ID

2017-04-05 Thread Hao Hao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58164/#review171184 ---

Re: Review Request 58164: SENTRY-1638 Update SQL script of MSentryPathChange table to add a column for notification ID

2017-04-05 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58164/#review171182 --- Ship it! Ship It! - Alexander Kolbasov On April 6, 2017,

Re: Review Request 58164: SENTRY-1638 Update SQL script of MSentryPathChange table to add a column for notification ID

2017-04-05 Thread kalyan kumar kalvagadda
> On April 4, 2017, 4:33 p.m., Hao Hao wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPermChange.java > > Line 30 (original), 30 (patched) > > > > > > I

Re: Review Request 58164: SENTRY-1638 Update SQL script of MSentryPathChange table to add a column for notification ID

2017-04-05 Thread kalyan kumar kalvagadda
> On April 6, 2017, 12:01 a.m., Alexander Kolbasov wrote: > > I don't see any changes to package.jdo announced at the header - are they > > missing? Updated the header > On April 6, 2017, 12:01 a.m., Alexander Kolbasov wrote: > >

Re: Review Request 58164: SENTRY-1638 Update SQL script of MSentryPathChange table to add a column for notification ID

2017-04-05 Thread kalyan kumar kalvagadda
> On April 4, 2017, 6:29 p.m., Alexander Kolbasov wrote: > > For tables that are new in sentry-ha-redesign branch, shouldn't we just > > update the initial creation scripts rather then add new scripts to fix the > > tables? If we need to that we need to move all the other commits done in

Re: Review Request 58164: SENTRY-1638 Update SQL script of MSentryPathChange table to add a column for notification ID

2017-04-05 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58164/ --- (Updated April 6, 2017, 12:05 a.m.) Review request for sentry, Alexander

Re: Review Request 58164: SENTRY-1638 Update SQL script of MSentryPathChange table to add a column for notification ID

2017-04-05 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58164/#review171172 --- I don't see any changes to package.jdo announced at the header -

Re: Review Request 58093: SENTRY-1676: FullUpdateInitializer#createInitialUpdate should not throw RuntimeExceptio

2017-04-05 Thread Sergio Pena
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58093/#review171152 --- Ship it! The change looks good Sasha. +1 (no-binding) -