Re: Review Request 58481: SENTRY-1674 HMSFollower shouldn't print the same value of notification ID multiple times

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58481/ --- (Updated April 18, 2017, 4:29 a.m.) Review request for sentry. Bugs: SENTRY-1

Re: Review Request 58481: SENTRY-1674 HMSFollower shouldn't print the same value of notification ID multiple times

> On April 17, 2017, 10:42 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Lines 258 (patched) > > > > > > size() may be expe

Re: Review Request 58221: SENTRY-1649 move HMS follower to runServer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58221/ --- (Updated April 18, 2017, 3:46 a.m.) Review request for sentry, Alexander Kolbas

Re: [DISCUSS] Merging Sentry HA branch with master

FYI, I contacted Colin Ma who was working on the refactoring and he was Ok with skipping this change for 1.8. That said, the refactoring was done for a reason it we should get back to it post 1.8, - Alex On Mon, Apr 17, 2017 at 5:51 PM Hao Hao wrote: > The proposal is good to me as well. Should

Re: Review Request 57901: SENTRY-1593 Implement client failover for all the sentry clients

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57901/#review172161 --- sentry-core/sentry-core-common/src/main/java/org/apache/sentry/co

Re: [DISCUSS] Merging Sentry HA branch with master

The proposal is good to me as well. Should we start a vote on this? Or we can just start to do it if no one is objecting? Best, Hao On Mon, Apr 17, 2017 at 4:42 PM, Vamsee Yarlagadda wrote: > > > > Cherry-pick any commits that happened since sentry-ha-redesign was > forked, > > except a few des

[DISCUSS] Sentry and Hive versions

I am curious whether we have any specific requirements for Hive versions that should be supported by Sentry? The question comes from the fact that Sentry HA relies on the Hive notification mechanism introduced in Hive 1.2 and some improvements to it made in Hive 1.3. If we base Sentry 1.8 on Sentr

Re: Review Request 58284: SENTRY-1687 FullUpdateInitializer can be more efficient

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58284/ --- (Updated April 18, 2017, 12:26 a.m.) Review request for sentry, Hao Hao, kalyan

Re: Review Request 58284: SENTRY-1687 FullUpdateInitializer can be more efficient

> On April 13, 2017, 7:13 p.m., Sergio Pena wrote: > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/FullUpdateInitializer.java > > Line 220 (original), 305 (patched) > > > > > > DbTask is retur

Re: [DISCUSS] Merging Sentry HA branch with master

> > Cherry-pick any commits that happened since sentry-ha-redesign was forked, > except a few described below > Exclude big refactoring commit (SENTRY-1205) and related commits > (SENTRY-1436, SENTRY-1438, SENTRY-1406) > Rename master to a dev branch > Rename sentry-ha-redesign to master This sou

Re: Review Request 58481: SENTRY-1674 HMSFollower shouldn't print the same value of notification ID multiple times

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58481/#review172145 --- - Alexander Kolbasov On April 17, 2017, 5:56 p.m., Na Li wrote:

Re: Review Request 58481: SENTRY-1674 HMSFollower shouldn't print the same value of notification ID multiple times

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58481/#review172144 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 58412: [WIP]SENTRY-1587: Refactor SentryStore transaction to persist a single path transcation bundled with corresponding delta path change

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58412/#review172131 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 58412: [WIP]SENTRY-1587: Refactor SentryStore transaction to persist a single path transcation bundled with corresponding delta path change

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58412/#review172035 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 57901: SENTRY-1593 Implement client failover for all the sentry clients

> On April 15, 2017, 12:36 a.m., Alexander Kolbasov wrote: > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryTransport.java > > Lines 210 (patched) > > > > > > Why don't y

Re: Review Request 57901: SENTRY-1593 Implement client failover for all the sentry clients

> On April 15, 2017, 12:36 a.m., Alexander Kolbasov wrote: > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryTransport.java > > Lines 67 (patched) > > > > > > Why do you ne

Re: Review Request 58221: SENTRY-1649 move HMS follower to runServer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58221/ --- (Updated April 17, 2017, 8:11 p.m.) Review request for sentry, Alexander Kolbas

Re: Review Request 58221: SENTRY-1649 move HMS follower to runServer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58221/ --- (Updated April 17, 2017, 6:48 p.m.) Review request for sentry, Alexander Kolbas

Re: Review Request 57901: SENTRY-1593 Implement client failover for all the sentry clients

> On April 15, 2017, 12:36 a.m., Alexander Kolbasov wrote: > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryTransport.java > > Lines 67 (patched) > > > > > > Why do you ne

Re: Review Request 58481: SENTRY-1674 HMSFollower shouldn't print the same value of notification ID multiple times

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58481/ --- (Updated April 17, 2017, 5:56 p.m.) Review request for sentry. Bugs: SENTRY-1

Re: Review Request 58221: SENTRY-1649 move HMS follower to runServer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58221/#review172104 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 58221: SENTRY-1649 move HMS follower to runServer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58221/ --- (Updated April 17, 2017, 5:55 p.m.) Review request for sentry, Alexander Kolbas

Review Request 58481: SENTRY-1674 HMSFollower shouldn't print the same value of notification ID multiple times

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58481/ --- Review request for sentry. Bugs: SENTRY-1674 https://issues.apache.org/jira

Re: Review Request 58221: SENTRY-1649 move HMS follower to runServer

> On April 12, 2017, 4:50 a.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > > Lines 160 (patched) > > > > > > Why do you need t

Re: Review Request 58221: SENTRY-1649 move HMS follower to runServer

> On April 14, 2017, 12:57 a.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > > Line 196 (original), 186 (patched) > > > > > > C

Re: Review Request 58221: SENTRY-1649 move HMS follower to runServer

> On April 14, 2017, 4:02 p.m., kalyan kumar kalvagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > > Lines 280 (patched) > > > > > > If hmsFollo

Re: Review Request 58221: SENTRY-1649 move HMS follower to runServer

> On April 14, 2017, 6:48 p.m., kalyan kumar kalvagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > > Lines 328 (patched) > > > > > > HmsFollower

Re: Review Request 58221: SENTRY-1649 move HMS follower to runServer

> On April 14, 2017, 12:57 a.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > > Lines 370 (patched) > > > > > > Do we need to ca

Re: Review Request 58221: SENTRY-1649 move HMS follower to runServer

- Na --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58221/#review172013 --- On April 14, 2017, 8:36 p.m., Na Li wrote: > > ---

Re: Review Request 58221: SENTRY-1649 move HMS follower to runServer

- Na --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58221/#review171666 --- On April 14, 2017, 8:36 p.m., Na Li wrote: > > ---