Re: Review Request 58221: SENTRY-1649 move HMS follower to runServer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58221/ --- (Updated April 19, 2017, 3:25 a.m.) Review request for sentry, Alexander Kolbas

Re: Review Request 58221: SENTRY-1649 move HMS follower to runServer

> On April 14, 2017, 7:04 p.m., kalyan kumar kalvagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > > Lines 222 (patched) > > > > > > I feel we s

Re: Review Request 58221: SENTRY-1649 move HMS follower to runServer

> On April 14, 2017, 4:02 p.m., kalyan kumar kalvagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > > Lines 280 (patched) > > > > > > If hmsFollo

Re: Review Request 58221: SENTRY-1649 move HMS follower to runServer

> On April 14, 2017, 12:57 a.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > > Line 196 (original), 186 (patched) > > > > > > C

Re: Review Request 58221: SENTRY-1649 move HMS follower to runServer

> On April 18, 2017, 9:15 p.m., Vamsee Yarlagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > > Lines 275 (patched) > > > > > > I know it doesn't

Re: Review Request 58221: SENTRY-1649 move HMS follower to runServer

> On April 18, 2017, 9:41 p.m., Hao Hao wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > > Lines 314 (patched) > > > > > > Nit: this line seems too lo

Re: Review Request 58221: SENTRY-1649 move HMS follower to runServer

> On April 18, 2017, 9:15 p.m., Vamsee Yarlagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > > Lines 275 (patched) > > > > > > I know it doesn't

Re: Review Request 58412: SENTRY-1587: Refactor SentryStore transaction to persist a single path transcation bundled with corresponding delta path change

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58412/#review172301 --- Initial batch of review comments. sentry-provider/sentry-provide

Re: Review Request 58221: SENTRY-1649 move HMS follower to runServer

> On April 17, 2017, 5:55 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > > Lines 107 (patched) > > > > > > Please add comme

Re: Review Request 58481: SENTRY-1674 HMSFollower shouldn't print the same value of notification ID multiple times

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58481/ --- (Updated April 19, 2017, 2:43 a.m.) Review request for sentry. Bugs: SENTRY-1

Re: Review Request 58481: SENTRY-1674 HMSFollower shouldn't print the same value of notification ID multiple times

> On April 18, 2017, 6:10 p.m., kalyan kumar kalvagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Lines 74 (patched) > > > > > > SENTRY-1587 is a

Re: Review Request 57901: SENTRY-1593 Implement client failover for all the sentry clients

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57901/#review172294 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 58412: SENTRY-1587: Refactor SentryStore transaction to persist a single path transcation bundled with corresponding delta path change

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58412/#review172289 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 58284: SENTRY-1687 FullUpdateInitializer can be more efficient

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58284/#review172288 --- Fix it, then Ship it! sentry-hdfs/sentry-hdfs-common/src/main/

Re: Review Request 57901: SENTRY-1593 Implement client failover for all the sentry clients

> On March 31, 2017, 6:18 a.m., Alexander Kolbasov wrote: > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryServiceClient.java > > Lines 33 (patched) > > > > > > I think th

Re: Review Request 57901: SENTRY-1593 Implement client failover for all the sentry clients

> On April 15, 2017, 12:36 a.m., Alexander Kolbasov wrote: > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryServiceClient.java > > Lines 39 (patched) > > > > > > Since thi

Re: Review Request 57901: SENTRY-1593 Implement client failover for all the sentry clients

> On April 6, 2017, 1:58 p.m., Na Li wrote: > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/RetryClientInvocationHandler.java > > Lines 86 (patched) > > > > > > At line 64, you

Re: Review Request 57901: SENTRY-1593 Implement client failover for all the sentry clients

> On March 31, 2017, 6:18 a.m., Alexander Kolbasov wrote: > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryServiceClient.java > > Lines 33 (patched) > > > > > > I think th

Re: Review Request 57901: SENTRY-1593 Implement client failover for all the sentry clients

> On April 18, 2017, 1:11 a.m., Alexander Kolbasov wrote: > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryHDFSServiceClientDefaultImpl.java > > Line 56 (original), 44 (patched) > > > > > >

Re: Review Request 57901: SENTRY-1593 Implement client failover for all the sentry clients

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57901/ --- (Updated April 18, 2017, 11:18 p.m.) Review request for sentry, Alexander Kolba

Re: Review Request 58284: SENTRY-1687 FullUpdateInitializer can be more efficient

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58284/#review172277 --- Ship it! LGTM - Vamsee Yarlagadda On April 18, 2017, 12:26 a

Re: Review Request 58221: SENTRY-1649 move HMS follower to runServer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58221/#review172273 --- Fix it, then Ship it! Overall the changes looks good to me. Tha

Re: Review Request 58412: SENTRY-1587: Refactor SentryStore transaction to persist a single path transcation bundled with corresponding delta path change

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58412/ --- (Updated April 18, 2017, 9:34 p.m.) Review request for sentry. Repository: se

Re: Review Request 58412: SENTRY-1587: Refactor SentryStore transaction to persist a single path transcation bundled with corresponding delta path change

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58412/ --- (Updated April 18, 2017, 9:29 p.m.) Review request for sentry. Repository: se

Re: Review Request 58412: SENTRY-1587: Refactor SentryStore transaction to persist a single path transcation bundled with corresponding delta path change

> On April 14, 2017, 6:45 p.m., Na Li wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 2519 (patched) > > > > > > Is it possible

Re: Review Request 58412: SENTRY-1587: Refactor SentryStore transaction to persist a single path transcation bundled with corresponding delta path change

> On April 14, 2017, 6:45 p.m., Na Li wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 2535 (patched) > > > > > > could the exce

Re: Review Request 58412: SENTRY-1587: Refactor SentryStore transaction to persist a single path transcation bundled with corresponding delta path change

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58412/#review172270 --- - Hao Hao On April 18, 2017, 7:34 a.m., Hao Hao wrote: > >

Re: Review Request 58221: SENTRY-1649 move HMS follower to runServer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58221/#review172262 --- Fix it, then Ship it! LGTM Otherwise sentry-provider/sentry-p

Re: Review Request 58412: SENTRY-1587: Refactor SentryStore transaction to persist a single path transcation bundled with corresponding delta path change

> On April 17, 2017, 8:35 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 2560 (patched) > > > > > > I

Re: Review Request 58412: SENTRY-1587: Refactor SentryStore transaction to persist a single path transcation bundled with corresponding delta path change

> On April 18, 2017, 4:14 p.m., Na Li wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 2545 (patched) > > > > > > Is it true tha

Re: Review Request 58412: SENTRY-1587: Refactor SentryStore transaction to persist a single path transcation bundled with corresponding delta path change

> On April 18, 2017, 4:14 p.m., Na Li wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 2563 (patched) > > > > > > Comment of thi

Re: Review Request 58412: SENTRY-1587: Refactor SentryStore transaction to persist a single path transcation bundled with corresponding delta path change

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58412/#review172256 --- - Hao Hao On April 18, 2017, 7:34 a.m., Hao Hao wrote: > >

Re: Review Request 58412: SENTRY-1587: Refactor SentryStore transaction to persist a single path transcation bundled with corresponding delta path change

> On April 18, 2017, 4:14 p.m., Na Li wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 2630 (patched) > > > > > > Could the auth

Re: Review Request 58412: SENTRY-1587: Refactor SentryStore transaction to persist a single path transcation bundled with corresponding delta path change

> On April 18, 2017, 4:14 p.m., Na Li wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Lines 257 (patched) > > > > > > how long will the notification I

Re: Review Request 58481: SENTRY-1674 HMSFollower shouldn't print the same value of notification ID multiple times

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58481/#review172233 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 58481: SENTRY-1674 HMSFollower shouldn't print the same value of notification ID multiple times

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58481/#review172232 --- Ship it! Ship It! - Alexander Kolbasov On April 18, 2017, 4:

Re: Review Request 58481: SENTRY-1674 HMSFollower shouldn't print the same value of notification ID multiple times

> On April 17, 2017, 10:42 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Lines 258 (patched) > > > > > > size() may be expe

Re: Review Request 58481: SENTRY-1674 HMSFollower shouldn't print the same value of notification ID multiple times

> On April 17, 2017, 10:42 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Lines 258 (patched) > > > > > > size() may be expe

Re: Review Request 58412: SENTRY-1587: Refactor SentryStore transaction to persist a single path transcation bundled with corresponding delta path change

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58412/#review172212 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 58221: SENTRY-1649 move HMS follower to runServer

> On April 12, 2017, 4:50 a.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > > Lines 160 (patched) > > > > > > Why do you need t

Re: Review Request 58481: SENTRY-1674 HMSFollower shouldn't print the same value of notification ID multiple times

> On April 17, 2017, 10:42 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Lines 258 (patched) > > > > > > size() may be expe

Re: [DISCUSS] Merging Sentry HA branch with master

OK thanks, sounds good to me then. Let's try and do development work on master from now on though... Colm. On Tue, Apr 18, 2017 at 2:14 AM, Alexander Kolbasov wrote: > FYI, I contacted Colin Ma who was working on the refactoring and he was Ok > with skipping this change for 1.8. That said, the

Re: Review Request 58412: [WIP]SENTRY-1587: Refactor SentryStore transaction to persist a single path transcation bundled with corresponding delta path change

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58412/ --- (Updated April 18, 2017, 7:34 a.m.) Review request for sentry. Repository: se

Re: Review Request 58412: SENTRY-1587: Refactor SentryStore transaction to persist a single path transcation bundled with corresponding delta path change

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58412/ --- (Updated April 18, 2017, 7:34 a.m.) Review request for sentry. Summary (updat

Re: Review Request 58412: [WIP]SENTRY-1587: Refactor SentryStore transaction to persist a single path transcation bundled with corresponding delta path change

> On April 14, 2017, 11:06 p.m., kalyan kumar kalvagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 2511 (patched) > > > > > >

Re: Review Request 58412: [WIP]SENTRY-1587: Refactor SentryStore transaction to persist a single path transcation bundled with corresponding delta path change

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58412/#review172024 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 58412: [WIP]SENTRY-1587: Refactor SentryStore transaction to persist a single path transcation bundled with corresponding delta path change

> On April 17, 2017, 8:35 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 2560 (patched) > > > > > > I