> On April 14, 2017, 4:02 p.m., kalyan kumar kalvagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > > Lines 280 (patched) > > <https://reviews.apache.org/r/58221/diff/10/?file=1692735#file1692735line308> > > > > If hmsFollower != null you can assume that notification log is enabled. > > I feel you don't have to make check it explicitly. > > Alexander Kolbasov wrote: > We'll remove notificationLogEnabled soon anyway since we don't support > anything else.
The intention of the code is more obvious when checking notification log is enabled or not. - Na ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58221/#review172004 ----------------------------------------------------------- On April 18, 2017, 3:46 a.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58221/ > ----------------------------------------------------------- > > (Updated April 18, 2017, 3:46 a.m.) > > > Review request for sentry, Alexander Kolbasov, Hao Hao, kalyan kumar > kalvagadda, and Sergio Pena. > > > Repository: sentry > > > Description > ------- > > SENTRY-1649 move HMS follower to runServer > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > 16676fb > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > 132db63 > > > Diff: https://reviews.apache.org/r/58221/diff/15/ > > > Testing > ------- > > > Thanks, > > Na Li > >
